From c1e1cfedf4643b69b3fc7b42e7c60be74dc993fd Mon Sep 17 00:00:00 2001
From: hickert <hickert@594d385d-05f5-0310-b6e9-bd551577e9d8>
Date: Thu, 1 Sep 2011 07:00:11 +0000
Subject: [PATCH] Fixed error handling in samba hash hook

git-svn-id: https://oss.gonicus.de/repositories/gosa/branches/2.6@20976 594d385d-05f5-0310-b6e9-bd551577e9d8
---
 gosa-core/include/functions.inc | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/gosa-core/include/functions.inc b/gosa-core/include/functions.inc
index 08b460b2b..62b227579 100644
--- a/gosa-core/include/functions.inc
+++ b/gosa-core/include/functions.inc
@@ -3024,9 +3024,9 @@ function change_password ($dn, $password, $mode=0, $hash= "")
 
     // Update shadow timestamp?
     if (isset($attrs["shadowLastChange"][0])){
-      $shadow= (int)(date("U") / 86400);
+        $shadow= (int)(date("U") / 86400);
     } else {
-      $shadow= 0;
+        $shadow= 0;
     }
 
     // Write back modified entry
@@ -3039,9 +3039,14 @@ function change_password ($dn, $password, $mode=0, $hash= "")
         // Create SMB Password
         if ($config->get_cfg_value('sambaHashHook', NULL)) { 
             $attrs= generate_smb_nt_hash($password);
-
-            if ($shadow != 0){
-                $attrs['shadowLastChange']= $shadow;
+            if(!count($attrs) || !is_array($attrs)){
+                msg_dialog::display(tr("Error"),tr("Cannot generate SAMBA hash!"),ERROR_DIALOG);
+                return(FALSE);    
+            }else{
+                $shadow = (isset($attrs["shadowLastChange"][0]))?(int)(date("U") / 86400):0;
+                if ($shadow != 0){
+                    $attrs['shadowLastChange']= $shadow;
+                }
             }
         }
     }
@@ -3113,7 +3118,7 @@ function generate_smb_nt_hash($password)
 
     if ($hash == "") {
       msg_dialog::display(_("Configuration error"), _("Cannot generate samba hash!"), ERROR_DIALOG);
-      return ("");
+      return (array());
     }
   } else {
 	  $tmp= $config->get_cfg_value('sambaHashHook')." ".escapeshellarg($password);
@@ -3126,7 +3131,7 @@ function generate_smb_nt_hash($password)
 
     if ($hash == "") {
       msg_dialog::display(_("Configuration error"), sprintf(_("Cannot generate samba hash: running '%s' failed, check the 'sambaHashHook'!"),$config->get_cfg_value('sambaHashHook')), ERROR_DIALOG);
-      return ("");
+      return (array());
     }
   }
 
-- 
2.30.2