From c063f0a973832784f09a6901eac9501b6f796bde Mon Sep 17 00:00:00 2001 From: Jeff King Date: Tue, 29 Mar 2011 16:56:04 -0400 Subject: [PATCH] revision.c: refactor notes ref expansion No need to do it ourselves when there is a library function. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- revision.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/revision.c b/revision.c index 0f38364cf..5826e5d59 100644 --- a/revision.c +++ b/revision.c @@ -1374,13 +1374,8 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg revs->show_notes_given = 1; if (!revs->notes_opt.extra_notes_refs) revs->notes_opt.extra_notes_refs = xcalloc(1, sizeof(struct string_list)); - if (!prefixcmp(arg+13, "refs/")) - /* happy */; - else if (!prefixcmp(arg+13, "notes/")) - strbuf_addstr(&buf, "refs/"); - else - strbuf_addstr(&buf, "refs/notes/"); strbuf_addstr(&buf, arg+13); + expand_notes_ref(&buf); string_list_append(revs->notes_opt.extra_notes_refs, strbuf_detach(&buf, NULL)); } else if (!strcmp(arg, "--no-notes")) { -- 2.30.2