From b58341233daa8f6450a6de5fa9dda97b57740dae Mon Sep 17 00:00:00 2001 From: rochecompaan Date: Tue, 22 Jan 2002 11:54:45 +0000 Subject: [PATCH] Fixed status change in mail gateway. git-svn-id: http://svn.roundup-tracker.org/svnroot/roundup/trunk@583 57a73879-2fb5-44c3-a270-3262357dd7e2 --- CHANGES.txt | 1 + roundup/mailgw.py | 17 ++++++++++++++--- test/test_mailgw.py | 16 +++++++++++++++- 3 files changed, 30 insertions(+), 4 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index d2d9add..6118843 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -19,6 +19,7 @@ Fixed: . handle attachments with no name (eg tnef) . fixed setting nosy as argument in subject line . fixed back_bsddb so it passed the journal tests + . fixed status changes in mail gateway (eg. unread -> chatting) 2002-01-16 - 0.4.0b2 Fixed: diff --git a/roundup/mailgw.py b/roundup/mailgw.py index a47db26..b80ee8f 100644 --- a/roundup/mailgw.py +++ b/roundup/mailgw.py @@ -73,7 +73,7 @@ are calling the create() method to create a new node). If an auditor raises an exception, the original message is bounced back to the sender with the explanatory message given in the exception. -$Id: mailgw.py,v 1.55 2002-01-21 10:05:47 rochecompaan Exp $ +$Id: mailgw.py,v 1.56 2002-01-22 11:54:45 rochecompaan Exp $ ''' @@ -580,9 +580,10 @@ not find a text/plain part to use. except KeyError: pass else: + current_status = cl.get(nodeid, 'status') if (not props.has_key('status') and - properties['status'] == unread_id or - properties['status'] == resolved_id): + current_status == unread_id or + current_status == resolved_id): props['status'] = chatting_id # add nosy in arguments to issue's nosy list @@ -753,6 +754,16 @@ def parseContent(content, blank_line=re.compile(r'[\r\n]+\s*[\r\n]+'), # # $Log: not supported by cvs2svn $ +# Revision 1.55 2002/01/21 10:05:47 rochecompaan +# Feature: +# . the mail gateway now responds with an error message when invalid +# values for arguments are specified for link or multilink properties +# . modified unit test to check nosy and assignedto when specified as +# arguments +# +# Fixed: +# . fixed setting nosy as argument in subject line +# # Revision 1.54 2002/01/16 09:14:45 grubert # . if the attachment has no name, name it unnamed, happens with tnefs. # diff --git a/test/test_mailgw.py b/test/test_mailgw.py index 0762d0e..d385334 100644 --- a/test/test_mailgw.py +++ b/test/test_mailgw.py @@ -8,7 +8,7 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. # -# $Id: test_mailgw.py,v 1.6 2002-01-21 10:05:48 rochecompaan Exp $ +# $Id: test_mailgw.py,v 1.7 2002-01-22 11:54:45 rochecompaan Exp $ import unittest, cStringIO, tempfile, os, shutil, errno, imp, sys @@ -141,6 +141,7 @@ This is a followup ---------- assignedto: -> mary nosy: +mary, john +status: unread -> chatting ___________________________________________________ "Roundup issue tracker" http://some.useful.url/issue1 @@ -178,6 +179,9 @@ mary added the comment: This is a second followup + +---------- +status: unread -> chatting ___________________________________________________ "Roundup issue tracker" http://some.useful.url/issue1 @@ -196,6 +200,16 @@ def suite(): # # $Log: not supported by cvs2svn $ +# Revision 1.6 2002/01/21 10:05:48 rochecompaan +# Feature: +# . the mail gateway now responds with an error message when invalid +# values for arguments are specified for link or multilink properties +# . modified unit test to check nosy and assignedto when specified as +# arguments +# +# Fixed: +# . fixed setting nosy as argument in subject line +# # Revision 1.5 2002/01/15 00:12:40 richard # #503340 ] creating issue with [asignedto=p.ohly] # -- 2.30.2