From aef5aedd8536fddbbd2e19245dfab201d05afb25 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Sun, 22 Apr 2007 11:49:35 -0700 Subject: [PATCH] pack-objects: quickfix for permission modes. mkstemp() often creates the file in 0600 which means the resulting packfile is not readable by anybody other than the repository owner. Force 0644 for now, even though this is not strictly correct. Signed-off-by: Junio C Hamano --- builtin-pack-objects.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c index c72e07a2b..840d4d697 100644 --- a/builtin-pack-objects.c +++ b/builtin-pack-objects.c @@ -1783,11 +1783,17 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix) write_index_file(last_obj_offset, object_list_sha1); snprintf(tmpname, sizeof(tmpname), "%s-%s.pack", base_name, sha1_to_hex(object_list_sha1)); + if (chmod(pack_tmp_name, 0644)) + die("unable to make temporary pack file readable: %s", + strerror(errno)); if (rename(pack_tmp_name, tmpname)) die("unable to rename temporary pack file: %s", strerror(errno)); snprintf(tmpname, sizeof(tmpname), "%s-%s.idx", base_name, sha1_to_hex(object_list_sha1)); + if (chmod(idx_tmp_name, 0644)) + die("unable to make temporary index file readable: %s", + strerror(errno)); if (rename(idx_tmp_name, tmpname)) die("unable to rename temporary index file: %s", strerror(errno)); -- 2.30.2