From aec1b94c999035922cd8c19878a4618883f5179b Mon Sep 17 00:00:00 2001 From: bryce Date: Sun, 6 Jan 2008 22:30:35 +0000 Subject: [PATCH] Fix missing tooltips in LPE's. (Closes LP: #178471) Whitespace cleanup. --- src/display/nr-filter-turbulence.h | 2 +- src/live_effects/lpe-gears.cpp | 9 ++++++++- src/live_effects/lpe-skeletalstrokes.cpp | 2 +- src/sp-feturbulence.cpp | 8 ++++---- src/ui/dialog/filter-effects-dialog.cpp | 2 +- 5 files changed, 15 insertions(+), 8 deletions(-) diff --git a/src/display/nr-filter-turbulence.h b/src/display/nr-filter-turbulence.h index bfbacc9f3..7325543b1 100644 --- a/src/display/nr-filter-turbulence.h +++ b/src/display/nr-filter-turbulence.h @@ -61,7 +61,7 @@ public: virtual int render(FilterSlot &slot, FilterUnits const &units); void update_pixbuffer(FilterSlot &slot, IRect &area); - + void set_baseFrequency(int axis, double freq); void set_numOctaves(int num); void set_seed(double s); diff --git a/src/live_effects/lpe-gears.cpp b/src/live_effects/lpe-gears.cpp index 00709f66c..699f2c83b 100644 --- a/src/live_effects/lpe-gears.cpp +++ b/src/live_effects/lpe-gears.cpp @@ -210,8 +210,15 @@ namespace LivePathEffect { LPEGears::LPEGears(LivePathEffectObject *lpeobject) : Effect(lpeobject), teeth(_("Teeth"), _("The number of teeth"), "teeth", &wr, this, 10), - phi(_("Phi"), _("???"), "phi", &wr, this, 5) + phi(_("Phi"), _("Tooth pressure angle (typically 20-25 deg). The ratio of teeth not in contact."), "phi", &wr, this, 5) { + /* Tooth pressure angle: The angle between the tooth profile and a perpendicular to the pitch + * circle, usually at the point where the pitch circle meets the tooth profile. Standard angles + * are 20 and 25 degrees. The pressure angle affects the force that tends to separate mating + * gears. A high pressure angle means that higher ratio of teeth not in contact. However, this + * allows the teeth to have higher capacity and also allows fewer teeth without undercutting. + */ + teeth.param_make_integer(); teeth.param_set_range(3, NR_HUGE); registerParameter( dynamic_cast(&teeth) ); diff --git a/src/live_effects/lpe-skeletalstrokes.cpp b/src/live_effects/lpe-skeletalstrokes.cpp index effa66e54..a2fe2be8a 100644 --- a/src/live_effects/lpe-skeletalstrokes.cpp +++ b/src/live_effects/lpe-skeletalstrokes.cpp @@ -66,7 +66,7 @@ LPESkeletalStrokes::LPESkeletalStrokes(LivePathEffectObject *lpeobject) : spacing(_("Spacing"), _("Space between copies of the pattern"), "spacing", &wr, this, 0), normal_offset(_("Normal offset"), "", "normal_offset", &wr, this, 0), tang_offset(_("Tangential offset"), "", "tang_offset", &wr, this, 0), - vertical_pattern(_("Pattern is vertical"), "", "vertical_pattern", &wr, this, false) + vertical_pattern(_("Pattern is vertical"), "Rotate pattern 90 deg before applying", "vertical_pattern", &wr, this, false) { registerParameter( dynamic_cast(&pattern) ); registerParameter( dynamic_cast(©type) ); diff --git a/src/sp-feturbulence.cpp b/src/sp-feturbulence.cpp index d95a921f1..5d351884c 100644 --- a/src/sp-feturbulence.cpp +++ b/src/sp-feturbulence.cpp @@ -156,10 +156,10 @@ sp_feTurbulence_set(SPObject *object, unsigned int key, gchar const *value) double read_num; bool read_bool; NR::FilterTurbulenceType read_type; - + switch(key) { /*DEAL WITH SETTING ATTRIBUTES HERE*/ - + case SP_ATTR_BASEFREQUENCY: feTurbulence->baseFrequency.set(value); //From SVG spec: If two s are provided, the first number represents a base frequency in the X direction and the second value represents a base frequency in the Y direction. If one number is provided, then that value is used for both X and Y. @@ -188,7 +188,7 @@ sp_feTurbulence_set(SPObject *object, unsigned int key, gchar const *value) read_bool = sp_feTurbulence_read_stitchTiles(value); if (read_bool != feTurbulence->stitchTiles){ feTurbulence->stitchTiles = read_bool; - feTurbulence->updated = false; + feTurbulence->updated = false; object->parent->requestModified(SP_OBJECT_MODIFIED_FLAG); } break; @@ -196,7 +196,7 @@ sp_feTurbulence_set(SPObject *object, unsigned int key, gchar const *value) read_type = sp_feTurbulence_read_type(value); if (read_type != feTurbulence->type){ feTurbulence->type = read_type; - feTurbulence->updated = false; + feTurbulence->updated = false; object->parent->requestModified(SP_OBJECT_MODIFIED_FLAG); } break; diff --git a/src/ui/dialog/filter-effects-dialog.cpp b/src/ui/dialog/filter-effects-dialog.cpp index e84635881..4318b54eb 100644 --- a/src/ui/dialog/filter-effects-dialog.cpp +++ b/src/ui/dialog/filter-effects-dialog.cpp @@ -2000,7 +2000,7 @@ void FilterEffectsDialog::init_settings_widgets() void FilterEffectsDialog::add_primitive() { SPFilter* filter = _filter_modifier.get_selected_filter(); - + if(filter) { SPFilterPrimitive* prim = filter_add_primitive(filter, _add_primitive_type.get_active_data()->id); -- 2.30.2