From a7b0cdea4f6a0f8d29ade21ae058182f720dd432 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Wed, 10 Aug 2016 20:07:14 +1000 Subject: [PATCH] Fix conceptual buglet in default_callback The 'DERIVE' path in default_callback() increments the 'counter' field of value instead of the 'derive' field. Since those fields have the same type and offset within the value union this will still work fine, but AFAICT it's conceptually incorrect. This corrects it. Signed-off-by: David Gibson Signed-off-by: Florian Forster --- src/daemon/utils_match.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/daemon/utils_match.c b/src/daemon/utils_match.c index 5083b05a..38472848 100644 --- a/src/daemon/utils_match.c +++ b/src/daemon/utils_match.c @@ -169,7 +169,7 @@ static int default_callback (const char __attribute__((unused)) *str, if (data->ds_type & UTILS_MATCH_CF_DERIVE_INC) { - data->value.counter++; + data->value.derive++; data->values_num++; return (0); } -- 2.30.2