From a4110db368267edb3b5c82222b7ceb1ccd5b9f7b Mon Sep 17 00:00:00 2001 From: richard Date: Tue, 8 Jan 2002 04:12:05 +0000 Subject: [PATCH] Changed message-id format to "<%s.%s.%s%s@%s>" so it complies with RFC822 git-svn-id: http://svn.roundup-tracker.org/svnroot/roundup/trunk@511 57a73879-2fb5-44c3-a270-3262357dd7e2 --- CHANGES.txt | 2 +- roundup/cgi_client.py | 7 +++++-- roundup/mailgw.py | 7 +++++-- roundup/roundupdb.py | 19 +++++++++++++++++-- 4 files changed, 28 insertions(+), 7 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 548b4e5..b5e6932 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -4,7 +4,7 @@ are given with the most recent entry first. 2002-01-?? - 0.4.0b2 Fixed: . #495392 ] empty nosy -patch - + . #500574 ] messageid must have format 2002-01-08 - 0.4.0b1 Feature: diff --git a/roundup/cgi_client.py b/roundup/cgi_client.py index d1fd360..c0270b9 100644 --- a/roundup/cgi_client.py +++ b/roundup/cgi_client.py @@ -15,7 +15,7 @@ # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE, # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. # -# $Id: cgi_client.py,v 1.91 2002-01-08 04:03:47 richard Exp $ +# $Id: cgi_client.py,v 1.92 2002-01-08 04:12:05 richard Exp $ __doc__ = """ WWW request handler (also used in the stand-alone server). @@ -470,7 +470,7 @@ class Client: # handle the messageid # TODO: handle inreplyto - messageid = "%s.%s.%s-%s"%(time.time(), random.random(), + messageid = "<%s.%s.%s@%s>"%(time.time(), random.random(), self.classname, self.MAIL_DOMAIN) # now create the message, attaching the files @@ -1180,6 +1180,9 @@ def parsePropsFromForm(db, cl, form, nodeid=0): # # $Log: not supported by cvs2svn $ +# Revision 1.91 2002/01/08 04:03:47 richard +# I mucked the intent of the code up. +# # Revision 1.90 2002/01/08 03:56:55 richard # Oops, missed this before the beta: # . #495392 ] empty nosy -patch diff --git a/roundup/mailgw.py b/roundup/mailgw.py index 441a56c..f1edd3d 100644 --- a/roundup/mailgw.py +++ b/roundup/mailgw.py @@ -73,7 +73,7 @@ are calling the create() method to create a new node). If an auditor raises an exception, the original message is bounced back to the sender with the explanatory message given in the exception. -$Id: mailgw.py,v 1.47 2002-01-02 02:32:38 richard Exp $ +$Id: mailgw.py,v 1.48 2002-01-08 04:12:05 richard Exp $ ''' @@ -427,7 +427,7 @@ Unknown address: %s inreplyto = message.getheader('in-reply-to') or '' # generate a messageid if there isn't one if not messageid: - messageid = "%s.%s.%s%s-%s"%(time.time(), random.random(), + messageid = "<%s.%s.%s%s@%s>"%(time.time(), random.random(), classname, nodeid, self.MAIL_DOMAIN) # @@ -708,6 +708,9 @@ def parseContent(content, blank_line=re.compile(r'[\r\n]+\s*[\r\n]+'), # # $Log: not supported by cvs2svn $ +# Revision 1.47 2002/01/02 02:32:38 richard +# ANONYMOUS_ACCESS -> ANONYMOUS_REGISTER +# # Revision 1.46 2002/01/02 02:31:38 richard # Sorry for the huge checkin message - I was only intending to implement #496356 # but I found a number of places where things had been broken by transactions: diff --git a/roundup/roundupdb.py b/roundup/roundupdb.py index bd1933e..3478bd5 100644 --- a/roundup/roundupdb.py +++ b/roundup/roundupdb.py @@ -15,7 +15,7 @@ # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE, # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. # -# $Id: roundupdb.py,v 1.36 2002-01-02 02:31:38 richard Exp $ +# $Id: roundupdb.py,v 1.37 2002-01-08 04:12:05 richard Exp $ __doc__ = """ Extending hyperdb with types specific to issue-tracking. @@ -331,7 +331,7 @@ class IssueClass(Class): if not messageid: # this is an old message that didn't get a messageid, so # create one - messageid = "%s.%s.%s%s-%s"%(time.time(), random.random(), + messageid = "<%s.%s.%s%s@%s>"%(time.time(), random.random(), self.classname, nodeid, self.MAIL_DOMAIN) messages.set(msgid, messageid=messageid) @@ -530,6 +530,21 @@ class IssueClass(Class): # # $Log: not supported by cvs2svn $ +# Revision 1.36 2002/01/02 02:31:38 richard +# Sorry for the huge checkin message - I was only intending to implement #496356 +# but I found a number of places where things had been broken by transactions: +# . modified ROUNDUPDBSENDMAILDEBUG to be SENDMAILDEBUG and hold a filename +# for _all_ roundup-generated smtp messages to be sent to. +# . the transaction cache had broken the roundupdb.Class set() reactors +# . newly-created author users in the mailgw weren't being committed to the db +# +# Stuff that made it into CHANGES.txt (ie. the stuff I was actually working +# on when I found that stuff :): +# . #496356 ] Use threading in messages +# . detectors were being registered multiple times +# . added tests for mailgw +# . much better attaching of erroneous messages in the mail gateway +# # Revision 1.35 2001/12/20 15:43:01 rochecompaan # Features added: # . Multilink properties are now displayed as comma separated values in -- 2.30.2