From 9c4cb412deb057fa83e381ff59e96430007a8586 Mon Sep 17 00:00:00 2001 From: oetiker Date: Tue, 22 Jul 2008 15:15:44 +0000 Subject: [PATCH] Fix for #167 - rrdcreate is arguably missing a check for 'step>=1' for RRAs with AVERAGE as a CF. I ran into this when specifying 0.6 as a step value, assuming floats were also accepted. Patch attached here. -- Bogdan git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1445 a5681a0c-68f1-0310-ab6d-d61299d08faa --- src/rrd_create.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/rrd_create.c b/src/rrd_create.c index 2cc8557..fd1ac9e 100644 --- a/src/rrd_create.c +++ b/src/rrd_create.c @@ -373,6 +373,8 @@ int rrd_create_r( default: rrd.rra_def[rrd.stat_head->rra_cnt].pdp_cnt = atoi(token); + if (atoi(token) < 1) + rrd_set_error("Invalid step: must be >= 1"); break; } break; -- 2.30.2