From 99bd0f555823f3c3868561af33d85864a90a7d9a Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 31 May 2006 15:23:44 -0700 Subject: [PATCH] fetch.c: do not pass uninitialized lock to unlock_ref(). Signed-off-by: Junio C Hamano --- fetch.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fetch.c b/fetch.c index ae92d5212..cc6013e7a 100644 --- a/fetch.c +++ b/fetch.c @@ -203,7 +203,7 @@ static int mark_complete(const char *path, const unsigned char *sha1) int pull(char *target) { - struct ref_lock *lock; + struct ref_lock *lock = NULL; unsigned char sha1[20]; char *msg; int ret; @@ -223,15 +223,18 @@ int pull(char *target) if (interpret_target(target, sha1)) { error("Could not interpret %s as something to pull", target); - unlock_ref(lock); + if (lock) + unlock_ref(lock); return -1; } if (process(lookup_unknown_object(sha1))) { - unlock_ref(lock); + if (lock) + unlock_ref(lock); return -1; } if (loop()) { - unlock_ref(lock); + if (lock) + unlock_ref(lock); return -1; } -- 2.30.2