From 99a6a97b1bf866d7050e8afb137b4b29507f0caa Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Sat, 29 Dec 2007 20:22:14 +0100 Subject: [PATCH] Optimize prefixcmp() Certain codepaths (notably "git log --pretty=format...") use prefixcmp() extensively, with very short prefixes. In those cases, calling strlen() is a wasteful operation, so avoid it. Initial patch by Marco Costalba. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- git-compat-util.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/git-compat-util.h b/git-compat-util.h index 79eb10eac..7059cbdab 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -398,7 +398,11 @@ static inline int sane_case(int x, int high) static inline int prefixcmp(const char *str, const char *prefix) { - return strncmp(str, prefix, strlen(prefix)); + for (; ; str++, prefix++) + if (!*prefix) + return 0; + else if (*str != *prefix) + return (unsigned char)*prefix - (unsigned char)*str; } static inline int strtoul_ui(char const *s, int base, unsigned int *result) -- 2.30.2