From 8a883b0260ba7f8d6e4c025ae3c32b454e80ade5 Mon Sep 17 00:00:00 2001 From: Jared Hance Date: Sat, 31 Jul 2010 08:54:55 -0400 Subject: [PATCH] builtin/push.c: remove useless temporary variable Creating a variable nr here to use throughout the function only to change refspec_nr to nr at the end, having not used refspec_nr the entire time, is rather pointless. Instead, simply increment refspec_nr. While at it, use ALLOC_GROW() instead of xrealloc(). Signed-off-by: Jared Hance Signed-off-by: Junio C Hamano --- builtin/push.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/push.c b/builtin/push.c index f4358b9d2..a2cc9fdea 100644 --- a/builtin/push.c +++ b/builtin/push.c @@ -22,13 +22,13 @@ static int progress; static const char **refspec; static int refspec_nr; +static int refspec_alloc; static void add_refspec(const char *ref) { - int nr = refspec_nr + 1; - refspec = xrealloc(refspec, nr * sizeof(char *)); - refspec[nr-1] = ref; - refspec_nr = nr; + refspec_nr++; + ALLOC_GROW(refspec, refspec_nr, refspec_alloc); + refspec[refspec_nr-1] = ref; } static void set_refspecs(const char **refs, int nr) -- 2.30.2