From 87412ec1f17bc2705595ebabc010d94cb46478b7 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 25 Jun 2008 12:08:15 -0400 Subject: [PATCH] for-each-ref: implement missing tag values The "type" and "object" fields for tags were accepted as valid atoms, but never implemented. Consequently, they simply returned the empty string, even for valid tags. Noticed by Lea Wiemann. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- builtin-for-each-ref.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c index 07d9c5721..fef93d748 100644 --- a/builtin-for-each-ref.c +++ b/builtin-for-each-ref.c @@ -234,6 +234,13 @@ static void grab_tag_values(struct atom_value *val, int deref, struct object *ob name++; if (!strcmp(name, "tag")) v->s = tag->tag; + else if (!strcmp(name, "type") && tag->tagged) + v->s = typename(tag->tagged->type); + else if (!strcmp(name, "object") && tag->tagged) { + char *s = xmalloc(41); + strcpy(s, sha1_to_hex(tag->tagged->sha1)); + v->s = s; + } } } -- 2.30.2