From 853a1ae34ba5ce93937efaca3a9c4f8fdbb65a93 Mon Sep 17 00:00:00 2001 From: ishmal Date: Wed, 16 Aug 2006 18:53:48 +0000 Subject: [PATCH] Clean up a bit. Clarify several variable names. Add a lot of comments. --- src/ui/widget/page-sizer.cpp | 161 +++++++++++++++++------------------ src/ui/widget/page-sizer.h | 112 +++++++++++++++++++----- 2 files changed, 168 insertions(+), 105 deletions(-) diff --git a/src/ui/widget/page-sizer.cpp b/src/ui/widget/page-sizer.cpp index 06b167e65..bf16effb6 100644 --- a/src/ui/widget/page-sizer.cpp +++ b/src/ui/widget/page-sizer.cpp @@ -8,7 +8,7 @@ * Jon Phillips * Ralf Stephan (Gtkmm) * - * Copyright (C) 2000 - 2005 Authors + * Copyright (C) 2000 - 2006 Authors * * Released under GNU GPL. Read the file 'COPYING' for more information */ @@ -19,9 +19,6 @@ #include #include -//#include -//#include -//#include #include "ui/widget/button.h" #include "ui/widget/scalar-unit.h" @@ -158,51 +155,20 @@ static PaperSizeRec const inkscape_papers[] = { { NULL, 0, 0, SP_UNIT_PX }, }; -//=================================================== - - -static const SPUnit _px_unit = sp_unit_get_by_id (SP_UNIT_PX); - - -/* -class SizeMenuItem : public Gtk::MenuItem { -public: - SizeMenuItem (PaperSizeRec const * paper, PageSizer * widget) - : Gtk::MenuItem (paper ? paper->name : _("Custom")), - _paper(paper), - _parent(widget) - {} -protected: - PaperSizeRec const * _paper; - PageSizer *_parent; - void on_activate(); -}; - -void -SizeMenuItem::on_activate() -{ - if (_parent == 0) // handle Custom entry - return; - - double w = _paper->smaller, h = _paper->larger; - SPUnit const &src_unit = sp_unit_get_by_id (_paper->unit); - sp_convert_distance (&w, &src_unit, &_px_unit); - sp_convert_distance (&h, &src_unit, &_px_unit); - if (_parent->_landscape) - _parent->setDim (h, w); - else - _parent->setDim (w, h); -} -*/ - -//--------------------------------------------------- +//######################################################################## +//# P A G E S I Z E R +//######################################################################## +//The default unit for this widget and its calculations +static const SPUnit _px_unit = sp_unit_get_by_id (SP_UNIT_PX); -PageSizer::PageSizer() -: Gtk::VBox(false,4) +/** + * Constructor + */ +PageSizer::PageSizer() : Gtk::VBox(false,4) { Gtk::HBox *hbox_size = manage (new Gtk::HBox (false, 4)); pack_start (*hbox_size, false, false, 0); @@ -224,18 +190,19 @@ PageSizer::PageSizer() } + +/** + * Destructor + */ PageSizer::~PageSizer() { - _paper_size_list_connection.disconnect(); - _portrait_connection.disconnect(); - _landscape_connection.disconnect(); - _changedw_connection.disconnect(); - _changedh_connection.disconnect(); } - +/** + * Initialize or reset this widget + */ void PageSizer::init (Registry& reg) { @@ -272,19 +239,22 @@ PageSizer::init (Registry& reg) frame->add (*table); - _wr = ® + _widgetRegistry = ® - _rum.init (_("U_nits:"), "units", *_wr); - _rusw.init (_("_Width:"), _("Width of paper"), "width", _rum, *_wr); - _rush.init (_("_Height:"), _("Height of paper"), "height", _rum, *_wr); + _dimensionUnits.init (_("U_nits:"), "units", + *_widgetRegistry); + _dimensionWidth.init (_("_Width:"), _("Width of paper"), "width", + _dimensionUnits, *_widgetRegistry); + _dimensionHeight.init (_("_Height:"), _("Height of paper"), "height", + _dimensionUnits, *_widgetRegistry); - table->attach (*_rum._label, 0,1,0,1, Gtk::FILL|Gtk::EXPAND, + table->attach (*_dimensionUnits._label, 0,1,0,1, Gtk::FILL|Gtk::EXPAND, (Gtk::AttachOptions)0,0,0); - table->attach (*_rum._sel, 1,2,0,1, Gtk::FILL|Gtk::EXPAND, + table->attach (*_dimensionUnits._sel, 1,2,0,1, Gtk::FILL|Gtk::EXPAND, (Gtk::AttachOptions)0,0,0); - table->attach (*_rusw.getSU(), 0,2,1,2, Gtk::FILL|Gtk::EXPAND, + table->attach (*_dimensionWidth.getSU(), 0,2,1,2, Gtk::FILL|Gtk::EXPAND, (Gtk::AttachOptions)0,0,0); - table->attach (*_rush.getSU(), 0,2,2,3, Gtk::FILL|Gtk::EXPAND, + table->attach (*_dimensionHeight.getSU(), 0,2,2,3, Gtk::FILL|Gtk::EXPAND, (Gtk::AttachOptions)0,0,0); table->attach (*fit_canv_cont, 0,2,3,4, Gtk::FILL|Gtk::EXPAND, (Gtk::AttachOptions)0,0,0); @@ -296,9 +266,9 @@ PageSizer::init (Registry& reg) sigc::mem_fun (*this, &PageSizer::on_landscape)); _portrait_connection = _portraitButton.signal_toggled().connect ( sigc::mem_fun (*this, &PageSizer::on_portrait)); - _changedw_connection = _rusw.getSU()->signal_value_changed().connect ( + _changedw_connection = _dimensionWidth.getSU()->signal_value_changed().connect ( sigc::mem_fun (*this, &PageSizer::on_value_changed)); - _changedh_connection = _rush.getSU()->signal_value_changed().connect ( + _changedh_connection = _dimensionHeight.getSU()->signal_value_changed().connect ( sigc::mem_fun (*this, &PageSizer::on_value_changed)); fit_canv->signal_clicked().connect( sigc::mem_fun(*this, &PageSizer::fire_fit_canvas_to_selection_or_drawing)); @@ -309,10 +279,12 @@ PageSizer::init (Registry& reg) /** * Set document dimensions (if not called by Doc prop's update()) and - * set the PageSizer's widgets and text entries accordingly. This is - * somewhat slow, is there something done too often invisibly? + * set the PageSizer's widgets and text entries accordingly. If + * 'chageList' is true, then adjust the paperSizeList to show the closest + * standard page size. * * \param w, h given in px + * \param changeList whether to modify the paper size list */ void PageSizer::setDim (double w, double h, bool changeList) @@ -329,24 +301,24 @@ PageSizer::setDim (double w, double h, bool changeList) _changedw_connection.block(); _changedh_connection.block(); - if (SP_ACTIVE_DESKTOP && !_wr->isUpdating()) { + if (SP_ACTIVE_DESKTOP && !_widgetRegistry->isUpdating()) { SPDocument *doc = sp_desktop_document(SP_ACTIVE_DESKTOP); sp_document_set_width (doc, w, &_px_unit); sp_document_set_height (doc, h, &_px_unit); sp_document_done (doc, SP_VERB_NONE, - /* TODO: annotate */ "page-sizer.cpp:301"); + /* TODO: annotate */ "page-sizer.cpp:301"); } - _landscape = w>h; + _landscape = ( w > h ); _landscapeButton.set_active(_landscape ? true : false); _portraitButton.set_active (_landscape ? false : true); if (changeList) _paperSizeList.set_active (find_paper_size (w, h)); - Unit const& unit = _rum._sel->getUnit(); - _rusw.setValue (w / unit.factor); - _rush.setValue (h / unit.factor); + Unit const& unit = _dimensionUnits._sel->getUnit(); + _dimensionWidth.setValue (w / unit.factor); + _dimensionHeight.setValue (h / unit.factor); _paper_size_list_connection.unblock(); _landscape_connection.unblock(); @@ -357,8 +329,9 @@ PageSizer::setDim (double w, double h, bool changeList) _called = false; } + /** - * Returns an index into inkscape_papers of a paper of the specified + * Returns an index into paperSizeTable of a paper of the specified * size (specified in px), or -1 if there's no such paper. */ int @@ -391,19 +364,30 @@ PageSizer::find_paper_size (double w, double h) const return -1; } + + +/** + * Tell the desktop to change the page size + */ void -PageSizer::fire_fit_canvas_to_selection_or_drawing() { +PageSizer::fire_fit_canvas_to_selection_or_drawing() +{ SPDesktop *dt = SP_ACTIVE_DESKTOP; - if (!dt) return; + if (!dt) + return; Verb *verb = Verb::get( SP_VERB_FIT_CANVAS_TO_SELECTION_OR_DRAWING ); if (verb) { SPAction *action = verb->get_action(dt); - if (action) { + if (action) sp_action_perform(action, NULL); - } } } + + +/** + * Paper Size list callback for when a user changes the selection + */ void PageSizer::on_paper_size_list_changed() { @@ -420,6 +404,7 @@ PageSizer::on_paper_size_list_changed() SPUnit const &src_unit = sp_unit_get_by_id (paper.unit); sp_convert_distance (&w, &src_unit, &_px_unit); sp_convert_distance (&h, &src_unit, &_px_unit); + if (_landscape) setDim (h, w, false); else @@ -427,37 +412,49 @@ PageSizer::on_paper_size_list_changed() } + +/** + * Portrait button callback + */ void PageSizer::on_portrait() { if (!_portraitButton.get_active()) return; - double w = _rusw.getSU()->getValue ("px"); - double h = _rush.getSU()->getValue ("px"); - if (hgetValue ("px"); + double h = _dimensionHeight.getSU()->getValue ("px"); + if (h < w) setDim (h, w); } + +/** + * Landscape button callback + */ void PageSizer::on_landscape() { if (!_landscapeButton.get_active()) return; - double w = _rusw.getSU()->getValue ("px"); - double h = _rush.getSU()->getValue ("px"); - if (wgetValue ("px"); + double h = _dimensionHeight.getSU()->getValue ("px"); + if (w < h) setDim (h, w); } +/** + * Callback for the dimension widgets + */ void PageSizer::on_value_changed() { - if (_wr->isUpdating()) return; + if (_widgetRegistry->isUpdating()) return; - setDim (_rusw.getSU()->getValue("px"), - _rush.getSU()->getValue("px")); + setDim (_dimensionWidth.getSU()->getValue("px"), + _dimensionHeight.getSU()->getValue("px")); } + } // namespace Widget } // namespace UI } // namespace Inkscape diff --git a/src/ui/widget/page-sizer.h b/src/ui/widget/page-sizer.h index d5934be04..b4b6145a8 100644 --- a/src/ui/widget/page-sizer.h +++ b/src/ui/widget/page-sizer.h @@ -4,7 +4,7 @@ * Author: * Ralf Stephan * - * Copyright (C) 2005 Authors + * Copyright (C) 2005-2006 Authors * * Released under GNU GPL. Read the file 'COPYING' for more information. */ @@ -12,8 +12,8 @@ #ifndef INKSCAPE_UI_WIDGET_PAGE_SIZER__H #define INKSCAPE_UI_WIDGET_PAGE_SIZER__H -#include #include +#include #include "ui/widget/registry.h" #include "ui/widget/registered-widget.h" #include "helper/units.h" @@ -24,13 +24,22 @@ namespace UI { namespace Widget { /** - * Class used to store common paper dimensions + * Data class used to store common paper dimensions. Used to make + * PageSizer's _paperSizeTable. */ class PaperSize { public: + + /** + * Default constructor + */ PaperSize() { init(); } + + /** + * Main constructor. Use this one. + */ PaperSize(const Glib::ustring &nameArg, double smallerArg, double largerArg, @@ -42,15 +51,46 @@ public: unit = unitArg; } + /** + * Copy constructor + */ PaperSize(const PaperSize &other) { assign(other); } + /** + * Assignment operator + */ PaperSize &operator=(const PaperSize &other) { assign(other); return *this; } + /** + * Destructor + */ virtual ~PaperSize() {} + /** + * Name of this paper specification + */ + Glib::ustring name; + + /** + * The lesser of the two dimensions + */ + double smaller; + + /** + * The greater of the two dimensions + */ + double larger; + + /** + * The units (px, pt, mm, etc) of this specification + */ + SPUnitId unit; + +private: + void init() { name = ""; @@ -67,10 +107,6 @@ public: unit = other.unit; } - Glib::ustring name; - double smaller; - double larger; - SPUnitId unit; }; @@ -78,7 +114,8 @@ public: /** - * Widget containing all widgets for specifying page size. + * A compound widget that allows the user to select the desired + * page size. This widget is used in DocumentPreferences */ class PageSizer : public Gtk::VBox { @@ -94,34 +131,63 @@ public: */ virtual ~PageSizer(); + /** + * Set up or reset this widget + */ void init (Registry& reg); + + /** + * Set the page size to the given dimensions. If 'changeList' is + * true, then reset the paper size list to the closest match + */ void setDim (double w, double h, bool changeList=true); - bool _landscape; - + protected: + /** + * Our handy table of all 'standard' paper sizes. + */ + std::map paperSizeTable; + + /** + * Find the closest standard paper size in the table, to the + */ int find_paper_size (double w, double h) const; + void fire_fit_canvas_to_selection_or_drawing(); - void on_portrait(); - void on_landscape(); - void on_value_changed(); - void on_paper_size_list_changed(); - RegisteredUnitMenu _rum; - RegisteredScalarUnit _rusw, _rush; + //### Dimension spinboxes + RegisteredUnitMenu _dimensionUnits; + RegisteredScalarUnit _dimensionWidth; + RegisteredScalarUnit _dimensionHeight; + //callback + void on_value_changed(); + sigc::connection _changedw_connection; + sigc::connection _changedh_connection; - //# Various things for a ComboBox + //### The Paper Size selection list Gtk::ComboBoxText _paperSizeList; - std::map paperSizeTable; + //callback + void on_paper_size_list_changed(); + sigc::connection _paper_size_list_connection; + //### Button to select 'portrait' orientation Gtk::RadioButton _portraitButton; - Gtk::RadioButton _landscapeButton; - sigc::connection _paper_size_list_connection; + //callback + void on_portrait(); sigc::connection _portrait_connection; + + //### Button to select 'landscape' orientation + Gtk::RadioButton _landscapeButton; + //callback + void on_landscape(); sigc::connection _landscape_connection; - sigc::connection _changedw_connection; - sigc::connection _changedh_connection; - Registry *_wr; + + Registry *_widgetRegistry; + + //### state - whether we are currently landscape or portrait + bool _landscape; + }; } // namespace Widget -- 2.30.2