From 83b767360a183abf29cb0cc0fd647fb683cff616 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Mon, 17 Nov 2008 07:54:07 -0800 Subject: [PATCH] builtin-remote.c: plug a small memory leak in get_one_remote_for_updates() We know that the string pointed at by remote->name won't change. It can be borrowed as the key in the string_list without copying. Other parts of existing code such as get_one_entry() already rely on this fact. Noticed by Cheng Renquan. Signed-off-by: Junio C Hamano --- builtin-remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin-remote.c b/builtin-remote.c index d032f2535..14774e36c 100644 --- a/builtin-remote.c +++ b/builtin-remote.c @@ -770,7 +770,7 @@ static int get_one_remote_for_update(struct remote *remote, void *priv) { struct string_list *list = priv; if (!remote->skip_default_update) - string_list_append(xstrdup(remote->name), list); + string_list_append(remote->name, list); return 0; } -- 2.30.2