From 7f8e1ac5e77f7c82381af27d7727ddd3b9361c04 Mon Sep 17 00:00:00 2001 From: Florian Forster Date: Tue, 1 Jun 2010 16:17:31 +0200 Subject: [PATCH] libvirt plugin: Don't copy a string if it is not necessary. --- src/libvirt.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index d97f90a4..6732656e 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -113,7 +113,6 @@ static enum hf_field hostname_format[HF_MAX_FIELDS] = { hf_name }; /* InterfaceFormat. */ - enum if_field { if_address, if_name @@ -253,24 +252,14 @@ lv_config (const char *key, const char *value) } if (strcasecmp (key, "InterfaceFormat") == 0) { - char *value_copy; - - value_copy = strdup (value); - if (value_copy == NULL) { - ERROR ("libvirt plugin: strdup failed."); - return -1; - } - - if (strcasecmp (value_copy, "name") == 0) + if (strcasecmp (value, "name") == 0) interface_format = if_name; - else if (strcasecmp (value_copy, "address") == 0) + else if (strcasecmp (value, "address") == 0) interface_format = if_address; else { - free (value_copy); - ERROR ("unknown InterfaceFormat: %s", value_copy); + ERROR ("unknown InterfaceFormat: %s", value); return -1; } - free (value_copy); return 0; } -- 2.30.2