From 7447b4bc837d2f73fb4cd34f2a44a0cb120c5c39 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 14 Feb 2007 18:38:46 -0800 Subject: [PATCH] git-svn: error checking for invalid [svn-remote "..."] sections We don't end up trying to pass an undef URL over to SVN::Ra->new because it'll segfault. Signed-off-by: Eric Wong --- git-svn.perl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index ace31021e..201418e09 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -753,9 +753,10 @@ sub parse_revision_argument { sub fetch_all { my ($repo_id, $remotes) = @_; - my $remote = $remotes->{$repo_id}; + my $remote = $remotes->{$repo_id} or + die "[svn-remote \"$repo_id\"] unknown\n"; my $fetch = $remote->{fetch}; - my $url = $remote->{url}; + my $url = $remote->{url} or die "svn-remote.$repo_id.url not defined\n"; my (@gs, @globs); my $ra = Git::SVN::Ra->new($url); my $uuid = $ra->get_uuid; -- 2.30.2