From 70d7099916c9621e157c620f9cc7fc982f109c55 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 30 Dec 2009 04:02:53 -0500 Subject: [PATCH] textconv: stop leaking file descriptors We read the output from textconv helpers over a pipe, but we never actually closed our end of the pipe after using it. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/diff.c b/diff.c index 387d19fde..69147b802 100644 --- a/diff.c +++ b/diff.c @@ -3485,11 +3485,13 @@ static char *run_textconv(const char *pgm, struct diff_filespec *spec, if (start_command(&child) != 0 || strbuf_read(&buf, child.out, 0) < 0 || finish_command(&child) != 0) { + close(child.out); if (temp.name == temp.tmp_path) unlink(temp.name); error("error running textconv command '%s'", pgm); return NULL; } + close(child.out); if (temp.name == temp.tmp_path) unlink(temp.name); -- 2.30.2