From 6be256a584f4d19d105f6fa06e5634cedc21db64 Mon Sep 17 00:00:00 2001 From: Marc Fournier Date: Thu, 19 Sep 2013 23:27:02 +0200 Subject: [PATCH] switch default write_graphite protocol back to TCP The *default* protocol was switched to UDP in 498a0dcd, when UDP support was added to the plugin. Switching this default back to TCP, because it makes the plugin break for users upgrading to 5.4, and also because the UDP listener is disabled in a default graphite installation (cf. https://github.com/graphite-project/carbon/blob/0.9.x/conf/carbon.conf.example#L78) Fixes GH#428 --- src/collectd.conf.in | 2 +- src/collectd.conf.pod | 4 ++-- src/write_graphite.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/collectd.conf.in b/src/collectd.conf.in index f93cda5c..6d19c322 100644 --- a/src/collectd.conf.in +++ b/src/collectd.conf.in @@ -1133,7 +1133,7 @@ # # Host "localhost" # Port "2003" -# Protocol "udp" +# Protocol "tcp" # LogSendErrors true # Prefix "collectd" # Postfix "collectd" diff --git a/src/collectd.conf.pod b/src/collectd.conf.pod index 2aebbd3a..4bd8aac3 100644 --- a/src/collectd.conf.pod +++ b/src/collectd.conf.pod @@ -6085,7 +6085,7 @@ Synopsis: Host "localhost" Port "2003" - Protocol "udp" + Protocol "tcp" LogSendErrors true Prefix "collectd" @@ -6106,7 +6106,7 @@ Service name or port number to connect to. Defaults to C<2003>. =item B I -Protocol to use when connecting to I. Defaults to C. +Protocol to use when connecting to I. Defaults to C. =item B B|B diff --git a/src/write_graphite.c b/src/write_graphite.c index 6124d33e..667c11e3 100644 --- a/src/write_graphite.c +++ b/src/write_graphite.c @@ -67,7 +67,7 @@ #endif #ifndef WG_DEFAULT_PROTOCOL -# define WG_DEFAULT_PROTOCOL "udp" +# define WG_DEFAULT_PROTOCOL "tcp" #endif #ifndef WG_DEFAULT_LOG_SEND_ERRORS -- 2.30.2