From 62b8102c60a716e66cfd2a33e596e9d5be134267 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Sat, 12 Feb 2011 00:18:51 -0500 Subject: [PATCH] string_list_append: always set util pointer to NULL It is not immediately obvious that the util field may contain random bytes after appending an item. Especially since the string_list_insert* functions _do_ explicitly zero the util pointer. This does not appear to be a bug in any current git code, as all callers either fill in the util field immediately or never use it. However, it is worth it to be less surprising to new users of the string-list API who may expect it to be intialized to NULL. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- string-list.c | 1 + 1 file changed, 1 insertion(+) diff --git a/string-list.c b/string-list.c index 9b023a258..51681189e 100644 --- a/string-list.c +++ b/string-list.c @@ -153,6 +153,7 @@ struct string_list_item *string_list_append(struct string_list *list, const char ALLOC_GROW(list->items, list->nr + 1, list->alloc); list->items[list->nr].string = list->strdup_strings ? xstrdup(string) : (char *)string; + list->items[list->nr].util = NULL; return list->items + list->nr++; } -- 2.30.2