From 5ffa49e50eeaf421361fb64ad7105f185251f59f Mon Sep 17 00:00:00 2001 From: Sebastian Harl Date: Sat, 16 Feb 2008 14:09:36 +0100 Subject: [PATCH] perl plugin: Do not abort while preparing the stack for a subroutine call. Else the stack would probably be left in an inconsistent case and might even leak memory. Signed-off-by: Sebastian Harl Signed-off-by: Florian Forster --- src/perl.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/perl.c b/src/perl.c index 3c50528f..7558a506 100644 --- a/src/perl.c +++ b/src/perl.c @@ -700,11 +700,19 @@ static int pplugin_call_all (pTHX_ int type, ...) ds = va_arg (ap, data_set_t *); vl = va_arg (ap, value_list_t *); - if (-1 == data_set2av (aTHX_ ds, pds)) - return -1; + if (-1 == data_set2av (aTHX_ ds, pds)) { + av_clear (pds); + av_undef (pds); + pds = Nullav; + ret = -1; + } - if (-1 == value_list2hv (aTHX_ vl, ds, pvl)) - return -1; + if (-1 == value_list2hv (aTHX_ vl, ds, pvl)) { + hv_clear (pvl); + hv_undef (pvl); + pvl = Nullhv; + ret = -1; + } XPUSHs (sv_2mortal (newSVpv (ds->type, 0))); XPUSHs (sv_2mortal (newRV_noinc ((SV *)pds))); @@ -738,8 +746,12 @@ static int pplugin_call_all (pTHX_ int type, ...) n = va_arg (ap, notification_t *); - if (-1 == notification2hv (aTHX_ n, notif)) - return -1; + if (-1 == notification2hv (aTHX_ n, notif)) { + hv_clear (notif); + hv_undef (notif); + notif = Nullhv; + ret = -1; + } XPUSHs (sv_2mortal (newRV_noinc ((SV *)notif))); } -- 2.30.2