From 534376ca04d524b99d69a30bdcf5e70ac8062aee Mon Sep 17 00:00:00 2001 From: Jeff King Date: Mon, 12 Dec 2011 16:54:42 -0500 Subject: [PATCH] mv: be quiet about overwriting When a user asks us to force a mv and overwrite the destination, we print a warning. However, since a typical use would be: $ git mv one two fatal: destination exists, source=one, destination=two $ git mv -f one two warning: overwriting 'two' this warning is just noise. We already know we're overwriting; that's why we gave -f! This patch silences the warning unless "--verbose" is given. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- builtin/mv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/builtin/mv.c b/builtin/mv.c index 4a8374f63..10154bb31 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -173,7 +173,8 @@ int cmd_mv(int argc, const char **argv, const char *prefix) * check both source and destination */ if (S_ISREG(st.st_mode) || S_ISLNK(st.st_mode)) { - warning(_("overwriting '%s'"), dst); + if (verbose) + warning(_("overwriting '%s'"), dst); bad = NULL; } else bad = _("Cannot overwrite"); -- 2.30.2