From 393402bd6f7875b422726b00aad7c69bdaca55e7 Mon Sep 17 00:00:00 2001
From: hickert <hickert@594d385d-05f5-0310-b6e9-bd551577e9d8>
Date: Mon, 14 May 2007 12:35:47 +0000
Subject: [PATCH] Added some checks to logging class

git-svn-id: https://oss.gonicus.de/repositories/gosa/trunk@6370 594d385d-05f5-0310-b6e9-bd551577e9d8
---
 include/class_log.inc | 50 +++++++++++++++++++++++++++++++++----------
 1 file changed, 39 insertions(+), 11 deletions(-)

diff --git a/include/class_log.inc b/include/class_log.inc
index b46a5adc9..2a9810f38 100644
--- a/include/class_log.inc
+++ b/include/class_log.inc
@@ -58,20 +58,48 @@ class log {
     /* Create data object */
     $entry = array(); 
     $entry['timestamp'] = time();
-    $entry['user']  =$ui->dn;
-    $entry['action'] = $action;
-    $entry['objecttype'] = $objecttype;
-    $entry['object'] = $object;
-    $entry['changes'] = $changes;
-    $entry['result'] = $result;
+    $entry['user']      = $ui->dn;
+    $entry['action']    = $action;
+    $entry['objecttype']= $objecttype;
+    $entry['object']    = $object;
+    $entry['changes']   = $changes;
+    $entry['result']    = $result;
  
-    /* Start logging for configured methods */
-    if(isset($this->config->current['LOGGING']) && preg_match("/(^|,)syslog(,|$)/i",$this->config->current['LOGGING'])){
-      @log::log_into_syslog($entry);
+    /* Check if all given values are valid */
+    $msgs = @log::check($entry);
+    if(count($msgs)){
+      foreach($msgs as $msg){
+        trigger_error("Logging failed, reason was: ".$msg);
+      }
+    }else{
+
+      /* Start logging for configured methods */
+      if(isset($this->config->current['LOGGING']) && preg_match("/(^|,)syslog(,|$)/i",$this->config->current['LOGGING'])){
+        @log::log_into_syslog($entry);
+      }
+      if(isset($this->config->current['LOGGING']) && preg_match("/(^|,)mysql(,|$)/i",$this->config->current['LOGGING'])){
+        @log::log_into_db($entry);
+      }
+    }
+  }
+
+
+  function check($entry = array())
+  {
+    $msgs = array();
+    if(!isset($entry['user']) || empty($entry['user'])){
+      $msgs[] = "Currently active user is empty.";
     }
-    if(isset($this->config->current['LOGGING']) && preg_match("/(^|,)mysql(,|$)/i",$this->config->current['LOGGING'])){
-      @log::log_into_db($entry);
+
+    if(!isset($entry['action']) || !in_array($entry['action'],array("modify","create","remove","copy","snapshot"))){
+      $msgs[] = "Invalid option specified '".$entry['action']."'";
     }
+
+    if(!isset($entry['objecttype']) || empty($entry['objecttype'])){
+      $msgs[] = "Specified objectType is empty or invalid.";
+    }
+  
+    return($msgs);
   }
 
    
-- 
2.30.2