From 36acd5f8c2988c2b73fee670b2d37cb38f5c518b Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Sun, 21 Sep 2008 13:48:44 +0200 Subject: [PATCH] screen_help: removed update() method Why redraw the help screen when nothing has changed? Redraw it only after help_cmd(), and when explicitly requested (help_paint()). --- src/screen_help.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/screen_help.c b/src/screen_help.c index 07e3375..7416e6e 100644 --- a/src/screen_help.c +++ b/src/screen_help.c @@ -216,22 +216,14 @@ help_paint(mpd_unused screen_t *screen, mpd_unused mpdclient_t *c) wrefresh(lw->w); } -static void -help_update(mpd_unused screen_t *screen, mpd_unused mpdclient_t *c) -{ - if (lw->repaint) { - list_window_paint(lw, list_callback, NULL); - wrefresh(lw->w); - lw->repaint = 0; - } -} - - static int help_cmd(screen_t *screen, mpd_unused mpdclient_t *c, command_t cmd) { - if (list_window_scroll_cmd(lw, help_text_rows, cmd)) + if (list_window_scroll_cmd(lw, help_text_rows, cmd)) { + list_window_paint(lw, list_callback, NULL); + wrefresh(lw->w); return 1; + } lw->selected = lw->start+lw->rows; if (screen_find(screen, @@ -239,6 +231,8 @@ help_cmd(screen_t *screen, mpd_unused mpdclient_t *c, command_t cmd) cmd, list_callback, NULL)) { /* center the row */ list_window_center(lw, help_text_rows, lw->selected); + list_window_paint(lw, list_callback, NULL); + wrefresh(lw->w); return 1; } @@ -250,7 +244,6 @@ const struct screen_functions screen_help = { .exit = help_exit, .resize = help_resize, .paint = help_paint, - .update = help_update, .cmd = help_cmd, .get_title = help_title, }; -- 2.30.2