From 3458b7647a8a5b7555b3fb0097d81bda4923e7c6 Mon Sep 17 00:00:00 2001 From: Michael Leinartas Date: Mon, 12 Sep 2016 10:20:34 -0500 Subject: [PATCH] Update collectd.conf manpage and address style issues --- src/collectd.conf.pod | 6 ++++++ src/utils_format_graphite.c | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/src/collectd.conf.pod b/src/collectd.conf.pod index 0fa74d54..c7a818dd 100644 --- a/src/collectd.conf.pod +++ b/src/collectd.conf.pod @@ -7818,6 +7818,12 @@ If set to B, append the name of the I (DS) to the "metric" identifier. If set to B (the default), this is only done when there is more than one DS. +=item B B|B + +If set to B, detect and remove duplicate components in Graphite metric +names. For example, the metric name C will +be shortened to C. + =back =head2 Plugin C diff --git a/src/utils_format_graphite.c b/src/utils_format_graphite.c index c7262655..904f43c5 100644 --- a/src/utils_format_graphite.c +++ b/src/utils_format_graphite.c @@ -151,12 +151,16 @@ static int gr_format_name (char *ret, int ret_len, if (n_type_instance[0] != '\0') if ((flags & GRAPHITE_DROP_DUPE_FIELDS) && strcmp(n_plugin, n_type) == 0) + { sstrncpy (tmp_type, n_type_instance, sizeof (tmp_type)); + } else + { ssnprintf (tmp_type, sizeof (tmp_type), "%s%c%s", n_type, (flags & GRAPHITE_SEPARATE_INSTANCES) ? '.' : '-', n_type_instance); + } else sstrncpy (tmp_type, n_type, sizeof (tmp_type)); @@ -164,11 +168,15 @@ static int gr_format_name (char *ret, int ret_len, assert (!(flags & GRAPHITE_ALWAYS_APPEND_DS) || (ds_name != NULL)); if (ds_name != NULL) if ((flags & GRAPHITE_DROP_DUPE_FIELDS) && strcmp(tmp_plugin, tmp_type) == 0) + { ssnprintf (ret, ret_len, "%s%s%s.%s.%s", prefix, n_host, postfix, tmp_plugin, ds_name); + } else + { ssnprintf (ret, ret_len, "%s%s%s.%s.%s.%s", prefix, n_host, postfix, tmp_plugin, tmp_type, ds_name); + } else ssnprintf (ret, ret_len, "%s%s%s.%s.%s", prefix, n_host, postfix, tmp_plugin, tmp_type); -- 2.30.2