From 292c8b38be2e6c9f3eba6c8a99b29feaa636901d Mon Sep 17 00:00:00 2001 From: rochecompaan Date: Wed, 24 Apr 2002 08:34:35 +0000 Subject: [PATCH] Sorting was applied to all nodes of the MultiLink class instead of the nodes that are actually linked to in the "field" template function. This adds about 20+ seconds in the display of an issue if your database has a 1000 or more issue in it. git-svn-id: http://svn.roundup-tracker.org/svnroot/roundup/trunk@710 57a73879-2fb5-44c3-a270-3262357dd7e2 --- CHANGES.txt | 4 ++++ roundup/htmltemplate.py | 10 ++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 1650c39..959ea21 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -26,6 +26,10 @@ Fixed: . stop sending blank (whitespace-only) notes . cleanup of serialisation for database storage . node ids are now generated from a lockable store - no more race conditions + . sorting was applied to all nodes of the MultiLink class instead of + to the nodes that are actually linked to in the "field" template + function. This adds about 20+ seconds in the display of an issue if + your database has a 1000 or more issues in it. 2002-03-25 - 0.4.1 diff --git a/roundup/htmltemplate.py b/roundup/htmltemplate.py index 5fd46f5..e04cb86 100644 --- a/roundup/htmltemplate.py +++ b/roundup/htmltemplate.py @@ -15,7 +15,7 @@ # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE, # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. # -# $Id: htmltemplate.py,v 1.87 2002-04-03 06:12:46 richard Exp $ +# $Id: htmltemplate.py,v 1.88 2002-04-24 08:34:35 rochecompaan Exp $ __doc__ = """ Template engine. @@ -223,9 +223,8 @@ class TemplateFunctions: elif isinstance(propclass, hyperdb.Multilink): sortfunc = self.make_sort_function(propclass.classname) linkcl = self.db.classes[propclass.classname] - list = linkcl.list() - list.sort(sortfunc) - l = [] + if value: + value.sort(sortfunc) # map the id to the label property if not showid: k = linkcl.labelprop() @@ -1128,6 +1127,9 @@ class NewItemTemplate(TemplateFunctions): # # $Log: not supported by cvs2svn $ +# Revision 1.87 2002/04/03 06:12:46 richard +# Fix for date properties as labels. +# # Revision 1.86 2002/04/03 05:54:31 richard # Fixed serialisation problem by moving the serialisation step out of the # hyperdb.Class (get, set) into the hyperdb.Database. -- 2.30.2