From 254cf9ac51c78ed22896fc22053db1a4f1a5da12 Mon Sep 17 00:00:00 2001 From: buliabyak Date: Sun, 7 Jan 2007 13:48:46 +0000 Subject: [PATCH] comment on possible optimization --- src/display/nr-arena-item.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/display/nr-arena-item.cpp b/src/display/nr-arena-item.cpp index 0657144ed..e7eab8b85 100644 --- a/src/display/nr-arena-item.cpp +++ b/src/display/nr-arena-item.cpp @@ -262,7 +262,10 @@ nr_arena_item_invoke_update (NRArenaItem *item, NRRectL *area, NRGC *gc, /* Clipping */ if (item->clip) { - unsigned int newstate = nr_arena_item_invoke_update (item->clip, area, &childgc, state, reset); + // FIXME: since here we only need bbox, consider passing + // ((state & !(NR_ARENA_ITEM_STATE_RENDER)) | NR_ARENA_ITEM_STATE_BBOX) + // instead of state, so it does not have to create rendering structures in nr_arena_shape_update + unsigned int newstate = nr_arena_item_invoke_update (item->clip, area, &childgc, state, reset); if (newstate & NR_ARENA_ITEM_STATE_INVALID) { item->state |= NR_ARENA_ITEM_STATE_INVALID; return item->state; -- 2.39.5