From 137a0d0ef568f0a2468c8c7f053ef113e295842f Mon Sep 17 00:00:00 2001 From: Johannes Sixt Date: Mon, 19 Nov 2007 20:48:58 +0100 Subject: [PATCH] Flush progress message buffer in display(). This will make progress display from pack-objects (invoked via upload-pack) more responsive on platforms with an implementation of stdio whose stderr is line buffered. The standard error stream is defined to be merely "not fully buffered"; this is different from "unbuffered". If the implementation of the stdio library chooses to make it line buffered, progress reports that end with CR but do not contain LF will accumulate in the stdio buffer before written out. A fflush() after each progress display gives a nice continuous progress. Signed-off-by: Johannes Sixt Signed-off-by: Junio C Hamano --- progress.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/progress.c b/progress.c index 4bd650f9b..d19f80c0b 100644 --- a/progress.c +++ b/progress.c @@ -98,11 +98,13 @@ static int display(struct progress *progress, unsigned n, const char *done) fprintf(stderr, "%s: %3u%% (%u/%u)%s%s", progress->title, percent, n, progress->total, tp, eol); + fflush(stderr); progress_update = 0; return 1; } } else if (progress_update) { fprintf(stderr, "%s: %u%s%s", progress->title, n, tp, eol); + fflush(stderr); progress_update = 0; return 1; } @@ -207,6 +209,7 @@ struct progress *start_progress_delay(const char *title, unsigned total, if (!progress) { /* unlikely, but here's a good fallback */ fprintf(stderr, "%s...\n", title); + fflush(stderr); return NULL; } progress->title = title; -- 2.30.2