From 135a522e3f0ddc85664b3cd094918f095ac76d79 Mon Sep 17 00:00:00 2001 From: Peter Baumann Date: Fri, 7 Jul 2006 12:55:41 +0200 Subject: [PATCH] git-cvsexportcommit can't handle merge commits correctly git-cvsexportcommit should check if the parent (supplied on the cmdline) to use for a merge commit is one of the real parents of the merge. But it errors out if the _first_ parent doesn't match and never checks the other parents. Signed-off-by: Peter Baumann Signed-off-by: Junio C Hamano --- git-cvsexportcommit.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl index d1051d074..5dcb2f9a8 100755 --- a/git-cvsexportcommit.perl +++ b/git-cvsexportcommit.perl @@ -63,15 +63,15 @@ foreach my $p (@commit) { } if ($parent) { + my $found; # double check that it's a valid parent foreach my $p (@parents) { - my $found; if ($p eq $parent) { $found = 1; last; }; # found it - die "Did not find $parent in the parents for this commit!"; } + die "Did not find $parent in the parents for this commit!" if !$found; } else { # we don't have a parent from the cmdline... if (@parents == 1) { # it's safe to get it from the commit $parent = $parents[0]; -- 2.30.2