From 118d938812f3fc660f43bad9b546e7dadc3571a9 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Wed, 26 Aug 2009 17:39:45 -0700 Subject: [PATCH] git-gui: Ensure submodule path is quoted properly When quoting an arbitrary user string in Tcl, its better to use [list ...] than to use {...}, in case the user string has spaces or { embedded within it. Signed-off-by: Shawn O. Pearce --- lib/diff.tcl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/diff.tcl b/lib/diff.tcl index d593323ae..bd5d189ed 100644 --- a/lib/diff.tcl +++ b/lib/diff.tcl @@ -300,9 +300,9 @@ proc start_show_diff {cont_info {add_opts {}}} { || [string match {160000 *} [lindex $s 3]]} { set is_submodule_diff 1 if {$w eq $ui_index} { - set cmd {submodule summary --cached -- $current_diff_path} + set cmd [list submodule summary --cached -- $path] } else { - set cmd {submodule summary --files -- $current_diff_path} + set cmd [list submodule summary --files -- $path] } } -- 2.30.2