From 0b1f113075aafb0c91a406d984d0152e55c981da Mon Sep 17 00:00:00 2001 From: Carlos Rica Date: Fri, 25 May 2007 03:46:22 +0200 Subject: [PATCH] fix memory leak in parse_object when check_sha1_signature fails When check_sha1_signature fails, program is not terminated: it prints an error message and returns NULL, so the buffer returned by read_sha1_file should be freed before. Signed-off-by: Carlos Rica Signed-off-by: Junio C Hamano --- object.c | 1 + 1 file changed, 1 insertion(+) diff --git a/object.c b/object.c index 78a44a6ef..ccd7dd796 100644 --- a/object.c +++ b/object.c @@ -185,6 +185,7 @@ struct object *parse_object(const unsigned char *sha1) if (buffer) { struct object *obj; if (check_sha1_signature(sha1, buffer, size, typename(type)) < 0) { + free(buffer); error("sha1 mismatch %s\n", sha1_to_hex(sha1)); return NULL; } -- 2.30.2