From 064d51dc40bc9df75279ca3346cd84c2611c6aba Mon Sep 17 00:00:00 2001 From: Michael Haggerty Date: Mon, 12 Dec 2011 06:38:20 +0100 Subject: [PATCH] resolve_gitlink_ref_recursive(): change to work with struct ref_cache resolve_gitlink_ref() and resolve_gitlink_ref_recursive(), together, basically duplicated the code in git_path_submodule(). So use that function instead. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano --- refs.c | 34 ++++++++++------------------------ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/refs.c b/refs.c index bf1f16433..ba7a8b020 100644 --- a/refs.c +++ b/refs.c @@ -431,17 +431,19 @@ static int resolve_gitlink_packed_ref(struct ref_cache *refs, } static int resolve_gitlink_ref_recursive(struct ref_cache *refs, - char *name, int pathlen, const char *refname, unsigned char *sha1, int recursion) { - int fd, len = strlen(refname); + int fd, len; char buffer[128], *p; + char *path; - if (recursion > MAXDEPTH || len > MAXREFLEN) + if (recursion > MAXDEPTH || strlen(refname) > MAXREFLEN) return -1; - memcpy(name + pathlen, refname, len+1); - fd = open(name, O_RDONLY); + path = *refs->name + ? git_path_submodule(refs->name, "%s", refname) + : git_path("%s", refname); + fd = open(path, O_RDONLY); if (fd < 0) return resolve_gitlink_packed_ref(refs, refname, sha1); @@ -464,15 +466,14 @@ static int resolve_gitlink_ref_recursive(struct ref_cache *refs, while (isspace(*p)) p++; - return resolve_gitlink_ref_recursive(refs, name, pathlen, p, sha1, recursion+1); + return resolve_gitlink_ref_recursive(refs, p, sha1, recursion+1); } int resolve_gitlink_ref(const char *path, const char *refname, unsigned char *sha1) { int len = strlen(path), retval; - char *submodule, *gitdir; + char *submodule; struct ref_cache *refs; - const char *tmp; while (len && path[len-1] == '/') len--; @@ -482,22 +483,7 @@ int resolve_gitlink_ref(const char *path, const char *refname, unsigned char *sh refs = get_ref_cache(submodule); free(submodule); - gitdir = xmalloc(len + MAXREFLEN + 8); - memcpy(gitdir, path, len); - memcpy(gitdir + len, "/.git", 6); - len += 5; - - tmp = read_gitfile(gitdir); - if (tmp) { - free(gitdir); - len = strlen(tmp); - gitdir = xmalloc(len + MAXREFLEN + 3); - memcpy(gitdir, tmp, len); - } - gitdir[len] = '/'; - gitdir[++len] = '\0'; - retval = resolve_gitlink_ref_recursive(refs, gitdir, len, refname, sha1, 0); - free(gitdir); + retval = resolve_gitlink_ref_recursive(refs, refname, sha1, 0); return retval; } -- 2.30.2