From 057bc808b4aa2e7795f9bd395e68071301bc0b74 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Sat, 11 Nov 2006 14:45:35 -0800 Subject: [PATCH] path-list: fix path-list-insert return value When path-list-insert is called on an existing path, it returned an unrelated element in the list. Luckily most of the callers are ignoring the return value, but merge-recursive uses it at three places and this would have resulted in a bogus rename detection. Signed-off-by: Junio C Hamano --- path-list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/path-list.c b/path-list.c index 0c332dc7b..f8800f8e6 100644 --- a/path-list.c +++ b/path-list.c @@ -57,7 +57,7 @@ struct path_list_item *path_list_insert(const char *path, struct path_list *list int index = add_entry(list, path); if (index < 0) - index = 1 - index; + index = -1 - index; return list->items + index; } -- 2.30.2