Code

gitweb: allow configurations that change with each request
authorJonathan Nieder <jrnieder@gmail.com>
Sat, 31 Jul 2010 03:01:59 +0000 (22:01 -0500)
committerJunio C Hamano <gitster@pobox.com>
Mon, 2 Aug 2010 18:47:07 +0000 (11:47 -0700)
commit7f425db9146b7ec8c67edfd8b49218cc110151ed
tree2cd5997a2c37d35d9d21a3d33ba8655b2f9ef03b
parent64fdc08dac6694d1e754580e7acb82dfa4988bb9
gitweb: allow configurations that change with each request

gitolite's contrib/gitweb/gitweb.conf includes:

$ENV{GL_USER} = $cgi->remote_user || "gitweb";

which is useful for setups where a user has to be authenticated
to access certain repos.  Perhaps other typical configurations
change per session in other ways, too.

v1.7.2-rc2~6 (gitweb: Move evaluate_gitweb_config out of run_request,
2010-07-05) broke such configurations for a speedup, by loading
the configuration once per FastCGI process.

Probably in the end there should be a way to specify in the
configuration whether a particular installation wants the speedup or
the flexibility.  But for now it is easier to just undo the relevant
change.

This partially reverts commit 869d58813b24c74e84c9388041eafcef40cb51e4.

Reported-by: Julio Lajara <julio.lajara@alum.rpi.edu>
Analysis-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl