author | Michal Ostrowski <mostrows@watson.ibm.com> | |
Wed, 11 Jan 2006 02:12:17 +0000 (21:12 -0500) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Sat, 14 Jan 2006 00:49:01 +0000 (16:49 -0800) | ||
commit | 77cb17e940c806a4cc811bfd66187277b729a1e7 | |
tree | aae0b04758379c89b2dd2d02dd44c97b4d33998f | tree | snapshot |
parent | c884dd9a54fcde71ea125c86e6b6ab92acbbc7cf | commit | diff |
Exec git programs without using PATH.
The git suite may not be in PATH (and thus programs such as
git-send-pack could not exec git-rev-list). Thus there is a need for
logic that will locate these programs. Modifying PATH is not
desirable as it result in behavior differing from the user's
intentions, as we may end up prepending "/usr/bin" to PATH.
- git C programs will use exec*_git_cmd() APIs to exec sub-commands.
- exec*_git_cmd() will execute a git program by searching for it in
the following directories:
1. --exec-path (as used by "git")
2. The GIT_EXEC_PATH environment variable.
3. $(gitexecdir) as set in Makefile (default value $(bindir)).
- git wrapper will modify PATH as before to enable shell scripts to
invoke "git-foo" commands.
Ideally, shell scripts should use the git wrapper to become independent
of PATH, and then modifying PATH will not be necessary.
[jc: with minor updates after a brief review.]
Signed-off-by: Michal Ostrowski <mostrows@watson.ibm.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
The git suite may not be in PATH (and thus programs such as
git-send-pack could not exec git-rev-list). Thus there is a need for
logic that will locate these programs. Modifying PATH is not
desirable as it result in behavior differing from the user's
intentions, as we may end up prepending "/usr/bin" to PATH.
- git C programs will use exec*_git_cmd() APIs to exec sub-commands.
- exec*_git_cmd() will execute a git program by searching for it in
the following directories:
1. --exec-path (as used by "git")
2. The GIT_EXEC_PATH environment variable.
3. $(gitexecdir) as set in Makefile (default value $(bindir)).
- git wrapper will modify PATH as before to enable shell scripts to
invoke "git-foo" commands.
Ideally, shell scripts should use the git wrapper to become independent
of PATH, and then modifying PATH will not be necessary.
[jc: with minor updates after a brief review.]
Signed-off-by: Michal Ostrowski <mostrows@watson.ibm.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
12 files changed:
Makefile | diff | blob | history | |
daemon.c | diff | blob | history | |
exec_cmd.c | [new file with mode: 0644] | blob |
exec_cmd.h | [new file with mode: 0644] | blob |
fetch-clone.c | diff | blob | history | |
git.c | diff | blob | history | |
receive-pack.c | diff | blob | history | |
run-command.c | diff | blob | history | |
run-command.h | diff | blob | history | |
send-pack.c | diff | blob | history | |
shell.c | diff | blob | history | |
upload-pack.c | diff | blob | history |