Code

[PATCH] plug memory leak in diff.c::diff_free_filepair()
authorYasushi SHOJI <yashi@atmark-techno.com>
Sat, 13 Aug 2005 10:58:56 +0000 (19:58 +0900)
committerJunio C Hamano <junkio@cox.net>
Sun, 14 Aug 2005 01:28:55 +0000 (18:28 -0700)
commit068eac91ce04b9aca163acb1927c3878c45d1a07
tree87b828dfa09d9e6f700abee565b48613cf15d5c1
parente54c5ea93e0785dfd37fd9201797977a02ca0ddb
[PATCH] plug memory leak in diff.c::diff_free_filepair()

When I run git-diff-tree on big change, it seems the command eats so
much memory.  so I just put git under valgrind to see what's going on.
diff_free_filespec_data() doesn't free diff_filespec itself.

[jc: I ended up doing things slightly differently from Yasushi's
patch.  The original idea was to use free_filespec_data() only to
free the data portion and keep useing the filespec itself, but
no existing code seems to do things that way, so I just yanked
that part out.]

Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
diff.c
diffcore-break.c
diffcore.h