Removed the `XXX_HAVE_READ' defines from all plugins.
build system: Do dependency checking in the configure script.
The plan is to remove the dependency defines from the plugins and do all that
in the configure script from now on.
The plan is to remove the dependency defines from the plugins and do all that
in the configure script from now on.
Merge branch 'collectd-4.0'
Bumped version to 4.0.4; Updated ChangeLog.
src/collectd-nagios.c: Copy the NAN-defines from `collectd.h'.
This should fix the bug reported by Daniel Leite.
This should fix the bug reported by Daniel Leite.
snmp plugin: Use several reading threads to parallelize the reading of SNMP hosts.
snmp plugin: Use the `snmp_sess_*' interface.
Apparently that's thread safe..
Apparently that's thread safe..
dns plugin: Check for `net/ppp_defs.h' and include it before `net/if_ppp.h' if it exists.
This hopefully solves build problems under OpenBSD.
This hopefully solves build problems under OpenBSD.
snmp plugin: Many important bugfixes.
It workes a lot better now :)
It workes a lot better now :)
memory plugin: Fix a typo in the Solaris code.
liboconfig: Added `%option noyywrap' to the scanner.
This should solve the link issues when collectd is built without flex being
installed.
This should solve the link issues when collectd is built without flex being
installed.
load plugin: Fix the Linux code that reads `/proc/loadavg'.
cpu, interface plugin: Fix compilation issues under Solaris.
Merge branch 'collectd-4.0'
Bumped version to 4.0.3.
ChangeLog, README: Documented the `--with-nan-emulation' option.
configure: Implemented `--with-nan-emulation' for crosscompiling.
When crosscompiling you cannot do the runtime checks for the (0.0 / 0.0) hack.
With this option you can force this implementation if neccessary.
When crosscompiling you cannot do the runtime checks for the (0.0 / 0.0) hack.
With this option you can force this implementation if neccessary.
src/Makefile.am: When building outside the source tree, install will fail
Signed-off-by: Ezra Peisach <epeisach@med-xtal.bu.edu>
Signed-off-by: Ezra Peisach <epeisach@med-xtal.bu.edu>
csv, rrdtool plugin: Initialize a buffer correctly.
While reading the source code, I found the following:
In csv.c (line 44) and rrdtool.c (line 363) (value_list_to_string) the
following syntax exists:
memset (buffer, '\0', sizeof (buffer_len));
The sizeof should be removed - assuming that the desire is to zero the buffer
and not the first four (sizeof(int)) bytes.
Based on the code paths - I do not see an information leak - or any security
implications...
While reading the source code, I found the following:
In csv.c (line 44) and rrdtool.c (line 363) (value_list_to_string) the
following syntax exists:
memset (buffer, '\0', sizeof (buffer_len));
The sizeof should be removed - assuming that the desire is to zero the buffer
and not the first four (sizeof(int)) bytes.
Based on the code paths - I do not see an information leak - or any security
implications...
Collectd::Unixsock: Implemented the `listval' method.
unixsock plugin: Implemented the `LISTVAL' command.
The LISTVAL command returnes a list of all available values and their timestamps.
The LISTVAL command returnes a list of all available values and their timestamps.
ChangeLog: Added changes for 4.0.3.
snmp plugin: Implemented the host-option `Interval'.
With this option hosts can be queried in different intervals, reducing the load
on devices with little CPU power, such as switches.
With this option hosts can be queried in different intervals, reducing the load
on devices with little CPU power, such as switches.
ping plugin: Actually check the uid, not the address of `getuid'.
xmms plugin: Added a plugin to graph bitrate and frequencies or files played by XMMS.
Of course, this is not the most useful plugin ever.. ;)
Of course, this is not the most useful plugin ever.. ;)
cpu plugin: Submit the right values in the Darwin code.
configure.in, src/Makefile.am: Only link against Net-SNMP if it is found.
snmp plugin: Use `size_t' for the OID length to be more portable.
Added initial version off cussh.pl to contrib/.
cussh (Collectd Unix Socket SHell) is a little interactive frontend for
the unixsock plugin. It supports two commands - GETVAL and PUTVAL - just
as the unixsock plugin itself.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
cussh (Collectd Unix Socket SHell) is a little interactive frontend for
the unixsock plugin. It supports two commands - GETVAL and PUTVAL - just
as the unixsock plugin itself.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
contrib/SpamAssassin/: Set default socket path to /var/run/collectd-email.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
email plugin: Set default path of the UNIX socket to $localstatedir.
In addition make it configurable using the "SocketFile" config option just
as for the unixsock plugin.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
In addition make it configurable using the "SocketFile" config option just
as for the unixsock plugin.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
unixsock plugin: Set default path of the UNIX socket to $localstatedir.
For this purpose LOCALSTATEDIR is defined to $localstatedir during
compilation.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
For this purpose LOCALSTATEDIR is defined to $localstatedir during
compilation.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Merge branch 'collectd-4.0'
Bumped version to 4.0.2; Updated ChangeLog.
hddtemp, ntpd plugin: Allow numeric `Port' arguments.
Merge branch 'collectd-4.0'
Bumped version to 4.0.1; Updated ChangeLog.
contrib/collection.cgi: Added graphs for gauge, if_errors, ipt_bytes and ipt_packets.
Merge branch 'collectd-4.0'
README, collectd.conf(5): its/it's in documentation
A grammatical pet peeve of mine...
Cheers,
Evan
A grammatical pet peeve of mine...
Cheers,
Evan
collectd.conf.pod: Fixed a typo.
The rrdtool plugin does not create CSV-files ;-)
Signed-off-by: Sebastian Harl <sh@tokkee.org>
The rrdtool plugin does not create CSV-files ;-)
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Merge branch 'collectd-4.0'
iptables plugin: Fix a segfault when a comment is passed in the configuration.
rrdtool plugin: Use the interval in the value lists to calculate the RRA sizes.
network plugin: Send and receive the interval of value lists.
src/plugin.h: Include the `interval' in the value lists.
Merge branch 'ff/rrdqueue'
Merge branch 'ff/snmp'
Bumped version to 4.0.0; Updated ChangeLog.
rrdtool plugin: Fixed some bugs in the queueing-code.
Marked the perl plugin to be experimental.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Added Perl module "Collectd" to contrib.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Sebastian Harl <sh@tokkee.org>
src/configfile.c: Pass the `oconfig_item_t' types to the plugins if they request it.
rrdtool plugin: Queue values to be written, but don't write them synchronously.
collectd-snmp(5): Fix some errors and typos.
Merge branch 'pull/master'
collectd-unixsock(5): Corrected the information about the PUTVAL format.
snmp plugin: Cast the `bitstring' to (char *).
The implementation apparently differs between versions.
The implementation apparently differs between versions.
collectd-snmp(5): Added a manpage for the SNMP plugin.
collectd-exec(5): Documented the recent changes.
exec plugin: Change the input format so it's identical to the one used in unixsock.
unixsock plugin: Moved the `parse_identifier' code to `common.c'
The new function `parse_values' in `common.c' can be used to parse
`time:value0:value1:...', as used by RRDTool, the unixsock plugin and, in the
very near future, the exec plugin.
The new function `parse_values' in `common.c' can be used to parse
`time:value0:value1:...', as used by RRDTool, the unixsock plugin and, in the
very near future, the exec plugin.
snmp plugin: Implemented fetching of tables.
This also works with ``sparse tables'' where rows are missing or some columns
are not defined in all rows. That may be improved still, though.
This also works with ``sparse tables'' where rows are missing or some columns
are not defined in all rows. That may be improved still, though.
snmp plugin: First experimental code to read an SNMP-table.
snmp plugin: Added the first prototype of an SNMP plugin.
Querying simple values already works.
Querying simple values already works.
src/configfile.c: Pass the `oconfig_item_t' types to the plugins if they request it.
ntpd plugin: Replace `syslog (LOG_ERR, ...)' with `ERROR (...)'.
Merge branch 'collectd-3.11'
Conflicts:
ChangeLog
configure.in
Conflicts:
ChangeLog
configure.in
Bumped version to 3.11.5; Updated ChangeLog.
ntpd plugin: Fix a possible buffer overflow.
Merge branch 'pull/master'
network plugin: Prepend the plugin's name to debug messages.
exec plugin: Print a warning when the returned string is incorrect.
Also the debug messages have been beautified.
Also the debug messages have been beautified.
contrib/migrate-3-4.px: Added usage information.
collectd.c: Added '-t' command line option.
This option allows to test the configuration only. The program immediately
exits after parsing the config file. A return code not equal to zero indicates
an error.
Some typos have been fixed as well.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
This option allows to test the configuration only. The program immediately
exits after parsing the config file. A return code not equal to zero indicates
an error.
Some typos have been fixed as well.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
memory plugin: Fix unused variable warning under FreeBSD.
Merge branch 'collectd-3.11'
Conflicts:
src/processes.c
Conflicts:
src/processes.c
processes plugin: ps_read_tasks will fail under Linux 2.4.
Take this into account and don't report all processes without tasks as zombies.
Take this into account and don't report all processes without tasks as zombies.
sensors plugin: Let the read-function fail if something isn't right..
..so it gets suspended as it should be.
..so it gets suspended as it should be.
17 years agoplugin.c: Added a comment that explains why the order of the linked list and callback...
plugin.c: Added a comment that explains why the order of the linked list and callback are important.
plugin.c: Advance the llentry_t pointer before calling the shutdown callback.
> Important note: Unregistering the shutdown callback during shutdown is
> somewhat tricky. Doing that frees the llist_t entry in plugin.c:list_shutdown.
> This might cause a segfault in plugin_shutdown_all () when it tries to access
> the next pointer of that entry. If plugin_unregister_shutdown () is the last
> statement before the return from the shutdown callback this should be save in
> about 99% of all cases. Still there should be some better way to handle this.
This is an imho nice way to fix it.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
> Important note: Unregistering the shutdown callback during shutdown is
> somewhat tricky. Doing that frees the llist_t entry in plugin.c:list_shutdown.
> This might cause a segfault in plugin_shutdown_all () when it tries to access
> the next pointer of that entry. If plugin_unregister_shutdown () is the last
> statement before the return from the shutdown callback this should be save in
> about 99% of all cases. Still there should be some better way to handle this.
This is an imho nice way to fix it.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
perl plugin: Unregister all callbacks from collectd when shutting down.
If we do not unregister the callbacks there is still an entry point into the
plugin after Perl has been shut down and its memory has been freed. This will
cause segmentation faults if collectd tries to call any of the registered
callbacks, e.g. by some plugin calling plugin_log () during shutdown.
Important note: Unregistering the shutdown callback during shutdown is
somewhat tricky. Doing that frees the llist_t entry in plugin.c:list_shutdown.
This might cause a segfault in plugin_shutdown_all () when it tries to access
the next pointer of that entry. If plugin_unregister_shutdown () is the last
statement before the return from the shutdown callback this should be save in
about 99% of all cases. Still there should be some better way to handle this.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
If we do not unregister the callbacks there is still an entry point into the
plugin after Perl has been shut down and its memory has been freed. This will
cause segmentation faults if collectd tries to call any of the registered
callbacks, e.g. by some plugin calling plugin_log () during shutdown.
Important note: Unregistering the shutdown callback during shutdown is
somewhat tricky. Doing that frees the llist_t entry in plugin.c:list_shutdown.
This might cause a segfault in plugin_shutdown_all () when it tries to access
the next pointer of that entry. If plugin_unregister_shutdown () is the last
statement before the return from the shutdown callback this should be save in
about 99% of all cases. Still there should be some better way to handle this.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
src/plugin.c: Remove slashed from host, {plugin,type}{,-instance} here.
A fix in the disk plugin has been removed again.
A fix in the disk plugin has been removed again.
email, users and vserver plugins: Changed license to GPL v2 only.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Sebastian Harl <sh@tokkee.org>
README: Fixed a typo.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Sebastian Harl <sh@tokkee.org>
configure.in: Bumped version to 4.0.0-rc10
collectd-nagios(1) and collectd-unixsock(5): Reference one another.
collectd-unixsock(5): Added a note about Collectd::Unixsock.
README: Cleaned up the description of plugins and added information about new plugins.
collectd-perl(5): Moved information about the `perl plugin' into an own manpage.
collectd-email(5): Moved information about the `email plugin' into an own manpage.
collectd.conf(5): Moved information about ``special'' plugins from collectd(1) to here.
collectd.conf(5): Documented `PluginDir' and `TypesDB'.
unixsock plugin: Return a message in any case.
This removes a fair amount of `FIXME's :)
This removes a fair amount of `FIXME's :)
Collectd::Unixsock: Handle instance `0' and interpret a returned `NaN' correctly.
collectd-exec(5): Corrected/added some information.
17 years agocollectd-unixsock(5): Moved information about the `unixsock plugin' into an own manpage.
collectd-unixsock(5): Moved information about the `unixsock plugin' into an own manpage.
collectd-exec(5): Moved information about the `exec plugin' into an own manpage.
contrib/collection.cgi: Improved some more graphs.
contrib/collection.cgi: Include `back'-links and more vertical labels.