Merge branch 'collectd-5.6' into collectd-5.7
Conflicts:
contrib/redhat/collectd.spec
Conflicts:
contrib/redhat/collectd.spec
collectd.spec: enable XFS support in df plugin
Fixes #2178
Fixes #2178
Merge branch 'collectd-5.6' into collectd-5.7
Merge pull request #2167 from maryamtahhan/feat_dpdkstat_bugfix_5_7
dpdkstat: Fix metrics' types
dpdkstat: Fix metrics' types
Merge pull request #2170 from javicacheiro/fix_redhat_spec_file
Fix rpm spec file for 5.7.1
Fix rpm spec file for 5.7.1
Fix release
Fix rpm spec file for 5.7.1
Merge pull request #2165 from maryamtahhan/feat_rdt_bugfix
intel_rdt: bugfix configuration
intel_rdt: bugfix configuration
dpdkstat: Fix metrics' types
This patch fixes parsing of metrics' types. Some statistics, such as
rx_q0errors, rx_q0bytes or rx_q0packet, don't contain suffix _errors, _bytes or
_packets. This has caused them to use generic type 'derive', rather than
more specific one, for instance 'if_rx_errors'. Additionally, some
statistics contain string 'error', rather than 'errors'.
Change-Id: I51dfa9c4d98346a654adbc4041b64ebd3897278c
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
This patch fixes parsing of metrics' types. Some statistics, such as
rx_q0errors, rx_q0bytes or rx_q0packet, don't contain suffix _errors, _bytes or
_packets. This has caused them to use generic type 'derive', rather than
more specific one, for instance 'if_rx_errors'. Additionally, some
statistics contain string 'error', rather than 'errors'.
Change-Id: I51dfa9c4d98346a654adbc4041b64ebd3897278c
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
intel_rdt: bugfix configuration
Fix the configuration to stop collectd bombing out and deal with configuration
errors gracefully. Otherwise collectd will fail at the configuration phase
with: "Error: Reading the config file failed!".
Signed-off-by: Tahhan, Maryam <maryam.tahhan@intel.com>
Fix the configuration to stop collectd bombing out and deal with configuration
errors gracefully. Otherwise collectd will fail at the configuration phase
with: "Error: Reading the config file failed!".
Signed-off-by: Tahhan, Maryam <maryam.tahhan@intel.com>
notify_email: don't explicitly link against libssl and libcrypto
libesmtp takes care of this.
Pointed out by https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852924
libesmtp takes care of this.
Pointed out by https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852924
Merge branch 'collectd-5.6' into collectd-5.7
dpdkstat plugin: jump to the right label
Bump version to 5.7.1; Update ChangeLog.
mqtt plugin: Fix invalid symbols in topic name.
mqtt plugin: Fix resource leak.
Fixes: #2123
Fixes: #2123
Merge pull request #2122 from octo/issue/2108
src/daemon/plugin.c: Register plugin_update_internal_statistics() as …
src/daemon/plugin.c: Register plugin_update_internal_statistics() as …
Merge branch 'collectd-5.6' into collectd-5.7
src/daemon/plugin.c: explicitly declare vl.interval
This properly gets rid of the warning reported in #2108
Thanks to @charliesignalfx for suggesting this and reporting the issue !
This properly gets rid of the warning reported in #2108
Thanks to @charliesignalfx for suggesting this and reporting the issue !
src/daemon/plugin.c: avoid deprecated statement
As suggested by @rubenk in #2122
As suggested by @rubenk in #2122
collectd.spec: ensure write_riemann build deps are installed
collectd.spec: fixes to previous commit
collectd.spec: re-enable write_riemann on EL7, as build dep is now available in EPEL7
Merge branch 'collectd-5.6' into collectd-5.7
curl_json: use configured interval as default timeout value
When no timeout is specified, the default timeout should be set to the
configured interval, not the default timeout (which is -1, no timeout).
This bug got introduced in bce14a848.
When no timeout is specified, the default timeout should be set to the
configured interval, not the default timeout (which is -1, no timeout).
This bug got introduced in bce14a848.
intel_rdt: check libpqos library version.
Change-Id: I83d42b63873569445d4c6339d7a69761e16ead14
Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
Change-Id: I83d42b63873569445d4c6339d7a69761e16ead14
Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
src/daemon/plugin.c: Register plugin_update_internal_statistics() as a read callback.
The previous special-snowflake-solution had issues since it didn't set a plugin
context up.
Fixes: #2108
The previous special-snowflake-solution had issues since it didn't set a plugin
context up.
Fixes: #2108
Merge branch 'collectd-5.6' into collectd-5.7
src/daemon/common.c: Change swrite() to return errno if possible.
Merge pull request #2121 from octo/netapp
netapp plugin: Fix complation problems.
netapp plugin: Fix complation problems.
netapp plugin: Fix compilation problems.
Fixes: #2120
Fixes: #2120
Auto-Merge pull request #2113 from rubenk/dpdk-double-close
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Merge pull request #2114 from mfournier/dpdkstat-formatstring
dpdkstat: use portable format strings
dpdkstat: use portable format strings
dpdkstat: use portable format strings
Merge pull request #2112 from rubenk/battery-plugin-nul-terminate-buffer
Battery plugin: nul-terminate buffer
Battery plugin: nul-terminate buffer
dpdkstat: don't close already closed fd on failure
CID #158525
CID #158525
battery plugin: null-terminate buffer
We call strstripnewline on it, which expects a null-terminated string.
CID #158524
We call strstripnewline on it, which expects a null-terminated string.
CID #158524
Fix parallel build
Fixes #2110
Fixes #2110
Auto-Merge pull request #2111 from octo/cid/157643
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
src/utils_cmd_getthreshold.c: Fix formatting.
set target: Avoid casting negative int to size_t.
CID: 157643
CID: 157643
Auto-Merge pull request #2099 from tokkee/sh/booleans
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
update README to mention write_prometheus & support lib
Auto-Merge pull request #2096 from rubenk/target-set-plug-leak
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Auto-Merge pull request #2092 from rubenk/prometheus-plug-leak
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Bump version to 5.7.0; Update ChangeLog.
configfile: Reintroduce support for boolean string config values.
For the network plugin, this was changed in ac73c75aed7 (which landed in 5.6)
which was a backward incompatible change breaking user configuration. Adding
support back in a central location ensures a more consistent behavior across
plugins. At the same time, we issue a warning message that this behavior is
deprecated.
GH #2083, #2098
For the network plugin, this was changed in ac73c75aed7 (which landed in 5.6)
which was a backward incompatible change breaking user configuration. Adding
support back in a central location ensures a more consistent behavior across
plugins. At the same time, we issue a warning message that this behavior is
deprecated.
GH #2083, #2098
target_set: plug leak on error
CID 157645
CID 157645
email plugin: initialize structure
CID 38125
CID 38125
write_prometheus: plug a small leak
Found by scan-build
Found by scan-build
Merge branch 'collectd-5.6' into collectd-5.7
Merge remote-tracking branch 'github/pr/2081' into collectd-5.7
smart plugin: Refactor, demote warnings to debug.
Fixes: #2062
Fixes: #2062
src/utils_cmd_*.[ch]: Remove unused and redundant includes.
src/Makefile.am: Fix linking with libcmds.la.
Issue: #2067
Issue: #2067
dpdkstats: fix detection of local libdpdk
- Fix typo.
Change-Id: I7cfb6dff4e1c2728650cd1d44aaaa36169880809
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
- Fix typo.
Change-Id: I7cfb6dff4e1c2728650cd1d44aaaa36169880809
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
write_kafka plugin: Use 32bit random number when formatting a random key.
Previously, negative numbers would be truncated to "ffffffff" by the
buffer length on architectures where longs are 64 bit.
Fixes: #2074
Previously, negative numbers would be truncated to "ffffffff" by the
buffer length on architectures where longs are 64 bit.
Fixes: #2074
src/daemon/utils_random.[ch]: Implement cdrand_u().
Merge pull request #2069 from octo/issue/2067
src/Makefile.am: Fix dependencies for the "tail" and "match" utilities.
src/Makefile.am: Fix dependencies for the "tail" and "match" utilities.
src/Makefile.am: Fix dependencies for the "tail" and "match" utilities.
Since being pulled out of the core daemon, the daemon no longer provides
all the required symbols for these shared objects. The "tail", "match"
and "tail_match" utils need to be compiled in explicitly. Also, we need
to link with the liblatency.la convenience library for the
"Distribution" handling in the "match" util.
Issue: #2067
Since being pulled out of the core daemon, the daemon no longer provides
all the required symbols for these shared objects. The "tail", "match"
and "tail_match" utils need to be compiled in explicitly. Also, we need
to link with the liblatency.la convenience library for the
"Distribution" handling in the "match" util.
Issue: #2067
Bump version to 5.6.1; Update ChangeLog.
Merge pull request #2064 from rubenk/fix-make-distcheck
Fix make distcheck
Fix make distcheck
Collected podtypo
Merge branch 'collectd-5.6' into collectd-5.7
Conflicts:
contrib/redhat/collectd.spec
Conflicts:
contrib/redhat/collectd.spec
collectd.spec: also disable write_redis on EL6
This plugin also depends on the hiredis library, which was retired from
EPEL6.
This plugin also depends on the hiredis library, which was retired from
EPEL6.
Merge branch 'collectd-5.5' into collectd-5.6
Conflicts:
contrib/redhat/collectd.spec
Conflicts:
contrib/redhat/collectd.spec
collectd.spec: disable redis plugin on EL6
hiredis has been retired from EPEL6
hiredis has been retired from EPEL6
collectd.spec: disable redis plugin on EL6
Even more renormalization.
Merge branch 'collectd-5.6'
More reformatting.
No idea why the previous round missed these files.
No idea why the previous round missed these files.
Merge branch 'collectd-5.6'
Tree wide: Reformat with clang-format.
Tree wide: Reformat with clang-format.
Merge branch 'collectd-5.5' into collectd-5.6
Bump version to 5.5.3; Update ChangeLog.
Merge branch 'pr/2056'
collectd.conf(5): Improve documentation of the turbostat plugin.
Updated to actually honor the boolean and clarified documentation per request
collectd.conf(5): Add missing blank line.
src/utils_latency_config.c: Avoid nested compound literals.
So GCC 4.6 doesn't crash.
So GCC 4.6 doesn't crash.
src/daemon/utils_match.[ch]: Rename UTILS_MATCH_CF_GAUGE_LATENCY to UTILS_MATCH_CF_GAUGE_DIST.
tail plugin: Rename DSType from Latency to Distribution.
This is a more flexible naming owing to the fact that percentiles and other
distribution parameters are interesting for a variety of metrics, not just
latencies.
The config handling is now completely in src/utils_latency_config.c so
that other plugins, such as the cURL plugin, can easily reuse the module
with consistent config handling.
This is a more flexible naming owing to the fact that percentiles and other
distribution parameters are interesting for a variety of metrics, not just
latencies.
The config handling is now completely in src/utils_latency_config.c so
that other plugins, such as the cURL plugin, can easily reuse the module
with consistent config handling.
src/utils_latency{,_config}.[ch]: Reformat new code with clang-format.
collectd.conf(5): Update the "LatencyRate" option.
src/utils_latency.[ch]: get_rate(): Make lower bound exclusive.
This has a bunch of benefits:
* You can easily iterate over a range of latencies without counting
latencies twice. This was previously tricky because both borders were
considered to be inclusive.
* When lower equals upper, the returned value is now zero.
Previously, it was a value very close to zero, but not zero. The exact
value depended on the bucket width, an information not easily
available to the caller.
This has a bunch of benefits:
* You can easily iterate over a range of latencies without counting
latencies twice. This was previously tricky because both borders were
considered to be inclusive.
* When lower equals upper, the returned value is now zero.
Previously, it was a value very close to zero, but not zero. The exact
value depended on the bucket width, an information not easily
available to the caller.
src/utils_latency.[ch]: Remove latency_counter_get_start_time().
src/utils_latency.[ch]: Improve accuracy, update unit test.
DSType latency: Improved after PR code review
+ liblatency: Added utils_latency_config code
+ tail plugin: DSType Latency added
+ tail plugin: DSType Latency added
+ utils_latency: Cleaned latency_counter_get_rate() from debugging
+ utils_latency: Added latency_counter_get_rate()
+ User_data destroy callback added to match_create_callback() in utils_match
Merge remote-tracking branch 'github/pr/2058'
amqp, write_graphite and write_kafka plugins: Implement the "[Graphite]PreserveSeparator" option.
Fixes: #419
Fixes: #419
src/utils_format_graphite.[ch]: Implement the GRAPHITE_PRESERVE_SEPARATOR flag.
Add config boolean for logical CPU naming for turbostat plugin
Merge remote-tracking branch 'github/pr/2052'