Code

rrdtool.git
12 years agorrdtool is assuming that rrd_xport will always return -1 on failure;
oetiker [Mon, 16 Jan 2012 10:59:14 +0000 (10:59 +0000)]
rrdtool is assuming that rrd_xport will always return -1 on failure;
however, rrd_xport returns errno (which is, generally, not -1) if
rrd_client fails. I figured it was easier to change rrdtool than to change
everything in rrd_client. For good measure, I also changed the checks on
the calls to rrd_fetch and rrd_graph. I'm not sure if they're susceptible
to the same problem, but, well, better to check for the one thing you do
what you want than to enumerate all the possible things you don't want.

This segfault is caused by an uninitialized variable use (in particular,
legend_v and col_cnt end up being used and passed to printf uninitialized).
Nothing offhand jumped out at me as easily-exploitable to do code
injection, but I only spent five or so minutes looking at it, so there very
well may be a security problem hiding behind this. -- James Brown <jbrown@yelp.com>

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2251 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agointegrated json support in rrdtool xport with inspiration from Erik Kastner and Micha...
oetiker [Sun, 15 Jan 2012 16:31:12 +0000 (16:31 +0000)]
integrated json support in rrdtool xport with inspiration from Erik Kastner and Michael Markstaller -- Tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2250 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agobe more careful when finding pic flags
oetiker [Mon, 19 Dec 2011 16:03:09 +0000 (16:03 +0000)]
be more careful when finding pic flags

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2247 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix horyzontal alignement of lines and aread
oetiker [Fri, 16 Dec 2011 20:19:49 +0000 (20:19 +0000)]
fix horyzontal alignement of lines and aread

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2245 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix grid fitting for corner cases
oetiker [Fri, 16 Dec 2011 17:39:14 +0000 (17:39 +0000)]
fix grid fitting for corner cases

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2243 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agouse standard functions for checking
oetiker [Fri, 16 Dec 2011 16:13:23 +0000 (16:13 +0000)]
use standard functions for checking

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2241 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agosearch for tcpd.h with <>
oetiker [Fri, 16 Dec 2011 13:25:34 +0000 (13:25 +0000)]
search for tcpd.h with <>

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2240 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix win32 distributables
oetiker [Fri, 16 Dec 2011 07:48:48 +0000 (07:48 +0000)]
fix win32 distributables

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2239 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agomerged updated win32 port by Larry Adams and the cacti team
oetiker [Thu, 15 Dec 2011 16:08:59 +0000 (16:08 +0000)]
merged updated win32 port by Larry Adams and the cacti team

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2236 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofixed some reference errors
oetiker [Mon, 12 Dec 2011 06:48:45 +0000 (06:48 +0000)]
fixed some reference errors

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2234 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agorpn compare operators CAN return unknown ... (#293)
oetiker [Thu, 1 Dec 2011 15:27:24 +0000 (15:27 +0000)]
rpn compare operators CAN return unknown ... (#293)

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2232 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agogettext 0.17 is sufficient too and more widely used than 0.18 ...
oetiker [Thu, 1 Dec 2011 15:09:12 +0000 (15:09 +0000)]
gettext 0.17 is sufficient too and more widely used than 0.18 ...
-- Bernard Li <bernard@vanhpc.org>

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2231 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix some issues with the
oetiker [Thu, 1 Dec 2011 15:07:38 +0000 (15:07 +0000)]
fix some issues with the
spec file, specifically:

- Reset Release to 1
- Add -lua subpackage
- Fix -perl subpackage so it includes the correct Perl package paths

The version should probably be updated to 1.5.0 (for trunk), or we
could just grab that from configure.ac.

Tested building on EL5 and EL6 (beta).

It would be great if this could also be backported to the 1.4 tree.

-- Bernard Li <bernard@vanhpc.org>

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2230 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix typo in configure.ac (regression from r2227) fix for #324
oetiker [Tue, 29 Nov 2011 22:42:45 +0000 (22:42 +0000)]
fix typo in configure.ac (regression from r2227) fix for #324

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2229 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoIt seems that function graph_size_location() doesn't call xtr(im, 0) if (im->extra_fl...
oetiker [Mon, 28 Nov 2011 07:38:54 +0000 (07:38 +0000)]
It seems that function graph_size_location() doesn't call xtr(im, 0) if (im->extra_flags & ONLY_GRAPH) != 0. Therefore, static variable pixie in function xtr() remains uninitialized (fix for #322). -- u00mp yandex.ru

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2228 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix glib dependency for --disable-rrd_graph and update library versions (fix for...
oetiker [Mon, 28 Nov 2011 07:32:36 +0000 (07:32 +0000)]
fix glib dependency for --disable-rrd_graph and update library versions (fix for #323)

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2227 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agocall this 1.4.999
oetiker [Thu, 24 Nov 2011 15:15:42 +0000 (15:15 +0000)]
call this 1.4.999

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2226 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoinitialize magfact to 1 ... fixes logarithm chart display issues (patch from Christop...
oetiker [Thu, 24 Nov 2011 15:07:23 +0000 (15:07 +0000)]
initialize magfact to 1 ... fixes logarithm chart display issues (patch from Christoph Biedl) #296

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2225 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoupdates to the win32 port -- Chris Larsen
oetiker [Thu, 24 Nov 2011 14:55:06 +0000 (14:55 +0000)]
updates to the win32 port -- Chris Larsen

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2223 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix some string marshaling bugs in the Dot Net binding -- Chris Larsen
oetiker [Thu, 24 Nov 2011 14:51:24 +0000 (14:51 +0000)]
fix some string marshaling bugs in the Dot Net binding -- Chris Larsen

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2222 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoafter fetching, data must be reduced to at least chart resolution, else some data...
oetiker [Thu, 24 Nov 2011 14:26:30 +0000 (14:26 +0000)]
after fetching, data must be reduced to at least chart resolution, else some data will not get plotted. fix for #298

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2221 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoproperly handle the case where RRDCACHED_ADDRESS is an empty string
oetiker [Thu, 24 Nov 2011 10:55:18 +0000 (10:55 +0000)]
properly handle the case where RRDCACHED_ADDRESS is an empty string

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2220 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agothe number of COMPUTE rpn nodes is architecture dependent. calculate the right number...
oetiker [Wed, 23 Nov 2011 16:54:17 +0000 (16:54 +0000)]
the number of COMPUTE rpn nodes is architecture dependent. calculate the right number and complain otherwise. Fix for #300.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2219 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agomake rrd_mkdir_p work on bsd* unixes too ... their dirname call works differently...
oetiker [Wed, 23 Nov 2011 08:52:37 +0000 (08:52 +0000)]
make rrd_mkdir_p work on bsd* unixes too ... their dirname call works differently ... #305

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2217 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agouse long int format
oetiker [Wed, 23 Nov 2011 08:49:23 +0000 (08:49 +0000)]
use long int format

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2216 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoa new command-line parameter, --week-fmt, by which I can translate the word "week...
oetiker [Tue, 22 Nov 2011 17:13:13 +0000 (17:13 +0000)]
a new command-line parameter, --week-fmt, by which I can translate the word "week" in the graphs. -- Martin Volf

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2215 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoallow to restore xml files with zero row rras ... this is a degenerated case
oetiker [Tue, 22 Nov 2011 15:40:22 +0000 (15:40 +0000)]
allow to restore xml files with zero row rras ... this is a degenerated case
that does not occure in the wild, as rrdtool prevents the creation of such
rrd files. But rrdtool restore 1.3 did allows to create them via restore.
Now this is possible again. Fix for #310.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2212 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix ifdef use
oetiker [Tue, 22 Nov 2011 15:28:45 +0000 (15:28 +0000)]
fix ifdef use

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2211 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agothe first TREND* value can be calculated earlier ... -- fredrick (fix for #312)
oetiker [Tue, 22 Nov 2011 12:59:57 +0000 (12:59 +0000)]
the first TREND* value can be calculated earlier ... -- fredrick (fix for #312)

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2210 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoactually link with LIBINTL if we got it ... should make solaris happy
oetiker [Tue, 22 Nov 2011 12:46:15 +0000 (12:46 +0000)]
actually link with LIBINTL if we got it ... should make solaris happy

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2209 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agodbi_result_get_datetime_idx() return timestamp in UTC, but time axis on graph suppose...
oetiker [Wed, 16 Nov 2011 16:49:10 +0000 (16:49 +0000)]
dbi_result_get_datetime_idx() return timestamp in UTC, but time axis on graph supposed to be in local time.
fix provided in #321
 --This line, and those below, will be ignored--

M    trunk/program/src/rrd_fetch_libdbi.c
M    branches/1.4/program/src/rrd_fetch_libdbi.c

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2208 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoallow rrdtool for windows to properly support binary mode stdout/stdin -- Larry Adams
oetiker [Mon, 14 Nov 2011 21:30:31 +0000 (21:30 +0000)]
allow rrdtool for windows to properly support binary mode stdout/stdin -- Larry Adams

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2207 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix ruby binding for rrd_xport #318
oetiker [Thu, 20 Oct 2011 06:48:39 +0000 (06:48 +0000)]
fix ruby binding for rrd_xport #318

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2206 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofree step_list on error. fix for #317
oetiker [Tue, 18 Oct 2011 14:22:04 +0000 (14:22 +0000)]
free step_list on error. fix for #317

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2204 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoimproved library handling
oetiker [Thu, 29 Sep 2011 11:40:10 +0000 (11:40 +0000)]
improved library handling

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2203 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix buffer overflow for LONG lines in journal handling code for update requests.
oetiker [Tue, 27 Sep 2011 06:15:36 +0000 (06:15 +0000)]
fix buffer overflow for LONG lines in journal handling code for update requests.
fix for #316

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2202 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agohandling of ENV_RRDCACHED_ADDRESS:
oetiker [Fri, 16 Sep 2011 13:04:31 +0000 (13:04 +0000)]
handling of ENV_RRDCACHED_ADDRESS:
added missing brackets after if, backported fix from trunk to 1.4 while doing it
-- patch by x @ zamyteam.org

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2199 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix alignment of centered items ... title and footer
oetiker [Sun, 14 Aug 2011 09:41:30 +0000 (09:41 +0000)]
fix alignment of centered items ... title and footer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2197 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoproper fix for the header size problem and its effects on rrd_resize
oetiker [Wed, 29 Jun 2011 15:18:22 +0000 (15:18 +0000)]
proper fix for the header size problem and its effects on rrd_resize

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2192 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofox for #302. refuse to build if troff and nroff are not around
oetiker [Thu, 23 Jun 2011 06:31:08 +0000 (06:31 +0000)]
fox for #302. refuse to build if troff and nroff are not around

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2188 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix for #301: plug memory leak in lua bindings -- bmayland @ leoninedev.com
oetiker [Thu, 23 Jun 2011 05:48:37 +0000 (05:48 +0000)]
fix for #301: plug memory leak in lua bindings -- bmayland @ leoninedev.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2187 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoFix for #304: checking for time_t is done with AC_RUN_IFELSE which fails when cross...
oetiker [Thu, 23 Jun 2011 05:45:36 +0000 (05:45 +0000)]
Fix for #304: checking for time_t is done with AC_RUN_IFELSE which fails when cross-compiling. The size of time_t can be detected with AC_CHECK_SIZEOF. -- Michael Olbrich

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2186 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix rrd_create behaviour when mmaping on a full filesystem by actually 'filling'...
oetiker [Thu, 21 Apr 2011 06:12:50 +0000 (06:12 +0000)]
fix rrd_create behaviour when mmaping on a full filesystem by actually 'filling' the file with
zero. -- Francois-Xavier Bourlet francois-xavier.bourlet dotcloud.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2181 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agowith libwrap use 'rrdcached' as the name of our daemon and not just rrdcache
oetiker [Tue, 15 Mar 2011 07:53:03 +0000 (07:53 +0000)]
with libwrap use 'rrdcached' as the name of our daemon and not just rrdcache

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2180 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agobring spaceing around graph back in line with 1.2 goodness ... in connection with...
oetiker [Mon, 14 Mar 2011 08:22:46 +0000 (08:22 +0000)]
bring spaceing around graph back in line with 1.2 goodness ... in connection with no-legend and no title

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2179 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoeven with libdbi enabled, do not mistake "sqlxxabc.rrd" for an sql url -- Peter Stamfest
oetiker [Thu, 3 Mar 2011 06:53:05 +0000 (06:53 +0000)]
even with libdbi enabled, do not mistake "sqlxxabc.rrd" for an sql url -- Peter Stamfest

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2176 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoas rrd_cgi fails to parse stuff, do NOT try to fix up the mess ... it is bound to...
oetiker [Wed, 26 Jan 2011 08:38:47 +0000 (08:38 +0000)]
as rrd_cgi fails to parse stuff, do NOT try to fix up the mess ... it is bound to fail

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2174 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoupdate timestamp continuity checks in rrd_cached ... allow sub-second precision
oetiker [Tue, 18 Jan 2011 14:18:09 +0000 (14:18 +0000)]
update timestamp continuity checks in rrd_cached ... allow sub-second precision

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2173 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoAdded configure option to disable building rrd_graph: --disable-rrd_graph. With suppo...
oetiker [Tue, 18 Jan 2011 08:49:24 +0000 (08:49 +0000)]
Added configure option to disable building rrd_graph: --disable-rrd_graph. With support from Ulf Zimmermann (OpenLane)

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2172 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoadded explanation on the rows returned from fetch. fix for #291.
oetiker [Sat, 15 Jan 2011 13:01:13 +0000 (13:01 +0000)]
added explanation on the rows returned from fetch. fix for #291.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2170 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agomake sure we do not free stuff in rrdnew which was simply copied from rrdold and...
oetiker [Sat, 15 Jan 2011 12:53:43 +0000 (12:53 +0000)]
make sure we do not free stuff in rrdnew which was simply copied from rrdold and thus gets freed there already ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2169 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix wording regarding min/max setting
oetiker [Thu, 6 Jan 2011 15:39:55 +0000 (15:39 +0000)]
fix wording regarding min/max setting

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2167 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agodo not close the filehandle to the resize file of there was a problem getting it...
oetiker [Thu, 6 Jan 2011 15:00:34 +0000 (15:00 +0000)]
do not close the filehandle to the resize file of there was a problem getting it in the first place.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2166 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoit there is no right label, do not reserve any space for it
oetiker [Sun, 26 Dec 2010 19:19:13 +0000 (19:19 +0000)]
it there is no right label, do not reserve any space for it

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2160 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agomake configure recognize tcl-site argument (#281)
oetiker [Sun, 26 Dec 2010 17:25:09 +0000 (17:25 +0000)]
make configure recognize tcl-site argument (#281)

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2159 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoadd some extra checks to RRA arguments
oetiker [Sun, 26 Dec 2010 17:13:08 +0000 (17:13 +0000)]
add some extra checks to RRA arguments

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2158 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agomake MAP_PRIVATE conditional on AIX not being defined ... should fix part of #216
oetiker [Sun, 26 Dec 2010 16:04:03 +0000 (16:04 +0000)]
make MAP_PRIVATE conditional on AIX not being defined ... should fix part of #216

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2157 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoThe buffer length for command buffers should be controlled by a single
oetiker [Tue, 21 Dec 2010 16:50:16 +0000 (16:50 +0000)]
The buffer length for command buffers should be controlled by a single
#define. Renamed CMD_MAX to RRD_CMD_MAX and put into rrd_client.h
so that it is available to clients as well. -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2156 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years ago1) Sigma calculation had an error. The first data value in each bin didn't get squared.
oetiker [Tue, 21 Dec 2010 16:38:48 +0000 (16:38 +0000)]
1) Sigma calculation had an error. The first data value in each bin didn't get squared.

2) "rrdfillmissing" was dummy. I have added code to do the work. The parameter has NOW to be in seconds. In doc it is
given in steps. The size of steps depends to much on size of graph so I think its easier to use seconds and internal
calculate the number of steps.

by Hans Jørgen Jakobsen

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2155 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agohandle the case where the realpath of the suggested journaldir does not exist. Patch...
oetiker [Tue, 21 Dec 2010 16:19:12 +0000 (16:19 +0000)]
handle the case where the realpath of the suggested journaldir does not exist. Patch by Alex Bennee and Tobi Oetiker

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2153 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agorrdcached: Fix permissions of the default socket.
oetiker [Tue, 21 Dec 2010 16:06:32 +0000 (16:06 +0000)]
rrdcached: Fix permissions of the default socket.

If neither the "-l" nor the "-P" options have been given, a UNIX domain
socket at a default location is created. However, due to a missing
initialization in this case, the "permissions" field will be left at
zero (no command allowed).

This patch fixes this problem by allowing all commands on the default
socket if no "-P" option is given. -- Florian Forster

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2152 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoadd extra space to LDFLAGS when building ruby bindings ... otherwhise this will break...
oetiker [Mon, 20 Dec 2010 07:03:40 +0000 (07:03 +0000)]
add extra space to LDFLAGS when building ruby bindings ... otherwhise this will break if there is already content in LDFLAGS ... fix for #284 thanks dam at opencsw.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2151 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agothe aix linker does not have -Wl flag
oetiker [Fri, 17 Dec 2010 16:09:07 +0000 (16:09 +0000)]
the aix linker does not have -Wl flag

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2149 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoadded not on using LINE AREA or PRINT
oetiker [Tue, 7 Dec 2010 17:58:56 +0000 (17:58 +0000)]
added not on using LINE AREA or PRINT

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2148 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agointroduce "epoch" as a new base time reference, meaning timestamp 0.
oetiker [Thu, 11 Nov 2010 16:12:17 +0000 (16:12 +0000)]
introduce "epoch" as a new base time reference, meaning timestamp 0.
This disambiguates between some "at-style" time specs:

11111111 yields an error message:

did you really mean month 1111111?

and

19711205 denotes Dec 12, 1971 and not the timestamp.

The patch allows to write:

epoch+11111111s or epoch+19711205s

-- Peter Stamfest

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2147 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoHere is a patch that fixes a serious endless loop problem on 32 bit
oetiker [Thu, 11 Nov 2010 16:06:55 +0000 (16:06 +0000)]
Here is a patch that fixes a serious endless loop problem on 32 bit
architectures near the timestamp 2^31 (oh yes - y2k038 is showing its ugly
face) when using the graph command(s). Once the endtime of a graph is
above the mentioned timestamp, mktime always returns -1 (and correctly
so), causing some loops to loop forever. The patch fixes this, causing
some strange output, but there is no other sane way to handle this (expect
by switching to a 64 bit platform). -- Peter Stamfest

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2146 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years ago add hosts_access support to rrdcached -- Shaun Reitan mailinglists@unix-scripts.com
oetiker [Tue, 9 Nov 2010 16:37:18 +0000 (16:37 +0000)]
 add hosts_access support to rrdcached -- Shaun Reitan mailinglists@unix-scripts.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2145 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agomake sure we do not try to draw points all that far outside the drawing area
oetiker [Tue, 9 Nov 2010 16:15:06 +0000 (16:15 +0000)]
make sure we do not try to draw points all that far outside the drawing area
since some versions of cairo seem to go unstable when this happens. -- Peter Stamfest

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2142 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agorrdcached uses tcp and not udp thanks Shaun for finding this
oetiker [Tue, 2 Nov 2010 12:15:02 +0000 (12:15 +0000)]
rrdcached uses tcp and not udp thanks Shaun for finding this

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2141 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofollow the normal code path for exiting rrd_update if there is a problem with rrdc...
oetiker [Mon, 25 Oct 2010 05:45:05 +0000 (05:45 +0000)]
follow the normal code path for exiting rrd_update if there is a problem with rrdc, plugging a memory leak on the way --  Christian Magnusson

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2139 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofree addrinfo list after use ... -- Christian Magnusson
oetiker [Mon, 25 Oct 2010 05:40:26 +0000 (05:40 +0000)]
free addrinfo list after use ... -- Christian Magnusson

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2138 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofix for the memory leak in info fixes the memory leak in "INFO".
oetiker [Fri, 22 Oct 2010 21:02:20 +0000 (21:02 +0000)]
fix for the memory leak in info fixes the memory leak in "INFO".

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2137 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years ago* introduce a new rrd_create_r2 call to fix the no-overwrite api mess
oetiker [Mon, 11 Oct 2010 07:48:45 +0000 (07:48 +0000)]
* introduce a new rrd_create_r2 call to fix the no-overwrite api mess
* various fixes to new rrd_cached comands as suggested by kevin
  1. Remove opt_no_overwrite and the rrd_create_set_no_overwrite function as they are ugly.  Make opt_no_overwrite a local var.
  2. Add 'no_overwrite' param to the rrd_create_r and rename as rrd_create_r2, add rrd_create_r  that calls rrd_create_r2 with a 0 for the no_overwrite function, preserving the API parameter format but allowing an extended arg list that can be used by rrd_create and rrd_handle_request_create
  3. Add -O option to rrdcached command line to force no-overwrite on any creates
  4. Add -O option on create via rrdcached to optionally add no-overwrite (cannot remove it is it was previously set at start)
  5. Fix rrd_handle_request_last to check the queue instead of forcing a flush.  Remove -no-flush option from LAST command since it is now no longer relevant as we're querying the cache chain
  6. Fix ulong/unsigned long issue for compilation under windows
  7. Change rrd_handle_request_create to only accept timestamp parameters, not at-syntax, in order to be threadsafe.  This is no  loss since the rrd_client already pre-parses any at-style syntax
  8. Reinstate missing free() in rrd_info.c and rrd_last.c

-- steve shipway

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2136 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoEnsure that response_read() always calls fflush() or fclose().
oetiker [Sat, 9 Oct 2010 09:50:44 +0000 (09:50 +0000)]
Ensure that response_read() always calls fflush() or fclose().
This fixes defect #278 (unknown commands from Solaris client). -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2135 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofix ruby bindings to be compatible with curent ruby implementations fix for #279
oetiker [Tue, 28 Sep 2010 15:44:19 +0000 (15:44 +0000)]
fix ruby bindings to be compatible with curent ruby implementations fix for #279

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2132 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoSummary of changes:
oetiker [Thu, 23 Sep 2010 06:08:09 +0000 (06:08 +0000)]
Summary of changes:

1. Add INFO  <filename>, FIRST <filename> <index>, LAST <filename> and
   CREATE <rrdfile> [-b start][-s step][-O] <DSdefs> <RRAdefs> to the rrdcached
   functions.

2. Add rrd_create_set_no_overwrite as a function in rrd_create.c to allow
   the overwrite flag to be set from rrd_daemon.c

3. Add rrdc_info, rrdc_first, rrdc_last, rrdc_create functions in
   rrd_client.c

4. Add rrdcached support to rrd_info(), rrd_first(), rrd_last() and
   rrd_create()

5. Add --noflush (-F) option to rrd_info(), rrd_last() to prevent cache
   flushing before function call if required for efficiency

6. Add --daemon option to rrd_info(), rrd_first() for rrdcached support

7. Add buffer_add_ulong function to rrd_client.c (used by new rrdc_*
   functions)

8. Add rrd_clear_error() call to rrd_create_r () to clean up bug if create
   called more than once

9. Add -O option to rrdcached to force no-overwrite mode in CREATE function

10. All relevant documentation updated

-- Steve Shipway steve steveshipway.org

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2130 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofix use of %s in strftime rrdgraph (G)PRINT commands ... bug (#277) found by Denis...
oetiker [Fri, 10 Sep 2010 09:16:49 +0000 (09:16 +0000)]
fix use of %s in strftime rrdgraph (G)PRINT commands ... bug (#277) found by Denis, fix by tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2129 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoit seems that strcasecmp and strcasencmp have issues on windows replace
oetiker [Wed, 8 Sep 2010 16:41:23 +0000 (16:41 +0000)]
it seems that strcasecmp and strcasencmp have issues on windows replace
with stricmp and strnicmp --  jkane mail.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2128 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofix use of setlocale all over the place ...
oetiker [Wed, 8 Sep 2010 12:15:13 +0000 (12:15 +0000)]
fix use of setlocale all over the place ...

-    old_locale = setlocale(LC_NUMERIC, "C");
+    old_locale = setlocale(LC_NUMERIC, NULL);
+    setlocale(LC_NUMERIC, "C");

the original version never restored the locale since it held a copy of the
new locale and not the old one despite the name. bug found by  Pawe? 'Reef' Polewicz

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2127 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofix MSVC2008 compilation ... it does not understand char *const *argv iin rrd_getopt
oetiker [Tue, 31 Aug 2010 07:31:43 +0000 (07:31 +0000)]
fix MSVC2008 compilation ... it does not understand char     *const *argv iin rrd_getopt
-- jkane mail.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2124 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agomake sure an extra %s in the secondi axis format does not kill us
oetiker [Wed, 25 Aug 2010 20:15:26 +0000 (20:15 +0000)]
make sure an extra %s in the secondi axis format does not kill us

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2123 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoits filename not filtname
oetiker [Tue, 24 Aug 2010 05:19:55 +0000 (05:19 +0000)]
its filename not filtname

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2121 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agodocument version variable
oetiker [Tue, 24 Aug 2010 05:19:46 +0000 (05:19 +0000)]
document version variable

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2120 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoin remote mode, make argument count for remote commmands strict as suggested by Dave...
oetiker [Mon, 23 Aug 2010 05:28:23 +0000 (05:28 +0000)]
in remote mode, make argument count for remote commmands strict as suggested by Dave Peticolas

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2119 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoFirst bug: in function rrd_fetch_fn_libdbi() variable 'struct sql_table_helper table_...
oetiker [Sun, 22 Aug 2010 17:56:02 +0000 (17:56 +0000)]
First bug: in function rrd_fetch_fn_libdbi() variable 'struct sql_table_helper table_help'
field 'filename' is uninitialized. So, if a sql error happens, it does not print an error like this
rrd_set_error( "libdbi: problems connecting to db with connect string %s - error: %s",th->filename,dbi_errstr);
instead of, it dumps core.

Second bug: when the output data buffer is allocated, it allocated for 'rows-1' max index, but in
'fetch loop' 'idx' may be equal to 'rows', so it needs one more extra record in data.

-- Pavel Nikiforov pavel artx.ru

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2118 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agohunting down pango allocation issues ... now the memory loss in rrd_graph seems to...
oetiker [Tue, 17 Aug 2010 21:41:03 +0000 (21:41 +0000)]
hunting down pango allocation issues ... now the memory loss in rrd_graph seems to be independant of the number
of graphs generated. fix for #208

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2117 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agorrdcached: Let the -s, -m and -P options affect the default socket as well -- Sebasti...
oetiker [Mon, 26 Jul 2010 05:35:11 +0000 (05:35 +0000)]
rrdcached: Let the -s, -m and -P options affect the default socket as well -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2116 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoprint \n for log messages while runing rrdcached in the foreground ... suggested...
oetiker [Sat, 10 Jul 2010 10:21:54 +0000 (10:21 +0000)]
print \n for log messages while runing rrdcached in the foreground ... suggested by Bernard Li

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2115 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoone with is enough ...
oetiker [Wed, 7 Jul 2010 21:06:55 +0000 (21:06 +0000)]
one with is enough ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2113 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agodo not try to whisk i18n support into existance ... use it when its there
oetiker [Mon, 5 Jul 2010 15:29:56 +0000 (15:29 +0000)]
do not try to whisk i18n support into existance ... use it when its there
don't when it is not, rrdtool works fine either way.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2104 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years ago* make rrd_getopt compile on solaris
oetiker [Mon, 5 Jul 2010 13:19:18 +0000 (13:19 +0000)]
* make rrd_getopt compile on solaris
* unify isinf isnan definitions for compilation and configuration
* replace round by rint if round is not available

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2103 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agobackport FP_* fixes and revert FPCLASSIFY fix since there the FP_* values are defines.
oetiker [Sun, 4 Jul 2010 20:59:49 +0000 (20:59 +0000)]
backport FP_* fixes and revert FPCLASSIFY fix since there the FP_* values are defines.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2101 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agodo NOT assume that FP_* is defined, it can also be a typedef enum ... bug report...
oetiker [Sun, 4 Jul 2010 20:53:15 +0000 (20:53 +0000)]
do NOT assume that FP_* is defined, it can also be a typedef enum ... bug report by Michael Zehender

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2100 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoupdated build tips for updated win32 port by Chris Larsen
oetiker [Fri, 2 Jul 2010 12:53:49 +0000 (12:53 +0000)]
updated build tips for updated win32 port by Chris Larsen

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2099 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agorrd_update and rrd_rpncalc - fix casts introduced by win32 patch to make gcc happy too
oetiker [Fri, 2 Jul 2010 05:33:10 +0000 (05:33 +0000)]
rrd_update and rrd_rpncalc - fix casts introduced by win32 patch to make gcc happy too

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2098 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agothere are bash scripts so lets have bash execute them
oetiker [Thu, 1 Jul 2010 22:21:43 +0000 (22:21 +0000)]
there are bash scripts so lets have bash execute them

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2096 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years ago* patches to make rrdtool compile on win32 (trunk and 1.4)
oetiker [Thu, 1 Jul 2010 20:49:42 +0000 (20:49 +0000)]
* patches to make rrdtool compile on win32 (trunk and 1.4)
* dotnet bindings (trunk)  by Euphoria Audio

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2095 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agosrc/rrd_client.c: Fix a potential segmentation fault in "get_path".
oetiker [Wed, 30 Jun 2010 12:48:47 +0000 (12:48 +0000)]
src/rrd_client.c: Fix a potential segmentation fault in "get_path".

The "get_path" function is called at least from "rrdc_update" without
checking for a connection first. In that case the "sd_path" pointer may be
NULL, so dereferencing it without checking for NULL is not good behavior.

This patch checks all arguments of the "get_path" function and returns an
error if any pointer is NULL. -- Florian Forster

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2094 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofixed solaris regression introduced in r1904 ... now the isnan macro should work...
oetiker [Fri, 25 Jun 2010 21:41:50 +0000 (21:41 +0000)]
fixed solaris regression introduced in r1904 ... now the isnan macro should work again ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2093 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoAdd rrd_update_v_r to librrd -- Frederik Kriewitz
oetiker [Fri, 11 Jun 2010 15:31:12 +0000 (15:31 +0000)]
Add rrd_update_v_r to librrd -- Frederik Kriewitz

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2092 a5681a0c-68f1-0310-ab6d-d61299d08faa