Code

collectd.git
8 years agoMerge pull request #1739 from tokkee/sh/memcheck
Ruben Kerkhof [Sat, 4 Jun 2016 16:44:18 +0000 (18:44 +0200)]
Merge pull request #1739 from tokkee/sh/memcheck

unit tests: Run all tests through Valgrind's memcheck, if available.

8 years agoActually add the testwrapper.sh script.
Sebastian Harl [Sat, 4 Jun 2016 16:39:21 +0000 (18:39 +0200)]
Actually add the testwrapper.sh script.

… it's now used for running all tests.

8 years agoconfigure: Drop unneeded AC_SUBST() calls for AC_PATH_PROG() results.
Sebastian Harl [Sat, 4 Jun 2016 16:37:26 +0000 (18:37 +0200)]
configure: Drop unneeded AC_SUBST() calls for AC_PATH_PROG() results.

AC_PATH_PROG calls AC_SUBST for us.

8 years agounit tests: Run all tests through Valgrind's memcheck, if available.
Sebastian Harl [Sat, 4 Jun 2016 16:27:52 +0000 (18:27 +0200)]
unit tests: Run all tests through Valgrind's memcheck, if available.

8 years agocollectd.spec: add new gRPC plugin
Ruben Kerkhof [Sat, 4 Jun 2016 16:31:16 +0000 (18:31 +0200)]
collectd.spec: add new gRPC plugin

Disable it for now as the version of protobuf-compiler
in RHEL and Fedora is too old.

8 years agoceph_test: Free the yajl handle.
Sebastian Harl [Sat, 4 Jun 2016 16:26:44 +0000 (18:26 +0200)]
ceph_test: Free the yajl handle.

8 years agoutils_mount_test: Free dynamically allocated strings.
Sebastian Harl [Sat, 4 Jun 2016 16:25:06 +0000 (18:25 +0200)]
utils_mount_test: Free dynamically allocated strings.

8 years agotesting: Evaluate expressions only once in EXPECT_EQ_STR().
Sebastian Harl [Sat, 4 Jun 2016 16:24:23 +0000 (18:24 +0200)]
testing: Evaluate expressions only once in EXPECT_EQ_STR().

8 years agoutils_vl_lookup: Free regexen when destroying class lists.
Sebastian Harl [Sat, 4 Jun 2016 15:58:23 +0000 (17:58 +0200)]
utils_vl_lookup: Free regexen when destroying class lists.

Else, we'll leak any memory used by the regex.

8 years agoMerge pull request #1738 from tokkee/sh/silent
Ruben Kerkhof [Sat, 4 Jun 2016 16:20:35 +0000 (18:20 +0200)]
Merge pull request #1738 from tokkee/sh/silent

src/Makefile: Support silent build rules for pod2man.

8 years agosrc/Makefile: Support silent build rules for pod2man.
Sebastian Harl [Sat, 4 Jun 2016 15:36:56 +0000 (17:36 +0200)]
src/Makefile: Support silent build rules for pod2man.

8 years agoMerge pull request #1699 from tokkee/sh/grpc
Ruben Kerkhof [Sat, 4 Jun 2016 15:25:46 +0000 (17:25 +0200)]
Merge pull request #1699 from tokkee/sh/grpc

gRPC server plugin

8 years agogRPC doc: Fixed typos and mention C++11 requirement.
Sebastian Harl [Sat, 4 Jun 2016 14:33:41 +0000 (16:33 +0200)]
gRPC doc: Fixed typos and mention C++11 requirement.

8 years agosrc/Makefile: Don't unnecessarily set plugin specific CXXFLAGS.
Sebastian Harl [Sat, 4 Jun 2016 14:24:17 +0000 (16:24 +0200)]
src/Makefile: Don't unnecessarily set plugin specific CXXFLAGS.

Also, drop unneeded -lphread / -ldl from grpc's libraries.

8 years agosrc/Makefile: Don't set subdir-objects.
Sebastian Harl [Sat, 4 Jun 2016 14:23:22 +0000 (16:23 +0200)]
src/Makefile: Don't set subdir-objects.

That's now done globally via configure.

8 years agocollectd.spec: fix rpmlint warning
Ruben Kerkhof [Sat, 4 Jun 2016 13:12:37 +0000 (15:12 +0200)]
collectd.spec: fix rpmlint warning

collectd.src: W: summary-not-capitalized C statistics collection and
monitoring daemon

8 years agocollectd.spec: make scriptlets work on Fedora
Ruben Kerkhof [Sat, 4 Jun 2016 13:11:43 +0000 (15:11 +0200)]
collectd.spec: make scriptlets work on Fedora

8 years agocollectd.spec: only require python26 on RHEL < 6
Ruben Kerkhof [Sat, 4 Jun 2016 12:18:57 +0000 (14:18 +0200)]
collectd.spec: only require python26 on RHEL < 6

Otherwise the else clause in the condition matches on Fedora too.

This makes the spec build on Fedora.

8 years agocollectd.spec: disable plugins on older distro
Ruben Kerkhof [Sat, 4 Jun 2016 11:26:06 +0000 (13:26 +0200)]
collectd.spec: disable plugins on older distro

Instead of keeping a list per RHEL version of which plugins to enable,
invert the logic and keep a list of plugins to disable when the distro
is too old. This way we only have to specify a plugin once, and this
also opens up the possibility to build on Fedora.

8 years agoMerge pull request #1737 from rubenk/pthread-cleanup
Ruben Kerkhof [Sat, 4 Jun 2016 11:04:55 +0000 (13:04 +0200)]
Merge pull request #1737 from rubenk/pthread-cleanup

Pthread cleanup

8 years agocollectd.spec: sort list
Ruben Kerkhof [Sat, 4 Jun 2016 10:57:34 +0000 (12:57 +0200)]
collectd.spec: sort list

8 years agocollectd.spec: EPEL7 has a recent ganglia-devel
Ruben Kerkhof [Sat, 4 Jun 2016 10:54:43 +0000 (12:54 +0200)]
collectd.spec: EPEL7 has a recent ganglia-devel

8 years agocollectd.spec: sort plugin lists
Ruben Kerkhof [Sat, 4 Jun 2016 10:51:47 +0000 (12:51 +0200)]
collectd.spec: sort plugin lists

8 years agocollectd.spec: turn TODO into changelog entry
Ruben Kerkhof [Sat, 4 Jun 2016 10:43:07 +0000 (12:43 +0200)]
collectd.spec: turn TODO into changelog entry

8 years agoAdd new Chrony plugin to rpm spec file
Ruben Kerkhof [Sat, 4 Jun 2016 10:25:54 +0000 (12:25 +0200)]
Add new Chrony plugin to rpm spec file

8 years agoRemove HAVE_PTHREAD_H include guard
Ruben Kerkhof [Sat, 4 Jun 2016 09:50:59 +0000 (11:50 +0200)]
Remove HAVE_PTHREAD_H include guard

We can't build without pthread.h so guarding it is not necessary
anymore.

8 years agoconfigure.ac: move AC_SUBST down to after define
Ruben Kerkhof [Sat, 4 Jun 2016 09:48:56 +0000 (11:48 +0200)]
configure.ac: move AC_SUBST down to after define

8 years agoSort types.db
Ruben Kerkhof [Sat, 4 Jun 2016 09:22:09 +0000 (11:22 +0200)]
Sort types.db

8 years agoMerge pull request #1548 from bbczeuz/zseng_dev_chrony
Ruben Kerkhof [Sat, 4 Jun 2016 09:19:14 +0000 (11:19 +0200)]
Merge pull request #1548 from bbczeuz/zseng_dev_chrony

[plugin] Chrony NTP service check

8 years agosrc/Makefile.am: merge EXTRA_DIST variables
Ruben Kerkhof [Fri, 3 Jun 2016 20:36:04 +0000 (22:36 +0200)]
src/Makefile.am: merge EXTRA_DIST variables

8 years agosrc/Makefile.am: remove commented out line
Ruben Kerkhof [Fri, 3 Jun 2016 20:34:28 +0000 (22:34 +0200)]
src/Makefile.am: remove commented out line

8 years agosrc/Makefile.am: remove useless assigment
Ruben Kerkhof [Fri, 3 Jun 2016 20:33:23 +0000 (22:33 +0200)]
src/Makefile.am: remove useless assigment

8 years agozfs_arc: simplify build logic
Ruben Kerkhof [Fri, 3 Jun 2016 20:29:03 +0000 (22:29 +0200)]
zfs_arc: simplify build logic

Use BUILD_SOLARIS instead of assuming that any OS not FreeBSD or Linux is Solaris.

8 years agosrc/Makefile.am: remove useless assignment
Ruben Kerkhof [Fri, 3 Jun 2016 20:22:06 +0000 (22:22 +0200)]
src/Makefile.am: remove useless assignment

8 years agoxencpu: add missing cppflags and ldflags
Ruben Kerkhof [Fri, 3 Jun 2016 20:20:43 +0000 (22:20 +0200)]
xencpu: add missing cppflags and ldflags

8 years agowrite_redis: append to CPPFLAGS, not CFLAGS
Ruben Kerkhof [Fri, 3 Jun 2016 18:49:48 +0000 (20:49 +0200)]
write_redis: append to CPPFLAGS, not CFLAGS

8 years agoopenvpn plugin: remove useless assignment
Ruben Kerkhof [Fri, 3 Jun 2016 18:45:20 +0000 (20:45 +0200)]
openvpn plugin: remove useless assignment

8 years agooracle plugin: use CPPFLAGS instead of CFLAGS
Ruben Kerkhof [Fri, 3 Jun 2016 18:44:58 +0000 (20:44 +0200)]
oracle plugin: use CPPFLAGS instead of CFLAGS

8 years agoopenldap plugin: use CPPFLAGS instead of CFLAGS
Ruben Kerkhof [Fri, 3 Jun 2016 18:42:36 +0000 (20:42 +0200)]
openldap plugin: use CPPFLAGS instead of CFLAGS

8 years agoopenldap plugin: use $PLUGIN_LDFLAGS
Ruben Kerkhof [Fri, 3 Jun 2016 18:41:50 +0000 (20:41 +0200)]
openldap plugin: use $PLUGIN_LDFLAGS

Just like the other plugins.

8 years agosrc/Makefile.am: remove useless assignment
Ruben Kerkhof [Fri, 3 Jun 2016 18:40:25 +0000 (20:40 +0200)]
src/Makefile.am: remove useless assignment

8 years agomysql plugin: simplify build logic
Ruben Kerkhof [Fri, 3 Jun 2016 18:38:10 +0000 (20:38 +0200)]
mysql plugin: simplify build logic

The MySQL plugin can't be build without libmysql support.
./configure already takes care of that.

8 years agolvm: add missing cppflags and ldflags to Makefile
Ruben Kerkhof [Fri, 3 Jun 2016 18:34:29 +0000 (20:34 +0200)]
lvm: add missing cppflags and ldflags to Makefile

8 years agosrc/Makefile.am: remove useless assignment
Ruben Kerkhof [Fri, 3 Jun 2016 18:32:53 +0000 (20:32 +0200)]
src/Makefile.am: remove useless assignment

8 years agoipvs: simplify logic a bit
Ruben Kerkhof [Fri, 3 Jun 2016 18:30:59 +0000 (20:30 +0200)]
ipvs: simplify logic a bit

8 years agosrc/Makefile.am: remove useless assignment
Ruben Kerkhof [Fri, 3 Jun 2016 18:26:10 +0000 (20:26 +0200)]
src/Makefile.am: remove useless assignment

8 years agosimplify Makefile.am for nginx and write_http
Ruben Kerkhof [Fri, 3 Jun 2016 17:23:09 +0000 (19:23 +0200)]
simplify Makefile.am for nginx and write_http

They can't be build without libcurl support,
./configure will take care of that.

Remove the now unused BUILD_WITH_LIBCURL conditional

8 years agoSimplify Makefile.am for curl plugins
Ruben Kerkhof [Fri, 3 Jun 2016 17:20:50 +0000 (19:20 +0200)]
Simplify Makefile.am for curl plugins

They can't be build without libcurl support,
./configure will take care of that.

8 years agoaquaero: add flags to the right variable
Ruben Kerkhof [Fri, 3 Jun 2016 17:10:39 +0000 (19:10 +0200)]
aquaero: add flags to the right variable

8 years agosrc/Makefile.am: merge 2 lines
Ruben Kerkhof [Fri, 3 Jun 2016 17:07:29 +0000 (19:07 +0200)]
src/Makefile.am: merge 2 lines

8 years agosrc/Makefile.am: simplify Apache plugin
Ruben Kerkhof [Fri, 3 Jun 2016 17:05:44 +0000 (19:05 +0200)]
src/Makefile.am: simplify Apache plugin

It can't be build without libcurl support and
configure will take care of that.

8 years agoconfigure.ac: break a few long lines up
Ruben Kerkhof [Fri, 3 Jun 2016 16:50:53 +0000 (18:50 +0200)]
configure.ac: break a few long lines up

8 years agoAlways build with pthread support
Ruben Kerkhof [Fri, 3 Jun 2016 16:30:00 +0000 (18:30 +0200)]
Always build with pthread support

Until now you could run ./configure --with-libpthread=no.
This didn't actually compile though.

The daemon has assumed for a while now that pthread support
is available. Bail out in ./configure if this is not the case.

8 years agoconfigure.ac: remove unused HAVE_LIBPTHREAD define
Ruben Kerkhof [Fri, 3 Jun 2016 16:05:11 +0000 (18:05 +0200)]
configure.ac: remove unused HAVE_LIBPTHREAD define

8 years agounixsock plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 16:01:14 +0000 (18:01 +0200)]
unixsock plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agostatsd plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:58:13 +0000 (17:58 +0200)]
statsd plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agosnmp plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:51:48 +0000 (17:51 +0200)]
snmp plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agonut plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:50:57 +0000 (17:50 +0200)]
nut plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agonotify_email plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:50:35 +0000 (17:50 +0200)]
notify_email plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agonetwork plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:50:08 +0000 (17:50 +0200)]
network plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agojava plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:49:24 +0000 (17:49 +0200)]
java plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agoexec plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:48:47 +0000 (17:48 +0200)]
exec plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agoemail plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:48:19 +0000 (17:48 +0200)]
email plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agodns plugin: stop linking with libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:47:35 +0000 (17:47 +0200)]
dns plugin: stop linking with libpthread

The collectd daemon already links with it.

8 years agoall plugins: remove pthread.h include
Ruben Kerkhof [Fri, 3 Jun 2016 15:44:58 +0000 (17:44 +0200)]
all plugins: remove pthread.h include

plugin.h already includes pthread.h

8 years agoDon't hardcode libpthread
Ruben Kerkhof [Fri, 3 Jun 2016 15:30:57 +0000 (17:30 +0200)]
Don't hardcode libpthread

8 years agocollectd_tg: let automake compute dependencies
Ruben Kerkhof [Fri, 3 Jun 2016 15:08:33 +0000 (17:08 +0200)]
collectd_tg: let automake compute dependencies

Automake already does the right thing based on the library added with _LDADD.
This also restores a missing dependency on libheap.la.

8 years agocollectd_tg: simplify logic a bit
Ruben Kerkhof [Fri, 3 Jun 2016 15:04:06 +0000 (17:04 +0200)]
collectd_tg: simplify logic a bit

We always link collectdctl with libcollectdclient/libcollectdclient.la.
Make this more obvious.

8 years agocollectdctl: let automake compute dependencies
Ruben Kerkhof [Fri, 3 Jun 2016 15:01:32 +0000 (17:01 +0200)]
collectdctl: let automake compute dependencies

Automake already does the right thing based on the library added with _LDADD

8 years agocollectdctl: simplify logic a bit
Ruben Kerkhof [Fri, 3 Jun 2016 15:00:33 +0000 (17:00 +0200)]
collectdctl: simplify logic a bit

We always link collectdctl with libcollectdclient/libcollectdclient.la.
Make this more obvious.

8 years agosrc/Makefile.am: let automake compute dependencies
Ruben Kerkhof [Fri, 3 Jun 2016 14:58:01 +0000 (16:58 +0200)]
src/Makefile.am: let automake compute dependencies

Automake already does the right thing based on the library
added with _LDADD

8 years agosrc/Makefile.am: simplify logic a bit
Ruben Kerkhof [Fri, 3 Jun 2016 14:52:47 +0000 (16:52 +0200)]
src/Makefile.am: simplify logic a bit

We always link collectd_nagios with libcollectdclient/libcollectdclient.la.
Make this more obvious.

8 years agoRemoved braces on single line 'if'. Always using inet_ntop.
Claudius Zingerli [Fri, 3 Jun 2016 14:38:23 +0000 (16:38 +0200)]
Removed braces on single line 'if'. Always using inet_ntop.

8 years agoMacro fixes, Implemented comments from code review (style, defines)
Claudius Zingerli [Fri, 3 Jun 2016 13:14:43 +0000 (15:14 +0200)]
Macro fixes, Implemented comments from code review (style, defines)

8 years agosrc/Makefile.am: remove CPPFLAGS assignment
Ruben Kerkhof [Fri, 3 Jun 2016 12:23:16 +0000 (14:23 +0200)]
src/Makefile.am: remove CPPFLAGS assignment

AM_CPPFLAGS are added by default, unless you override _CPPFLAGS

8 years agoMerge branch 'collectd-5.5'
Ruben Kerkhof [Fri, 3 Jun 2016 10:56:53 +0000 (12:56 +0200)]
Merge branch 'collectd-5.5'

Conflicts:
src/perl.c

8 years agoMerge branch 'collectd-5.4' into collectd-5.5
Ruben Kerkhof [Fri, 3 Jun 2016 10:51:59 +0000 (12:51 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5

8 years agosrc/Makefile.am: remove unused variable
Ruben Kerkhof [Fri, 3 Jun 2016 10:51:13 +0000 (12:51 +0200)]
src/Makefile.am: remove unused variable

8 years agoconfigure: Add some more information about protoc/gRPC in the summary.
Sebastian Harl [Sat, 7 May 2016 11:35:17 +0000 (13:35 +0200)]
configure: Add some more information about protoc/gRPC in the summary.

8 years agosrc/Makefile: Move proto-generated sources to nodist_*_SOURCES.
Sebastian Harl [Sat, 7 May 2016 11:26:22 +0000 (13:26 +0200)]
src/Makefile: Move proto-generated sources to nodist_*_SOURCES.

8 years agocollectd.conf(5): Briefly document grpc's SSL options.
Sebastian Harl [Sat, 7 May 2016 00:34:25 +0000 (02:34 +0200)]
collectd.conf(5): Briefly document grpc's SSL options.

8 years agocollectd.conf: Update grpc sample configuration.
Sebastian Harl [Sat, 7 May 2016 00:26:39 +0000 (02:26 +0200)]
collectd.conf: Update grpc sample configuration.

8 years agogrpc plugin: Add options to enable SSL protected connections.
Sebastian Harl [Sat, 7 May 2016 00:17:12 +0000 (02:17 +0200)]
grpc plugin: Add options to enable SSL protected connections.

8 years agogrpc plugin: Use std::vector to store listener configs.
Sebastian Harl [Fri, 6 May 2016 22:36:40 +0000 (00:36 +0200)]
grpc plugin: Use std::vector to store listener configs.

8 years agogrpc plugin: Replace the ListValues RPC with QueryValues.
Sebastian Harl [Fri, 6 May 2016 22:15:49 +0000 (00:15 +0200)]
grpc plugin: Replace the ListValues RPC with QueryValues.

This is a more powerful function to query values from collectd's cache.

8 years agogrpc plugin: Split out identifier into it's own message type.
Sebastian Harl [Fri, 6 May 2016 22:09:45 +0000 (00:09 +0200)]
grpc plugin: Split out identifier into it's own message type.

8 years agogrpc plugin: Use plugin_thread_create instead of pthread_create.
Sebastian Harl [Fri, 6 May 2016 21:49:01 +0000 (23:49 +0200)]
grpc plugin: Use plugin_thread_create instead of pthread_create.

8 years agogrpc plugin: Always populate *instance fields in a value-list.
Sebastian Harl [Fri, 6 May 2016 21:47:53 +0000 (23:47 +0200)]
grpc plugin: Always populate *instance fields in a value-list.

That is, ensure a (null-terminated!) empty string if the field is empty.

8 years agogrpc plugin: Update to the new gRPC API.
Sebastian Harl [Mon, 25 Apr 2016 21:52:57 +0000 (23:52 +0200)]
grpc plugin: Update to the new gRPC API.

8 years agogrpc plugin: Make RPC call implementation more modular.
Sebastian Harl [Mon, 2 Nov 2015 23:03:11 +0000 (00:03 +0100)]
grpc plugin: Make RPC call implementation more modular.

Use a template class for the RPC call object implementation to handle all
common functionality. The actual RPC implementation has been moved into
overloaded functions, one for each RPC. This approach only works as long as
the request and response type pairs are unique per call. That's common
practice, though, and in case there's an exception, it would have to fall back
to the previous approach (one class per call).

8 years agocollectd.conf: Example grpc configuration.
Sebastian Harl [Thu, 29 Oct 2015 23:10:38 +0000 (00:10 +0100)]
collectd.conf: Example grpc configuration.

8 years agogrpc plugin: Implement the ListValues() RPC.
Sebastian Harl [Thu, 29 Oct 2015 23:01:52 +0000 (00:01 +0100)]
grpc plugin: Implement the ListValues() RPC.

8 years agoREADME: Document grpc dependencies.
Sebastian Harl [Thu, 29 Oct 2015 22:25:25 +0000 (23:25 +0100)]
README: Document grpc dependencies.

8 years agocollectd.conf(5): Document the gRPC plugin.
Sebastian Harl [Thu, 29 Oct 2015 22:19:53 +0000 (23:19 +0100)]
collectd.conf(5): Document the gRPC plugin.

8 years agogrpc plugin: Make listeners and worker threads configurable.
Sebastian Harl [Thu, 29 Oct 2015 22:15:46 +0000 (23:15 +0100)]
grpc plugin: Make listeners and worker threads configurable.

8 years agogrpc plugin: Add a plugin providing a gRPC server.
Sebastian Harl [Thu, 29 Oct 2015 21:37:53 +0000 (22:37 +0100)]
grpc plugin: Add a plugin providing a gRPC server.

gRPC is an open source RPC framework based on protocol buffers. The plugin
currently exposes one RPC end-point for dispatching values to the daemon but
is easy to extend for more functionality.

The plugin is written in C++ and uses an synchronous architecture which should
provide maximum performance. The collectd build system has been extended to
support C++ (11) and protocol buffers (3.0+).

8 years agoutils cache: Add an iterator interface.
Sebastian Harl [Fri, 6 May 2016 21:52:02 +0000 (23:52 +0200)]
utils cache: Add an iterator interface.

This may be used to query additional information from the cache.

8 years agoMerged branch 'collectd-4.10' into collectd-5.4.
Sebastian Harl [Mon, 30 May 2016 20:09:07 +0000 (22:09 +0200)]
Merged branch 'collectd-4.10' into collectd-5.4.

8 years agoperl plugin: Be more consistent about capitalization.
Sebastian Harl [Mon, 30 May 2016 19:59:46 +0000 (21:59 +0200)]
perl plugin: Be more consistent about capitalization.

8 years agoperl plugin: Removed commented code
Pavel Rochnyack [Mon, 30 May 2016 06:00:38 +0000 (12:00 +0600)]
perl plugin: Removed commented code