Code

collectd.git
12 years agoWe have to convert CDTime to seconds since epoch
Chris Lundquist [Fri, 20 Jan 2012 22:29:31 +0000 (14:29 -0800)]
We have to convert CDTime to seconds since epoch

12 years agoremove commented out code
Chris Lundquist [Mon, 16 Jan 2012 17:44:37 +0000 (09:44 -0800)]
remove commented out code

12 years agoOk it is posting to the local server
Chris Lundquist [Tue, 17 Jan 2012 05:10:46 +0000 (21:10 -0800)]
Ok it is posting to the local server

12 years agoadded more debugging. cleaned up commented lines
Chris Lundquist [Tue, 17 Jan 2012 00:13:13 +0000 (16:13 -0800)]
added more debugging. cleaned up commented lines

12 years agocompiles cleanly. libmongoc doesn't have an install target, will try to commit one...
Chris Lundquist [Fri, 13 Jan 2012 22:33:29 +0000 (14:33 -0800)]
compiles cleanly. libmongoc doesn't have an install target, will try to commit one there instead of having to hack the directory stucture to please ./configure.

12 years agoconfigure.in: Improve check for libmongoc (aka. mongo-c-driver)
Florian Forster [Sat, 6 Nov 2010 10:53:42 +0000 (11:53 +0100)]
configure.in: Improve check for libmongoc (aka. mongo-c-driver)

12 years agowrite_mongodb plugin: Rename the "write_mongo" plugin.
Florian Forster [Wed, 3 Nov 2010 14:19:26 +0000 (15:19 +0100)]
write_mongodb plugin: Rename the "write_mongo" plugin.

12 years agowrite_mongo plugin: Build fixes.
Florian Forster [Wed, 3 Nov 2010 14:13:28 +0000 (15:13 +0100)]
write_mongo plugin: Build fixes.

Enable the "write_mongo" plugin when the library is available. Move the
"MONGO_HAVE_STDINT" define into the .c file. Avoid the poisoned "strcpy".

12 years agoFix plugin and type instance field name, also free bson object buffer
Akkarit Sangpetch [Sat, 2 Oct 2010 15:49:43 +0000 (11:49 -0400)]
Fix plugin and type instance field name, also free bson object buffer

12 years agoAdd write_mongo plugin support for mongodb output (based on write_redis)
Akkarit Sangpetch [Wed, 3 Nov 2010 13:01:11 +0000 (14:01 +0100)]
Add write_mongo plugin support for mongodb output (based on write_redis)

12 years agoconfigure.in: Check for libmongoc.
Ryan Cox [Wed, 3 Nov 2010 13:04:09 +0000 (14:04 +0100)]
configure.in: Check for libmongoc.

12 years agoMerge branch 'collectd-5.0'
Florian Forster [Sat, 21 Jan 2012 17:26:17 +0000 (18:26 +0100)]
Merge branch 'collectd-5.0'

12 years agoMerge branch 'collectd-4.10' into collectd-5.0 collectd-5.0.2
Florian Forster [Sat, 21 Jan 2012 17:25:37 +0000 (18:25 +0100)]
Merge branch 'collectd-4.10' into collectd-5.0

Change-Id: I8fea9338ac6490b2a76530a58c6bd36ec17d021a

12 years agoUpdate ChangeLog. collectd-4.10.5
Florian Forster [Sat, 21 Jan 2012 17:24:45 +0000 (18:24 +0100)]
Update ChangeLog.

Change-Id: I7361ea08e1695b2928463150df36d385aa51299c

12 years agooracle plugin: Fix a memory leak.
Florian Forster [Sat, 21 Jan 2012 17:21:46 +0000 (18:21 +0100)]
oracle plugin: Fix a memory leak.

Parameters must be freed using OCIDescriptorFree. D'oh!

Thanks to Rena Vetterling for helping me hunt down this problem!

Change-Id: Ic374ae13085c8d2afbdf9a3c0ceef92b485e7723

12 years agooracle plugin: Improve the error printing function.
Florian Forster [Sat, 21 Jan 2012 17:01:24 +0000 (18:01 +0100)]
oracle plugin: Improve the error printing function.

Change-Id: Ie52c80bd4a686b403037c97383176adf3e701419

12 years agoBump version to 5.0.2; Update ChangeLog.
Florian Forster [Sat, 21 Jan 2012 13:01:34 +0000 (14:01 +0100)]
Bump version to 5.0.2; Update ChangeLog.

Change-Id: I8e564e51d9e9f3dc847811fd0d51fbf0079c20ba

12 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Sat, 21 Jan 2012 12:07:50 +0000 (13:07 +0100)]
Merge branch 'collectd-4.10' into collectd-5.0

Conflicts:
ChangeLog
src/df.c
src/plugin.h
version-gen.sh

Change-Id: Id7a31088cdb3371534d5c1e6a690464f3343543d

12 years agoBump version to 4.10.5; Update ChangeLog.
Florian Forster [Sat, 21 Jan 2012 12:04:28 +0000 (13:04 +0100)]
Bump version to 4.10.5; Update ChangeLog.

Change-Id: I900278064970e0c2d2bf471f4f80c7672aa8211f

12 years agodf: Set negative free space values to zero.
Toni Ylenius [Fri, 6 Jan 2012 16:13:56 +0000 (18:13 +0200)]
df: Set negative free space values to zero.

Some file systems (eg. UFS) may report negative free spave values.
Previously this caused underflow, but now it is prevented by setting
negative values to zero.

Change-Id: I821adb8a6d7a40dcbd6c65ab3541fbcd714f8aba

Conflicts:

src/df.c

12 years agonetwork plugin: Use the new plugin_dispatch_values_secure().
Florian Forster [Wed, 23 Nov 2011 13:40:58 +0000 (14:40 +0100)]
network plugin: Use the new plugin_dispatch_values_secure().

Change-Id: I2cc65a36366c6c714cd79c2905879bce313efe31

12 years agosrc/plugin.[ch]: Add plugin_dispatch_values_secure().
Florian Forster [Wed, 23 Nov 2011 13:28:27 +0000 (14:28 +0100)]
src/plugin.[ch]: Add plugin_dispatch_values_secure().

Change-Id: I1f7403b2e82edd099f0168d0a0735cd18f8ce05a

12 years agosrc/meta_data.[ch]: Add meta_data_clone().
Florian Forster [Wed, 23 Nov 2011 13:28:01 +0000 (14:28 +0100)]
src/meta_data.[ch]: Add meta_data_clone().

Change-Id: I8449e27c908cbe75ea4ea3b8dd4df556f9aec9e7

12 years agoMerge "Fix case when availrmem < freemem" into collectd-4.10
Florian Forster [Sat, 21 Jan 2012 10:14:53 +0000 (11:14 +0100)]
Merge "Fix case when availrmem < freemem" into collectd-4.10

12 years agoFix case when availrmem < freemem
Fabien Wernli [Fri, 9 Dec 2011 15:30:30 +0000 (16:30 +0100)]
Fix case when availrmem < freemem

Change-Id: I03b188afeb2357e7b8c426bd0c6daff06fda2c4f

Conflicts:

src/memory.c

12 years agoMerge pull request #16 from pyr/master
Florian Forster [Wed, 18 Jan 2012 15:17:47 +0000 (07:17 -0800)]
Merge pull request #16 from pyr/master

GenericJMX plugin: Allow attribute to call operations.

12 years agorespect provided format
Pierre-Yves Ritschard [Wed, 18 Jan 2012 15:05:27 +0000 (16:05 +0100)]
respect provided format

12 years agoas per octo's request, provide details on nulls
Pierre-Yves Ritschard [Wed, 18 Jan 2012 15:02:52 +0000 (16:02 +0100)]
as per octo's request, provide details on nulls

12 years agoAllow `Attribute` to query an MBean operation
Pierre-Yves Ritschard [Wed, 18 Jan 2012 12:57:11 +0000 (13:57 +0100)]
Allow `Attribute` to query an MBean operation

MBeans provide two entities to the outside world:

* Attributes
* Operations

The former is a simple key/value lookup, while the latter
triggers a method call and yields the result.

Operations have signatures, they can be fed an array of
parameters. For now, calls are triggered assuming
there are no parameters. Later a separate keyword
`Operation` can be introduced, taking a list of
`Parameter` directives specifying type and values
to feed to the MBean operation.

12 years agoMerge pull request #14 from insom/master
Florian Forster [Wed, 18 Jan 2012 11:08:14 +0000 (03:08 -0800)]
Merge pull request #14 from insom/master

Add persistent 'OKAY' notifications.

12 years agoMerge pull request #13 from insom/improved-migration
Florian Forster [Wed, 18 Jan 2012 11:01:04 +0000 (03:01 -0800)]
Merge pull request #13 from insom/improved-migration

Migration: Ensure destination directories exist when moving RRDs

12 years agopython: Fixed memory leaks during dispatch.
Sven Trenkel [Tue, 17 Jan 2012 01:56:03 +0000 (01:56 +0000)]
python: Fixed memory leaks during dispatch.

12 years agoAdded "PersistOK" option to threshold to send notifications, even for OKAYs.
Aaron Brady [Wed, 2 Mar 2011 23:10:26 +0000 (23:10 +0000)]
Added "PersistOK" option to threshold to send notifications, even for OKAYs.

12 years agoMigration: Ensure destination directories exist when moving RRDs
Aaron Brady [Sun, 15 Jan 2012 13:16:37 +0000 (13:16 +0000)]
Migration: Ensure destination directories exist when moving RRDs

If you have not run collectd 5 before, then when type instances
are migrated to plugin instances the destination directories
may not already exist. For example:

mv "./test/df/df-mnt-dlna.rrd" "./test/df-mnt-dlna/df.rrd"

This one-liner does a mkdir -p of the destination before
attempting to move the file.

12 years agoUpdated the redhat spec so 5.0.1 would build.
Jason Stelzer [Thu, 5 Jan 2012 14:45:53 +0000 (09:45 -0500)]
Updated the redhat spec so 5.0.1 would build.

Change-Id: I3f4f8e520b0be0226cd0ff5e3da5ff5dd090065c

12 years agosrc/common.c: parse_value: Be more verbose about parsing problems.
Florian Forster [Mon, 19 Dec 2011 14:17:39 +0000 (15:17 +0100)]
src/common.c: parse_value: Be more verbose about parsing problems.

Change-Id: I784ec4ee9a1e89a82fdc9da54ed1fafd3d9c3e57

12 years agocollectd-perl(5): Fix example Perl script.
Florian Forster [Wed, 14 Dec 2011 12:02:16 +0000 (13:02 +0100)]
collectd-perl(5): Fix example Perl script.

Thanks to Sergey for catching this!

Change-Id: I4bbb609079734cd54d68f77681ea742b4eb83239

13 years agoThis improves solaris memory plugin granularity.
Fabien Wernli [Tue, 25 Oct 2011 13:15:16 +0000 (15:15 +0200)]
This improves solaris memory plugin granularity.

Locked memory is now only tracking non-kernel locked memory.
We add kernel and unusable memory.
Source: http://www.brendangregg.com/K9Toolkit/swapinfo

Change-Id: I4f4d281e991068dc845d8c3615d285fc2a3296c8

13 years agouse 64bit counters if available
Fabien Wernli [Thu, 27 Oct 2011 15:14:06 +0000 (17:14 +0200)]
use 64bit counters if available

13 years agoMerge "Fix file:// not working as return code is 0 and not 200, as fixed beforehand...
Florian Forster [Fri, 25 Nov 2011 09:48:22 +0000 (10:48 +0100)]
Merge "Fix file:// not working as return code is 0 and not 200, as fixed beforehand in curl_json. Remove mention of http in documention as file also works now (and ftp most likely too)" into collectd-4.10

13 years agoFix file:// not working as return code is 0 and not 200, as fixed
Fabien Wernli [Fri, 4 Nov 2011 10:25:59 +0000 (11:25 +0100)]
Fix file:// not working as return code is 0 and not 200, as fixed
beforehand in curl_json.
Remove mention of http in documention as file also works now (and ftp most likely too)

Change-Id: Iccb35e6b8c831f555dc5bbd17fa8d04672e13eb3

13 years agoMerge "interface plugin: Fix for bogus interfaces under Solaris." into collectd-4.10
Florian Forster [Thu, 24 Nov 2011 14:43:21 +0000 (15:43 +0100)]
Merge "interface plugin: Fix for bogus interfaces under Solaris." into collectd-4.10

13 years agoMerge "irq plugin: Use the standard ignorelist for filtering interrupts."
Florian Forster [Thu, 24 Nov 2011 13:41:54 +0000 (14:41 +0100)]
Merge "irq plugin: Use the standard ignorelist for filtering interrupts."

13 years agoChangeLog: Remove blank line. collectd-5.0.1
Florian Forster [Fri, 14 Oct 2011 20:42:26 +0000 (22:42 +0200)]
ChangeLog: Remove blank line.

Change-Id: Ief9cabb148d75b79e0764d629c571ee9dc3d7d3b

13 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Fri, 14 Oct 2011 20:42:09 +0000 (22:42 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0

Conflicts:
ChangeLog

Change-Id: I65f02dbcad46460f18f356bc8d32eb15a7a352c2

13 years agoChangeLog: Add thanks to Peter Green. collectd-4.10.4
Florian Forster [Fri, 14 Oct 2011 20:41:21 +0000 (22:41 +0200)]
ChangeLog: Add thanks to Peter Green.

Change-Id: Ie392f7dfc7d637c92e286b0bf6d5d32877f70f76

13 years agoBump version to 5.0.1; Update ChangeLog.
Florian Forster [Fri, 7 Oct 2011 15:36:10 +0000 (17:36 +0200)]
Bump version to 5.0.1; Update ChangeLog.

Change-Id: I01466d5fb5c0d5c08a48d7c7e7a81239960a2d3c

13 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Fri, 7 Oct 2011 15:27:06 +0000 (17:27 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0

Conflicts:
ChangeLog
src/collectd.conf.in
src/curl_json.c
version-gen.sh

Change-Id: I313c0d3c73d47481baa0a3b38bcdf508f1d4f8d8

13 years agoBump version to 4.10.4; Update ChangeLog.
Florian Forster [Fri, 7 Oct 2011 15:21:57 +0000 (17:21 +0200)]
Bump version to 4.10.4; Update ChangeLog.

Change-Id: Ie23cf45f929c52e94e968c7129d24aca7a287dd5

13 years agoAMQP plugin: My kingdom for a few semicolons
Scott Lyons [Mon, 5 Sep 2011 21:04:25 +0000 (17:04 -0400)]
AMQP plugin: My kingdom for a few semicolons

Change-Id: I08621fd2381e064f1006728162c22cfd12c48cc6

13 years agointerface plugin: Fix for bogus interfaces under Solaris.
Eddy Geez [Sat, 3 Sep 2011 13:10:21 +0000 (09:10 -0400)]
interface plugin: Fix for bogus interfaces under Solaris.

Under newer versions of Solaris, the method for finding network interfaces
results in 'collectd' gathering statistics on an interface called 'mac', along
with 16 interfaces named 'wrsmd0' through 'wrsmd15' (which are for WCI Remote
Shared Memory). The 'mac' interface is especially problematic because it
occurs multiple times, which results in warnings from rrdtool about insertions
with the same timestamp.

Change-Id: I1ae070ecbc820da25c0f0ad457aba80213339fd2
Signed-off-by: Florian Forster <octo@collectd.org>
13 years agocollectd.conf.in: Use the "Globals" option for perl and python.
Florian Forster [Fri, 2 Sep 2011 22:41:05 +0000 (18:41 -0400)]
collectd.conf.in: Use the "Globals" option for perl and python.

Change-Id: Icaccaab601b91bc829c4da94c5344e0d766735bd

13 years agoAdd RPM .spec file and startup script for AIX
Aurelien Reynaud [Thu, 14 Oct 2010 19:18:47 +0000 (21:18 +0200)]
Add RPM .spec file and startup script for AIX

Change-Id: Ic6187891e2014d84f8b2926df1c8b2012f26923f
Signed-off-by: Aurelien Reynaud <collectd@wattapower.net>
Signed-off-by: Florian Forster <octo@collectd.org>
13 years agoMerge "curl_json plugin: Be more clever building the type instance." into collectd...
Florian Forster [Fri, 2 Sep 2011 22:48:47 +0000 (00:48 +0200)]
Merge "curl_json plugin: Be more clever building the type instance." into collectd-4.10

13 years agoirq plugin: Use the standard ignorelist for filtering interrupts.
Florian Forster [Fri, 2 Sep 2011 01:40:24 +0000 (21:40 -0400)]
irq plugin: Use the standard ignorelist for filtering interrupts.

Change-Id: I7d15318c3c1d519d5e7bc715566a9b298f087bcc

13 years agoMerge branch 'collectd-5.0'
Florian Forster [Fri, 2 Sep 2011 01:34:00 +0000 (21:34 -0400)]
Merge branch 'collectd-5.0'

13 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Fri, 2 Sep 2011 01:28:05 +0000 (21:28 -0400)]
Merge branch 'collectd-4.10' into collectd-5.0

Conflicts:
src/irq.c

Change-Id: Ie6c78234f07cc5b7bac7e6914813e9545ce1b1af

13 years agoirq plugin: Implement collection of non-numeric interrupts.
Bostjan Skufca [Fri, 2 Sep 2011 00:35:38 +0000 (20:35 -0400)]
irq plugin: Implement collection of non-numeric interrupts.

Hi all!

I've created a patch that enables collectd to collect all irqs present in
/proc/interrupts, with numeric and string names (NMI, LOC, RES, etc).

Two notices:
a) Unfortunately I was unable to build collectd from git repo (build.sh
   failures), therefore I created this patch for latest stable release: 4.10.1
b) I am fairly unexperienced in C programming, so please inform me gently of my
   mistakes:) But I am already using a patched version and it works fine.

Any feedback on code quality or recommendations are welcome.

Change-Id: Ia17bd953921051dfe53e838b76672adbef9e73c3
Signed-off-by: Florian Forster <octo@collectd.org>
13 years agoprocesses plugin: Fixed handling of ProcessMatch regexes containing spaces.
Sebastian Harl [Wed, 24 Aug 2011 16:26:12 +0000 (18:26 +0200)]
processes plugin: Fixed handling of ProcessMatch regexes containing spaces.

Previously, something like 'ProcessMatch name "My Regex"' would have been
interpreted as three values. This was caused by using the old, non-complex
config interface which joins all config values using a space and passing the
resulting string to the plugin. The processes plugin used to use strsplit() to
re-gain a list of all values, obviously ignoring any quoting that might exist.

This has been fixed by using the complex config interface, which passes all
values as an array of strings and thus honoring the quoting handled by
liboconfig.

13 years agoMerge "exec plugin: Fixed incorrect typecast of 64-bit timestamp to unsigned int...
Florian Forster [Sat, 27 Aug 2011 19:48:12 +0000 (21:48 +0200)]
Merge "exec plugin: Fixed incorrect typecast of 64-bit timestamp to unsigned int (collectd-5.0)" into collectd-5.0

13 years agoexec plugin: Fixed incorrect typecast of 64-bit timestamp to unsigned int (collectd...
Alexander Kovalenko [Sat, 27 Aug 2011 18:20:22 +0000 (22:20 +0400)]
exec plugin: Fixed incorrect typecast of 64-bit timestamp to unsigned int (collectd-5.0)

Change-Id: Ia99285c8158828760e74083ed6ea54112fa8a156
Signed-off-by: Alexander Kovalenko <alexanderk23@gmail.com>
Signed-off-by: Florian Forster <octo@collectd.org>
13 years agocurl_json plugin: Be more clever building the type instance.
Florian Forster [Sat, 27 Aug 2011 19:29:42 +0000 (15:29 -0400)]
curl_json plugin: Be more clever building the type instance.

When the key of the parent object is empty, don't use it. The previous code led
to type instances starting with a dash, e.g. "-foo".

Also, be more verbose when unable to resolve types.

Change-Id: Ib5f55efe1acc1e819ac3189b6780a4e998bf9c9f

13 years agoVarnish plugin: Fix gauge vs. derive issues.
Florian Forster [Wed, 24 Aug 2011 16:26:59 +0000 (18:26 +0200)]
Varnish plugin: Fix gauge vs. derive issues.

Some of the values are submitted using the wrong submit function.

Change-Id: Icf82844e54605d46cce8e41d2678aa4bca1cb2c1

13 years agoMerge "fix xff excessive rounding" into collectd-4.10
Florian Forster [Fri, 26 Aug 2011 12:37:25 +0000 (14:37 +0200)]
Merge "fix xff excessive rounding" into collectd-4.10

13 years ago.gitignore: Added collectdctl.
Sebastian Harl [Thu, 12 Aug 2010 20:12:47 +0000 (22:12 +0200)]
.gitignore: Added collectdctl.

13 years agoCorrect a missing yajl1/2 check
jbergstroem [Wed, 24 Aug 2011 14:25:29 +0000 (16:25 +0200)]
Correct a missing yajl1/2 check

Change-Id: Ie3e0380721d88e54cb5630e1c3ecb613790b32b3

13 years agotcpconns plugin: add support for AIX
Manuel Luis SanmartĂ­n Rozada [Mon, 6 Jun 2011 12:14:27 +0000 (14:14 +0200)]
tcpconns plugin: add support for AIX

Hi.

In AIX there is a undocumented function/syscall in libc: netinfo
returns a structure with the state of the tcp connections.

I didn't found the description or info abut this syscall,  I guess is
something like this:

int netinfo (int proto, void *data, int *size,  int n);

and the struct something like this: (with some work we can guess the
unknow remaining bytes)

struct netinfo_header {
        unsigned int proto;
        unsigned int size;
        struct netinfo_entry e[];
};
struct netinfo_entry {
        uint32_t unknow1;
        uint32_t unknow2;
        uint16_t dstport;
        uint16_t unknow3;
        struct in6_addr dstaddr;
        uint16_t srcport;
        uint16_t unknow4;
        struct in6_addr srcaddr;
        uint32_t unknow01[4];
        uint32_t unknow02[2];
        uint16_t so_options;
        uint16_t unknow02a;
        uint16_t so_q0len;
        uint16_t so_qlen;
        uint16_t so_qlimit;
        uint16_t so_dqlen;
        uint32_t unknow03[4];
        struct {
                uint32_t sb_hiwat;
                uint32_t unknow01;
                uint32_t unknow02;
                uint32_t unknow03;
                uint32_t sb_mbmax;
                uint32_t unknow04;
                uint32_t sb_lowat;
                uint16_t sb_flags;
                uint16_t unknow05;
        } rcvbuf;
        uint32_t unknow07;
        uint32_t unknow08[2];
        uint32_t unknow09;
        struct {
                uint32_t sb_hiwat;
                uint32_t unknow01;
                uint32_t unknow02;
                uint32_t unknow03;
                uint32_t sb_mbmax;
                uint32_t unknow04;
                uint32_t sb_lowat;
                uint16_t sb_flags;
                uint16_t unknow05;
        } sndbuf;
        uint32_t unknow11;
        uint32_t so_uid;
        uint16_t so_special;
        uint16_t so_special2;
        uint16_t tcp_state;
        uint16_t unknow12;
        uint32_t tcp_flags;
        uint32_t tcp_mss;
        uint32_t unknow15;
};

Signed-off-by: Florian Forster <octo@collectd.org>
13 years agosrc/plugin.c: add info to 'Invalid value list' error message
Xavier Mehrenberger [Sat, 11 Jun 2011 21:01:57 +0000 (23:01 +0200)]
src/plugin.c: add info to 'Invalid value list' error message

Signed-off-by: Florian Forster <octo@collectd.org>
13 years agocollectd_unixsock.py: Fix infinite wait.
Peter Warasin [Mon, 27 Jun 2011 18:10:51 +0000 (20:10 +0200)]
collectd_unixsock.py: Fix infinite wait.

raise a KeyError if getval() or getthreshold() unixsock returns replies an
error because of request of an unknown identifier

Signed-off-by: Florian Forster <octo@collectd.org>
13 years agoMerge branch 'collectd-5.0'
Florian Forster [Sun, 21 Aug 2011 14:51:36 +0000 (16:51 +0200)]
Merge branch 'collectd-5.0'

Conflicts:
configure.in
src/owniptc/libiptc.c

Change-Id: I0ab8fc1accd476f5d1a243b1a155eac4b751cd8c

13 years agorrdtool plugin: Fix warning about unused variable "stepsize".
Florian Forster [Sun, 21 Aug 2011 14:50:29 +0000 (16:50 +0200)]
rrdtool plugin: Fix warning about unused variable "stepsize".

Change-Id: Ibd4dd3f17db62b10b96c59f37b66941ddc5ea7b0

13 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Sun, 21 Aug 2011 14:43:22 +0000 (16:43 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0

Conflicts:
src/curl_json.c
src/libvirt.c

Change-Id: I0852495b416435fa3cfd36068d967e0cd5ff689f

13 years agoconfigure: Link with ip4tc and ip6tc, too.
Florian Forster [Sun, 21 Aug 2011 14:40:23 +0000 (16:40 +0200)]
configure: Link with ip4tc and ip6tc, too.

This solves this problem:

octo@leeloo:/tmp $ gcc -o conftest -g -O2     conftest.c -liptc -ldl
/usr/bin/ld: /tmp/ccuJEDqP.o: undefined reference to symbol 'iptc_init'
/usr/bin/ld: note: 'iptc_init' is defined in DSO /lib64/libip4tc.so.0 so try adding it to the linker command line
/lib64/libip4tc.so.0: could not read symbols: Invalid operation
collect2: ld returned 1 exit status

Why the iptables plugin compiles without this is beyond me.

Change-Id: If615bee0c9524d907ca1834d5c337ed50c625c5b

13 years agofix xff excessive rounding
Francois-Xavier Bourlet [Sun, 21 Aug 2011 09:05:40 +0000 (11:05 +0200)]
fix xff excessive rounding

Hi,

When generating arguments for rrd_create, the previous
format string "%.1f", was rounding up the value too aggressively.

ex: for xff==0.9999 the result would be -> 1.0 (invalid value for xff!)

The new format string is "%.10f", which lead up to 10 digits after the
dot, enough to be close to the double type limit, and so handling
correctly the previous example.

Change-Id: I7c6cc55b0d43beb5ef351bb04b67f4628249c737

13 years agoconfigure.in: Add AC_CONFIG_AUX_DIR for libltdl.
Florian Forster [Tue, 16 Aug 2011 06:51:59 +0000 (08:51 +0200)]
configure.in: Add AC_CONFIG_AUX_DIR for libltdl.

13 years agomysql plugin: Remove sideeffect-free function call.
Florian Forster [Tue, 16 Aug 2011 06:51:21 +0000 (08:51 +0200)]
mysql plugin: Remove sideeffect-free function call.

13 years agonotify_email plugin: Remove useless function and fix indentation.
Florian Forster [Tue, 16 Aug 2011 06:50:40 +0000 (08:50 +0200)]
notify_email plugin: Remove useless function and fix indentation.

13 years agoMany build fixes that turned up with GCC 4.6.
Peter Green [Tue, 16 Aug 2011 06:48:52 +0000 (08:48 +0200)]
Many build fixes that turned up with GCC 4.6.

Signed-off-by: Florian Forster <octo@collectd.org>
13 years agosrc/csv.c: use a bigger buffer
Colin Patrick McCabe [Wed, 27 Jul 2011 17:00:30 +0000 (10:00 -0700)]
src/csv.c: use a bigger buffer

The CSV plugin formerly used a relatively small output buffer. If you
had a large dataset, you would always get error -1 because the line
length was be too long. This patch extends the buffer.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
13 years agosrc/utils_format_json.c: Correctly format the time of value lists.
Florian Forster [Thu, 7 Jul 2011 14:59:13 +0000 (16:59 +0200)]
src/utils_format_json.c: Correctly format the time of value lists.

Users should get epoch, not our internal format.

13 years agocurl_json plugin: Add compatibility code for libyajl v2.
Florian Forster [Tue, 5 Jul 2011 14:28:10 +0000 (16:28 +0200)]
curl_json plugin: Add compatibility code for libyajl v2.

Thanks to "spupykin" of the Arch Linux project on whose patch this commit is
loosely based.

13 years agoAMQP plugin: Fix printing of interval_g.
Florian Forster [Fri, 17 Jun 2011 14:37:31 +0000 (16:37 +0200)]
AMQP plugin: Fix printing of interval_g.

13 years agorrdcached plugin: Handle boolean config options as well.
Sebastian Harl [Fri, 17 Jun 2011 08:29:13 +0000 (10:29 +0200)]
rrdcached plugin: Handle boolean config options as well.

This was lost previously when changing to the complex config callback.

13 years agorrdcached plugin: Register write/flush only if DaemonAddress has been given.
Sebastian Harl [Fri, 17 Jun 2011 08:25:48 +0000 (10:25 +0200)]
rrdcached plugin: Register write/flush only if DaemonAddress has been given.

Else, the write callback would remove itself on the first call. This
operation, however, is not thread-safe as access to the write list is not
synchronized. Thus, removing the callback at that point leads to random
segfaults.

13 years agorrdcached plugin: Handle configuration using a "complex config" callback.
Sebastian Harl [Fri, 17 Jun 2011 08:20:17 +0000 (10:20 +0200)]
rrdcached plugin: Handle configuration using a "complex config" callback.

This allows to handle all of the configuration in one go and execute some
action once after doing so.

13 years agothreshold: Don't register missing/write callbacks unless we have thresholds.
Sebastian Harl [Fri, 17 Jun 2011 07:25:05 +0000 (09:25 +0200)]
threshold: Don't register missing/write callbacks unless we have thresholds.

The checking is fairly expensive, so don't do that unless really necessary.

13 years agoavl tree: Report size of the tree and make that available in _get_size().
Sebastian Harl [Fri, 17 Jun 2011 07:24:02 +0000 (09:24 +0200)]
avl tree: Report size of the tree and make that available in _get_size().

13 years agothreshold plugin: Dont check for interesting values if there are no thresholds.
Sebastian Harl [Fri, 17 Jun 2011 07:05:48 +0000 (09:05 +0200)]
threshold plugin: Dont check for interesting values if there are no thresholds.

13 years agoamqp plugin: Fixed format strings when printing 'interval_g'.
Sebastian Harl [Thu, 16 Jun 2011 09:42:20 +0000 (11:42 +0200)]
amqp plugin: Fixed format strings when printing 'interval_g'.

13 years agoconfigure: Removed last traces of 'owniptc'.
Sebastian Harl [Thu, 16 Jun 2011 09:11:40 +0000 (11:11 +0200)]
configure: Removed last traces of 'owniptc'.

E.g., autoconf still tried to generated src/owniptc/Makefile in AC_OUTPUT(),
which obviously fails if owniptc is no longer there.

13 years agoVarious plugins: Set the cURL option "CURLOPT_NOSIGNAL".
Mike Flisher [Sun, 22 May 2011 15:39:29 +0000 (17:39 +0200)]
Various plugins: Set the cURL option "CURLOPT_NOSIGNAL".

This fixes problems with version 7.21.2 (and later) of libcurl that are due to
collectd being a multi-threaded program.

Signed-off-by: Florian Forster <octo@collectd.org>
13 years agocollectd-nagios: Sort LISTVAL output.
Sebastian Harl [Mon, 16 May 2011 13:08:41 +0000 (15:08 +0200)]
collectd-nagios: Sort LISTVAL output.

Also, output the data for each host in a separate "section", printing the
hostname as the heading and leaving it out from any further output.

This way, the strings may directly be used as options for -H and -n.

13 years agolibcollectdclient: Added `lcc_sort_identifiers()'.
Sebastian Harl [Mon, 16 May 2011 13:07:18 +0000 (15:07 +0200)]
libcollectdclient: Added `lcc_sort_identifiers()'.

This function may be used to sort an array of lcc_identifier_t objects.

13 years agocollectd-nagios: Select a single host in LISTVAL output when -H has been used.
Sebastian Harl [Mon, 16 May 2011 12:43:34 +0000 (14:43 +0200)]
collectd-nagios: Select a single host in LISTVAL output when -H has been used.

13 years agocollectd-nagios: Let '-n LIST' list all available datasets.
Sebastian Harl [Mon, 16 May 2011 12:39:53 +0000 (14:39 +0200)]
collectd-nagios: Let '-n LIST' list all available datasets.

13 years agosrc/meta_data.c: Free a leaking mutex.
Rafal Lesniak [Fri, 13 May 2011 15:15:54 +0000 (17:15 +0200)]
src/meta_data.c: Free a leaking mutex.

This problem primarily manifested on FreeBSD but may well effect other
systems as well.

Thanks to Tomas Krasnican for reporting this problem.

Signed-off-by: Florian Forster <octo@collectd.org>
13 years agodf plugin: Improve error message.
Florian Forster [Mon, 9 May 2011 21:36:17 +0000 (23:36 +0200)]
df plugin: Improve error message.

13 years agocontrib/migrate-4-5.px: "df" does not have COUNTER DSTs.
Florian Forster [Wed, 27 Apr 2011 15:29:33 +0000 (17:29 +0200)]
contrib/migrate-4-5.px: "df" does not have COUNTER DSTs.

13 years agocontrib/migrate-4-5.px: Remove useless "OutDir" option.
Florian Forster [Sat, 23 Apr 2011 15:31:08 +0000 (08:31 -0700)]
contrib/migrate-4-5.px: Remove useless "OutDir" option.

13 years agoiptables plugin: Remove the shipped version of libiptc.
Florian Forster [Sun, 3 Apr 2011 16:17:26 +0000 (09:17 -0700)]
iptables plugin: Remove the shipped version of libiptc.

Since libiptc is now publicly available as a shared library, we don't really
have any need to ship it with collectd anymore.