Code

git.git
18 years agogit-write-tree writes garbage on sparc64
Dennis Stosberg [Sun, 28 May 2006 19:08:08 +0000 (21:08 +0200)]
git-write-tree writes garbage on sparc64

In the "next" branch, write_index_ext_header() writes garbage on a
64-bit big-endian machine; the written index file will be unreadable.
I noticed this on NetBSD/sparc64. Reproducible with:

$ git init-db
$ :>file
$ git-update-index --add file
$ git-write-tree
$ git-update-index
error: index uses  extension, which we do not understand
fatal: index file corrupt

Signed-off-by: Dennis Stosberg <dennis@stosberg.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix crash when reading the empty tree
Johannes Schindelin [Sun, 7 May 2006 15:42:37 +0000 (17:42 +0200)]
Fix crash when reading the empty tree

cvsimport needs to call git-read-tree without arguments to create an empty
tree.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agofsck-objects: do not segfault on missing tree in cache-tree
Junio C Hamano [Thu, 4 May 2006 04:17:45 +0000 (21:17 -0700)]
fsck-objects: do not segfault on missing tree in cache-tree

Even if trees are missing in cache-tree, we should continue and
check the rest of the object database.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocache-tree: a bit more debugging support.
Junio C Hamano [Wed, 3 May 2006 23:10:45 +0000 (16:10 -0700)]
cache-tree: a bit more debugging support.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoread-tree: invalidate cache-tree entry when a new index entry is added.
Junio C Hamano [Wed, 3 May 2006 23:07:02 +0000 (16:07 -0700)]
read-tree: invalidate cache-tree entry when a new index entry is added.

When doing two-way merge, we failed to invalidate the directory
that a new entry is added (we correctly did so for modified and
deleted entries).

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix test-dump-cache-tree in one-tree disappeared case.
Junio C Hamano [Wed, 3 May 2006 22:32:54 +0000 (15:32 -0700)]
Fix test-dump-cache-tree in one-tree disappeared case.

When reconstructing an invalidated subtree for reference purposes by
test-dump-cache-tree, we did not handle the case where we shouldn't
have a cached and invalidated subtree in the result, leading to an
unneeded die().

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agofsck-objects: mark objects reachable from cache-tree
Junio C Hamano [Tue, 2 May 2006 05:15:54 +0000 (22:15 -0700)]
fsck-objects: mark objects reachable from cache-tree

When fsck-objects scanned cache-tree, it forgot to mark the
trees it found reachable and in use.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocache-tree: replace a sscanf() by two strtol() calls
Johannes Schindelin [Tue, 2 May 2006 01:31:02 +0000 (03:31 +0200)]
cache-tree: replace a sscanf() by two strtol() calls

On one of my systems, sscanf() first calls strlen() on the buffer. But
this buffer is not terminated by NUL. So git crashed.

strtol() does not share that problem, as it stops reading after the
first non-digit.

[jc: original patch was wrong and did not read the cache-tree
 structure correctly; this has been fixed up and tested minimally
 with fsck-objects. ]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocache-tree.c: typefix
Junio C Hamano [Fri, 28 Apr 2006 05:48:27 +0000 (22:48 -0700)]
cache-tree.c: typefix

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotest-dump-cache-tree: validate the cached data as well.
Junio C Hamano [Thu, 27 Apr 2006 23:22:45 +0000 (16:22 -0700)]
test-dump-cache-tree: validate the cached data as well.

While dumping the cached data, try recomputing everything from
scratch to make sure things match.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocache_tree_update: give an option to update cache-tree only.
Junio C Hamano [Thu, 27 Apr 2006 23:21:54 +0000 (16:21 -0700)]
cache_tree_update: give an option to update cache-tree only.

When the extra "dryrun" parameter is true, cache_tree_update()
recomputes the invalid entry but does not actually creates
new tree object.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoread-tree: teach 1-way merege and plain read to prime cache-tree.
Junio C Hamano [Thu, 27 Apr 2006 08:33:07 +0000 (01:33 -0700)]
read-tree: teach 1-way merege and plain read to prime cache-tree.

This teaches read-tree to fully populate valid cache-tree when
reading a tree from scratch, or reading a single tree into an
existing index, reusing only the cached stat information (i.e.
one-way merge).  We have already taught update-index about cache-tree,
so "git checkout" followed by updates to a few path followed by
a "git commit" would become very efficient.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoread-tree: teach 1 and 2 way merges about cache-tree.
Junio C Hamano [Thu, 27 Apr 2006 07:13:34 +0000 (00:13 -0700)]
read-tree: teach 1 and 2 way merges about cache-tree.

This teaches one-way and two-way "read-tree -m" (and its special
form, "read-tree --reset" as well) not to discard cache-tree but
invalidate only the changed parts of the tree.  When switching
between related branches, this helps the eventual commit
(i.e. write-tree) by keeping cache-tree valid as much as
possible.

This does not prime cache-tree yet, but we ought to be able to
do that for no-merge (i.e. reading from a tree object) case and,
and also perhaps 1 way merge case.

With this patch applied, switching between the tip of Linux 2.6
kernel tree and a branch that touches one path (fs/ext3/Makefile)
from it invalidates only 3 paths out of 1201 cache-tree entries
in the index, and subsequent write-tree takes about a half as
much time as before.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoupdate-index: when --unresolve, smudge the relevant cache-tree entries.
Junio C Hamano [Thu, 27 Apr 2006 05:05:05 +0000 (22:05 -0700)]
update-index: when --unresolve, smudge the relevant cache-tree entries.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into jc/cache-tree
Junio C Hamano [Thu, 27 Apr 2006 01:32:45 +0000 (18:32 -0700)]
Merge branch 'master' into jc/cache-tree

* master:
  t0000-basic: more commit-tree tests.
  commit-tree.c: check_valid() microoptimization.
  Fix filename verification when in a subdirectory
  rebase: typofix.
  socksetup: don't return on set_reuse_addr() error

18 years agot0000-basic: more commit-tree tests.
Junio C Hamano [Thu, 27 Apr 2006 01:25:15 +0000 (18:25 -0700)]
t0000-basic: more commit-tree tests.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'fix'
Junio C Hamano [Thu, 27 Apr 2006 00:08:00 +0000 (17:08 -0700)]
Merge branch 'fix'

* fix:
  commit-tree.c: check_valid() microoptimization.
  Fix filename verification when in a subdirectory
  rebase: typofix.
  socksetup: don't return on set_reuse_addr() error

18 years agocommit-tree.c: check_valid() microoptimization.
Junio C Hamano [Wed, 26 Apr 2006 23:55:25 +0000 (16:55 -0700)]
commit-tree.c: check_valid() microoptimization.

There is no point reading the whole object just to make sure it exists and
it is of the expected type.  We added sha1_object_info() for such need
after this code was written, so use it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix filename verification when in a subdirectory
Linus Torvalds [Wed, 26 Apr 2006 17:15:54 +0000 (10:15 -0700)]
Fix filename verification when in a subdirectory

When we are in a subdirectory of a git archive, we need to take the prefix
of that subdirectory into accoung when we verify filename arguments.

Noted by Matthias Lederhofer

This also uses the improved error reporting for all the other git commands
that use the revision parsing interfaces, not just git-rev-parse. Also, it
makes the error reporting for mixed filenames and argument flags clearer
(you cannot put flags after the start of the pathname list).

[jc: with fix to a trivial typo noticed by Timo Hirvonen]

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agorebase: typofix.
Junio C Hamano [Wed, 26 Apr 2006 19:07:42 +0000 (12:07 -0700)]
rebase: typofix.

Noticed by Sean.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into jc/cache-tree
Junio C Hamano [Wed, 26 Apr 2006 10:29:09 +0000 (03:29 -0700)]
Merge branch 'master' into jc/cache-tree

* master:
  commit-tree: allow generic object name for the tree as well.
  Makefile: remove and create xdiff library from scratch.
  t0000-basic: Add ls-tree recursive test back.
  Libified diff-index: backward compatibility fix.
  Libify diff-index.
  Libify diff-files.
  Makefile: remove and create libgit.a from scratch.
  Document the configuration file
  Document git-var -l listing also configuration variables
  rev-parse: better error message for ambiguous arguments
  make update-index --chmod work with multiple files and --stdin
  socksetup: don't return on set_reuse_addr() error
  Fix "git show --stat"
  git-update-index --unresolve
  Add git-unresolve <paths>...
  Add colordiff for git to contrib/colordiff.
  gitk: Let git-rev-list do the argument list parsing

18 years agocommit-tree: allow generic object name for the tree as well.
Junio C Hamano [Wed, 26 Apr 2006 10:18:51 +0000 (03:18 -0700)]
commit-tree: allow generic object name for the tree as well.

We use get_sha1() for -p (parent) objects, but still used
get_sha1_hex() for the tree.  Just to be consistent, allow
extended SHA1 expression for the tree object name.

Note that this is not to encourage funky things like this:

git-commit-tree HEAD^{tree} -p HEAD

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMakefile: remove and create xdiff library from scratch.
Junio C Hamano [Wed, 26 Apr 2006 10:12:58 +0000 (03:12 -0700)]
Makefile: remove and create xdiff library from scratch.

... in the same spirit as 71459c193d04870076efa0a387c317390b53e3e2.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agot0000-basic: Add ls-tree recursive test back.
Junio C Hamano [Wed, 26 Apr 2006 09:27:59 +0000 (02:27 -0700)]
t0000-basic: Add ls-tree recursive test back.

When we updated ls-tree recursive output to omit the tree nodes,
246cc52f388cae8ca99e5a12b8458c9bfa467765 adjusted the old test
so that we do not expect to see trees in its output.  Later,
with 0f8f45cb4a7e664b396f73c25891da46b953b8b8, we added back the
ability to show both with -t option, but we forgot to update the
test as well.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/diff'
Junio C Hamano [Wed, 26 Apr 2006 06:12:21 +0000 (23:12 -0700)]
Merge branch 'jc/diff'

* jc/diff:
  Libified diff-index: backward compatibility fix.
  Libify diff-index.
  Libify diff-files.

18 years agoMakefile: remove and create libgit.a from scratch.
Junio C Hamano [Wed, 26 Apr 2006 06:11:17 +0000 (23:11 -0700)]
Makefile: remove and create libgit.a from scratch.

Foolishly I renamed diff.o around which caused an old diff.o
taken out of libgit.a and got linked into resulting binary and
exhibited mysterious breakage for many people.  This borrows
from the kernel Makefile (scripts/Makefile.build) to first remove
the target and then recreate.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotest-dump-cache-tree: report number of subtrees.
Junio C Hamano [Wed, 26 Apr 2006 00:40:24 +0000 (17:40 -0700)]
test-dump-cache-tree: report number of subtrees.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocache-tree: sort the subtree entries.
Junio C Hamano [Wed, 26 Apr 2006 00:40:02 +0000 (17:40 -0700)]
cache-tree: sort the subtree entries.

Not that this makes practical performance difference; the kernel tree
for example has 200 or so directories that have subdirectory, and the
largest ones have 57 of them (fs and drivers).  With a test to apply
600 patches with git-apply and git-write-tree, this did not make more
than one per-cent of a difference, but it is a good cleanup.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoTeach fsck-objects about cache-tree.
Junio C Hamano [Tue, 25 Apr 2006 23:37:08 +0000 (16:37 -0700)]
Teach fsck-objects about cache-tree.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosocksetup: don't return on set_reuse_addr() error v1.3.1
Serge E. Hallyn [Tue, 18 Apr 2006 13:11:06 +0000 (08:11 -0500)]
socksetup: don't return on set_reuse_addr() error

The set_reuse_addr() error case was the only error case in
socklist() where we returned rather than continued.  Not sure
why.  Either we must free the socklist, or continue.  This patch
continues on error.

Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
(cherry picked from 0032d548db56eac9ea09b4ba05843365f6325b85 commit)

18 years agoMerge branch 'fix'
Junio C Hamano [Tue, 25 Apr 2006 05:26:57 +0000 (22:26 -0700)]
Merge branch 'fix'

* fix:
  Document the configuration file
  Document git-var -l listing also configuration variables
  rev-parse: better error message for ambiguous arguments

18 years agoDocument the configuration file
Petr Baudis [Mon, 24 Apr 2006 22:59:33 +0000 (00:59 +0200)]
Document the configuration file

This patch adds a Documentation/config.txt file included by git-repo-config
and currently aggregating hopefully all the available git plumbing / core
porcelain configuration variables, as well as briefly describing the format.

It also updates an outdated bit of the example in git-repo-config(1).

Signed-off-by: Petr Baudis <pasky@suse.cz>
18 years agoDocument git-var -l listing also configuration variables
Petr Baudis [Mon, 24 Apr 2006 22:59:28 +0000 (00:59 +0200)]
Document git-var -l listing also configuration variables

Signed-off-by: Petr Baudis <pasky@suse.cz>
18 years agorev-parse: better error message for ambiguous arguments
Paul Mackerras [Tue, 25 Apr 2006 00:00:03 +0000 (10:00 +1000)]
rev-parse: better error message for ambiguous arguments

Currently, if git-rev-parse encounters an argument that is neither a
recognizable revision name nor the name of an existing file or
directory, and it hasn't encountered a "--" argument, it prints an
error message saying "No such file or directory".  This can be
confusing for users, including users of programs such as gitk that
use git-rev-parse, who may then think that they can't ask about the
history of files that no longer exist.

This makes it print a better error message, one that points out the
ambiguity and tells the user what to do to fix it.

Signed-off-by: Paul Mackerras <paulus@samba.org>
18 years agoindex: make the index file format extensible.
Junio C Hamano [Tue, 25 Apr 2006 04:18:58 +0000 (21:18 -0700)]
index: make the index file format extensible.

... and move the cache-tree data into it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocache-tree: protect against "git prune".
Junio C Hamano [Mon, 24 Apr 2006 22:12:42 +0000 (15:12 -0700)]
cache-tree: protect against "git prune".

We reused the cache-tree data without verifying the tree object
still exists.  Recompute in cache_tree_update() an otherwise
valid cache-tree entry when the tree object disappeared.

This is not usually a problem, but theoretically without this
fix things can break when the user does something like this:

- read-index from a side branch
- write-tree the result
- remove the side branch with "git branch -D"
- remove the unreachable objects with "git prune"
- write-tree what is in the index.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'ar/chmod-series'
Junio C Hamano [Mon, 24 Apr 2006 09:08:35 +0000 (02:08 -0700)]
Merge branch 'ar/chmod-series'

* ar/chmod-series:
  make update-index --chmod work with multiple files and --stdin

18 years agoMerge branch 'sh/daemon'
Junio C Hamano [Mon, 24 Apr 2006 09:08:28 +0000 (02:08 -0700)]
Merge branch 'sh/daemon'

* sh/daemon:
  socksetup: don't return on set_reuse_addr() error

18 years agoMerge branch 'jc/cc-stat'
Junio C Hamano [Mon, 24 Apr 2006 09:06:40 +0000 (02:06 -0700)]
Merge branch 'jc/cc-stat'

* jc/cc-stat:
  Fix "git show --stat"

18 years agoMerge branch 'jc/unresolve'
Junio C Hamano [Mon, 24 Apr 2006 09:05:55 +0000 (02:05 -0700)]
Merge branch 'jc/unresolve'

* jc/unresolve:
  git-update-index --unresolve
  Add git-unresolve <paths>...

18 years agoMerge branch 'jc/color'
Junio C Hamano [Mon, 24 Apr 2006 09:05:07 +0000 (02:05 -0700)]
Merge branch 'jc/color'

* jc/color:
  Add colordiff for git to contrib/colordiff.

18 years agoMerge git://git.kernel.org/pub/scm/gitk/gitk
Junio C Hamano [Mon, 24 Apr 2006 08:39:01 +0000 (01:39 -0700)]
Merge git://git.kernel.org/pub/scm/gitk/gitk

* git://git.kernel.org/pub/scm/gitk/gitk:
  gitk: Let git-rev-list do the argument list parsing

18 years agoAdd test-dump-cache-tree
Junio C Hamano [Mon, 24 Apr 2006 03:20:25 +0000 (20:20 -0700)]
Add test-dump-cache-tree

This was useful in diagnosing the corrupt index.aux format
problem.  But do not bother building or installing it by
default.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoUse cache-tree in update-index.
Junio C Hamano [Mon, 24 Apr 2006 07:23:54 +0000 (00:23 -0700)]
Use cache-tree in update-index.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoInvalidate cache-tree entries for touched paths in git-apply.
Junio C Hamano [Sun, 23 Apr 2006 23:52:52 +0000 (16:52 -0700)]
Invalidate cache-tree entries for touched paths in git-apply.

This updates git-apply to maintain cache-tree information.  With
this and the previous write-tree patch, repeated "apply --index"
followed by "write-tree" on a huge tree will hopefully become
faster.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoUpdate write-tree to use cache-tree.
Junio C Hamano [Sun, 23 Apr 2006 23:52:35 +0000 (16:52 -0700)]
Update write-tree to use cache-tree.

The updated write-tree reads from $GIT_DIR/index.aux to pick up
subtree objects information, updates the cache-tree with the
index, and updates index.aux file after writing a tree out of
the index file.

Until update-index and other programs that modify the index are
updated to maintain index.aux file, the index.aux file written
by the last write-tree will become stale immediately after they
update the index, which will result in the whole tree
recomputation just like the original write-tree.

The idea is to convert those commands to invalidate cache-tree
whenever they touch the index entries, and write updated
index.aux out.  After the index is updated with them, write-tree
will be able to reuse the parts of the cache-tree that have not
been touched.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAdd cache-tree.
Junio C Hamano [Sun, 23 Apr 2006 23:52:20 +0000 (16:52 -0700)]
Add cache-tree.

The cache_tree data structure is to cache tree object names that
would result from the current index file.

The idea is to have an optional file to record each tree object
name that corresponds to a directory path in the cache when we
run write_cache(), and read it back when we run read_cache().
During various index manupulations, we selectively invalidate
the parts so that the next write-tree can bypass regenerating
tree objects for unchanged parts of the directory hierarchy.

We could perhaps make the cache-tree data an optional part of
the index file, but that would involve the index format updates,
so unless we need it for performance reasons, the current plan
is to use a separate file, $GIT_DIR/index.aux to store this
information and link it with the index file with the checksum
that is already used for index file integrity check.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoread-cache/write-cache: optionally return cache checksum SHA1.
Junio C Hamano [Sun, 23 Apr 2006 23:52:08 +0000 (16:52 -0700)]
read-cache/write-cache: optionally return cache checksum SHA1.

read_cache_1() and write_cache_1() takes an extra parameter
*sha1 that returns the checksum of the index file when non-NULL.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogitk: Let git-rev-list do the argument list parsing
Paul Mackerras [Sun, 23 Apr 2006 08:00:24 +0000 (18:00 +1000)]
gitk: Let git-rev-list do the argument list parsing

This is a fix for a problem reported by Jim Radford where an argument
list somewhere overflows on repositories with lots of tags.  In fact
it's now unnecessary to use git-rev-parse since git-rev-list can take
all the arguments that git-rev-parse can.  This is inspired by but not
the same as the solutions suggested by Jim Radford and Linus Torvalds.

Signed-off-by: Paul Mackerras <paulus@samba.org>
18 years agomake update-index --chmod work with multiple files and --stdin
Alex Riesen [Sun, 23 Apr 2006 07:01:29 +0000 (09:01 +0200)]
make update-index --chmod work with multiple files and --stdin

The patch makes "--chmod=-x" and "--chmod=+x" act like "--add"
and "--remove" to affect the behaviour of the command for the
rest of the path parameters, not just the following one.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoLibified diff-index: backward compatibility fix.
Junio C Hamano [Sat, 22 Apr 2006 10:58:04 +0000 (03:58 -0700)]
Libified diff-index: backward compatibility fix.

"diff-index -m" does not mean "do not ignore merges", but means
"pretend missing files match the index".

The previous round tried to address this, but failed because
setup_revisions() ate "-m" flag before the caller had a chance
to intervene.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoLibify diff-index.
Junio C Hamano [Sat, 22 Apr 2006 09:43:00 +0000 (02:43 -0700)]
Libify diff-index.

The second installment to libify diff brothers.  The pathname
arguments are checked more strictly than before because we now
use the revision.c::setup_revisions() infrastructure.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoLibify diff-files.
Junio C Hamano [Sat, 22 Apr 2006 06:57:45 +0000 (23:57 -0700)]
Libify diff-files.

This is the first installment to libify diff brothers.

The updated diff-files uses revision.c::setup_revisions()
infrastructure to parse its command line arguments, which means
the pathname arguments are checked more strictly than before.
The tests are adjusted to separate possibly missing paths from
the rest of arguments with double-dashes, to show the kosher
way.

As Linus pointed out, renaming diff.c to diff-lib.c was simply
stupid, so I am renaming it back.  The new diff-lib.c is to
contain pieces extracted from diff brothers.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix "git show --stat"
Junio C Hamano [Sat, 22 Apr 2006 02:39:04 +0000 (19:39 -0700)]
Fix "git show --stat"

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAdd colordiff for git to contrib/colordiff.
Junio C Hamano [Wed, 12 Apr 2006 06:05:14 +0000 (23:05 -0700)]
Add colordiff for git to contrib/colordiff.

I hacked it up to teach it the git extended diff headers, made
it not to read the whole patch in the array.

Also, the original program, when arguments are given, ran "diff"
with the given arguments and showed the output from it.  Of
course, I changed it to run "git diff" ;-).

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/diff'
Junio C Hamano [Sat, 22 Apr 2006 05:03:07 +0000 (22:03 -0700)]
Merge branch 'jc/diff'

* jc/diff:
  diff --stat: do not drop rename information.

18 years agoMakefile: dependency for builtin-help.o
Junio C Hamano [Sat, 22 Apr 2006 04:56:13 +0000 (21:56 -0700)]
Makefile: dependency for builtin-help.o

builtin-help.c wants to include common-cmds.h which is a
generated file.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoSplit up builtin commands into separate files from git.c
Linus Torvalds [Fri, 21 Apr 2006 17:27:34 +0000 (10:27 -0700)]
Split up builtin commands into separate files from git.c

Right now it split it into "builtin-log.c" for log-related commands
("log", "show" and "whatchanged"), and "builtin-help.c" for the
informational commands (usage printing and "help" and "version").

This just makes things easier to read, I find.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'fix'
Junio C Hamano [Fri, 21 Apr 2006 20:14:30 +0000 (13:14 -0700)]
Merge branch 'fix'

* fix:
  git-log produces no output

18 years agogit-log produces no output
Linus Torvalds [Fri, 21 Apr 2006 19:25:13 +0000 (12:25 -0700)]
git-log produces no output

When $PAGER is set to 'less -i', we used to fail because we
assumed the $PAGER is a command and simply exec'ed it.

Try exec first, and then run it through shell if it fails.  This
allows even funkier PAGERs like these ;-):

PAGER='sed -e "s/^/`date`: /" | more'
PAGER='contrib/colordiff.perl | less -RS'

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'fix'
Junio C Hamano [Fri, 21 Apr 2006 07:45:40 +0000 (00:45 -0700)]
Merge branch 'fix'

* fix:
  fix pack-object buffer size
  mailinfo: decode underscore used in "Q" encoding properly.
  Reintroduce svn pools to solve the memory leak.
  pack-objects: do not stop at object that is "too small"

18 years agofix pack-object buffer size
Nicolas Pitre [Thu, 20 Apr 2006 21:25:37 +0000 (17:25 -0400)]
fix pack-object buffer size

The input line has 40 _chars_ of sha1 and no 20 _bytes_. It should also
account for the space before the pathname, and the terminating \n and \0.

Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agomailinfo: decode underscore used in "Q" encoding properly.
Junio C Hamano [Fri, 21 Apr 2006 07:06:58 +0000 (00:06 -0700)]
mailinfo: decode underscore used in "Q" encoding properly.

Quoted-Printable (RFC 2045) and the "Q" encoding (RFC 2047) are
subtly different; the latter is used on the mail header and an
underscore needs to be decoded to 0x20.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoReintroduce svn pools to solve the memory leak.
Santi_Béjar [Mon, 27 Mar 2006 11:26:01 +0000 (13:26 +0200)]
Reintroduce svn pools to solve the memory leak.

Introduced in 4802426.

Signed-off-by: Santi Béjar <sbejar@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agopack-objects: do not stop at object that is "too small"
Junio C Hamano [Fri, 21 Apr 2006 06:36:22 +0000 (23:36 -0700)]
pack-objects: do not stop at object that is "too small"

Because we sort the delta window by name-hash and then size,
hitting an object that is too small to consider as a delta base
for the current object does not mean we do not have better
candidate in the window beyond it.

Noticed by Shawn Pearce, analyzed by Nico, Linus and me.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'fix'
Junio C Hamano [Thu, 20 Apr 2006 09:52:04 +0000 (02:52 -0700)]
Merge branch 'fix'

* fix:
  git-commit --amend: two fixes.

18 years agogit-commit --amend: two fixes.
Junio C Hamano [Thu, 20 Apr 2006 08:20:56 +0000 (01:20 -0700)]
git-commit --amend: two fixes.

When running "git commit --amend" only to fix the commit log
message without any content change, we mistakenly showed the
git-status output that says "nothing to commit" without
commenting it out.

If you have already run update-index but you want to amend the
top commit, "git commit --amend --only" without any paths should
have worked, because --only means "starting from the base
commit, update-index these paths only to prepare the index to
commit, and perform the commit".  However, we refused -o without
paths.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-update-index --unresolve
Junio C Hamano [Thu, 20 Apr 2006 06:52:05 +0000 (23:52 -0700)]
git-update-index --unresolve

Retire git-unresolve and make it into "git-update-index --unresolve".
It processes all paths that follow.

During a merge, you would mark a path that is dealt with with:

$ git update-index hello

and you would "undo" it with:

$ git update-index --unresolve hello

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agodiff --stat: do not drop rename information.
Junio C Hamano [Thu, 20 Apr 2006 03:41:14 +0000 (20:41 -0700)]
diff --stat: do not drop rename information.

When a verbatim rename or copy is detected, we did not show
anything on the "diff --stat" for the filepair.  This makes it
to show the rename information.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAdd git-unresolve <paths>...
Junio C Hamano [Wed, 19 Apr 2006 19:51:29 +0000 (12:51 -0700)]
Add git-unresolve <paths>...

This is an attempt to address the issue raised on #git channel
recently by Carl Worth.

After a conflicted automerge, "git diff" shows a combined diff
to give you how the tentative automerge result differs from
what came from each branch.  During a complex merge, it is
tempting to be able to resolve a few paths at a time, mark
them "I've dealt with them" with git-update-index to unclutter
the next "git diff" output, and keep going.  However, when the
final result does not compile or otherwise found to be a
mismerge, the workflow to fix the mismerged paths suddenly
changes to "git diff HEAD -- path" (to get a diff from our
HEAD before merging) and "git diff MERGE_HEAD -- path" (to get
a diff from theirs), and it cannot show the combined anymore.

With git-unresolve <paths>..., the versions from our branch and
their branch for specified blobs are placed in stage #2 and
stage #3, without touching the working tree files.  This gives
you the combined diff back for easier review, along with
"diff --ours" and "diff --theirs".

One thing it does not do is to place the base in stage #1; this
means "diff --base" would behave differently between the run
immediately after a conflicted three-way merge, and the run
after an update-index by mistake followed by a git-unresolve.

We could theoretically run merge-base between HEAD and
MERGE_HEAD to find which tree to place in stage #1, but
reviewing "diff --base" is not that useful so....

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'lt/xsha1'
Junio C Hamano [Wed, 19 Apr 2006 22:57:45 +0000 (15:57 -0700)]
Merge branch 'lt/xsha1'

* lt/xsha1:
  get_tree_entry(): make it available from tree-walk
  sha1_name.c: no need to include diff.h; tree-walk.h will do.
  sha1_name.c: prepare to make get_tree_entry() reusable from others.
  get_sha1() shorthands for blob/tree objects

18 years agoMerge branch 'maint'
Junio C Hamano [Wed, 19 Apr 2006 22:41:55 +0000 (15:41 -0700)]
Merge branch 'maint'

* maint:
  pre-commit hook: complain about conflict markers.
  git-merge: a bit more readable user guidance.

18 years agodiff: move diff.c to diff-lib.c to make room.
Junio C Hamano [Wed, 19 Apr 2006 22:12:02 +0000 (15:12 -0700)]
diff: move diff.c to diff-lib.c to make room.

Now I am not doing any real "git-diff in C" yet, but this would
help before doing so.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agopre-commit hook: complain about conflict markers.
Junio C Hamano [Wed, 19 Apr 2006 21:58:24 +0000 (14:58 -0700)]
pre-commit hook: complain about conflict markers.

Several <<< or === or >>> characters at the beginning of a line
is very likely to be leftover conflict markers from a failed
automerge the user resolved incorrectly, so detect them.

As usual, this can be defeated with "git commit --no-verify" if
you really do want to have those files, just like changes that
introduce trailing whitespaces.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-merge: a bit more readable user guidance.
Junio C Hamano [Wed, 19 Apr 2006 21:54:27 +0000 (14:54 -0700)]
git-merge: a bit more readable user guidance.

We said "fix up by hand" after failed automerge, which was a big
"Huh?  Now what?".  Be a bit more explicit without being too
verbose. Suggested by Carl Worth.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoget_tree_entry(): make it available from tree-walk
Junio C Hamano [Wed, 19 Apr 2006 21:05:47 +0000 (14:05 -0700)]
get_tree_entry(): make it available from tree-walk

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosha1_name.c: no need to include diff.h; tree-walk.h will do.
Junio C Hamano [Wed, 19 Apr 2006 18:56:53 +0000 (11:56 -0700)]
sha1_name.c: no need to include diff.h; tree-walk.h will do.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosha1_name.c: prepare to make get_tree_entry() reusable from others.
Junio C Hamano [Wed, 19 Apr 2006 18:56:07 +0000 (11:56 -0700)]
sha1_name.c: prepare to make get_tree_entry() reusable from others.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit log: don't do merge diffs by default
Linus Torvalds [Wed, 19 Apr 2006 17:20:49 +0000 (10:20 -0700)]
git log: don't do merge diffs by default

I personally prefer "ignore_merges" to be on by default, because quite
often the merge diff is distracting and not interesting. That's true both
with "-p" and with "--stat" output.

If you want output from merges, you can trivially use the "-m", "-c" or
"--cc" flags to tell that you're interested in merges, which also tells
the diff generator what kind of diff to do (for --stat, any of the three
will do, of course, but they differ for plain patches or for
--patch-with-stat).

This trivial patch just removes the two lines that tells "git log" not to
ignore merges. It will still show the commit log message, of course, due
to the "always_show_header" part.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAllow "git repack" users to specify repacking window/depth
Linus Torvalds [Wed, 19 Apr 2006 17:05:12 +0000 (10:05 -0700)]
Allow "git repack" users to specify repacking window/depth

.. but don't even bother documenting it. I don't think any normal person
is supposed to ever really care, but it simplifies testing when you want
to use the "git repack" wrapper rather than forcing you to use the core
programs (which already do support the window/depth arguments, of course).

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'fix'
Junio C Hamano [Wed, 19 Apr 2006 09:25:29 +0000 (02:25 -0700)]
Merge branch 'fix'

* fix:
  Document git-clone --reference
  Fix filename scaling for binary files

18 years agoget_sha1() shorthands for blob/tree objects
Linus Torvalds [Tue, 18 Apr 2006 23:45:16 +0000 (16:45 -0700)]
get_sha1() shorthands for blob/tree objects

This is a fairly straightforward patch to allow "get_sha1()" to also have
shorthands for tree and blob objects.

The syntax is very simple and intuitive: you can specify a tree or a blob
by simply specifying <revision>:<path>, and get_sha1() will do the SHA1
lookup from the tree for you.

You can currently do it with "git ls-tree <rev> <path>" and parsing the
output, but that's actually pretty awkward.

With this, you can do something like

git cat-file blob v1.2.4:Makefile

to get the contents of "Makefile" at revision v1.2.4.

Now, this isn't necessarily something you really need all that often, but
the concept itself is actually pretty powerful. We could, for example,
allow things like

git diff v0.99.6:git-commit-script..v1.3.0:git-commit.sh

to see the difference between two arbitrary files in two arbitrary
revisions. To do that, the only thing we'd have to do is to make
git-diff-tree accept two blobs to diff, in addition to the two trees it
now expects.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix uninteresting tags in new revision parsing
Linus Torvalds [Wed, 19 Apr 2006 03:31:41 +0000 (20:31 -0700)]
Fix uninteresting tags in new revision parsing

When I unified the revision argument parsing, I introduced a simple bug
wrt tags that had been marked uninteresting. When it was preparing for the
revision walk, it would mark all the parent commits of an uninteresting
tag correctly uninteresting, but it would forget about the commit itself.

This means that when I just did my 2.6.17-rc2 release, and my scripts
generated the log for "v2.6.17-rc1..v2.6.17-rc2", everything was fine,
except the commit pointed to by 2.6.17-rc1 (which shouldn't have been
there) was included. Even though it should obviously have been marked as
being uninteresting.

Not a huge deal, and the fix is trivial.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoDocument git-clone --reference
Shawn Pearce [Wed, 19 Apr 2006 00:19:48 +0000 (20:19 -0400)]
Document git-clone --reference

The new --reference flag introduced to git-clone in
GIT 1.3.0 was not documented but is rather handy.
So document it.

Also corrected a minor issue with the documentation for the
-s flag; the info/alternates file name was spelled wrong.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix filename scaling for binary files
Jonas Fonseca [Tue, 18 Apr 2006 21:26:43 +0000 (23:26 +0200)]
Fix filename scaling for binary files

Set maximum filename length for binary files so that scaling won't be
triggered and result in invalid string access.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosocksetup: don't return on set_reuse_addr() error
Serge E. Hallyn [Tue, 18 Apr 2006 13:11:06 +0000 (08:11 -0500)]
socksetup: don't return on set_reuse_addr() error

The set_reuse_addr() error case was the only error case in
socklist() where we returned rather than continued.  Not sure
why.  Either we must free the socklist, or continue.  This patch
continues on error.

Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/pager-cat'
Junio C Hamano [Tue, 18 Apr 2006 20:57:22 +0000 (13:57 -0700)]
Merge branch 'jc/pager-cat'

* jc/pager-cat:
  Do not fork PAGER=cat

18 years agoMerge branch 'lt/logopt'
Junio C Hamano [Tue, 18 Apr 2006 20:56:36 +0000 (13:56 -0700)]
Merge branch 'lt/logopt'

* lt/logopt:
  Fix "git log --stat": make sure to set recursive with --stat.
  combine-diff: show diffstat with the first parent.
  git.c: LOGSIZE is unused after log printing cleanup.
  Log message printout cleanups (#3): fix --pretty=oneline
  Log message printout cleanups (#2)
  Log message printout cleanups
  rev-list --header: output format fix
  Fixes for option parsing
  log/whatchanged/show - log formatting cleanup.
  Simplify common default options setup for built-in log family.
  Tentative built-in "git show"
  Built-in git-whatchanged.
  rev-list option parser fix.
  Split init_revisions() out of setup_revisions()
  Fix up rev-list option parsing.
  Fix up default abbrev in setup_revisions() argument parser.
  Common option parsing for "git log --diff" and friends

18 years agoGIT 1.3.0 v1.3.0
Junio C Hamano [Tue, 18 Apr 2006 20:15:18 +0000 (13:15 -0700)]
GIT 1.3.0

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAdd git-annotate(1) and git-blame(1)
Jonas Fonseca [Mon, 6 Mar 2006 05:24:44 +0000 (06:24 +0100)]
Add git-annotate(1) and git-blame(1)

[jc: with entries in git.txt]

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix "git log --stat": make sure to set recursive with --stat.
Junio C Hamano [Tue, 18 Apr 2006 18:41:28 +0000 (11:41 -0700)]
Fix "git log --stat": make sure to set recursive with --stat.

Just like "patch" format always needs recursive, "diffstat"
format does not make sense without setting recursive.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agodiff --stat: make sure to set recursive.
Junio C Hamano [Tue, 18 Apr 2006 18:29:33 +0000 (11:29 -0700)]
diff --stat: make sure to set recursive.

Just like "patch" format always needs recursive, "diffstat"
format does not make sense without setting recursive.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-svnimport symlink support
Herbert Valerio Riedel [Mon, 17 Apr 2006 10:58:39 +0000 (06:58 -0400)]
git-svnimport symlink support

added svn:special symlink support for access methods other than
direct-http

Signed-off-by: Herbert Valerio Riedel <hvr@gnu.org>
Acked-by: Matthias Urlichs <smurf@smurf.noris.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocombine-diff: show diffstat with the first parent.
Junio C Hamano [Tue, 18 Apr 2006 05:53:03 +0000 (22:53 -0700)]
combine-diff: show diffstat with the first parent.

Asking for stat (either with --stat or --patch-with-stat) gives
you diffstat for the first parent, even under combine-diff.

While the combined patch is useful to highlight the complexity
and interaction of the parts touched by all branches when
reviewing a merge commit, diffstat is a tool to assess the
extent of damage the merge brings in, and showing stat with the
first parent is more sensible than clever per-parent diffstat.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit.c: LOGSIZE is unused after log printing cleanup.
Junio C Hamano [Tue, 18 Apr 2006 04:47:35 +0000 (21:47 -0700)]
git.c: LOGSIZE is unused after log printing cleanup.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoLog message printout cleanups (#3): fix --pretty=oneline
Linus Torvalds [Tue, 18 Apr 2006 00:43:40 +0000 (17:43 -0700)]
Log message printout cleanups (#3): fix --pretty=oneline

This option is very special, since pretty_print_commit() will _remove_
the newline at the end of it, so we want to have an extra separator
between the things.

I added a honking big comment this time, so that (a) I don't forget this
_again_ (I broke "oneline" several times during this printout cleanup),
and so that people can understand _why_ the code does what it does.

Now, arguably the alternate fix is to always have the '\n' at the end in
pretty-print-commit, but git-rev-list depends on the current behaviour
(but we could have git-rev-list remove it, whatever).

With the big comment, the code hopefully doesn't get broken again. And now
things like

git log --pretty=oneline --cc --patch-with-stat

works (even if that is admittedly a totally insane combination: if you
want the patch, having the "oneline" log format is just crazy, but hey,
it _works_. Even insane people are people).

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoLog message printout cleanups (#2)
Linus Torvalds [Mon, 17 Apr 2006 23:59:42 +0000 (16:59 -0700)]
Log message printout cleanups (#2)

Here's a further patch on top of the previous one with cosmetic
improvements (no "real" code changes, just trivial updates):

 - it gets the "---" before a diffstat right, including for the combined
   merge case. Righ now the logic is that we always use "---" when we have
   a diffstat, and an empty line otherwise. That's how I visually prefer
   it, but hey, it can be tweaked later.

 - I made "diff --cc/combined" add the "---/+++" header lines too. The
   thing won't be mistaken for a valid diff, since the "@@" lines have too
   many "@" characters (three or more), but it just makes it visually
   match a real diff, which at least to me makes a big difference in
   readability. Without them, it just looks very "wrong".

   I guess I should have taken the filename from each individual entry
   (and had one "---" file per parent), but I didn't even bother to try to
   see how that works, so this was the simple thing.

With this, doing a

git log --cc --patch-with-stat

looks quite readable, I think. The only nagging issue - as far as I'm
concerned - is that diffstats for merges are pretty questionable the way
they are done now. I suspect it would be better to just have the _first_
diffstat, and always make the merge diffstat be the one for "result
against first parent".

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agopacked_object_info_detail(): check for corrupt packfile.
Junio C Hamano [Tue, 18 Apr 2006 00:46:07 +0000 (17:46 -0700)]
packed_object_info_detail(): check for corrupt packfile.

Serge E. Hallyn noticed that we compute how many input bytes are
still left, but did not use it for sanity checking.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoLog message printout cleanups
Linus Torvalds [Mon, 17 Apr 2006 18:59:32 +0000 (11:59 -0700)]
Log message printout cleanups

On Sun, 16 Apr 2006, Junio C Hamano wrote:
>
> In the mid-term, I am hoping we can drop the generate_header()
> callchain _and_ the custom code that formats commit log in-core,
> found in cmd_log_wc().

Ok, this was nastier than expected, just because the dependencies between
the different log-printing stuff were absolutely _everywhere_, but here's
a patch that does exactly that.

The patch is not very easy to read, and the "--patch-with-stat" thing is
still broken (it does not call the "show_log()" thing properly for
merges). That's not a new bug. In the new world order it _should_ do
something like

if (rev->logopt)
show_log(rev, rev->logopt, "---\n");

but it doesn't. I haven't looked at the --with-stat logic, so I left it
alone.

That said, this patch removes more lines than it adds, and in particular,
the "cmd_log_wc()" loop is now a very clean:

while ((commit = get_revision(rev)) != NULL) {
log_tree_commit(rev, commit);
free(commit->buffer);
commit->buffer = NULL;
}

so it doesn't get much prettier than this. All the complexity is entirely
hidden in log-tree.c, and any code that needs to flush the log literally
just needs to do the "if (rev->logopt) show_log(...)" incantation.

I had to make the combined_diff() logic take a "struct rev_info" instead
of just a "struct diff_options", but that part is pretty clean.

This does change "git whatchanged" from using "diff-tree" as the commit
descriptor to "commit", and I changed one of the tests to reflect that new
reality. Otherwise everything still passes, and my other tests look fine
too.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocleanups: remove unused variable from exec_cmd.c
Serge E. Hallyn [Mon, 17 Apr 2006 15:14:48 +0000 (10:14 -0500)]
cleanups: remove unused variable from exec_cmd.c

Not sure whether it should be removed, or whether
execv_git_cmd() should return it rather than -1 at bottom.

Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>