12 years agoremove perl 5.004 compatibility hack and make things work on newer perls in exchange :-)
remove perl 5.004 compatibility hack and make things work on newer perls in exchange :-)
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2258 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2258 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix libwrap and libdbi detection logic
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2254 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2254 a5681a0c-68f1-0310-ab6d-d61299d08faa
addeded documentation for json
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2253 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2253 a5681a0c-68f1-0310-ab6d-d61299d08faa
rrdtool is assuming that rrd_xport will always return -1 on failure;
however, rrd_xport returns errno (which is, generally, not -1) if
rrd_client fails. I figured it was easier to change rrdtool than to change
everything in rrd_client. For good measure, I also changed the checks on
the calls to rrd_fetch and rrd_graph. I'm not sure if they're susceptible
to the same problem, but, well, better to check for the one thing you do
what you want than to enumerate all the possible things you don't want.
This segfault is caused by an uninitialized variable use (in particular,
legend_v and col_cnt end up being used and passed to printf uninitialized).
Nothing offhand jumped out at me as easily-exploitable to do code
injection, but I only spent five or so minutes looking at it, so there very
well may be a security problem hiding behind this. -- James Brown <jbrown@yelp.com>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2251 a5681a0c-68f1-0310-ab6d-d61299d08faa
however, rrd_xport returns errno (which is, generally, not -1) if
rrd_client fails. I figured it was easier to change rrdtool than to change
everything in rrd_client. For good measure, I also changed the checks on
the calls to rrd_fetch and rrd_graph. I'm not sure if they're susceptible
to the same problem, but, well, better to check for the one thing you do
what you want than to enumerate all the possible things you don't want.
This segfault is caused by an uninitialized variable use (in particular,
legend_v and col_cnt end up being used and passed to printf uninitialized).
Nothing offhand jumped out at me as easily-exploitable to do code
injection, but I only spent five or so minutes looking at it, so there very
well may be a security problem hiding behind this. -- James Brown <jbrown@yelp.com>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2251 a5681a0c-68f1-0310-ab6d-d61299d08faa
12 years agointegrated json support in rrdtool xport with inspiration from Erik Kastner and Micha...
integrated json support in rrdtool xport with inspiration from Erik Kastner and Michael Markstaller -- Tobi
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2250 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2250 a5681a0c-68f1-0310-ab6d-d61299d08faa
be more careful when finding pic flags
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2247 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2247 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix horyzontal alignement of lines and aread
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2245 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2245 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix grid fitting for corner cases
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2243 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2243 a5681a0c-68f1-0310-ab6d-d61299d08faa
use standard functions for checking
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2241 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2241 a5681a0c-68f1-0310-ab6d-d61299d08faa
search for tcpd.h with <>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2240 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2240 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix win32 distributables
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2239 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2239 a5681a0c-68f1-0310-ab6d-d61299d08faa
merged updated win32 port by Larry Adams and the cacti team
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2236 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2236 a5681a0c-68f1-0310-ab6d-d61299d08faa
fixed some reference errors
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2234 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2234 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix rpn example
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2233 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2233 a5681a0c-68f1-0310-ab6d-d61299d08faa
rpn compare operators CAN return unknown ... (#293)
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2232 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2232 a5681a0c-68f1-0310-ab6d-d61299d08faa
gettext 0.17 is sufficient too and more widely used than 0.18 ...
-- Bernard Li <bernard@vanhpc.org>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2231 a5681a0c-68f1-0310-ab6d-d61299d08faa
-- Bernard Li <bernard@vanhpc.org>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2231 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix some issues with the
spec file, specifically:
- Reset Release to 1
- Add -lua subpackage
- Fix -perl subpackage so it includes the correct Perl package paths
The version should probably be updated to 1.5.0 (for trunk), or we
could just grab that from configure.ac.
Tested building on EL5 and EL6 (beta).
It would be great if this could also be backported to the 1.4 tree.
-- Bernard Li <bernard@vanhpc.org>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2230 a5681a0c-68f1-0310-ab6d-d61299d08faa
spec file, specifically:
- Reset Release to 1
- Add -lua subpackage
- Fix -perl subpackage so it includes the correct Perl package paths
The version should probably be updated to 1.5.0 (for trunk), or we
could just grab that from configure.ac.
Tested building on EL5 and EL6 (beta).
It would be great if this could also be backported to the 1.4 tree.
-- Bernard Li <bernard@vanhpc.org>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2230 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix typo in configure.ac (regression from r2227) fix for #324
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2229 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2229 a5681a0c-68f1-0310-ab6d-d61299d08faa
12 years agoIt seems that function graph_size_location() doesn't call xtr(im, 0) if (im->extra_fl...
It seems that function graph_size_location() doesn't call xtr(im, 0) if (im->extra_flags & ONLY_GRAPH) != 0. Therefore, static variable pixie in function xtr() remains uninitialized (fix for #322). -- u00mp yandex.ru
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2228 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2228 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix glib dependency for --disable-rrd_graph and update library versions (fix for #323)
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2227 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2227 a5681a0c-68f1-0310-ab6d-d61299d08faa
call this 1.4.999
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2226 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2226 a5681a0c-68f1-0310-ab6d-d61299d08faa
13 years agoinitialize magfact to 1 ... fixes logarithm chart display issues (patch from Christop...
initialize magfact to 1 ... fixes logarithm chart display issues (patch from Christoph Biedl) #296
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2225 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2225 a5681a0c-68f1-0310-ab6d-d61299d08faa
updates to the win32 port -- Chris Larsen
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2223 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2223 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix some string marshaling bugs in the Dot Net binding -- Chris Larsen
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2222 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2222 a5681a0c-68f1-0310-ab6d-d61299d08faa
after fetching, data must be reduced to at least chart resolution, else some data will not get plotted. fix for #298
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2221 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2221 a5681a0c-68f1-0310-ab6d-d61299d08faa
properly handle the case where RRDCACHED_ADDRESS is an empty string
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2220 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2220 a5681a0c-68f1-0310-ab6d-d61299d08faa
13 years agothe number of COMPUTE rpn nodes is architecture dependent. calculate the right number...
the number of COMPUTE rpn nodes is architecture dependent. calculate the right number and complain otherwise. Fix for #300.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2219 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2219 a5681a0c-68f1-0310-ab6d-d61299d08faa
make rrd_mkdir_p work on bsd* unixes too ... their dirname call works differently ... #305
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2217 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2217 a5681a0c-68f1-0310-ab6d-d61299d08faa
use long int format
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2216 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2216 a5681a0c-68f1-0310-ab6d-d61299d08faa
a new command-line parameter, --week-fmt, by which I can translate the word "week" in the graphs. -- Martin Volf
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2215 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2215 a5681a0c-68f1-0310-ab6d-d61299d08faa
allow to restore xml files with zero row rras ... this is a degenerated case
that does not occure in the wild, as rrdtool prevents the creation of such
rrd files. But rrdtool restore 1.3 did allows to create them via restore.
Now this is possible again. Fix for #310.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2212 a5681a0c-68f1-0310-ab6d-d61299d08faa
that does not occure in the wild, as rrdtool prevents the creation of such
rrd files. But rrdtool restore 1.3 did allows to create them via restore.
Now this is possible again. Fix for #310.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2212 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix ifdef use
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2211 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2211 a5681a0c-68f1-0310-ab6d-d61299d08faa
the first TREND* value can be calculated earlier ... -- fredrick (fix for #312)
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2210 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2210 a5681a0c-68f1-0310-ab6d-d61299d08faa
actually link with LIBINTL if we got it ... should make solaris happy
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2209 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2209 a5681a0c-68f1-0310-ab6d-d61299d08faa
13 years agodbi_result_get_datetime_idx() return timestamp in UTC, but time axis on graph suppose...
dbi_result_get_datetime_idx() return timestamp in UTC, but time axis on graph supposed to be in local time.
fix provided in #321
--This line, and those below, will be ignored--
M trunk/program/src/rrd_fetch_libdbi.c
M branches/1.4/program/src/rrd_fetch_libdbi.c
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2208 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix provided in #321
--This line, and those below, will be ignored--
M trunk/program/src/rrd_fetch_libdbi.c
M branches/1.4/program/src/rrd_fetch_libdbi.c
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2208 a5681a0c-68f1-0310-ab6d-d61299d08faa
allow rrdtool for windows to properly support binary mode stdout/stdin -- Larry Adams
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2207 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2207 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix ruby binding for rrd_xport #318
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2206 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2206 a5681a0c-68f1-0310-ab6d-d61299d08faa
free step_list on error. fix for #317
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2204 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2204 a5681a0c-68f1-0310-ab6d-d61299d08faa
improved library handling
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2203 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2203 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix buffer overflow for LONG lines in journal handling code for update requests.
fix for #316
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2202 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix for #316
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2202 a5681a0c-68f1-0310-ab6d-d61299d08faa
handling of ENV_RRDCACHED_ADDRESS:
added missing brackets after if, backported fix from trunk to 1.4 while doing it
-- patch by x @ zamyteam.org
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2199 a5681a0c-68f1-0310-ab6d-d61299d08faa
added missing brackets after if, backported fix from trunk to 1.4 while doing it
-- patch by x @ zamyteam.org
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2199 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix alignment of centered items ... title and footer
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2197 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2197 a5681a0c-68f1-0310-ab6d-d61299d08faa
flip colors
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2195 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2195 a5681a0c-68f1-0310-ab6d-d61299d08faa
white on black
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2193 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2193 a5681a0c-68f1-0310-ab6d-d61299d08faa
proper fix for the header size problem and its effects on rrd_resize
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2192 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2192 a5681a0c-68f1-0310-ab6d-d61299d08faa
fox for #302. refuse to build if troff and nroff are not around
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2188 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2188 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix for #301: plug memory leak in lua bindings -- bmayland @ leoninedev.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2187 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2187 a5681a0c-68f1-0310-ab6d-d61299d08faa
Fix for #304: checking for time_t is done with AC_RUN_IFELSE which fails when cross-compiling. The size of time_t can be detected with AC_CHECK_SIZEOF. -- Michael Olbrich
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2186 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2186 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix rrd_create behaviour when mmaping on a full filesystem by actually 'filling' the file with
zero. -- Francois-Xavier Bourlet francois-xavier.bourlet dotcloud.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2181 a5681a0c-68f1-0310-ab6d-d61299d08faa
zero. -- Francois-Xavier Bourlet francois-xavier.bourlet dotcloud.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2181 a5681a0c-68f1-0310-ab6d-d61299d08faa
with libwrap use 'rrdcached' as the name of our daemon and not just rrdcache
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2180 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2180 a5681a0c-68f1-0310-ab6d-d61299d08faa
bring spaceing around graph back in line with 1.2 goodness ... in connection with no-legend and no title
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2179 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2179 a5681a0c-68f1-0310-ab6d-d61299d08faa
13 years agoeven with libdbi enabled, do not mistake "sqlxxabc.rrd" for an sql url -- Peter Stamfest
even with libdbi enabled, do not mistake "sqlxxabc.rrd" for an sql url -- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2176 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2176 a5681a0c-68f1-0310-ab6d-d61299d08faa
as rrd_cgi fails to parse stuff, do NOT try to fix up the mess ... it is bound to fail
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2174 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2174 a5681a0c-68f1-0310-ab6d-d61299d08faa
update timestamp continuity checks in rrd_cached ... allow sub-second precision
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2173 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2173 a5681a0c-68f1-0310-ab6d-d61299d08faa
13 years agoAdded configure option to disable building rrd_graph: --disable-rrd_graph. With suppo...
Added configure option to disable building rrd_graph: --disable-rrd_graph. With support from Ulf Zimmermann (OpenLane)
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2172 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2172 a5681a0c-68f1-0310-ab6d-d61299d08faa
added explanation on the rows returned from fetch. fix for #291.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2170 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2170 a5681a0c-68f1-0310-ab6d-d61299d08faa
make sure we do not free stuff in rrdnew which was simply copied from rrdold and thus gets freed there already ...
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2169 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2169 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix wording regarding min/max setting
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2167 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2167 a5681a0c-68f1-0310-ab6d-d61299d08faa
do not close the filehandle to the resize file of there was a problem getting it in the first place.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2166 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2166 a5681a0c-68f1-0310-ab6d-d61299d08faa
it there is no right label, do not reserve any space for it
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2160 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2160 a5681a0c-68f1-0310-ab6d-d61299d08faa
make configure recognize tcl-site argument (#281)
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2159 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2159 a5681a0c-68f1-0310-ab6d-d61299d08faa
add some extra checks to RRA arguments
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2158 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2158 a5681a0c-68f1-0310-ab6d-d61299d08faa
make MAP_PRIVATE conditional on AIX not being defined ... should fix part of #216
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2157 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2157 a5681a0c-68f1-0310-ab6d-d61299d08faa
The buffer length for command buffers should be controlled by a single
#define. Renamed CMD_MAX to RRD_CMD_MAX and put into rrd_client.h
so that it is available to clients as well. -- kevin brintnall
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2156 a5681a0c-68f1-0310-ab6d-d61299d08faa
#define. Renamed CMD_MAX to RRD_CMD_MAX and put into rrd_client.h
so that it is available to clients as well. -- kevin brintnall
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2156 a5681a0c-68f1-0310-ab6d-d61299d08faa
1) Sigma calculation had an error. The first data value in each bin didn't get squared.
2) "rrdfillmissing" was dummy. I have added code to do the work. The parameter has NOW to be in seconds. In doc it is
given in steps. The size of steps depends to much on size of graph so I think its easier to use seconds and internal
calculate the number of steps.
by Hans Jørgen Jakobsen
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2155 a5681a0c-68f1-0310-ab6d-d61299d08faa
2) "rrdfillmissing" was dummy. I have added code to do the work. The parameter has NOW to be in seconds. In doc it is
given in steps. The size of steps depends to much on size of graph so I think its easier to use seconds and internal
calculate the number of steps.
by Hans Jørgen Jakobsen
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2155 a5681a0c-68f1-0310-ab6d-d61299d08faa
handle the case where the realpath of the suggested journaldir does not exist. Patch by Alex Bennee and Tobi Oetiker
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2153 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2153 a5681a0c-68f1-0310-ab6d-d61299d08faa
rrdcached: Fix permissions of the default socket.
If neither the "-l" nor the "-P" options have been given, a UNIX domain
socket at a default location is created. However, due to a missing
initialization in this case, the "permissions" field will be left at
zero (no command allowed).
This patch fixes this problem by allowing all commands on the default
socket if no "-P" option is given. -- Florian Forster
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2152 a5681a0c-68f1-0310-ab6d-d61299d08faa
If neither the "-l" nor the "-P" options have been given, a UNIX domain
socket at a default location is created. However, due to a missing
initialization in this case, the "permissions" field will be left at
zero (no command allowed).
This patch fixes this problem by allowing all commands on the default
socket if no "-P" option is given. -- Florian Forster
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2152 a5681a0c-68f1-0310-ab6d-d61299d08faa
13 years agoadd extra space to LDFLAGS when building ruby bindings ... otherwhise this will break...
add extra space to LDFLAGS when building ruby bindings ... otherwhise this will break if there is already content in LDFLAGS ... fix for #284 thanks dam at opencsw.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2151 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2151 a5681a0c-68f1-0310-ab6d-d61299d08faa
the aix linker does not have -Wl flag
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2149 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2149 a5681a0c-68f1-0310-ab6d-d61299d08faa
added not on using LINE AREA or PRINT
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2148 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2148 a5681a0c-68f1-0310-ab6d-d61299d08faa
introduce "epoch" as a new base time reference, meaning timestamp 0.
This disambiguates between some "at-style" time specs:
11111111 yields an error message:
did you really mean month 1111111?
and
19711205 denotes Dec 12, 1971 and not the timestamp.
The patch allows to write:
epoch+11111111s or epoch+19711205s
-- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2147 a5681a0c-68f1-0310-ab6d-d61299d08faa
This disambiguates between some "at-style" time specs:
11111111 yields an error message:
did you really mean month 1111111?
and
19711205 denotes Dec 12, 1971 and not the timestamp.
The patch allows to write:
epoch+11111111s or epoch+19711205s
-- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2147 a5681a0c-68f1-0310-ab6d-d61299d08faa
Here is a patch that fixes a serious endless loop problem on 32 bit
architectures near the timestamp 2^31 (oh yes - y2k038 is showing its ugly
face) when using the graph command(s). Once the endtime of a graph is
above the mentioned timestamp, mktime always returns -1 (and correctly
so), causing some loops to loop forever. The patch fixes this, causing
some strange output, but there is no other sane way to handle this (expect
by switching to a 64 bit platform). -- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2146 a5681a0c-68f1-0310-ab6d-d61299d08faa
architectures near the timestamp 2^31 (oh yes - y2k038 is showing its ugly
face) when using the graph command(s). Once the endtime of a graph is
above the mentioned timestamp, mktime always returns -1 (and correctly
so), causing some loops to loop forever. The patch fixes this, causing
some strange output, but there is no other sane way to handle this (expect
by switching to a 64 bit platform). -- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2146 a5681a0c-68f1-0310-ab6d-d61299d08faa
add hosts_access support to rrdcached -- Shaun Reitan mailinglists@unix-scripts.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2145 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2145 a5681a0c-68f1-0310-ab6d-d61299d08faa
tune the command
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2143 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2143 a5681a0c-68f1-0310-ab6d-d61299d08faa
make sure we do not try to draw points all that far outside the drawing area
since some versions of cairo seem to go unstable when this happens. -- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2142 a5681a0c-68f1-0310-ab6d-d61299d08faa
since some versions of cairo seem to go unstable when this happens. -- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2142 a5681a0c-68f1-0310-ab6d-d61299d08faa
rrdcached uses tcp and not udp thanks Shaun for finding this
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2141 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2141 a5681a0c-68f1-0310-ab6d-d61299d08faa
follow the normal code path for exiting rrd_update if there is a problem with rrdc, plugging a memory leak on the way -- Christian Magnusson
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2139 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2139 a5681a0c-68f1-0310-ab6d-d61299d08faa
free addrinfo list after use ... -- Christian Magnusson
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2138 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2138 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix for the memory leak in info fixes the memory leak in "INFO".
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2137 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2137 a5681a0c-68f1-0310-ab6d-d61299d08faa
* introduce a new rrd_create_r2 call to fix the no-overwrite api mess
* various fixes to new rrd_cached comands as suggested by kevin
1. Remove opt_no_overwrite and the rrd_create_set_no_overwrite function as they are ugly. Make opt_no_overwrite a local var.
2. Add 'no_overwrite' param to the rrd_create_r and rename as rrd_create_r2, add rrd_create_r that calls rrd_create_r2 with a 0 for the no_overwrite function, preserving the API parameter format but allowing an extended arg list that can be used by rrd_create and rrd_handle_request_create
3. Add -O option to rrdcached command line to force no-overwrite on any creates
4. Add -O option on create via rrdcached to optionally add no-overwrite (cannot remove it is it was previously set at start)
5. Fix rrd_handle_request_last to check the queue instead of forcing a flush. Remove -no-flush option from LAST command since it is now no longer relevant as we're querying the cache chain
6. Fix ulong/unsigned long issue for compilation under windows
7. Change rrd_handle_request_create to only accept timestamp parameters, not at-syntax, in order to be threadsafe. This is no loss since the rrd_client already pre-parses any at-style syntax
8. Reinstate missing free() in rrd_info.c and rrd_last.c
-- steve shipway
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2136 a5681a0c-68f1-0310-ab6d-d61299d08faa
* various fixes to new rrd_cached comands as suggested by kevin
1. Remove opt_no_overwrite and the rrd_create_set_no_overwrite function as they are ugly. Make opt_no_overwrite a local var.
2. Add 'no_overwrite' param to the rrd_create_r and rename as rrd_create_r2, add rrd_create_r that calls rrd_create_r2 with a 0 for the no_overwrite function, preserving the API parameter format but allowing an extended arg list that can be used by rrd_create and rrd_handle_request_create
3. Add -O option to rrdcached command line to force no-overwrite on any creates
4. Add -O option on create via rrdcached to optionally add no-overwrite (cannot remove it is it was previously set at start)
5. Fix rrd_handle_request_last to check the queue instead of forcing a flush. Remove -no-flush option from LAST command since it is now no longer relevant as we're querying the cache chain
6. Fix ulong/unsigned long issue for compilation under windows
7. Change rrd_handle_request_create to only accept timestamp parameters, not at-syntax, in order to be threadsafe. This is no loss since the rrd_client already pre-parses any at-style syntax
8. Reinstate missing free() in rrd_info.c and rrd_last.c
-- steve shipway
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2136 a5681a0c-68f1-0310-ab6d-d61299d08faa
Ensure that response_read() always calls fflush() or fclose().
This fixes defect #278 (unknown commands from Solaris client). -- kevin brintnall
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2135 a5681a0c-68f1-0310-ab6d-d61299d08faa
This fixes defect #278 (unknown commands from Solaris client). -- kevin brintnall
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2135 a5681a0c-68f1-0310-ab6d-d61299d08faa
ready for publication
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2133 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2133 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix ruby bindings to be compatible with curent ruby implementations fix for #279
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2132 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2132 a5681a0c-68f1-0310-ab6d-d61299d08faa
Summary of changes:
1. Add INFO <filename>, FIRST <filename> <index>, LAST <filename> and
CREATE <rrdfile> [-b start][-s step][-O] <DSdefs> <RRAdefs> to the rrdcached
functions.
2. Add rrd_create_set_no_overwrite as a function in rrd_create.c to allow
the overwrite flag to be set from rrd_daemon.c
3. Add rrdc_info, rrdc_first, rrdc_last, rrdc_create functions in
rrd_client.c
4. Add rrdcached support to rrd_info(), rrd_first(), rrd_last() and
rrd_create()
5. Add --noflush (-F) option to rrd_info(), rrd_last() to prevent cache
flushing before function call if required for efficiency
6. Add --daemon option to rrd_info(), rrd_first() for rrdcached support
7. Add buffer_add_ulong function to rrd_client.c (used by new rrdc_*
functions)
8. Add rrd_clear_error() call to rrd_create_r () to clean up bug if create
called more than once
9. Add -O option to rrdcached to force no-overwrite mode in CREATE function
10. All relevant documentation updated
-- Steve Shipway steve steveshipway.org
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2130 a5681a0c-68f1-0310-ab6d-d61299d08faa
1. Add INFO <filename>, FIRST <filename> <index>, LAST <filename> and
CREATE <rrdfile> [-b start][-s step][-O] <DSdefs> <RRAdefs> to the rrdcached
functions.
2. Add rrd_create_set_no_overwrite as a function in rrd_create.c to allow
the overwrite flag to be set from rrd_daemon.c
3. Add rrdc_info, rrdc_first, rrdc_last, rrdc_create functions in
rrd_client.c
4. Add rrdcached support to rrd_info(), rrd_first(), rrd_last() and
rrd_create()
5. Add --noflush (-F) option to rrd_info(), rrd_last() to prevent cache
flushing before function call if required for efficiency
6. Add --daemon option to rrd_info(), rrd_first() for rrdcached support
7. Add buffer_add_ulong function to rrd_client.c (used by new rrdc_*
functions)
8. Add rrd_clear_error() call to rrd_create_r () to clean up bug if create
called more than once
9. Add -O option to rrdcached to force no-overwrite mode in CREATE function
10. All relevant documentation updated
-- Steve Shipway steve steveshipway.org
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2130 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix use of %s in strftime rrdgraph (G)PRINT commands ... bug (#277) found by Denis, fix by tobi
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2129 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2129 a5681a0c-68f1-0310-ab6d-d61299d08faa
it seems that strcasecmp and strcasencmp have issues on windows replace
with stricmp and strnicmp -- jkane mail.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2128 a5681a0c-68f1-0310-ab6d-d61299d08faa
with stricmp and strnicmp -- jkane mail.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2128 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix use of setlocale all over the place ...
- old_locale = setlocale(LC_NUMERIC, "C");
+ old_locale = setlocale(LC_NUMERIC, NULL);
+ setlocale(LC_NUMERIC, "C");
the original version never restored the locale since it held a copy of the
new locale and not the old one despite the name. bug found by Pawe? 'Reef' Polewicz
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2127 a5681a0c-68f1-0310-ab6d-d61299d08faa
- old_locale = setlocale(LC_NUMERIC, "C");
+ old_locale = setlocale(LC_NUMERIC, NULL);
+ setlocale(LC_NUMERIC, "C");
the original version never restored the locale since it held a copy of the
new locale and not the old one despite the name. bug found by Pawe? 'Reef' Polewicz
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2127 a5681a0c-68f1-0310-ab6d-d61299d08faa
fix MSVC2008 compilation ... it does not understand char *const *argv iin rrd_getopt
-- jkane mail.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2124 a5681a0c-68f1-0310-ab6d-d61299d08faa
-- jkane mail.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2124 a5681a0c-68f1-0310-ab6d-d61299d08faa
make sure an extra %s in the secondi axis format does not kill us
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2123 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2123 a5681a0c-68f1-0310-ab6d-d61299d08faa
its filename not filtname
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2121 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2121 a5681a0c-68f1-0310-ab6d-d61299d08faa
document version variable
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2120 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2120 a5681a0c-68f1-0310-ab6d-d61299d08faa
in remote mode, make argument count for remote commmands strict as suggested by Dave Peticolas
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2119 a5681a0c-68f1-0310-ab6d-d61299d08faa
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2119 a5681a0c-68f1-0310-ab6d-d61299d08faa
14 years agoFirst bug: in function rrd_fetch_fn_libdbi() variable 'struct sql_table_helper table_...
First bug: in function rrd_fetch_fn_libdbi() variable 'struct sql_table_helper table_help'
field 'filename' is uninitialized. So, if a sql error happens, it does not print an error like this
rrd_set_error( "libdbi: problems connecting to db with connect string %s - error: %s",th->filename,dbi_errstr);
instead of, it dumps core.
Second bug: when the output data buffer is allocated, it allocated for 'rows-1' max index, but in
'fetch loop' 'idx' may be equal to 'rows', so it needs one more extra record in data.
-- Pavel Nikiforov pavel artx.ru
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2118 a5681a0c-68f1-0310-ab6d-d61299d08faa
field 'filename' is uninitialized. So, if a sql error happens, it does not print an error like this
rrd_set_error( "libdbi: problems connecting to db with connect string %s - error: %s",th->filename,dbi_errstr);
instead of, it dumps core.
Second bug: when the output data buffer is allocated, it allocated for 'rows-1' max index, but in
'fetch loop' 'idx' may be equal to 'rows', so it needs one more extra record in data.
-- Pavel Nikiforov pavel artx.ru
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk@2118 a5681a0c-68f1-0310-ab6d-d61299d08faa