Code

collectd.git
16 years agoCollectd.pm: Fixed the check for complete function names in plugin_register.
Sebastian Harl [Sun, 20 Apr 2008 21:21:50 +0000 (23:21 +0200)]
Collectd.pm: Fixed the check for complete function names in plugin_register.

plugin_register() checks if the registered function includes the plugin's
package name. Up to now, this check would also have succeeded if the
function name itself would be prepended by the package name. Now, the
check looks for the separator "::".

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 30 Apr 2008 08:26:28 +0000 (10:26 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoMoved <statgrab.h> out of "collectd.h" and into the plugins that actually use the...
Florian Forster [Wed, 30 Apr 2008 08:25:15 +0000 (10:25 +0200)]
Moved <statgrab.h> out of "collectd.h" and into the plugins that actually use the library.

The libstatgrab specific CFLAGS are only passed to these plugins, so that other
plugins may fail if libstatgrab is in a non-standard path.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 30 Apr 2008 06:18:21 +0000 (08:18 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoMerge branch 'collectd-4.2' of /var/lib/git/collectd into collectd-4.2
Florian Forster [Wed, 30 Apr 2008 06:18:08 +0000 (08:18 +0200)]
Merge branch 'collectd-4.2' of /var/lib/git/collectd into collectd-4.2

16 years agobuild system: Fix another bug in the detection of the statgrab library.
Florian Forster [Wed, 30 Apr 2008 06:17:21 +0000 (08:17 +0200)]
build system: Fix another bug in the detection of the statgrab library.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Tue, 29 Apr 2008 15:43:27 +0000 (17:43 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoMerge branch 'collectd-4.2' of git://git.verplant.org/collectd into collectd-4.2
Florian Forster [Tue, 29 Apr 2008 15:43:19 +0000 (17:43 +0200)]
Merge branch 'collectd-4.2' of git://git.verplant.org/collectd into collectd-4.2

16 years agoMerge branch 'collectd-4.3' of git://git.verplant.org/collectd into collectd-4.3
Florian Forster [Tue, 29 Apr 2008 15:43:04 +0000 (17:43 +0200)]
Merge branch 'collectd-4.3' of git://git.verplant.org/collectd into collectd-4.3

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Tue, 29 Apr 2008 14:52:08 +0000 (16:52 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

src/Makefile.am

16 years agobuild system: Use pkg-config to determine flags for the statgrab library.
Florian Forster [Tue, 29 Apr 2008 09:34:22 +0000 (11:34 +0200)]
build system: Use pkg-config to determine flags for the statgrab library.

16 years agobuild system: Don't (accidentally) clear the LDFLAGS when checking for libxml2 or...
Florian Forster [Tue, 29 Apr 2008 08:27:38 +0000 (10:27 +0200)]
build system: Don't (accidentally) clear the LDFLAGS when checking for libxml2 or libvirt.

16 years agoBumped version to 4.3.3; Updated ChangeLog. collectd-4.3.3
Florian Forster [Tue, 22 Apr 2008 11:18:21 +0000 (13:18 +0200)]
Bumped version to 4.3.3; Updated ChangeLog.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Tue, 22 Apr 2008 11:17:05 +0000 (13:17 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoChangeLog: Add missing notes about _REENTRANT and the sensors plugin. collectd-4.2.7
Florian Forster [Tue, 22 Apr 2008 11:16:34 +0000 (13:16 +0200)]
ChangeLog: Add missing notes about _REENTRANT and the sensors plugin.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Tue, 22 Apr 2008 11:11:46 +0000 (13:11 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

ChangeLog
version-gen.sh

16 years agoBumped version to 4.2.7; Updated ChangeLog.
Florian Forster [Tue, 22 Apr 2008 08:28:20 +0000 (10:28 +0200)]
Bumped version to 4.2.7; Updated ChangeLog.

16 years agomigrate-3-4.px: Rename vs_processes's data source from "total" to "value".
Sebastian Harl [Fri, 18 Apr 2008 12:54:50 +0000 (14:54 +0200)]
migrate-3-4.px: Rename vs_processes's data source from "total" to "value".

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@verplant.org>
16 years agocollection.cgi: Updated "vserver" graph definitions to version 4.
Sebastian Harl [Fri, 18 Apr 2008 12:53:50 +0000 (14:53 +0200)]
collection.cgi: Updated "vserver" graph definitions to version 4.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@verplant.org>
16 years agosensors plugin: Fix the return status of `sensors_snprintf_chip_name'.
Florian Forster [Fri, 18 Apr 2008 05:23:48 +0000 (07:23 +0200)]
sensors plugin: Fix the return status of `sensors_snprintf_chip_name'.

The function should return <0 only if an error occured, but in two out of three
branches the initial status of -1 was not modified. This may have rendered the
sensors plugin unusable for some people.

16 years agoconfigure: Build perl bindings only if a perl interpreter is available.
Sebastian Harl [Wed, 16 Apr 2008 16:53:30 +0000 (18:53 +0200)]
configure: Build perl bindings only if a perl interpreter is available.

For this purpose a check for the perl interpreter has been added. As the
check for libperl requires a perl interpreter as well (to get the compiler
and linker flags) the perl module will be disabled as well if a perl
interpreter is not available.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@verplant.org>
16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Tue, 15 Apr 2008 12:04:47 +0000 (14:04 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agobuild system: Check if strtok_r needs _REENTRANT
Florian Forster [Mon, 14 Apr 2008 10:26:08 +0000 (12:26 +0200)]
build system: Check if strtok_r needs _REENTRANT

Resolves: #8

16 years agoMerge branch 'collectd-4.2' of octo@verplant.org:/var/lib/git/collectd into collectd-4.2
Florian Forster [Sun, 13 Apr 2008 09:12:22 +0000 (11:12 +0200)]
Merge branch 'collectd-4.2' of octo@verplant.org:/var/lib/git/collectd into collectd-4.2

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 9 Apr 2008 16:34:48 +0000 (18:34 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

src/exec.c

16 years agoexec plugin: Close all file descriptors but the one connected to the pipe.
Florian Forster [Wed, 9 Apr 2008 16:32:14 +0000 (18:32 +0200)]
exec plugin: Close all file descriptors but the one connected to the pipe.

16 years agoCOPYING: Switched to a version with the new address of the FSF.
Florian Forster [Thu, 3 Apr 2008 08:11:57 +0000 (10:11 +0200)]
COPYING: Switched to a version with the new address of the FSF.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Thu, 3 Apr 2008 07:38:56 +0000 (09:38 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoCOPYING: Added the file (including the GPLv2).
Florian Forster [Thu, 3 Apr 2008 07:35:28 +0000 (09:35 +0200)]
COPYING: Added the file (including the GPLv2).

Newer versions of automake copy the GPLv3 when invoked with ``--add-missing''
which is not what we want.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Tue, 1 Apr 2008 13:05:45 +0000 (15:05 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

configure.in
src/plugin.c

16 years agounixsock plugin: Do not unregister a write-callback in us_shutdown().
Sebastian Harl [Mon, 31 Mar 2008 09:31:38 +0000 (11:31 +0200)]
unixsock plugin: Do not unregister a write-callback in us_shutdown().

The unixsock plugin no longer registers a write-callback. Basically,
unregistering a non-existent callback does not do any harm, However, if no
write-callback has been registered at all, the appropriate linked list has
never been created and the process will segfault when trying to access it.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigure.in: Set CPPFLAGS when checking headers.
Florian Forster [Tue, 1 Apr 2008 12:11:35 +0000 (14:11 +0200)]
configure.in: Set CPPFLAGS when checking headers.

When checking for <upsclient.h> (and the headers of a few other libraries) the
library specific CFLAGS were added to the global CFLAGS variable. This variable
is used when checking for ``header usability'', but not when checking for
``header presence'' for some reason.

This commit uses the global CPPFLAGS variable instead, which is used in both
checks. Libraries that benefit from this commit are:
- libcurl,
- libmysql(client),
- libnetsnmp,
- libupsclient.

Resolves #6

16 years agoapache plugin: Increase the size of the read-buffer dynamically.
Florian Forster [Tue, 1 Apr 2008 08:40:39 +0000 (10:40 +0200)]
apache plugin: Increase the size of the read-buffer dynamically.

Why guess the size if you can just adapt to whatever comes in? The memory isn't
freed ever, though.

16 years agosrc/plugin.c: plugin_dispatch_values: Improve the error messages.
Florian Forster [Mon, 31 Mar 2008 15:03:56 +0000 (17:03 +0200)]
src/plugin.c: plugin_dispatch_values: Improve the error messages.

If no write plugin was loaded or no DS was defined, the
`plugin_dispatch_values' used to fail silently. This is of course not good, so
this commit introduces error messages for this case, so that users can see why
their setup is not working properly.

Also, the ``no such DS type'' message was promoted from DEBUG to INFO.

16 years agosrc/common.c: Make really sure BYTE_ORDER and BIG_ENDIAN are defined.
Florian Forster [Mon, 31 Mar 2008 13:51:13 +0000 (15:51 +0200)]
src/common.c: Make really sure BYTE_ORDER and BIG_ENDIAN are defined.

If both, BYTE_ORDER and BIG_ENDIAN, are undefined, the statement
  #if BYTE_ORDER == BIG_ENDIAN
will be evaluated to `true', which may cause `ntohll' and `htonll' to behave
weird.

16 years agoplugin.c: Tell the user if a plugin could not be found.
Sebastian Harl [Mon, 31 Mar 2008 08:46:42 +0000 (10:46 +0200)]
plugin.c: Tell the user if a plugin could not be found.

Up to now this error was silently ignored, letting the user believe that
everything went fine.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollection.cgi: Make sure to pass valid variable names to rrdgraph.
Sebastian Harl [Sun, 30 Mar 2008 18:00:45 +0000 (20:00 +0200)]
collection.cgi: Make sure to pass valid variable names to rrdgraph.

Variable names used with DEF, VDEF, etc. must be made up of the
characters "A-Z, a-z, 0-9, -, _". In meta_graph_generic_stack() variable
names have been generated from the instance name which may, however,
contain illegal characters. Now, all illegal characters will be replaced
with "_" and a number will be prepended to the variable name to make
sure the name is still unique.

Thanks to Joerg Jaspert for pointing this out and helpful debugging
information.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agohddtemp plugin: Prefix all messages with "hddtemp plugin:".
Florian Forster [Mon, 31 Mar 2008 06:29:25 +0000 (08:29 +0200)]
hddtemp plugin: Prefix all messages with "hddtemp plugin:".

16 years agocollection.cgi: Added "meta graph" for "dns_qtype" and "dns_rcode".
Sebastian Harl [Sun, 30 Mar 2008 15:25:16 +0000 (17:25 +0200)]
collection.cgi: Added "meta graph" for "dns_qtype" and "dns_rcode".

This will merge all query types and return codes into a single graph each.

get_n_colors() has been taken from the version 3 script to get the colors for
the graphs. get_random_color() imho is not suitable for that purpose as it can
return colors that are hardly different - which would result in graphs that
are hard to read. get_n_colors() now returns a hash-ref suitable to be passed
to meta_graph_generic_stack().

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollection.cgi: Added support for "wireless" values.
Sebastian Harl [Sun, 30 Mar 2008 17:35:14 +0000 (19:35 +0200)]
collection.cgi: Added support for "wireless" values.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollection.cgi: Updated "dns" types to version 4.x.
Sebastian Harl [Sun, 30 Mar 2008 13:45:04 +0000 (15:45 +0200)]
collection.cgi: Updated "dns" types to version 4.x.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoBumped version to 4.3.2; Updated ChangeLog. collectd-4.3.2
Florian Forster [Sat, 29 Mar 2008 10:07:13 +0000 (11:07 +0100)]
Bumped version to 4.3.2; Updated ChangeLog.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Sat, 29 Mar 2008 09:52:45 +0000 (10:52 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

ChangeLog
version-gen.sh

16 years agoBumped version to 4.2.6 collectd-4.2.6
Florian Forster [Sat, 29 Mar 2008 09:34:46 +0000 (10:34 +0100)]
Bumped version to 4.2.6

16 years agoChangeLog: Added changes since 4.2.5.
Florian Forster [Thu, 27 Mar 2008 16:52:53 +0000 (17:52 +0100)]
ChangeLog: Added changes since 4.2.5.

16 years agosensors plugin: Simple fix for temperature sensors.
Peter Holik [Wed, 26 Mar 2008 12:48:09 +0000 (13:48 +0100)]
sensors plugin: Simple fix for temperature sensors.

Hi everybody!

While playing with sensors i missed temperature rrd files:

--- sensors.c.orig      2008-03-25 14:58:21.000000000 +0100
+++ sensors.c   2008-03-25 14:58:27.000000000 +0100
@@ -580,7 +580,7 @@
                        type = "fanspeed";
                else if (fl->feature->type
                                == SENSORS_FEATURE_TEMP)
-                       type = "input";
+                       type = "temperature";
                else
                        continue;

because this type got registered as input and "input" is not in types.db

after configuring with --enable-debug i saw a log:

No such dataset registered: input

should that be also without --enable-debug in my syslog?

cu Peter

16 years agoMerge branch 'pull/collectd-4.3' into collectd-4.3
Florian Forster [Wed, 26 Mar 2008 08:56:22 +0000 (09:56 +0100)]
Merge branch 'pull/collectd-4.3' into collectd-4.3

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 26 Mar 2008 08:48:27 +0000 (09:48 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

src/unixsock.c

16 years agounixsock plugin: Open two different IO stream handles for reading and writing.
Sebastian Harl [Wed, 26 Mar 2008 08:44:04 +0000 (09:44 +0100)]
unixsock plugin: Open two different IO stream handles for reading and writing.

Full-duplex standard IO streams are not really supported on sockets.
Mixing input and output functions involves calls to lseek(2) which is
not supported on sockets and thus causes the IO operations to fail.
Opening two IO streams solves the problem.

This is a backport of 43df21461d523023951746ef669f1bb95f61366d.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agounixsock plugin: Open two different IO stream handles for reading and writing.
Sebastian Harl [Wed, 26 Mar 2008 08:42:56 +0000 (09:42 +0100)]
unixsock plugin: Open two different IO stream handles for reading and writing.

Full-duplex standard IO streams are not really supported on sockets.
Mixing input and output functions involves calls to lseek(2) which is
not supported on sockets and thus causes the IO operations to fail.
Opening two IO streams solves the problem.

This is a backport of 43df21461d523023951746ef669f1bb95f61366d.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoCollectd::Unixsock: Fixed some typos.
Sebastian Harl [Tue, 25 Mar 2008 14:58:47 +0000 (15:58 +0100)]
Collectd::Unixsock: Fixed some typos.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoutils_cmd_{get,put}val.c: Fixed usage of parse_identifier().
Sebastian Harl [Wed, 26 Mar 2008 08:34:14 +0000 (09:34 +0100)]
utils_cmd_{get,put}val.c: Fixed usage of parse_identifier().

This function modifies its first argument which, in these cases, is used
again after the function call. Now, a copy of the string is passed to
parse_identifier().

This is a backport of 0a905cbd3151716c5749b5e7c5e439861466804d.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoutils_cmd_*: Terminate all lines printed to the socket with newline.
Florian Forster [Wed, 26 Mar 2008 08:31:33 +0000 (09:31 +0100)]
utils_cmd_*: Terminate all lines printed to the socket with newline.

This is a backport of 1ca0b79a4274784e4cc15d45e46e2cfa0c2039cf.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd-unixsock(5): Updated the paragraph about Collectd::Unixsock.
Sebastian Harl [Tue, 25 Mar 2008 14:52:47 +0000 (15:52 +0100)]
collectd-unixsock(5): Updated the paragraph about Collectd::Unixsock.

The module is no longer available in contrib/PerlLib/ but bindings/perl/.
Also it's now installed by default.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Mon, 24 Mar 2008 12:36:05 +0000 (13:36 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoliboconfig/parser.y: Enabled verbose error messages.
Sebastian Harl [Mon, 24 Mar 2008 11:07:20 +0000 (12:07 +0100)]
liboconfig/parser.y: Enabled verbose error messages.

This uses bison's "%error-verbose" option which might not be available in
other yacc implementations.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoliboconfig: Include the filename in error messages.
Sebastian Harl [Mon, 24 Mar 2008 11:06:49 +0000 (12:06 +0100)]
liboconfig: Include the filename in error messages.

As collectd now supports more than one config file, this is more
convenient.

A module-global variable is used for that purpose. If no filename is
available (e.g. if the user uses oconfig_parse_fh() directly), a string
like "<fd#X>" is used instead, where X is replaced by the file descriptor.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Updated copyright information.
Sebastian Harl [Sat, 22 Mar 2008 16:22:49 +0000 (17:22 +0100)]
perl plugin: Updated copyright information.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd-unixsock(5): Fixed some typos.
Sebastian Harl [Sat, 22 Mar 2008 16:22:19 +0000 (17:22 +0100)]
collectd-unixsock(5): Fixed some typos.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosensors plugin: Print information why a specific feature is ignored in debug mode.
Florian Forster [Sat, 22 Mar 2008 10:14:03 +0000 (11:14 +0100)]
sensors plugin: Print information why a specific feature is ignored in debug mode.

As requested by Ondřej Válek.

16 years agowireless plugin: Fix reading the noise value.
Florian Forster [Sat, 22 Mar 2008 09:45:11 +0000 (10:45 +0100)]
wireless plugin: Fix reading the noise value.

Accidentally the wrong value was used as `noise'. This patch fixes it.
Thanks to Ondřej Válek for pointing this out.

16 years agobuild.sh: Use glibtoolize if it's available.
Sebastian Harl [Sun, 9 Mar 2008 18:59:15 +0000 (19:59 +0100)]
build.sh: Use glibtoolize if it's available.

This way, the script should work on e.g. MacOSX as well.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigure: Do not preset $with_libstatgrab and $with_libdevstat.
Sebastian Harl [Sun, 9 Mar 2008 18:58:24 +0000 (19:58 +0100)]
configure: Do not preset $with_libstatgrab and $with_libdevstat.

Those variables are set when parsing the command line options and evaluated
inside the AC_ARG_WITH() macro. Presetting them overwrites any command line
options.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocontrib/redhat/collectd.spec: Updated the description of the package.
Florian Forster [Sat, 22 Mar 2008 09:07:34 +0000 (10:07 +0100)]
contrib/redhat/collectd.spec: Updated the description of the package.

Also updated the packager and vendor fields and added the redhat/ subdirectory
to contrib/README.

16 years agocontrib/redhat/: Added a spec file and affiliated config files.
Richard Shade [Sat, 22 Mar 2008 08:55:05 +0000 (09:55 +0100)]
contrib/redhat/: Added a spec file and affiliated config files.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Sat, 22 Mar 2008 08:40:00 +0000 (09:40 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoperl plugin: Fixed the "EnableDebugger after LoadPlugin" warning.
Sebastian Harl [Tue, 18 Mar 2008 11:34:17 +0000 (12:34 +0100)]
perl plugin: Fixed the "EnableDebugger after LoadPlugin" warning.

For some strange reason my original patch (perl plugin: Warn if
"EnableDebugger" has been used after "LoadPlugin".) has been applied at the
wrong position (it has been applied to perl_config_includedir() instead of
perl_config_enabledebugger() - I have absolutely no clue why though).

Also, the check for the precondition of this warning has been fixed. In some
cases aTHX does not seem to be set, even though the Perl interpreter has
already been initialized. Now, perl_threads is used to check for that
condition.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigfile.c: Include more than one files in lexicographical order.
Sebastian Harl [Thu, 20 Mar 2008 12:22:15 +0000 (13:22 +0100)]
configfile.c: Include more than one files in lexicographical order.

Using qsort() and strcmp() the list of files (after reading the contents
of a directory or expanding globs) is sorted before inclusion. As the
order of options in the config file matters this is more convenient.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoliboconfig/oconfig.c: Free all allocated memory in oconfig_free().
Sebastian Harl [Thu, 20 Mar 2008 10:03:32 +0000 (11:03 +0100)]
liboconfig/oconfig.c: Free all allocated memory in oconfig_free().

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigfile.c: Abort if any config file could not be read.
Sebastian Harl [Thu, 20 Mar 2008 10:02:06 +0000 (11:02 +0100)]
configfile.c: Abort if any config file could not be read.

So far, when including all files from some directory, errors while reading
any of those config files have been reported but otherwise ignored. So,
collectd would run with some potentially incomplete configuration which is
not what I would expect.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigfile.c: Fixed a memory leak in cf_read_generic().
Sebastian Harl [Thu, 20 Mar 2008 10:01:18 +0000 (11:01 +0100)]
configfile.c: Fixed a memory leak in cf_read_generic().

In case stat(2) failed, the memory allocated for the return value has not
been freed.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigfile.c: Fixed a segfault after a parse error.
Sebastian Harl [Thu, 20 Mar 2008 10:00:37 +0000 (11:00 +0100)]
configfile.c: Fixed a segfault after a parse error.

In cf_read_generic(), the parse result had not been checked to not be
NULL, which caused a segfault when trying to access any of its members.
Now, an error will be returned in that case.

Also, cf_ci_append_children() has been made more robust in that respect.
It now detects an empty source and does nothing in that case.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoAUTHORS: Speak about `plugins', not `modules'.
Florian Forster [Sat, 22 Mar 2008 08:27:44 +0000 (09:27 +0100)]
AUTHORS: Speak about `plugins', not `modules'.

Also sorted the plugins and put them all before any other patches.

16 years agoMerge branch 'pull/collectd-4.3' into collectd-4.3
Florian Forster [Tue, 18 Mar 2008 09:19:43 +0000 (10:19 +0100)]
Merge branch 'pull/collectd-4.3' into collectd-4.3

16 years agosrc/utils_{cache,threshold}.c: Fix the concept of failed and missing values.
Florian Forster [Tue, 18 Mar 2008 09:18:11 +0000 (10:18 +0100)]
src/utils_{cache,threshold}.c: Fix the concept of failed and missing values.

Apparently I was confused at the time - and still am ;)

16 years agoMerge branch 'pull/collectd-4.3' into collectd-4.3
Florian Forster [Mon, 17 Mar 2008 09:45:23 +0000 (10:45 +0100)]
Merge branch 'pull/collectd-4.3' into collectd-4.3

16 years agosrc/utils_cache.c: Fix the handling of `Persist'.
Florian Forster [Fri, 14 Mar 2008 13:30:02 +0000 (14:30 +0100)]
src/utils_cache.c: Fix the handling of `Persist'.

And reorganized/cleaned up the code a bit.

16 years agocontrib/rrd_filter.px: Added the ability to add (empty) data sources.
Florian Forster [Thu, 13 Mar 2008 17:19:48 +0000 (18:19 +0100)]
contrib/rrd_filter.px: Added the ability to add (empty) data sources.

16 years agosrc/{mbmon,plugin,unixsock}.c: Simple fixes for Solaris 5.8
Florian Forster [Thu, 13 Mar 2008 17:19:00 +0000 (18:19 +0100)]
src/{mbmon,plugin,unixsock}.c: Simple fixes for Solaris 5.8

16 years agocontrib/rrd_filter.px: Added a scale and shift filter.
Florian Forster [Thu, 13 Mar 2008 11:33:50 +0000 (12:33 +0100)]
contrib/rrd_filter.px: Added a scale and shift filter.

16 years agosrc/utils_threshold.c: Fix the configuration of {Failure,Warning}Max and inverted...
Florian Forster [Wed, 5 Mar 2008 13:15:02 +0000 (14:15 +0100)]
src/utils_threshold.c: Fix the configuration of {Failure,Warning}Max and inverted checking.

The first issue is a simple copy'n'paste error, the second a nasty oversight.

16 years agocontrib/rrd_filter.px: Remove the (unused) Data::Dumper.
Florian Forster [Wed, 5 Mar 2008 09:03:18 +0000 (10:03 +0100)]
contrib/rrd_filter.px: Remove the (unused) Data::Dumper.

16 years agoBumped version to 4.3.1; Updated ChangeLog. collectd-4.3.1
Florian Forster [Wed, 5 Mar 2008 08:44:24 +0000 (09:44 +0100)]
Bumped version to 4.3.1; Updated ChangeLog.

16 years agocontrib/rrd_filter.px: Renamed the old `extractDS.px'.
Florian Forster [Wed, 5 Mar 2008 08:43:21 +0000 (09:43 +0100)]
contrib/rrd_filter.px: Renamed the old `extractDS.px'.

It can do more than extracting DSes now.

16 years agonetwork plugin: Use `sstrncpy' instead of `strncpy'.
Florian Forster [Wed, 5 Mar 2008 08:28:11 +0000 (09:28 +0100)]
network plugin: Use `sstrncpy' instead of `strncpy'.

This removes a few "buf[buflen - 1] = '\0';".

16 years agosrc/common.[ch]: Changed the signature of `sstrncpy' to match that of `strncpy'.
Florian Forster [Wed, 5 Mar 2008 08:27:28 +0000 (09:27 +0100)]
src/common.[ch]: Changed the signature of `sstrncpy' to match that of `strncpy'.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 5 Mar 2008 08:16:16 +0000 (09:16 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

ChangeLog
src/network.c
version-gen.sh

16 years agoBumped version to 4.2.5; Updated ChangeLog. collectd-4.2.5
Florian Forster [Tue, 4 Mar 2008 13:43:40 +0000 (14:43 +0100)]
Bumped version to 4.2.5; Updated ChangeLog.

16 years agoconfigure.in: Fix a typo.
Florian Forster [Tue, 4 Mar 2008 13:36:14 +0000 (14:36 +0100)]
configure.in: Fix a typo.

16 years agonetwork plugin: Tested and fixed the receiving part on Sparc.
Florian Forster [Tue, 4 Mar 2008 13:35:07 +0000 (14:35 +0100)]
network plugin: Tested and fixed the receiving part on Sparc.

16 years agonetwork plugin: Use `memcpy' when parsing packages, too.
Florian Forster [Tue, 4 Mar 2008 10:09:07 +0000 (11:09 +0100)]
network plugin: Use `memcpy' when parsing packages, too.

This should prevent crashes due to unaligned memory access when running as
server.

16 years agoChangeLog: Wrote an entry for 4.2.5.
Florian Forster [Tue, 4 Mar 2008 08:36:42 +0000 (09:36 +0100)]
ChangeLog: Wrote an entry for 4.2.5.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Thu, 28 Feb 2008 22:06:16 +0000 (23:06 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agosrc/common.c: Use uint8_t's instead of (signed) char's.
Florian Forster [Thu, 28 Feb 2008 18:54:55 +0000 (19:54 +0100)]
src/common.c: Use uint8_t's instead of (signed) char's.

16 years agosrc/common.[ch]: Implemented `htond' and `ntohd' and applied it to the network plugin.
Florian Forster [Thu, 28 Feb 2008 14:15:53 +0000 (15:15 +0100)]
src/common.[ch]: Implemented `htond' and `ntohd' and applied it to the network plugin.

The functions convert doubles to the x86 representation or from the x86
representation to the representation used on the host. On x86 systems, this is
a NOP.

16 years agoconfigure.in: Added checks to find out how doubles are stored.
Florian Forster [Thu, 28 Feb 2008 13:23:27 +0000 (14:23 +0100)]
configure.in: Added checks to find out how doubles are stored.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 27 Feb 2008 14:33:45 +0000 (15:33 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agosrc/utils_cache.c: Fix SPARC alignment problems.
Florian Forster [Wed, 27 Feb 2008 11:20:42 +0000 (12:20 +0100)]
src/utils_cache.c: Fix SPARC alignment problems.

16 years agonetwork plugin: Align write access to the send buffer.
Florian octo Forster [Wed, 27 Feb 2008 09:22:19 +0000 (10:22 +0100)]
network plugin: Align write access to the send buffer.

SPARC and possibly other architectures cannot access arbitrary memory
locations. This caused a `bus error' on SPARC when the network plugin was
loaded. This change hopefully fixes this problem.

16 years agosrc/Makefile.am: Added dependencies on `utils_cmd_putnotif.[ch]' to the exec plugin.
Florian Forster [Wed, 27 Feb 2008 09:21:00 +0000 (10:21 +0100)]
src/Makefile.am: Added dependencies on `utils_cmd_putnotif.[ch]' to the exec plugin.