Code

collectd.git
11 years agoBump version to 4.10.8; Update ChangeLog.
Florian Forster [Sun, 11 Nov 2012 10:32:55 +0000 (11:32 +0100)]
Bump version to 4.10.8; Update ChangeLog.

11 years agoping plugin: Don't abort the "ping_thread" when ping_send() fails.
Florian Forster [Sun, 11 Nov 2012 09:57:55 +0000 (10:57 +0100)]
ping plugin: Don't abort the "ping_thread" when ping_send() fails.

This may happen when the network is down. If the thread fails, the read
callback will indicate an error and the exponential back-off will start.
This is not optimal for this scenario, since you usually want to have
ping stats from right when the network is back up.

Fixes Github issue #171.

11 years agoping plugin: Refactor "ping_thread": Move iteration over hosts into a function.
Florian Forster [Sun, 11 Nov 2012 09:56:00 +0000 (10:56 +0100)]
ping plugin: Refactor "ping_thread": Move iteration over hosts into a function.

11 years ago1) Cleans up one configure.ac error AC_LINK_IFELSE requires AC_LANG_PROGRAM (or somet...
Brian Aker [Fri, 26 Oct 2012 06:02:15 +0000 (02:02 -0400)]
1) Cleans up one configure.ac error AC_LINK_IFELSE requires AC_LANG_PROGRAM (or something similar) to get the setup right.
2) Fix for maintaier-clean so that you can run the autoreconf build script multiple times.
3) Clean up the generated man pages when running cleanup.

Signed-off-by: Florian Forster <octo@collectd.org>
11 years agocollectd-python.conf(5): fix register_* argument description
Idan Kamara [Wed, 24 Oct 2012 09:31:48 +0000 (11:31 +0200)]
collectd-python.conf(5): fix register_* argument description

Signed-off-by: Florian Forster <octo@collectd.org>
11 years agocollectd-python.conf(5): change phrasing of function descriptions
Idan Kamara [Wed, 24 Oct 2012 09:30:28 +0000 (11:30 +0200)]
collectd-python.conf(5): change phrasing of function descriptions

Signed-off-by: Florian Forster <octo@collectd.org>
11 years agocollectd-python.conf(5): change phrasing of minimum required version
Idan Kamara [Wed, 24 Oct 2012 09:29:03 +0000 (11:29 +0200)]
collectd-python.conf(5): change phrasing of minimum required version

Signed-off-by: Florian Forster <octo@collectd.org>
11 years agocollectd-python.conf(5): fix trivial spelling mistakes
Idan Kamara [Wed, 24 Oct 2012 08:53:58 +0000 (10:53 +0200)]
collectd-python.conf(5): fix trivial spelling mistakes

Signed-off-by: Florian Forster <octo@collectd.org>
11 years agocollectd-python.conf(5): capitalize Python
Idan Kamara [Wed, 24 Oct 2012 08:49:17 +0000 (10:49 +0200)]
collectd-python.conf(5): capitalize Python

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agonetwork.c: call gcry_check_version() as required by library.
Chris Lundquist [Fri, 12 Oct 2012 10:15:13 +0000 (03:15 -0700)]
network.c: call gcry_check_version() as required by library.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMerge remote-tracking branch 'trenkel/collectd-4.10' into collectd-4.10
Florian Forster [Sat, 20 Oct 2012 06:57:02 +0000 (08:57 +0200)]
Merge remote-tracking branch 'trenkel/collectd-4.10' into collectd-4.10

12 years agoChange the libnetlink function used to query link statistics to match iproute2's...
KIvosak [Sat, 13 Oct 2012 10:50:40 +0000 (12:50 +0200)]
Change the libnetlink function used to query link statistics to match iproute2's behavior and thus not trip on the kernel's new parsing of optional attributes for RTM_GETLINK.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agodisk plugin: Multiply the average read/write latency with the interval.
Florian Forster [Wed, 17 Oct 2012 14:08:07 +0000 (16:08 +0200)]
disk plugin: Multiply the average read/write latency with the interval.

The counter/derive will later be divided by the interval, resulting in too
small rates (for interval > 1.0).

Should fix issue #150. Thanks to Manuel Sanmartin for identifying this problem!

12 years agopython: Fix memory leaks.
Sven Trenkel [Sun, 14 Oct 2012 15:12:45 +0000 (15:12 +0000)]
python: Fix memory leaks.

12 years agonetwork.c: workaround for broken OSX compilers issuing false warnings
Chris Lundquist [Thu, 11 Oct 2012 00:04:26 +0000 (17:04 -0700)]
network.c: workaround for broken OSX compilers issuing false warnings

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agosrc/utils_db_query.[ch]: Remove duplicate "const" modifier.
Florian Forster [Thu, 11 Oct 2012 19:52:36 +0000 (21:52 +0200)]
src/utils_db_query.[ch]: Remove duplicate "const" modifier.

12 years agoMerge branch 'ff/snmp' into collectd-4.10
Florian Forster [Thu, 11 Oct 2012 08:01:44 +0000 (10:01 +0200)]
Merge branch 'ff/snmp' into collectd-4.10

12 years agosnmp plugin: Fix incorrect comparison in csnmp_oid_compare().
Florian Forster [Thu, 4 Oct 2012 05:57:25 +0000 (07:57 +0200)]
snmp plugin: Fix incorrect comparison in csnmp_oid_compare().

12 years agosnmp plugin: Check the return value of csnmp_oid_suffix().
Florian Forster [Wed, 3 Oct 2012 06:32:20 +0000 (08:32 +0200)]
snmp plugin: Check the return value of csnmp_oid_suffix().

Also fix an issue where the complete OID is compared with only the suffix.

Thanks to Mark Juric to test the changes and point out these problems.

Issue: #131

12 years agosnmp plugin: Fix iterating over tables without an instance configuration.
Florian Forster [Tue, 2 Oct 2012 07:28:32 +0000 (09:28 +0200)]
snmp plugin: Fix iterating over tables without an instance configuration.

Also should fix incorrect handling of instance values; the first one would
be skipped.

12 years agoconfigure: Only set the Perl interpreter if the argument is a file.
Florian Forster [Tue, 25 Sep 2012 10:32:50 +0000 (12:32 +0200)]
configure: Only set the Perl interpreter if the argument is a file.

This fixes Github issue #137.

12 years agoFixed bugs that prevented to "make distcheck"
Yves Mettier [Mon, 17 Sep 2012 13:46:24 +0000 (15:46 +0200)]
Fixed bugs that prevented to "make distcheck"

Fixes Github issue #132.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoFix for Solaris when setting ip-opt multicast-loop (must be a char, not int).
hume-github [Tue, 18 Sep 2012 18:19:39 +0000 (15:19 -0300)]
Fix for Solaris when setting ip-opt multicast-loop (must be a char, not int).
General logging additions for tracking down the problem.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMultithreading fix: localize unneeded global variable
hume-github [Tue, 18 Sep 2012 18:12:25 +0000 (15:12 -0300)]
Multithreading fix: localize unneeded global variable

12 years agosnmp plugin: Improve subtree matching.
Florian Forster [Sun, 23 Sep 2012 09:50:57 +0000 (11:50 +0200)]
snmp plugin: Improve subtree matching.

Some MIBs use subtrees with an unusual OID naming schema. For example,
some network hardware encodes the MAC address in the last six parts of
the OID. Previously, the code only checked the last part of the OID
("sub-id") and assumed this was increasing. This assumption is not true
in such naming schemas and is not required by SNMP. This patch fixes
this behavior by comparing the entire "OID suffix".

This hopefully fixes Github issue #131.

12 years agosnmp plugin: Expand tabs.
Florian Forster [Sun, 23 Sep 2012 09:44:39 +0000 (11:44 +0200)]
snmp plugin: Expand tabs.

12 years agosnmp plugin: Rename a couple of confusing variables.
Florian Forster [Tue, 18 Sep 2012 06:40:00 +0000 (08:40 +0200)]
snmp plugin: Rename a couple of confusing variables.

"head" and "tail" are way better names, I hope.

12 years agosnmp plugin: Improve some comments.
Florian Forster [Tue, 18 Sep 2012 06:29:26 +0000 (08:29 +0200)]
snmp plugin: Improve some comments.

12 years agobindings/Makefile: perl: Use INSTALL_BASE rather than PREFIX.
Sebastian Harl [Wed, 13 Jun 2012 12:33:05 +0000 (14:33 +0200)]
bindings/Makefile: perl: Use INSTALL_BASE rather than PREFIX.

Some versions of Perl / ExtUtils::MakeMaker will else abort with an error
message explaining INSTALL_BASE and PREFIX may not be used both. However, I
don't know where the other definition comes from.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoconfigure: Don't add -liptc to the global LIBS setting.
Sebastian Harl [Wed, 13 Jun 2012 12:31:00 +0000 (14:31 +0200)]
configure: Don't add -liptc to the global LIBS setting.

AC_SEARCH_LIBS() would do that, so save and restore LIBS when calling that
macro.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoconfigure: Use AC_INCLUDES_DEFAULT when checking any libkvm stuff.
Sebastian Harl [Fri, 18 May 2012 20:31:13 +0000 (22:31 +0200)]
configure: Use AC_INCLUDES_DEFAULT when checking any libkvm stuff.

kvm.h requires sys/types.h to be included. Using AC_INCLUDES_DEFAULT will
hopefully make sure that we're save for a bit ;-)

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agocurl_xml plugin: Mark read-only strings as const.
Florian Forster [Thu, 13 Sep 2012 08:53:19 +0000 (10:53 +0200)]
curl_xml plugin: Mark read-only strings as const.

12 years agofix Host config being ignored
Fabien Wernli [Mon, 28 Nov 2011 09:46:18 +0000 (10:46 +0100)]
fix Host config being ignored

Change-Id: I8a109818d8a821e2f3e0660fbb6ba1843279fcc2
Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoapcups plugin: Retry sending the "status" command.
Florian Forster [Thu, 13 Sep 2012 08:18:14 +0000 (10:18 +0200)]
apcups plugin: Retry sending the "status" command.

If that fails more than twice in the first 10 iterations, gracefully shut
down the socket in all future iterations.

This should fix Github issue #15.

12 years agoapcups plugin: Add function net_shutdown().
Florian Forster [Thu, 13 Sep 2012 08:05:35 +0000 (10:05 +0200)]
apcups plugin: Add function net_shutdown().

12 years agoapcups plugin: Make sure the socket is closed on errors.
Florian Forster [Thu, 13 Sep 2012 08:04:26 +0000 (10:04 +0200)]
apcups plugin: Make sure the socket is closed on errors.

12 years agosrc/utils_db_query.c: Use the right field when checking for size.
Florian Forster [Wed, 12 Sep 2012 20:51:58 +0000 (22:51 +0200)]
src/utils_db_query.c: Use the right field when checking for size.

12 years agoRevert "swap plugin: Add the "ReportBytes" option."
Florian Forster [Wed, 12 Sep 2012 19:31:41 +0000 (21:31 +0200)]
Revert "swap plugin: Add the "ReportBytes" option."

This reverts commit 25fd1667c186eb871a4b66f9866d6446e41f1bc2.

12 years agoswap plugin: Add the "ReportBytes" option.
Florian Forster [Wed, 12 Sep 2012 16:55:08 +0000 (18:55 +0200)]
swap plugin: Add the "ReportBytes" option.

When enabled, swap I/O is reported in bytes, not pages. Only valid for Linux.

This should fix Github issue #10.

12 years agoexec plugin: Really remove STDERR from the select() set.
Florian Forster [Wed, 12 Sep 2012 16:25:20 +0000 (18:25 +0200)]
exec plugin: Really remove STDERR from the select() set.

select(2) is actually using a variable called "copy", which we didn't set in
this case.

Fixes Github issue #12. Thanks to Tetsuya Kawaguchi for reporting this problem.

12 years agoconfigure.in: Make sure sa_familiy_t is defined when checking rtnl_dump_filter().
Florian Forster [Tue, 11 Sep 2012 07:54:32 +0000 (09:54 +0200)]
configure.in: Make sure sa_familiy_t is defined when checking rtnl_dump_filter().

12 years agonetlink plugin: Check for the number of arguments to 'rtnl_dump_filter'.
Sebastian Harl [Sat, 19 May 2012 10:31:52 +0000 (12:31 +0200)]
netlink plugin: Check for the number of arguments to 'rtnl_dump_filter'.

In recent versions of iproute2, 'rtnl_dump_filter' expects three rather than
five arguments.

This should fix Github issue #7.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoFixed collectd's unixsock read interrupted by SIGCHLD's.
Gerrie Roos [Tue, 17 Apr 2012 13:22:36 +0000 (15:22 +0200)]
Fixed collectd's unixsock read interrupted by SIGCHLD's.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoFixed various collectd memory leaks.
Gerrie Roos [Fri, 25 May 2012 03:38:47 +0000 (05:38 +0200)]
Fixed various collectd memory leaks.

Once I understood what's going on I tried to keep the changes to a minimum.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMerge branch 'ff/kstat' into collectd-4.10
Florian Forster [Mon, 10 Sep 2012 19:10:45 +0000 (21:10 +0200)]
Merge branch 'ff/kstat' into collectd-4.10

12 years agosnmp plugin: Fix error message printed by the "Shift" option.
Dan Thomson [Fri, 7 Sep 2012 02:00:11 +0000 (19:00 -0700)]
snmp plugin: Fix error message printed by the "Shift" option.

I noticed a small error in snmp.c in collectd-5.1.0 (might be
elsewhere). The warning message in csnmp_config_add_data_shift says
"Scale config option" instead of "Shift" config option:
[…]

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agodf plugin: when checking / do it just once
Bruno Prémont [Wed, 21 Mar 2012 20:34:00 +0000 (21:34 +0100)]
df plugin: when checking / do it just once

Newer system symlink /etc/mtab to /proc/mounts which makes root
filesystem seem mounted twice, once as type rootfs and once for the
real device.

When / is selected for df plugin, skip the rootfs mount-point as
real root is usually mounted right on top of it.

Not skipping it causes rrdtool to complain about two updates for the
same timestamp, the first entry for rootfs passes but rrdtool complains
when stats for the second occurrence for real filesystem is being
considered.

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Florian Forster <octo@collectd.org>
12 years agosnmp plugin: Check for SNMP_ENDOFMIBVIEW.
Florian Forster [Fri, 7 Sep 2012 08:11:42 +0000 (10:11 +0200)]
snmp plugin: Check for SNMP_ENDOFMIBVIEW.

Some implementations of SNMP will send a special "variable" when you're
leaving the requested subtree with type "endOfMibView" aka.
"SNMP_ENDOFMIBVIEW". Examples of such implementations are Citrix
Netscalers and IBM's General Parallel File System (GPFS). Reading past
this special variable will result in weird values being returned.

This adds an appropriate check to csnmp_check_res_left_subtree().

Thanks to "Mark" for reporting this issue and clarifying.

12 years agosrc/common.c: Add missing semicolon.
Florian Forster [Thu, 6 Sep 2012 15:29:59 +0000 (17:29 +0200)]
src/common.c: Add missing semicolon.

12 years agosrc/common.c: get_kstat_value: Check the arguments and return error codes.
Florian Forster [Thu, 6 Sep 2012 14:12:53 +0000 (16:12 +0200)]
src/common.c: get_kstat_value: Check the arguments and return error codes.

Rather than asserting that an argument is not NULL, check this condition
and return an error code.

This should fix Github issue #71.

12 years agosrc/Makefile.am: Unconditionally link collectd with libm.
Florian Forster [Wed, 5 Sep 2012 06:43:18 +0000 (08:43 +0200)]
src/Makefile.am: Unconditionally link collectd with libm.

Under FreeBSD, running src/utils_format_json.c fails because isfinite()
cannot be resolved. The GNU manpages for isnan() and isfinite() also
advise users to link with libm and AIX has had the library being linked
in for a while. Since it's such a basic library it seems easier to just
link with it unconditionally.

Fixes Github issue #122.

12 years agoFix bad definition of UDP src port in DNS plugin.
Daniel Sutto [Wed, 11 Jul 2012 17:32:16 +0000 (19:32 +0200)]
Fix bad definition of UDP src port in DNS plugin.

12 years agocollectd.conf(5): Improve description of the configuration syntax.
Florian Forster [Thu, 5 Jul 2012 06:32:28 +0000 (08:32 +0200)]
collectd.conf(5): Improve description of the configuration syntax.

12 years agoFix for config file parsing ("memcachec plugin: Option `Server' not allowed here.")
Pascal Hofmann [Thu, 14 Jun 2012 19:54:47 +0000 (21:54 +0200)]
Fix for config file parsing ("memcachec plugin: Option `Server' not allowed here.")

12 years agoFix out-of-bound index in rrdtool.c
Will Hawkins [Fri, 22 Jun 2012 18:45:45 +0000 (14:45 -0400)]
Fix out-of-bound index in rrdtool.c

Fix a reference to argv[1] that is (always?)
outside the bounds of the argv array. It happens
during a log statement that seems to want
to actually refer to the rrd filename.

12 years agooracle plugin: Add database name and query name (if applicable) to error messages.
Florian Forster [Tue, 19 Jun 2012 11:14:32 +0000 (13:14 +0200)]
oracle plugin: Add database name and query name (if applicable) to error messages.

12 years agooracle plugin: Report the "connect id" when OCILogon() fails.
Florian Forster [Mon, 18 Jun 2012 08:49:38 +0000 (10:49 +0200)]
oracle plugin: Report the "connect id" when OCILogon() fails.

12 years agocollection3: Use {instance} in Df's grpah title.
Florian Forster [Sun, 17 Jun 2012 18:46:43 +0000 (20:46 +0200)]
collection3: Use {instance} in Df's grpah title.

{type_instance} didn't work when used with other plugins than "df", e.g.
the example configuration of the Oracle plugin uses this.

12 years agosrc/utils_dns.c: Remove duplicate line.
Florian Forster [Fri, 1 Jun 2012 05:45:30 +0000 (07:45 +0200)]
src/utils_dns.c: Remove duplicate line.

12 years agosrc/utils_dns.c: Rename the "s_addr" and "d_addr" variables.
Florian Forster [Thu, 31 May 2012 13:09:43 +0000 (15:09 +0200)]
src/utils_dns.c: Rename the "s_addr" and "d_addr" variables.

On Solaris, there is a macro called "s_addr" resulting in syntax errors
when this is used as a variable name. The variables have been renamed to
circumvent this problem. Thanks to Maciej Bliziński for reporting this
problem and helping to debug it!

12 years agocollection3: Filter out identifiers with control characters.
Florian Forster [Sun, 27 May 2012 09:13:04 +0000 (11:13 +0200)]
collection3: Filter out identifiers with control characters.

Otherwise XML errors will prevent the page from rendering.

12 years agosrc/utils_avltree.c: Add sanity check to c_avl_destroy().
Florian Forster [Sun, 27 May 2012 09:10:56 +0000 (11:10 +0200)]
src/utils_avltree.c: Add sanity check to c_avl_destroy().

12 years agonetapp plugin: Close connection on communication errors.
Florian Forster [Sat, 12 May 2012 14:17:17 +0000 (16:17 +0200)]
netapp plugin: Close connection on communication errors.

12 years agoCreate directories with permission 0777.
Florian Forster [Fri, 6 Apr 2012 14:18:18 +0000 (16:18 +0200)]
Create directories with permission 0777.

Let umask work its magic. Thanks to "Poil" for reporting this problem.
Fixes GitHub issue #63.

12 years agoChangeLog: Correct date. collectd-4.10.7
Florian Forster [Sun, 1 Apr 2012 10:06:42 +0000 (12:06 +0200)]
ChangeLog: Correct date.

12 years agoBump version to 4.10.7; Update ChangeLog.
Florian Forster [Sun, 1 Apr 2012 09:51:38 +0000 (11:51 +0200)]
Bump version to 4.10.7; Update ChangeLog.

12 years agoRevert "Proposal fix for large "MaxPacketSize" use."
Florian Forster [Sat, 31 Mar 2012 15:27:14 +0000 (17:27 +0200)]
Revert "Proposal fix for large "MaxPacketSize" use."

This reverts commit 12213f8dfeee3feb3846aa658def0bb79c1211d0.

12 years agonetwork plugin: Do not forward received notifications.
Florian Forster [Fri, 23 Mar 2012 21:21:43 +0000 (22:21 +0100)]
network plugin: Do not forward received notifications.

The network plugin would send out all notifications it got through its
callback, even the ones it received itself and even when forwarding was
disabled.

With this patch the network plugin will only transmit notifications created
locally -- forwarding of notifications is not implemented due to missing
loop-detection. For loop-detection we would have to keep track of the last
timestamp of each notifications, and since each host/plugin/type/-instance
field may be empty, this is not as straight forward as with value lists. If
someone needs this, they will need to invest some work I'm afraid.

12 years agoProposal fix for large "MaxPacketSize" use.
Cyril Feraudet [Mon, 19 Mar 2012 10:08:06 +0000 (11:08 +0100)]
Proposal fix for large "MaxPacketSize" use.

When we use a "MaxPacketSize" over two thousand of octets (to pass huge
message in notification for example), buffer may not be flushed for a
while.
By flushing buffer when there is about 1400 octets, we're sure there is
no data too longer in.

12 years agosrc/common.h: Add comment about return value of read_file_contents().
Florian Forster [Mon, 19 Mar 2012 09:47:22 +0000 (10:47 +0100)]
src/common.h: Add comment about return value of read_file_contents().

12 years agotcpconns plugin: Include <bsd/nlist.h> rather than <nlist.h>.
Florian Forster [Sun, 18 Mar 2012 08:14:54 +0000 (09:14 +0100)]
tcpconns plugin: Include <bsd/nlist.h> rather than <nlist.h>.

It appears that <nlist.h> is being deprecated / moved.
This hopefully fixes Debian bug #664429.

12 years agosrc/common.c: parse_value: Strip trailing whitespace before parsing.
Florian Forster [Fri, 16 Mar 2012 17:26:08 +0000 (18:26 +0100)]
src/common.c: parse_value: Strip trailing whitespace before parsing.

This hopefully avoids the annoying "trailing garbage" message when the buffer
only contains a newline or space at the end.

12 years agocollectd.conf(5): Document the "Hits" and "Hysteresis" threshold options.
Florian Forster [Fri, 16 Mar 2012 16:44:50 +0000 (17:44 +0100)]
collectd.conf(5): Document the "Hits" and "Hysteresis" threshold options.

Fixes GitHub issue #53.

12 years agoMakefile adds dependency on $(LIBLTDL), which is valued "-lltdl"
Clemens Lang [Sat, 10 Mar 2012 01:30:26 +0000 (02:30 +0100)]
Makefile adds dependency on $(LIBLTDL), which is valued "-lltdl"

When building on OS X, the collectd build failed, because the collectd target
has a dependency on "-lltdl", which is the value the variable $(LIBLTDL) has.
Obviously, this should be the file name instead. I am however not sure how to
specify the correct filename in this case.

Fixes GitHub issue #54.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMerge pull request #44 from octo/ff/perl
Florian Forster [Sun, 11 Mar 2012 12:11:33 +0000 (05:11 -0700)]
Merge pull request #44 from octo/ff/perl

Fix race condition in the Perl plugin.

12 years agocollectd.conf(5): Improve the network plugin's documentation.
Florian Forster [Sun, 11 Mar 2012 12:04:13 +0000 (13:04 +0100)]
collectd.conf(5): Improve the network plugin's documentation.

The example given was confusing since it didn't make it clear enough, that only
one "Server" stanza is required.

Resolves GitHub issue #19.

12 years agonetwork plugin: Fix compiler warnings.
Florian Forster [Sun, 11 Mar 2012 11:57:10 +0000 (12:57 +0100)]
network plugin: Fix compiler warnings.

Resolves GitHub issue #49.

12 years agosnmp plugin: Keep track of signedness of ASN values.
Florian Forster [Sun, 11 Mar 2012 11:13:37 +0000 (12:13 +0100)]
snmp plugin: Keep track of signedness of ASN values.

Prior to this, the signed variant was used when casting to gauge_t. This caused
problems with values larger than 2^31-1, since they were casted to negative
values.

Hopefully fixes GitHub issue #50.

12 years agoFixed memory leak in collectdclient library.
Jason Schmidlapp [Thu, 1 Mar 2012 01:27:50 +0000 (20:27 -0500)]
Fixed memory leak in collectdclient library.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoperl plugin: Fix a race condition.
Florian Forster [Sun, 4 Mar 2012 10:10:20 +0000 (11:10 +0100)]
perl plugin: Fix a race condition.

This hopefully fixes GitHub issue #9.

12 years agoMerge pull request #40 from octo/db/processes
Florian Forster [Thu, 1 Mar 2012 09:57:02 +0000 (01:57 -0800)]
Merge pull request #40 from octo/db/processes

Add support for processes with spaces in their names.

12 years agoprocesses plugin: Support processes with spaces in their names.
Florian Forster [Thu, 1 Mar 2012 08:56:56 +0000 (09:56 +0100)]
processes plugin: Support processes with spaces in their names.

… without replacing the space in the process name. This is done by using
an equivalent of strchr() and strrchr() to determine the boundaries of
the second "field".

Change-Id: Id4c1a84c0544554fae05623457d2a7a3e0630db2

12 years agoprocesses plugin: Support processes with spaces in their name.
Darrell Bishop [Sat, 5 Nov 2011 08:29:00 +0000 (09:29 +0100)]
processes plugin: Support processes with spaces in their name.

Fixes GitHub issue #11.

Change-Id: Ifa9db0e020f19da43bbf49bba0626e70c16dc30f

12 years agoconntrack plugin: Strip newlie before calling parse_value().
Florian Forster [Wed, 29 Feb 2012 19:47:08 +0000 (20:47 +0100)]
conntrack plugin: Strip newlie before calling parse_value().

Change-Id: Ifa4db20a6b937912db77a214d2c0ef3eeebfa164

12 years agoUse parse_value in the conntrack plugin and submit the result even if it's zero
Louis Opter [Tue, 28 Feb 2012 17:23:06 +0000 (18:23 +0100)]
Use parse_value in the conntrack plugin and submit the result even if it's zero

Dear collectd,

Please find attached a patch for the conntrack plugin.

The patch is about two things:

1. submit the value even if it is zero (which is a legitimate value according
   to types.db);
2. use parse_value and a value_t instead of directly using a double and atof(3).

The first point was important because it meant that the metric was not created
when the initial value was zero. (It could also lead to holes in your graphs).

The parse_value return value is correctly checked, note that the parsed file
ends with a \n which mean that parse_value always complain when running in
debug/info maybe we should replace it with a \0 before handing the buffer to
parse_value() ?

Thanks

--
Louis Opter

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoFix buffer size for memcached stats answer
Timon [Tue, 28 Feb 2012 11:10:35 +0000 (17:10 +0600)]
Fix buffer size for memcached stats answer

Typical stats answer has ~1900 bytes length.
$ memcached-tool localhost:11211 stats | wc -c
1863
But buffer for this answer was only 1024 bytes length.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoAlso check in ip4tc for iptc_init
Andrew Elwell [Sun, 26 Feb 2012 21:32:08 +0000 (22:32 +0100)]
Also check in ip4tc for iptc_init

./configure --enable-iptables was failing on fedora as iptc_init
wasn't found. This patches configure.in to also look in ip4tc

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agocontrib/exec-nagios.px: Implement the "NRPEConfig" option.
Florian Forster [Mon, 19 Apr 2010 11:04:35 +0000 (13:04 +0200)]
contrib/exec-nagios.px: Implement the "NRPEConfig" option.

12 years agobind plugin: Fix use of the "QType" types.
Florian Forster [Sat, 25 Feb 2012 15:56:35 +0000 (16:56 +0100)]
bind plugin: Fix use of the "QType" types.

This should resolve GitHub issue #21.

Change-Id: I67e4b440a6fbc8a8608fa672fb3320b05f9c0a12

12 years agodf plugin: Fix a compiler issue with Mac OS X 10.7.
Florian Forster [Sat, 25 Feb 2012 10:42:19 +0000 (11:42 +0100)]
df plugin: Fix a compiler issue with Mac OS X 10.7.

Xcode Version 4.1 (11C74), GitHub issue #24

Change-Id: Ic6f49a95868c7f77bfb19f9c8afc87a97a1bf670

12 years agoUpdate ChangeLog. collectd-4.10.6
Florian Forster [Sun, 19 Feb 2012 09:58:46 +0000 (10:58 +0100)]
Update ChangeLog.

Change-Id: I41518e6e48c089e79919d1bc65b03744872bcec0

12 years agoexec plugin: Replace tabs with spaces to fix indentation.
Florian Forster [Fri, 17 Feb 2012 14:09:26 +0000 (15:09 +0100)]
exec plugin: Replace tabs with spaces to fix indentation.

Change-Id: I6e623f237c1d79007bd471732476a4e32dafde97

12 years agonetwork plugin: Fixed incorrect collectd warning when configuring network plugin.
Gerrie Roos [Tue, 20 Dec 2011 04:30:59 +0000 (06:30 +0200)]
network plugin: Fixed incorrect collectd warning when configuring network plugin.

Cosmetic only

Change-Id: I4c4c8fe19c23e9aa31b35e61eba31aa686429c10
Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoexec plugin: incorrectly exited select loop on signal.
Gerrie Roos [Tue, 10 Jan 2012 07:00:42 +0000 (09:00 +0200)]
exec plugin: incorrectly exited select loop on signal.

Sometimes dead modules won't be started up correctly or running ones
would not generate stats anymore.  Problem manifests more often under
load and on multicore hw

Change-Id: Ifb70a74c0cd55fc421b65a1f4332147916eadb70
Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoconfigure.in: Use the `--libs_r' option of mysql-config.
Cyril Feraudet [Tue, 14 Feb 2012 09:47:27 +0000 (10:47 +0100)]
configure.in: Use the `--libs_r' option of mysql-config.

Rather than the `--libs' option.

Change-Id: Idd2a3828f4d154f353c44a4b69aa094acbadcabf
Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoBump version to 4.10.6; Update ChangeLog.
Florian Forster [Sun, 5 Feb 2012 13:02:07 +0000 (14:02 +0100)]
Bump version to 4.10.6; Update ChangeLog.

Change-Id: I95bfb6e742ba7ad9e2b9c89dc990cd4bf573dbfa

12 years agoBuild system: Remove superfluous C(PP)FLAG.
Florian Forster [Sun, 5 Feb 2012 12:49:45 +0000 (13:49 +0100)]
Build system: Remove superfluous C(PP)FLAG.

Change-Id: Ic2f665869f863b1e0dca9b5ccde2803715386a3c

12 years agoBuild system: Use pkg-config to configure libiptc.
Florian Forster [Sat, 4 Feb 2012 15:28:02 +0000 (16:28 +0100)]
Build system: Use pkg-config to configure libiptc.

This hopefully fixes Goobuntu Bug #375733.

Change-Id: I0a4215351ce836fb62418cbd40bee27fd695d9da

12 years agoversion-gen.sh: Switch to bash due to bashisms.
Jo-Philipp Wich [Thu, 2 Feb 2012 22:27:45 +0000 (23:27 +0100)]
version-gen.sh: Switch to bash due to bashisms.

Change-Id: I8480afad2d157382fb7e5ff35785e97066c8553c

12 years agoRevert "interface plugin: Fix for bogus interfaces under Solaris."
Florian Forster [Mon, 30 Jan 2012 15:29:13 +0000 (16:29 +0100)]
Revert "interface plugin: Fix for bogus interfaces under Solaris."

This results in problems on aggregated interfaces, amongst other things.
I guess Solaris users will need to use the "IgnoreSelected" option to
get rid of "bogus" interfaces.

This reverts commit e7a75874a24c1bf19931d5b4b423a0daa7f9be6b.