strfsong: add a '\0' after copied chars; avoid memset
Fix strfsong behaviour for unknown identifier
[jn: adjusted the white space style]
[jn: adjusted the white space style]
ncmpc.1: describe the "chat" protocol
ncmpc.1: document the "chat-prefix" option
Merge branch 'chat' of git://git.musicpd.org/jn/ncmpc
screen_chat: add an option to set the message prefix
screen_chat: add nick name emulation
screen_chat: make it useful
This patch adds basic functionality to the chat screen.
This patch adds basic functionality to the chat screen.
mpdclient: add client-to-client support
configure.ac: screen_chat needs screen_text
configure.ac: the chat screen needs libmpdclient >= 2.5
screen_text: add support for appending text
screen_text: (API) use (char *) for strings
Reduce some unneeded complexity when adding strings returned
by other libraries than glib.
Reduce some unneeded complexity when adding strings returned
by other libraries than glib.
struct mpdclient: add a reconnection count
configure.ac: set HAVE_WINDOWS=0 to avoid a "test" warning
The warning would be:
./configure: line 5033: test: -eq: unary operator expected
The warning would be:
./configure: line 5033: test: -eq: unary operator expected
add an initial version of a chat screen
win32: Add a Windows OS resource file and icon
conf.c: Add windows system key binding config
conf.c: Move system key binding filename building to a function
conf.c: Add windows default user key binding config check
conf.c: Add windows default config checking
Modify version string to post-release version 0.21~git
ncmpc version 0.20
configure.ac: Don't add CURSES_LIB to AM_CPPFLAGS
screen_keydef: don't crash on Ctrl-Space
command: don't crash on Ctrl-Space
screen_keydef: use inline functions instead of macros for non-constants
conf.c: return void in read_configuration
show the path of the config files in --version output
fixes http://musicpd.org/mantis/view.php?id=3354
fixes http://musicpd.org/mantis/view.php?id=3354
conf: helper functions to build config file names
conf: rename get_user_key_binding_filename to build_*
This name is consistent with g_build_filename and it better reflects
the fact that memory is allocatd by this function.
This name is consistent with g_build_filename and it better reflects
the fact that memory is allocatd by this function.
ncmpc.1: update --version documentation
Merge remote branches 'jn/keydef' and 'jn/dev'
screen_keydef: join two short-ish lines
screen_keydef: support CMD_GO_ROOT_DIRECTORY
Maybe a bit pointless, but some user might want that.
Maybe a bit pointless, but some user might want that.
screen_keydef: support adding keys with CMD_ADD
AUTHORS: fix some grammar ("whom"/"who")
This commit lacks a good description.
This commit lacks a good description.
mpdclient: add G_GNUC_PURE to _is_connected()/_get_current_song()
screen_queue: fix indentation after #ifndef block
conf: make "hardware-cursor" a macro
remove obsolete str_pool.c and str_pool.h
command.c: remove obsolete DEBUG_KEYS and DK()
screen_keydef: save lw->start when switching view modes
screen_keydef: split out code to switch views
screen_keydef: better distinction of adding and replacing keys
screen_keydef: don't assign a key twice to one command
screen_keydef: show command descriptions
screen_keydef: rework the list length / item position logic
screen_keydef: clean up keydef_cmd return values
screen_keydef: remove LIST_ITEM_{SAVE,APPLY}_LABEL
These macros were only being used in one place.
These macros were only being used in one place.
screen_keydef: get rid of the BUFSIZE constant
It was only used in one function. Use sizeof(buf) instead.
It was only used in one function. Use sizeof(buf) instead.
screen_keydef: document delete_key
options: get_key_names: use bool
(And true/false in calls to it)
(And true/false in calls to it)
command.c: set_key_flags: return void
The return value was unused
The return value was unused
config.sample: add the "timeout" option
ncmpc.1: the default connection timeout is 5 seconds
change CMD_LYRICS_EDIT to CMD_EDIT
This allows other screens to implement edit funtionality
This allows other screens to implement edit funtionality
screen_lyrics: optionally ask before starting an editor
use screen_get_yesno
screen_utils: add function screen_get_yesno
options: don't use "editor" as the default editor
Just leave it unconfigured for as long as the editor fallback
machanism isn't yet implemented.
Just leave it unconfigured for as long as the editor fallback
machanism isn't yet implemented.
options: don't leak options.text_editor
NEWS: mention the lyrics_screen edit functionality
doc: remove obsolete --exit documentation
options: configurable timeout for MPD connections
command.c: comment an #endif
command.c: change find_key_command for MAX_COMMAND_KEYS != 3
The performance penalty shouldn't be too high (loop unrolling could
help here).
The performance penalty shouldn't be too high (loop unrolling could
help here).
command.c: turn while loops into for loops
command.c: rework loop logic in find_key_command
screen_interface: document the cmd callback
command: make Ctrl-X/Alt-X/F1 etc. translatable
screen_lyrics: new key to edit lyrics
Thanks for the idea and an initial patch go to Jitka Novotna <jitka@ucw.cz>
Thanks for the idea and an initial patch go to Jitka Novotna <jitka@ucw.cz>
screen_lyrics: put code for reloading in a function
Add option "text-editor"
The lyrics screen is going to spawn a text editor to edit lyrics.
Put the infrastructure in place to make it configurable.
The lyrics screen is going to spawn a text editor to edit lyrics.
Put the infrastructure in place to make it configurable.
Merge remote branches 'jn/cosmetics', 'jn/doxygen' and 'jn/renames'
screen_song: make Path a proper label
command.c: use for instead of while in check_key_bindings
command.c: put curly braces around a single large statement
main: don't show "connecting to (null)"
This patch is a follow-up to commit b774eac8d9 ("main: don't show
(null) as the server name").
This patch is a follow-up to commit b774eac8d9 ("main: don't show
(null) as the server name").
screen_song: don't show unknown kbit rates
(calling mpd_status_get_kbit_rate twice in a row shouldn't impact
performance, it's declared as "pure")
(calling mpd_status_get_kbit_rate twice in a row shouldn't impact
performance, it's declared as "pure")
rename screen_message to screen_status
Its two functions are screen_status_message and screen_status_printf
so this just seems logical to me.
Its two functions are screen_status_message and screen_status_printf
so this just seems logical to me.
doxygen: don't sort functions in the file documentation
add doc/doxygen.conf and doc/api/ to .gitignore
mention doxygen support in NEWS
add doxygen support
use mpdclient_finish_command at the obvious places
mpdclient: export mpdclient_finish_command
(and include mpdclient.h in mpdclient.c, so it can be used there)
(and include mpdclient.h in mpdclient.c, so it can be used there)
options.c: rewrite two #ifndefs as one #if
configure.ac: (default: enabled) -> [default=yes]
apply whitespace cosmetics to the license comments
ncmpc.h: document sigstop
Makefile.am: Add @CURSES_LIB@ to link the test program
mpdclient: define MPD_IDLE_ALL
configure.ac: Remove duplicate output screen merge error.
configure.ac: Change to the more correct variable for wide support.
screen_list: use G_N_ELEMENTS()
Merge remote branches 'avuton/master' and 'jn/dev'
m4: Add robust curses detection and support
This commit adds the ax_with_curses.m4 macro from the autoconf-archive
project. This also adds support for more plain curses, proper color detection
and compartmentalizes the curses autoconf stuff.
This commit adds the ax_with_curses.m4 macro from the autoconf-archive
project. This also adds support for more plain curses, proper color detection
and compartmentalizes the curses autoconf stuff.
screen.c: Add pdcurses mouse support