contrib/format.sh: Fix bashisms.
Auto-Merge pull request #2507 from rpv-tomsk/issue-2506
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
Fix hostname_g initialization from gethostname()
Closes: #2506
Closes: #2506
Auto-Merge pull request #2505 from jiriproX/dpdkstat_enh
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
One more review comment
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Incorporation of review commnets
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Auto-Merge pull request #2474 from octo/maintainer-guide
Automatically merged due to "Automerge" label
Automatically merged due to "Automerge" label
docs/maintainer_guide.md: First draft.
Merge pull request #2468 from octo/ff/memcached
memcached plugin: Report "listen_disabled_num" as "total_events".
memcached plugin: Report "listen_disabled_num" as "total_events".
Format correction.
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
Correction of tracing from child process
- There was read 16kb from pipe but only less then 1kb was traced.
Rest of trace data was lost.
Added support for two EAL parameters:
LogLevel - optional EAL paramenter which enable debug traces from rte libs
If parameter is not used default trace level = 7 (INFO) is used
LogLevel "8" - (DEBUG) can be set to collectd.conf into dpdkstat
EAL section
RteDriverLibPath - optional EAL parameter which enable loading of shared
pmd driver libs. Param value can be full path to single
pmd diriver lib or directory where pmd driver libs are
located. E.g.: "/usr/lib/dpdk-pmd/librte_pmd_i40e.so"
or "/usr/lib/dpdk-pmd"
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
- There was read 16kb from pipe but only less then 1kb was traced.
Rest of trace data was lost.
Added support for two EAL parameters:
LogLevel - optional EAL paramenter which enable debug traces from rte libs
If parameter is not used default trace level = 7 (INFO) is used
LogLevel "8" - (DEBUG) can be set to collectd.conf into dpdkstat
EAL section
RteDriverLibPath - optional EAL parameter which enable loading of shared
pmd driver libs. Param value can be full path to single
pmd diriver lib or directory where pmd driver libs are
located. E.g.: "/usr/lib/dpdk-pmd/librte_pmd_i40e.so"
or "/usr/lib/dpdk-pmd"
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>
CONTRIBUTING.md: Update formatting requirements.
Also point to contrib/format.sh as the source of truth.
Also point to contrib/format.sh as the source of truth.
memcached plugin: Report "listen_disabled_num" as type "total_events".
memcached plugin: Report "listen_disabled_num" as "operations".
Fixes: #2386
Fixes: #2386
contrib/format.sh: Add script for formatting files using a remote clang-format.
lvm plugin: Fix compilation issues
Merge remote-tracking branch 'github/pr/2492'
src/daemon/plugin.c: Fix some coding style.
Primarily to test the clang-format bot.
Primarily to test the clang-format bot.
lvm update: Check for the CAP_SYS_ADMIN capability.
Fixes: #2426
Fixes: #2426
Merge remote-tracking branch 'github/pr/2464'
clang-format src/postgresql.c
Update postgresql.c
A simple way collectd to identify itself to pg_stat_activity view.
A simple way collectd to identify itself to pg_stat_activity view.
Merge branch 'collectd-5.7'
Merge branch 'collectd-5.6' into collectd-5.7
Merge pull request #2346 from trenkel/master
Add CollectdError exception which can be thrown without causing a stacktrace to be logged.
Add CollectdError exception which can be thrown without causing a stacktrace to be logged.
Fix left ssnprintf in test
python plugin: Passed through clang-format
Merge pull request #2071 from maryamtahhan/feat_ipmi_analog
ipmi plugin: add more analog sensors support
ipmi plugin: add more analog sensors support
ceph plugin: Move comment to right place
Add comment about "avgtime" usage
Fix parse_keys() to use cut_suffixes array
ceph plugin: Make cut_suffix void, change var names
Merge remote-tracking branch 'github/pr/2467'
clang-format -style=file -i src/daemon/{collectd,configfile,globals}.c
Minor changes to address PR comments.
Tidy up formatting with clang-format.
Merge remote-tracking branch 'github/pr/2490'
rrdtool plugin: Small code cleanup.
Primarily to test the clang-format bot.
Primarily to test the clang-format bot.
Merge remote-tracking branch 'github/pr/2488'
clang-format -style=file -i src/snmp.c
Set timeout initially to 0 per reviewer's suggestion
Adress reviewer's suggestions and add documentation
Merge remote-tracking branch 'github/pr/2489'
Merge pull request #2485 from rpv-tomsk/processes
processes: Improved documentation
processes: Improved documentation
processes: Improved documentation
snmp plugin: Use cf_util_get_boolean() for boolean config options.
filecount: Controls whether or not to include only regular files in the count (#2483)
Address reviewer's suggestions
Add timeout and retry config options for SNMP plugin
ipmi: make unhandled sensor msg more informative
Change-Id: I5fc6056b2d0c5bb5cb1b28c3d24aaca163eb245b
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Change-Id: I5fc6056b2d0c5bb5cb1b28c3d24aaca163eb245b
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
[2475] write_prometheus plugin: Fix port listening
Signed-off-by: Florian Forster <octo@collectd.org>
Signed-off-by: Florian Forster <octo@collectd.org>
Merge pull request #2482 from outini/master
Implementation of "Prefix" option for write_http plugin
Implementation of "Prefix" option for write_http plugin
write_http: Allow to set empty metrics prefix in KAIROSDB format
write_http: Added strdup() result check
Setting metrics_prefix as char const *
Added denis pompilio to contributors
Implementation of "Prefix" for write_http plugin
This option is only available for the KAIROSDB format
This option defaults to "collectd"
This option is only available for the KAIROSDB format
This option defaults to "collectd"
Add sstrncpy if count_parts>2 but no suffix
Leftover reference to hostname_g[].
Make g_strings in perl.c not global so that hostname_g as a char* doesn't break it.x
Clang-format done
Fix unit test
".sum" is not cutted in parse_keys() now.
".sum" is not cutted in parse_keys() now.
ipmi: add more analog sensors support
- Add support of new analog sensors:
System Airflow, PS1 Input Power, MTT CPU1, MTT CPU2
- Extend list of sensors to support "memory" sensor type.
- Map sensors with a 'percent' flag to 'percent' type
and add sensor type as a prefix to type_instance in
this case. The type_instance of non % sensors will
remain the same (just sensor name).
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
- Add support of new analog sensors:
System Airflow, PS1 Input Power, MTT CPU1, MTT CPU2
- Extend list of sensors to support "memory" sensor type.
- Map sensors with a 'percent' flag to 'percent' type
and add sensor type as a prefix to type_instance in
this case. The type_instance of non % sensors will
remain the same (just sensor name).
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Merge pull request #2300 from rpv-tomsk/fix-sread
Remove close() call from sread()
Remove close() call from sread()
Merge remote-tracking branch 'github/pr/2135'
python: Addressed review comments
- Run clang-format
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
- Run clang-format
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Changed return type of sread() and swrite() from 'ssize_t' to 'int'
Functions 'sread()' and 'swrite()', unlike 'read()' and 'write()', does not return the number of bytes actually read/written.
They return error status, which is returned as 'int' type in Collectd code.
Functions 'sread()' and 'swrite()', unlike 'read()' and 'write()', does not return the number of bytes actually read/written.
They return error status, which is returned as 'int' type in Collectd code.
Proper check for `swrite()` return value
The `swrite()` can return positive value from `errno` in case of error.
The `swrite()` can return positive value from `errno` in case of error.
Remove close() call from sread()
The sread() function should not close fd in any cases, that is unexpected.
The sread() function should not close fd in any cases, that is unexpected.
write_prometheus plugin: Implement logging callback.
Merge pull request #2024 from rpv-tomsk/master-ipmi
ipmi plugin: Implemented IPMI LAN connection and plugin improved
ipmi plugin: Implemented IPMI LAN connection and plugin improved
ipmi plugin: style
ipmi plugin: Refactored to use c_ipmi_notification_init_()
ipmi plugin: Fixed remarks found while review
memcached: Fix hitratio calculation
If there is no requests, NAN is reported as hitratio.
If there is no hits - zero is reported.
If there is no requests, NAN is reported as hitratio.
If there is no hits - zero is reported.
ipmi plugin: Use cf_util_get_boolean()
memcached: style changes
memcached: Replace gauge_t with derive_t
memcached: Fix CPU usage reporting
Signed-off-by: Florian Forster <octo@collectd.org>
Signed-off-by: Florian Forster <octo@collectd.org>
memcached: Renamed calculate_rate to calculate_ratio_percent
memcached: Fix hitratio reporting
When Collectd calculates 'hitratio', it divides two continiously-grown values of Memcached stats.
As result, reported metric contains the average since Memcached start, which is incorrect.
When Collectd calculates 'hitratio', it divides two continiously-grown values of Memcached stats.
As result, reported metric contains the average since Memcached start, which is incorrect.
memcached: Fix CPU usage reporting
ipmi plugin: Added a define for errors / messages buffer size
ipmi plugin: Notify about IPMI connection state change
ipmi plugin: Improvements
* Do not request reading unless domain is connected
* Report instance name in error messages
* Do not request reading unless domain is connected
* Report instance name in error messages
Make node_handler_fetch_data() stateless
This code also works with previous ceph versions now.
This code also works with previous ceph versions now.
style
statsd: Document collectd behaviour when receiving the 0.000 timer value
Signed-off-by: Florian Forster <octo@collectd.org>
Signed-off-by: Florian Forster <octo@collectd.org>
ipmi plugin: Code cleanup
Currently curl_json will barely ignore boolean values in a non erroneous
way, so that if you have an array like this:
you will be able to access the 123 number like
We now rather call our number parser with 0 for false, 1 for true.
way, so that if you have an array like this:
you will be able to access the 123 number like
We now rather call our number parser with 0 for false, 1 for true.
ipmi plugin: Implemented IPMI LAN connection and plugin improved
* Added instances support
* Removed the sensor removal in case of reading errors
* Added the lock to do not request new readings until previous reading is complete
* Disabled SDRs local cache
* Added the check for sensors 'is readable' flag
* Added the check for sensor event reading type (if sensor is discrete or not)
* Added checks for sensor states 'scanning disabled' and 'initial update in progress'
* Changes in error reporting
* Added instances support
* Removed the sensor removal in case of reading errors
* Added the lock to do not request new readings until previous reading is complete
* Disabled SDRs local cache
* Added the check for sensors 'is readable' flag
* Added the check for sensor event reading type (if sensor is discrete or not)
* Added checks for sensor states 'scanning disabled' and 'initial update in progress'
* Changes in error reporting
Fixed issues with initializing hostname.
Fix kstat_ctl_t definition in globals.
Cleanup some defines and includes.
Adds setter for hostname_g and eliminates hostname_g_size variable.
Add MIT license to new globals files.
Merge remote-tracking branch 'github/pr/2469'
Merge remote-tracking branch 'github/pr/2453'
Merge remote-tracking branch 'github/pr/2398'
libcollectdclient/network_parse.c: Ensure memory allocated in parse_values() is always freed.
Shoutout to scan-build for finding this one!
Shoutout to scan-build for finding this one!