Fix to make write_mongodb work with any version of mongo-c-driver
collectd.conf(5): Fix typo.
contrib/collection3: Ignore control characters.
While they are correctly encoded, e.g. as "", browsers will
complain about invalid XML and not render the page. Ignore all control
characters other than whitespace.
While they are correctly encoded, e.g. as "", browsers will
complain about invalid XML and not render the page. Ignore all control
characters other than whitespace.
varnish plugin: Make argument "stats" const.
ethstat plugin: Fix a typo.
Bump version to 5.1.0; Update ChangeLog.
Merge branch 'collectd-5.0'
Merge branch 'collectd-4.10' into collectd-5.0
Conflicts:
ChangeLog
Conflicts:
ChangeLog
ChangeLog: Correct date.
Bump version to 5.0.4; Update ChangeLog.
Merge branch 'collectd-4.10' into collectd-5.0
Conflicts:
ChangeLog
src/collectd.conf.pod
src/common.c
src/network.c
src/processes.c
version-gen.sh
Conflicts:
ChangeLog
src/collectd.conf.pod
src/common.c
src/network.c
src/processes.c
version-gen.sh
Bump version to 4.10.7; Update ChangeLog.
Revert "Proposal fix for large "MaxPacketSize" use."
This reverts commit 12213f8dfeee3feb3846aa658def0bb79c1211d0.
This reverts commit 12213f8dfeee3feb3846aa658def0bb79c1211d0.
network plugin: Do not forward received notifications.
The network plugin would send out all notifications it got through its
callback, even the ones it received itself and even when forwarding was
disabled.
With this patch the network plugin will only transmit notifications created
locally -- forwarding of notifications is not implemented due to missing
loop-detection. For loop-detection we would have to keep track of the last
timestamp of each notifications, and since each host/plugin/type/-instance
field may be empty, this is not as straight forward as with value lists. If
someone needs this, they will need to invest some work I'm afraid.
The network plugin would send out all notifications it got through its
callback, even the ones it received itself and even when forwarding was
disabled.
With this patch the network plugin will only transmit notifications created
locally -- forwarding of notifications is not implemented due to missing
loop-detection. For loop-detection we would have to keep track of the last
timestamp of each notifications, and since each host/plugin/type/-instance
field may be empty, this is not as straight forward as with value lists. If
someone needs this, they will need to invest some work I'm afraid.
Merge pull request #56 from octo/ci/nfs
NFS plugin: Add Solaris support.
NFS plugin: Add Solaris support.
Merge branch 'ff/zfs'
zfs_arc plugin: Move reading of kstat values into separate functions.
This way error handling can be done in a central place and we can do this more
carefully overall.
This way error handling can be done in a central place and we can do this more
carefully overall.
Merge pull request #60 from octo/ar/zfs
more zfs kstat values
more zfs kstat values
zfs_arc plugin: Add copyright header for Aurelien Rougemont.
Proposal fix for large "MaxPacketSize" use.
When we use a "MaxPacketSize" over two thousand of octets (to pass huge
message in notification for example), buffer may not be flushed for a
while.
By flushing buffer when there is about 1400 octets, we're sure there is
no data too longer in.
When we use a "MaxPacketSize" over two thousand of octets (to pass huge
message in notification for example), buffer may not be flushed for a
while.
By flushing buffer when there is about 1400 octets, we're sure there is
no data too longer in.
zfs_arc plugin: Fix the "hash collision" and "mutex miss" metrics.
zfs_arc plugin: Fix typo in variable name.
zfs_arc plugin: Introduce the single-valued "mutex_operation" type.
zfs_arc plugin: Introduce the single-valued "cache_eviction" type.
zfs_arc plugin: Convert to use DERIVE.
add types for deleted, evict, hash, mutex
Signed-off-by: Florian Forster <octo@collectd.org>
Signed-off-by: Florian Forster <octo@collectd.org>
add hash_collisions, deleted, mutex_miss, evict_*
Fixed Solaris compilation errors
The value returned by get_kstat_value is of type long long whereas values is a union. Fixed the code so that the value gets assigned to one of the union members, in this case counter.
The value returned by get_kstat_value is of type long long whereas values is a union. Fixed the code so that the value gets assigned to one of the union members, in this case counter.
Fixed solaris configure script generation errors
The brackets in configure.in and the changes in version-gen.sh are needed in order for the build.sh script to generate the configure script correctly. Else the generated script won't work.
The brackets in configure.in and the changes in version-gen.sh are needed in order for the build.sh script to generate the configure script correctly. Else the generated script won't work.
src/common.h: Add comment about return value of read_file_contents().
nfs plugin: Minor coding style fixes.
nfs plugin: Remove duplicated code.
Changes include:
* Calculate nfs[234]_procedures_names_num at compile time.
* Made nfs_procedures_submit() more versatile, so it can be used from the Linux
and the Solaris code.
* Switched to plugin_dispatch_values_secure(), since the code is using the same
value_list_t for multiple values.
* Broke out nfs_submit_fields() from the Linux code. This removed quite a bit
of code duplication between the v2/v3 code.
* Broke out nfs_read_kstat() which does the get_kstat_value() call in a loop
rather than duplicating all the NFS procedure names.
Changes include:
* Calculate nfs[234]_procedures_names_num at compile time.
* Made nfs_procedures_submit() more versatile, so it can be used from the Linux
and the Solaris code.
* Switched to plugin_dispatch_values_secure(), since the code is using the same
value_list_t for multiple values.
* Broke out nfs_submit_fields() from the Linux code. This removed quite a bit
of code duplication between the v2/v3 code.
* Broke out nfs_read_kstat() which does the get_kstat_value() call in a loop
rather than duplicating all the NFS procedure names.
Enable modules for Solaris
Enabling nfs,processes and protocols modules for Solaris when running the
configure script.
Enabling nfs,processes and protocols modules for Solaris when running the
configure script.
Fix Linux compilation errors
Fixed compilation errors for the linux platform
Fixed compilation errors for the linux platform
Added safe-guard for kstat libraries
Added Solaris support for nfs3 and nfs4 (client/server)
tcpconns plugin: Include <bsd/nlist.h> rather than <nlist.h>.
It appears that <nlist.h> is being deprecated / moved.
This hopefully fixes Debian bug #664429.
It appears that <nlist.h> is being deprecated / moved.
This hopefully fixes Debian bug #664429.
Merge branch 'jr/varnish'
Merge pull request #48 from octo/pk/processes
Fix processes plugin under FreeBSD.
Fix processes plugin under FreeBSD.
processes plugin: Minimize whitespace-only changes.
processes plugin: Some more minor coding style fixes.
Merge pull request #52 from octo/cf/ethstat
ethstat support
ethstat support
ethstat plugin: Implement the "MappedOnly" option.
ethstat plugin: Fix indentation. It was a mess, sorry.
src/common.c: parse_value: Strip trailing whitespace before parsing.
This hopefully avoids the annoying "trailing garbage" message when the buffer
only contains a newline or space at the end.
This hopefully avoids the annoying "trailing garbage" message when the buffer
only contains a newline or space at the end.
collectd.conf(5): Document the "Hits" and "Hysteresis" threshold options.
Fixes GitHub issue #53.
Fixes GitHub issue #53.
Makefile adds dependency on $(LIBLTDL), which is valued "-lltdl"
When building on OS X, the collectd build failed, because the collectd target
has a dependency on "-lltdl", which is the value the variable $(LIBLTDL) has.
Obviously, this should be the file name instead. I am however not sure how to
specify the correct filename in this case.
Fixes GitHub issue #54.
Signed-off-by: Florian Forster <octo@collectd.org>
When building on OS X, the collectd build failed, because the collectd target
has a dependency on "-lltdl", which is the value the variable $(LIBLTDL) has.
Obviously, this should be the file name instead. I am however not sure how to
specify the correct filename in this case.
Fixes GitHub issue #54.
Signed-off-by: Florian Forster <octo@collectd.org>
ethstat plugin: Implement the "Map" option.
ethstat plugin: Add documentation.
ethstat plugin: Use the system header files if available.
And disable the plugin when they are not.
And disable the plugin when they are not.
ethstat module: Fix allocation of "ifacelist".
And remove uses of strcpy(3).
And remove uses of strcpy(3).
ethstat plugin: Fix includes.
ethstat plugin: Collect performance statistics from NICs.
Hi all,
For my needs at work I wrote a plugin for collectd and I wish to share it with
you.
This plugins, temporary called ethstat and wrote in C, collect lot of
performance counter about network interface as "ethtool -S ethX" do by asking
NIC driver module.
At the moment this plugin work only under Linux. Any help would be great for
make it working under Solaris, AIX and co ...
If you think this plugin may be included to collectd sources, what is the
procedure to do it ?
Regards,
Cyril Feraudet
To be added to configuration file to make it work :
LoadPlugin ethstat
<Plugin ethstat>
Iface "eth0"
#Iface "eth1"
#Iface "eth2"
#Iface "eth3"
</Plugin>
Signed-off-by: Florian Forster <octo@collectd.org>
Hi all,
For my needs at work I wrote a plugin for collectd and I wish to share it with
you.
This plugins, temporary called ethstat and wrote in C, collect lot of
performance counter about network interface as "ethtool -S ethX" do by asking
NIC driver module.
At the moment this plugin work only under Linux. Any help would be great for
make it working under Solaris, AIX and co ...
If you think this plugin may be included to collectd sources, what is the
procedure to do it ?
Regards,
Cyril Feraudet
To be added to configuration file to make it work :
LoadPlugin ethstat
<Plugin ethstat>
Iface "eth0"
#Iface "eth1"
#Iface "eth2"
#Iface "eth3"
</Plugin>
Signed-off-by: Florian Forster <octo@collectd.org>
varnish plugin: Simplify the v2/v3 define structs.
This somewhat duplicates the code in the read callback, but it's easier to read
than having four or so defines in one function.
Addresses GitHub issue #14.
This somewhat duplicates the code in the read callback, but it's easier to read
than having four or so defines in one function.
Addresses GitHub issue #14.
varnish plugin: Closed VSM
varnish plugin: Switched to AC_CHECK_HEADERS
varnish plugin: Fixed wrong function name
varnish plugin: Added basic Varnish 3.0 support
varnish plugin: Added Varnish version detection flag
amqp plugin: Fix compabitility with current librabbitmq.
In particular, add compatibility to the 0.9.1 and current development version.
Unfortunately, no version macro exists, so we need to do some autoconf trickery
:(
Fixes GitHub issue #6.
In particular, add compatibility to the 0.9.1 and current development version.
Unfortunately, no version macro exists, so we need to do some autoconf trickery
:(
Fixes GitHub issue #6.
Merge pull request #44 from octo/ff/perl
Fix race condition in the Perl plugin.
Fix race condition in the Perl plugin.
collectd.conf(5): Improve the network plugin's documentation.
The example given was confusing since it didn't make it clear enough, that only
one "Server" stanza is required.
Resolves GitHub issue #19.
The example given was confusing since it didn't make it clear enough, that only
one "Server" stanza is required.
Resolves GitHub issue #19.
network plugin: Fix compiler warnings.
Resolves GitHub issue #49.
Resolves GitHub issue #49.
snmp plugin: Keep track of signedness of ASN values.
Prior to this, the signed variant was used when casting to gauge_t. This caused
problems with values larger than 2^31-1, since they were casted to negative
values.
Hopefully fixes GitHub issue #50.
Prior to this, the signed variant was used when casting to gauge_t. This caused
problems with values larger than 2^31-1, since they were casted to negative
values.
Hopefully fixes GitHub issue #50.
processes plugin: A few coding style fixes for the FreeBSD code.
Change-Id: I3469a605c0dc0b7ce51049636ab3f82b03fdfa17
Change-Id: I3469a605c0dc0b7ce51049636ab3f82b03fdfa17
collectd-5.0.1-mine.patch some processes.c fixes for FreeBSD
I welcome from rainy Ingermanland!
Our thoughts are now occupied by Putin and vodka, however...
I have paid attention to a little incorrect data which is given out by
a processes plugin on my beautifull FreeBSD system.
I have corrected them and in process have made absolutely slightly
have improved accuracy and productivity of a processes plugin for
FreeBSD systems.
- Fix strange plural call of getpagesize(). Has entered a global
variable and initialization procedure for FreeBSD
- Data was summarized on all processes including threads. It led to
absolutely uncertain result. Fix based on codebase of FreeBSD top
programm. KERN_PROC_ALL attribute keep for future purposes.
- Gets command argument failed for some processes as system and some
other. It led to error messages to console. Fix based on codebase of
FreeBSD top programm.
- System and user CPU times turned out from the sum of miliseconds
and... Oh! microseconds in one glass with overflow possibility. Fixed.
My girlfriend has left me for such Christmas vacation, but I am
assured that have made good business.
Patch in mail attachment.
--
Non nobis Domine non nobis sed Nomini Tuo da gloriam
Phil Kulin
Change-Id: Ib88faadf5a0fd335b426e9024b0a2e438ddbaf1f
Signed-off-by: Florian Forster <octo@collectd.org>
I welcome from rainy Ingermanland!
Our thoughts are now occupied by Putin and vodka, however...
I have paid attention to a little incorrect data which is given out by
a processes plugin on my beautifull FreeBSD system.
I have corrected them and in process have made absolutely slightly
have improved accuracy and productivity of a processes plugin for
FreeBSD systems.
- Fix strange plural call of getpagesize(). Has entered a global
variable and initialization procedure for FreeBSD
- Data was summarized on all processes including threads. It led to
absolutely uncertain result. Fix based on codebase of FreeBSD top
programm. KERN_PROC_ALL attribute keep for future purposes.
- Gets command argument failed for some processes as system and some
other. It led to error messages to console. Fix based on codebase of
FreeBSD top programm.
- System and user CPU times turned out from the sum of miliseconds
and... Oh! microseconds in one glass with overflow possibility. Fixed.
My girlfriend has left me for such Christmas vacation, but I am
assured that have made good business.
Patch in mail attachment.
--
Non nobis Domine non nobis sed Nomini Tuo da gloriam
Phil Kulin
Change-Id: Ib88faadf5a0fd335b426e9024b0a2e438ddbaf1f
Signed-off-by: Florian Forster <octo@collectd.org>
write_mongodb plugin: Fix reconnection behavior.
The previous code would never detect a disconnect and act appropriately. In the
process, manual tracking of the connection state is removed in favor of
mongo_is_connected().
The previous code would never detect a disconnect and act appropriately. In the
process, manual tracking of the connection state is removed in favor of
mongo_is_connected().
write_mongodb plugin: Export DS names and DS types.
The values are exported as an array now. This is very close to the way data is
exported as JSON.
The values are exported as an array now. This is very close to the way data is
exported as JSON.
Merge pull request #43 from octo/ff/numa
numa plugin: Add plugin for Non-Uniform Memory Access (NUMA).
numa plugin: Add plugin for Non-Uniform Memory Access (NUMA).
collectd.conf.in: Add the numa plugin.
write_mongodb plugin: Actually store time as "date" type.
Fixed memory leak in collectdclient library.
Signed-off-by: Florian Forster <octo@collectd.org>
Signed-off-by: Florian Forster <octo@collectd.org>
perl plugin: Fix a race condition.
This hopefully fixes GitHub issue #9.
This hopefully fixes GitHub issue #9.
numa plugin: Add plugin for Non-Uniform Memory Access (NUMA).
Change-Id: I2610c7d8f73082154672114ad82001c6bd1b6f14
Change-Id: I2610c7d8f73082154672114ad82001c6bd1b6f14
Merge pull request #40 from octo/db/processes
Add support for processes with spaces in their names.
Add support for processes with spaces in their names.
processes plugin: Support processes with spaces in their names.
… without replacing the space in the process name. This is done by using
an equivalent of strchr() and strrchr() to determine the boundaries of
the second "field".
Change-Id: Id4c1a84c0544554fae05623457d2a7a3e0630db2
… without replacing the space in the process name. This is done by using
an equivalent of strchr() and strrchr() to determine the boundaries of
the second "field".
Change-Id: Id4c1a84c0544554fae05623457d2a7a3e0630db2
processes plugin: Support processes with spaces in their name.
Fixes GitHub issue #11.
Change-Id: Ifa9db0e020f19da43bbf49bba0626e70c16dc30f
Fixes GitHub issue #11.
Change-Id: Ifa9db0e020f19da43bbf49bba0626e70c16dc30f
write_mongodb plugin: Actually implement the "Timeout" option.
Change-Id: I8eb1bc53a15cd301d663e55a5ea71e46013f04c5
Change-Id: I8eb1bc53a15cd301d663e55a5ea71e46013f04c5
collectd.conf(5): Add documentation for the write_mongodb plugin.
Resolves GitHub issue #37.
Change-Id: I9b2ff533003e379f0eb81de256a946fdf8851661
Resolves GitHub issue #37.
Change-Id: I9b2ff533003e379f0eb81de256a946fdf8851661
conntrack plugin: Strip newlie before calling parse_value().
Change-Id: Ifa4db20a6b937912db77a214d2c0ef3eeebfa164
Change-Id: Ifa4db20a6b937912db77a214d2c0ef3eeebfa164
Use parse_value in the conntrack plugin and submit the result even if it's zero
Dear collectd,
Please find attached a patch for the conntrack plugin.
The patch is about two things:
1. submit the value even if it is zero (which is a legitimate value according
to types.db);
2. use parse_value and a value_t instead of directly using a double and atof(3).
The first point was important because it meant that the metric was not created
when the initial value was zero. (It could also lead to holes in your graphs).
The parse_value return value is correctly checked, note that the parsed file
ends with a \n which mean that parse_value always complain when running in
debug/info maybe we should replace it with a \0 before handing the buffer to
parse_value() ?
Thanks
--
Louis Opter
Signed-off-by: Florian Forster <octo@collectd.org>
Dear collectd,
Please find attached a patch for the conntrack plugin.
The patch is about two things:
1. submit the value even if it is zero (which is a legitimate value according
to types.db);
2. use parse_value and a value_t instead of directly using a double and atof(3).
The first point was important because it meant that the metric was not created
when the initial value was zero. (It could also lead to holes in your graphs).
The parse_value return value is correctly checked, note that the parsed file
ends with a \n which mean that parse_value always complain when running in
debug/info maybe we should replace it with a \0 before handing the buffer to
parse_value() ?
Thanks
--
Louis Opter
Signed-off-by: Florian Forster <octo@collectd.org>
Fix buffer size for memcached stats answer
Typical stats answer has ~1900 bytes length.
$ memcached-tool localhost:11211 stats | wc -c
1863
But buffer for this answer was only 1024 bytes length.
Signed-off-by: Florian Forster <octo@collectd.org>
Typical stats answer has ~1900 bytes length.
$ memcached-tool localhost:11211 stats | wc -c
1863
But buffer for this answer was only 1024 bytes length.
Signed-off-by: Florian Forster <octo@collectd.org>
Merge pull request #36 from octo/mh/softraid
Merge the "md" plugin, collecting disk counts from Linux software-RAID devices.
Merge the "md" plugin, collecting disk counts from Linux software-RAID devices.
AUTHORS, README: Add Michael Hanselmann / the md plugin.
collectd.conf(5): Update the information on the md plugin.
md plugin: Change metrics so each disk is reported only once.
This hopefully makes graphing easier.
This hopefully makes graphing easier.
Also check in ip4tc for iptc_init
./configure --enable-iptables was failing on fedora as iptc_init
wasn't found. This patches configure.in to also look in ip4tc
Signed-off-by: Florian Forster <octo@collectd.org>
./configure --enable-iptables was failing on fedora as iptc_init
wasn't found. This patches configure.in to also look in ip4tc
Signed-off-by: Florian Forster <octo@collectd.org>
Merge pull request #38 from octo/ff/mongodb
write_mongodb plugin: Implement the "StoreRates" option.
write_mongodb plugin: Implement the "StoreRates" option.
write_mongodb plugin: Implement the "StoreRates" option.
Change-Id: I73503de7605d456156664fd91c81cac1f3624939
Change-Id: I73503de7605d456156664fd91c81cac1f3624939
Plugin for Linux Software-RAID devices
This is an initial implementation of a plugin to collect information
about Linux Software-RAID (md) devices. It reports the number of
component devices, number of devices in array, number of active,
working, failed and spare disks.
Change-Id: Id0ba8e678f33153112e9999c6341dd2ce71b10c0
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Signed-off-by: Florian Forster <octo@collectd.org>
This is an initial implementation of a plugin to collect information
about Linux Software-RAID (md) devices. It reports the number of
component devices, number of devices in array, number of active,
working, failed and spare disks.
Change-Id: Id0ba8e678f33153112e9999c6341dd2ce71b10c0
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Signed-off-by: Florian Forster <octo@collectd.org>
contrib/exec-ksm.sh: Exec plugin for Kernel Samepage Merging (KSM).
Change-Id: I98d834ca849b21637c8fb00a63a037b73e0879b7
Change-Id: I98d834ca849b21637c8fb00a63a037b73e0879b7
Merge branch 'collectd-5.0'
Conflicts:
src/amqp.c
Change-Id: I85ab3ee2b51830ad0b5d474cf1f18b5c828d6588
Conflicts:
src/amqp.c
Change-Id: I85ab3ee2b51830ad0b5d474cf1f18b5c828d6588
Merge branch 'collectd-4.10' into collectd-5.0
Conflicts:
src/df.c
Change-Id: Ie7c9fd4a20cc356bb53b135bf2ca2d5162a8a953
Conflicts:
src/df.c
Change-Id: Ie7c9fd4a20cc356bb53b135bf2ca2d5162a8a953
contrib/exec-nagios.px: Implement the "NRPEConfig" option.
syslog plugin: Copy the BUFFER_ADD() macro from src/utils_format_json.c.
Also determine the string representation of the severity in the switch
block, since it's much easier to read than the ?:-cascade.
Change-Id: Ieb5467633db3e06e1fad6a60b5a19fd7708e2002
Also determine the string representation of the severity in the switch
block, since it's much easier to read than the ?:-cascade.
Change-Id: Ieb5467633db3e06e1fad6a60b5a19fd7708e2002
syslog plugin: Log "OKAY" notifications with severity "NOTICE".
It's a noteworthy event that implies normal operation, i.e. NOTICE. Also
renamed "severity" to "log_severity" to emphasize its use.
Change-Id: I7f3e4b12dabeb0caa9c9c8c86924bf77b2627ba1
It's a noteworthy event that implies normal operation, i.e. NOTICE. Also
renamed "severity" to "log_severity" to emphasize its use.
Change-Id: I7f3e4b12dabeb0caa9c9c8c86924bf77b2627ba1
syslog plugin: Change notification severity handling.
This way it is more like log severity handling, i.e. "OKAY" implies
"WARNING" and "WARNING" implies "FAILURE".
Change-Id: I972c09e4bc9e26b5abeb17cc4d8c5e0e1a42e1c3
This way it is more like log severity handling, i.e. "OKAY" implies
"WARNING" and "WARNING" implies "FAILURE".
Change-Id: I972c09e4bc9e26b5abeb17cc4d8c5e0e1a42e1c3
syslog plugin: Parse "value" as severity, not "key".
Change-Id: I4a7bde018be5a8925c9a998cd3e89e0289453063
Change-Id: I4a7bde018be5a8925c9a998cd3e89e0289453063
src/plugin.c: Fix use of strcmp().
Change-Id: I078ca80ba6e3cac413186c2ad063d32cdfbb398e
Change-Id: I078ca80ba6e3cac413186c2ad063d32cdfbb398e
Add notifications to syslog plugin
Deduplicated some code from logfile and syslog
and added NotifyLevel option to plugin.
Change-Id: I364067189d628420333cb625c885a256399e076a
Signed-off-by: Florian Forster <octo@collectd.org>
Deduplicated some code from logfile and syslog
and added NotifyLevel option to plugin.
Change-Id: I364067189d628420333cb625c885a256399e076a
Signed-off-by: Florian Forster <octo@collectd.org>