octo@leeloo:~/collectd $ svn merge -r822:823 branches/disk-linux trunk
octo@leeloo:~/collectd $ svn merge -r786:HEAD branches/freebsd trunk
disk-linux branch: Fix a bug in the disk plugin.
When `{read,write}-sectors' hit the 32 bit boundary, `atoi' would always return
LONG_MAX, resulting in the same counter-value being logged over and over again,
resulting in zero-entries in the RRD file.
Thanks to James Valente for reporting this bug and providing much debugging
information :)
When `{read,write}-sectors' hit the 32 bit boundary, `atoi' would always return
LONG_MAX, resulting in the same counter-value being logged over and over again,
resulting in zero-entries in the RRD file.
Thanks to James Valente for reporting this bug and providing much debugging
information :)
octo@casella:~/collectd $ svn cp trunk branches/disk-linux
octo@leeloo:~/collectd $ svn merge -r812:815 branches/apcups trunk
trunk: add .gitignore
Thanks to Olaf Rempel for this patch.
Thanks to Olaf Rempel for this patch.
trunk: Added the `apcups' and the `ntpd' plugins to the `README' file.
trunk: traffic plugin: fix linux pkt/err counters
Thanks to Olaf Rempel for this patch.
Thanks to Olaf Rempel for this patch.
trunk: fix some fd-leaks
Thanks to Olaf Rempel for this patch.
Thanks to Olaf Rempel for this patch.
trunk: Updated the `collection.cgi' with the `ntpd' types.
Some ntpd-specific types have been added. The `apcups_*' types have been
removed, since the apcups-plugin uses pretty generic types that are also used
the `battery' plugin and possibly others..
Some ntpd-specific types have been added. The `apcups_*' types have been
removed, since the apcups-plugin uses pretty generic types that are also used
the `battery' plugin and possibly others..
apcups branch: Remove `write_nbytes' and replace it with `swrite'.
`swrite' is defined in `common.c' and (re)used by other plugins.
Also, use `[u]int16_t' rather than `short', since the C standard doesn't
garuantee a specific size for this storage type.
Finally, the naming of the `packet_size' variable has been unified.
`swrite' is defined in `common.c' and (re)used by other plugins.
Also, use `[u]int16_t' rather than `short', since the C standard doesn't
garuantee a specific size for this storage type.
Finally, the naming of the `packet_size' variable has been unified.
apcups branch: Removed `read_nbytes' and replaced with `sread'.
`sread' is the secure-read function provided by `common.c'. This removed
duplicate code..
`sread' is the secure-read function provided by `common.c'. This removed
duplicate code..
apcups branch: Fixed the behavior of `sread'.
If `sread' receives an EOF it will now close the file descriptor and return an
error. Prior to this revision it would try to read again and possibly fail
then.. Alternatively it might have crashed, who knows..? ;)
If `sread' receives an EOF it will now close the file descriptor and return an
error. Prior to this revision it would try to read again and possibly fail
then.. Alternatively it might have crashed, who knows..? ;)
octo@casella:~/collectd $ svn cp trunk branches/apcups
trunk: Added config options of the `apcups' plugin to the `collectd.conf' manpage.
trunk: Added configuration options for `ntpd' to the `collectd.conf' manpage.
trunk: Documentes the two new plugins, apcups and ntpd
octo@casella:~/collectd $ svn merge -r754:800 branches/ntpd trunk
octo@casella:~/collectd $ svn rm branches/ntpd
octo@casella:~/collectd $ svn rm branches/ntpd
octo@casella:~/collectd $ svn merge -r784:HEAD branches/apcups trunk
apcups branch: Don't close the socket after each iteration.
The apcups daemon can handle it and it's nicer to the system to just leave the
socket open, so that's what we're doing. The socket is still closed if
`APCMAIN' is defined.
The apcups daemon can handle it and it's nicer to the system to just leave the
socket open, so that's what we're doing. The socket is still closed if
`APCMAIN' is defined.
apcups branch: Some debug messages and such.
collectd dies when the port is forwarded using ssh and then the server exits.
Apparently ssh doesn't anser with a connection refused right away which may
result in problems..
This revision adds some debug messages and handles `EOF' correctly (when
reading).
collectd dies when the port is forwarded using ssh and then the server exits.
Apparently ssh doesn't anser with a connection refused right away which may
result in problems..
This revision adds some debug messages and handles `EOF' correctly (when
reading).
ntpd branch: Changed the RRD files of the NTPd plugin to store seconds rather than milliseconds.
Apparently seconds is what we get. I was assuming it was milliseconds for some
unknown reason..
Apparently seconds is what we get. I was assuming it was milliseconds for some
unknown reason..
apcups branch: Renames some RRD files and DSes.
The `charge_percent' has been renamed to `load_percent' because it's actually
the load on the UPS, not the charge.
The `charge' file has been renamed to `charge_percent', because the values are
in percent, not Ah.
The `charge_percent' has been renamed to `load_percent' because it's actually
the load on the UPS, not the charge.
The `charge' file has been renamed to `charge_percent', because the values are
in percent, not Ah.
apcups branch: Renamed the temperature-DS to `value' to work with existing plugins.
apcups branch: Fixed some minor issues with the apcups plugin. It's working now.
freebsd branch: swap plugin: Added the possibility to use `libkvm' to collect swap statistics.
For some weird reason one needs r00t for this, though..
For some weird reason one needs r00t for this, though..
freebsd branch: memory plugin: Include "utils_debug.h" because DBG is being used.
18 years agofreebsd branch: swap plugin: Use `sysctlnametomib' to query the mib if we don't know it.
freebsd branch: swap plugin: Use `sysctlnametomib' to query the mib if we don't know it.
Maybe this should be the default?
Maybe this should be the default?
freebsd branch: memory plugin: Use `errno', not the return value of `sysctlbyname', as argument to `strerror'.
freebsd branch: memory plugin: Quick bugfix. Works under FreeBSD now.
memory plugin: MACH_VM_STATISTICS_H -> HAVE_MACH_VM_STATISTICS_H
Not really a bug. It worked the other way, too..
Not really a bug. It worked the other way, too..
freebsd branch: memory.c: Hopefully working version.
Use `sysctlbyname' to get values instead of the `sysctl' call. Also, use the
`HAVE_SYSCTLBYNAME' define rather than `VM_TOTAL'.
Use `sysctlbyname' to get values instead of the `sysctl' call. Also, use the
`HAVE_SYSCTLBYNAME' define rather than `VM_TOTAL'.
freebsd branch: First attempt at porting the `memory' plugin to FreeBSD.
octo@huhu:~/collectd $ svn cp trunk branches/freebsd
octo@leeloo:~/collectd $ svn merge -r737:784 branches/apcups trunk
The trunk did not compile with the `apcups' plugin enabled. Since it's enabled
by default some extra action was neccessary. The `apcups' plugin in the branch
compiles and may be useable, so I'm merging it back to get to some consistent
state.
The trunk did not compile with the `apcups' plugin enabled. Since it's enabled
by default some extra action was neccessary. The `apcups' plugin in the branch
compiles and may be useable, so I'm merging it back to get to some consistent
state.
apcups branch: Fix minor issues with the apcups plugin.
- Removed `#include <errno.h>' since it is included from `collectd.h'.
- Changed `global_host' back to NULL. Added a ?:-construct to use a default
value when querying the server.
- Use `strcmp' rather than `strncmp' to compare the full string, not just part
of the strings.
- Removed `#include <errno.h>' since it is included from `collectd.h'.
- Changed `global_host' back to NULL. Added a ?:-construct to use a default
value when querying the server.
- Use `strcmp' rather than `strncmp' to compare the full string, not just part
of the strings.
1. Was erroneously using tokptr vice key.
2. Changed calls to strcmp to strncmp so that
only definate ranges where being compared.
2. Changed calls to strcmp to strncmp so that
only definate ranges where being compared.
1. Keeping the socket open on my system, when apcupsd is shutdown, collectd dies as well.
I re-inserted the net_close() and now when apcupsd is shutdown (or otherwise goes away)
collectd stays running.
2. Changed the 'complain' and 'complain_step' code so that it will chirp the first time, then
every 6 hours. As it was originally it would only start complaining after 6 hours. Additionally
I made complain an unsigned int. If it was an int and rolled over I wasn't certain what would happen.
3. 'global_host' set to localhost. It was set to NULL, but what happens is if someone does not enter
an apcups section to collectd.conf, then it will not connect to anyone. With 'global_host' set to localhost
the default behavior is now to connect to the apcupsd on the localhost.
4. Added entry for apcupsd.so in 'contrib/collectd.spec'.
I re-inserted the net_close() and now when apcupsd is shutdown (or otherwise goes away)
collectd stays running.
2. Changed the 'complain' and 'complain_step' code so that it will chirp the first time, then
every 6 hours. As it was originally it would only start complaining after 6 hours. Additionally
I made complain an unsigned int. If it was an int and rolled over I wasn't certain what would happen.
3. 'global_host' set to localhost. It was set to NULL, but what happens is if someone does not enter
an apcups section to collectd.conf, then it will not connect to anyone. With 'global_host' set to localhost
the default behavior is now to connect to the apcupsd on the localhost.
4. Added entry for apcupsd.so in 'contrib/collectd.spec'.
Changed the build system to link against the system's `liboping' if it is found.
If it is not found the version shipped in `src/liboping' is used.
If it is not found the version shipped in `src/liboping' is used.
octo@leeloo:~/collectd $ svn merge -r773:777 branches/collectd-3.9 trunk
Bumped version to 3.9.3
Added a ChangeLog entry for version 3.9.3.
Removed the call to `bind'.
It's only neccessary when binding to a specific (local) address, which we
don't. FreeBSD, Mac OS X and potentially other operating systems didn't like
this.. GNU/Linux never complained, though..
It's only neccessary when binding to a specific (local) address, which we
don't. FreeBSD, Mac OS X and potentially other operating systems didn't like
this.. GNU/Linux never complained, though..
Updated the configure script to work under *BSD.
There was a problem with building the `oping' library under FreeBSD. The
`netinet/*.h' includes need to have `sys/types.h' included before them. Under
other operating systems only `stdint.h' is neccessary.
There was a problem with building the `oping' library under FreeBSD. The
`netinet/*.h' includes need to have `sys/types.h' included before them. Under
other operating systems only `stdint.h' is neccessary.
ntpd branch: Close the ntpd-socket if a read or write failes (with something else then EAGAIN or EINTR).
ntpd branch: Removed the headerfiles that were copied from the NTPd distribution: They are not used (anymore).
18 years agontpd branch: Added `time_dispersion' and `delay' to the `collection.cgi' Also, change...
ntpd branch: Added `time_dispersion' and `delay' to the `collection.cgi' Also, changed `time_offset' to use `Seconds' and let RRDTool scale that to milli- or micro-seconds.
ntpd branch: Added the collection of the `time_dispersion' and `delay' values to the ntpd plugin.
18 years agontpd branch: The ntpd plugin now resolves the `127.127.$id.*' addresses to the refere...
ntpd branch: The ntpd plugin now resolves the `127.127.$id.*' addresses to the reference-clock name.
ntpd branch: Added config-code to the ntpd plugin, so one can configure the host and port to use/query.
ntpd branch: Added the reverse-lookup for both, IPv4 and IPv6 to the ntpd plugin.
ntpd branch: Added `frequency_offset' and `time_offset' to `collection.cgi'
ntpd branch: The ntpd plugin now requests the `peer info summary' but doesn't record it yet.
18 years agontpd branch: Added some debug messages to the ntpd plugin. Also changed it to request...
ntpd branch: Added some debug messages to the ntpd plugin. Also changed it to request `kern_info' rather than `sys_info'. `peer_stats' or something is still to be done.
ntpd branch: The ntpd-plugin compiles and gets _some_ values. Doesn't entirely work yet, though.
ntpd branch: Fixed misspelled variable name in common.h.
18 years agoAdded a call to `poll(2)' to the ntpd plugin. Also added some needed time calculation...
Added a call to `poll(2)' to the ntpd plugin. Also added some needed time calculation for the timeout.
ntpd.c: Fixed most syntax errors.. Removed the inclusion of `ntp_request.h' since it has too many dependencies.
Added `ntp_{types,machine}.h' from the NTPd distribution.
First (incomplete) code for querying an ntpd.
Added `sread' and `swrite': `read' and `write' like functions that assure that all data is written or fail completely..
hddtemp.c: Don't try other sockets if one could be opened..
Copied `ntp-4.2.0a+stable/include/ntp_request.h' to the source directory.
Created the `ntpd' branch.
Added the `Ignore' config option of the `traffic' plugin to the collectd.conf(5) manpage.
Build the `submit_{packages,errors}' functions when the proc interface is used..
traffic plugin: Store the packet- and error-counter for the proc interface, too.
Changed the build-system to only use the getifaddrs-code under Linux, if the user specifically said to do so.
Changed the apcups plugin to keep the socket open.
Define the `APCMAIN' define in any way. Set it to zero if building as a plugin (default).
apcups.c: Closed run-away comment. Sorry.
Removed all the conflicts from the apcups-plugin again.
1. (major) Code no longer calls exit() when it encounters an error. It
will send an appropriate error via syslog instead.
2. Adopted the code recommended by Octo (thx) It was considerably cleaner
and easier to understand. Not to mention the plugin size is smaller. A win
all around ;-) I rearranged some, though.
3. Fixed the indentation. I believe I see what is recommended by octo....
Hopefully, it is now similar to the other plugins.
4. On a failure to connect apcups will log the initial failure via syslog. It will
only log another failure after the integer apcConnStatus rolls over. This should prevent
apcups from overloading syslog.
5. Other minor code cleanups.
will send an appropriate error via syslog instead.
2. Adopted the code recommended by Octo (thx) It was considerably cleaner
and easier to understand. Not to mention the plugin size is smaller. A win
all around ;-) I rearranged some, though.
3. Fixed the indentation. I believe I see what is recommended by octo....
Hopefully, it is now similar to the other plugins.
4. On a failure to connect apcups will log the initial failure via syslog. It will
only log another failure after the integer apcConnStatus rolls over. This should prevent
apcups from overloading syslog.
5. Other minor code cleanups.
Renamed `host' and `port' to `global_host' and `global_port' to distinguish between the global and the local variables.
Improved the config function: Set `global_host' to NULL if not configured and copy the value otherwise. Don't use a static variable within the config routine and reference to it..
Improved the config function: Set `global_host' to NULL if not configured and copy the value otherwise. Don't use a static variable within the config routine and reference to it..
Rearranged the functions in the `apcups' plugin.
Simplified the `submit' and `write' functions of the `apcups' plugin. Also changed the DS definitions.
18 years agoChanged the network code to use `getaddrinfo' rather than the old style name resolution.
Changed the network code to use `getaddrinfo' rather than the old style name resolution.
branches/apcups/src/apcups.c:
Restored changes made to the trunk.
Restored changes made to the trunk.
1. (major) The code in apcups.c was adapted from apcupsd-3.12.3 the command
'apcaccess status'. The code I used calls 'exit()' if it cannot connect
to the apcupsd daemon. A reasonable action for a standalone program.
Not good for a monitoring daemon. This was completely an oversight on my part.
2. (minor) Some dead code is now defined out if APCMAIN is not defined.
3. (minor) My units in collection.cgi where incorrect.
4. (minor) if the apcups plugin cannot connect to the apcupsd it will
simply not call the submit routines allowing the rrd files to fill with NAN
as expected, rather than submitting zeros.
'apcaccess status'. The code I used calls 'exit()' if it cannot connect
to the apcupsd daemon. A reasonable action for a standalone program.
Not good for a monitoring daemon. This was completely an oversight on my part.
2. (minor) Some dead code is now defined out if APCMAIN is not defined.
3. (minor) My units in collection.cgi where incorrect.
4. (minor) if the apcups plugin cannot connect to the apcupsd it will
simply not call the submit routines allowing the rrd files to fill with NAN
as expected, rather than submitting zeros.
Copied trunk to `branches/apcups'
Fixed miscellaneous small stuff..
Cleaned up the apcups plugin some more..
apcups.c:
- Improved the `do_pthreads_status' function to not have the same code 10 times (or so).
- Improved the `do_pthreads_status' function to not have the same code 10 times (or so).
src/apcups.c:
- Fixed more indentation.
- Made internal-only functions static.
- Fixed more indentation.
- Made internal-only functions static.
Added the apcups plugin to the build system.
Removed the av?snprintf-auxiliary-functions from the apcups-plugin.
`fixed' indentation in the apcups-plugin (not done yet).
Removed the av?snprintf-auxiliary-functions from the apcups-plugin.
`fixed' indentation in the apcups-plugin (not done yet).
Added `apcups.c' by Anthony Gialluca <tonyabg at charter.net>
Merged stuff from branches/collectd-3.9: After release 3.9.2 the ChangeLog additions were not copied..
Renamed threads to vs_threads in collection.cgi (should have already been done
in r532 :-/ ).
in r532 :-/ ).
octo@leeloo:~/collectd $ svn merge -r630:631 trunk branches/collectd-3.8
octo@leeloo:~/collectd $ svn merge -r630:631 trunk branches/collectd-3.9
octo@leeloo:~/collectd $ svn merge -r630:631 trunk branches/collectd-3.9
octo@leeloo:~/collectd $ svn cp tags/collectd-3.9.2 branches/collectd-3.9
octo@leeloo:~/collectd $ svn cp tags/collectd-3.8.5 branches/collectd-3.8
octo@leeloo:~/collectd $ svn cp tags/collectd-3.8.5 branches/collectd-3.8
octo@huhu:~/collectd $ svn merge -r717:718 trunk tags/collectd-3.9.2
Bumped version to 3.9.2
Merged changelog entries from versions 3.8.5 and 3.9.1
Fixed the nasty bug in the ping plugin: The sequence wasn't checked correctly. Argh.
Removed `trunk/src/libping/', since it's obsolete.
Updated ChangeLog; also added version 3.9.1
Added a config option to the traffic plugin to ignore certain interfaces. Thanks to Sune Marcher for the patch.
Changed the build system to
- only check for libkvm and libdevstat if libstatgrab is installed
- only link against the above libraries if libstatgrab is present.
- only check for libkvm and libdevstat if libstatgrab is installed
- only link against the above libraries if libstatgrab is present.
Corrected/removed fixme-note.
A first port of the `swap' plugin to Mach/Mac OS X