Code

git.git
18 years agols-files --others --directory: fix a bug with index entry ordering
Junio C Hamano [Sat, 7 Jan 2006 22:32:09 +0000 (14:32 -0800)]
ls-files --others --directory: fix a bug with index entry ordering

When both howto-index.sh and howto/make-dist.txt exist under
Documentation/ directory, dir_exists() mistakenly checked it
without the trailing slash to see if there was something under
Documentation/howto directory, and did not realize there was,
because '-' sorts earlier than '/' and cache_name_pos() finds
howto-index.sh, which is not under howto/ directory.  This
caused --others --directory to show it which was incorrect.

Check the directory name with the trailing slash, because having
an entry that has such as a prefix is what we are looking for.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agols-files -o: optionally skip showing the contents in "untracked" directories
Linus Torvalds [Wed, 4 Jan 2006 21:31:25 +0000 (13:31 -0800)]
ls-files -o: optionally skip showing the contents in "untracked" directories

Darrin Thompson notes that git-ls-files -o reports all the unknown
files it finds in a work area.  Subversion and probably other systems
"simply ignore all the files and directories inside an unknown
directory and just note the directory as unknown."

With --directory option, ls-files --others shows untracked directories
without descending into them.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-fetch: auto-following tags.
Junio C Hamano [Sat, 7 Jan 2006 08:48:04 +0000 (00:48 -0800)]
git-fetch: auto-following tags.

I added things to ls-remote so that Cogito can auto-follow tags
easily and correctly a while ago, but git-fetch did not use the
facility.  Recently added git-describe command relies on
repository keeping up-to-date set of tags, which made it much
more attractive to automatically follow tags, so we do that as
well.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMake GIT-VERSION-GEN tolerate missing git describe command
John Ellson [Fri, 30 Dec 2005 16:23:17 +0000 (11:23 -0500)]
Make GIT-VERSION-GEN tolerate missing git describe command

I think it is probably a bug that "git non_existent_command"
returns its error message to stdout without an error, where
"git-non_existent_command" behaves differently and does return an
error.

Older versions of git did not implement "git describe"  and
GIT-VERSION-GEN produces an empty version string if run on
a system with such a git installed.  The consequence
is that "make rpm" fails.

This patch fixes GIT-VERSION-GEN so that it works in the
absence of a working "git describe"

Signed-off-by: John Ellson <ellson@research.att.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge fixes up to GIT 1.0.7
Junio C Hamano [Fri, 6 Jan 2006 04:54:42 +0000 (20:54 -0800)]
Merge fixes up to GIT 1.0.7

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoGIT 1.0.7 v1.0.7
Junio C Hamano [Fri, 6 Jan 2006 04:52:50 +0000 (20:52 -0800)]
GIT 1.0.7

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix git-symbolic-ref typo in git.txt.
Jon Loeliger [Tue, 3 Jan 2006 14:38:15 +0000 (08:38 -0600)]
Fix git-symbolic-ref typo in git.txt.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit: grok 'help' to mean '--help'.
Andreas Ericsson [Tue, 3 Jan 2006 09:53:54 +0000 (10:53 +0100)]
git: grok 'help' to mean '--help'.

Most other scm's understand it, most users expect it and it's an easy fix.

Signed-off-by: Andreas Ericsson <ae@op5.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoDocumentation/git-svnimport: document -T and -t switches correctly
Eric Wong [Sun, 1 Jan 2006 21:32:53 +0000 (13:32 -0800)]
Documentation/git-svnimport: document -T and -t switches correctly

The -T and -t switches are swapped in the documentation and actual
code.  I've made the documentation match the code.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosvnimport: support repositories requiring SSL authentication
Eric Wong [Sun, 1 Jan 2006 21:25:47 +0000 (13:25 -0800)]
svnimport: support repositories requiring SSL authentication

I looked at svn-mirror to see how it did this, seems about right.
"It works for me" when using it against https://svn.musicpd.org

tested command-line: git-svnimport -C mpc -i -m -v  \
-T mpc/trunk -b mpc/branches -t mpc/tags https://svn.musicpd.org

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agot3300: skip when filesystem does not like TAB in filenames.
Junio C Hamano [Fri, 6 Jan 2006 04:14:40 +0000 (20:14 -0800)]
t3300: skip when filesystem does not like TAB in filenames.

Instead of checking Cygwin explicitly, see if the filesystem lets us
create funny filenames.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoformat-patch/commit: Quote single quote in the author name properly.
Junio C Hamano [Fri, 6 Jan 2006 03:50:37 +0000 (19:50 -0800)]
format-patch/commit: Quote single quote in the author name properly.

Noticed by Kyle McMartin.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-fetch --tags: reject malformed tags.
Junio C Hamano [Fri, 6 Jan 2006 03:42:12 +0000 (19:42 -0800)]
git-fetch --tags: reject malformed tags.

When the other end was prepared with older git and has tags that
do not follow the naming convention (see check-ref-format), do not
barf but simply reject to copy them.

Initial fix by Simon Richter, but done differently.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoWrap synopsis lines and use [verse] to keep formatting
Jonas Fonseca [Sat, 31 Dec 2005 17:37:15 +0000 (18:37 +0100)]
Wrap synopsis lines and use [verse] to keep formatting

In addition, also fixes a few synopses to be more consistent and a gitlink.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agouse GIT_DIR instead of /var/tmp
Alex Riesen [Thu, 5 Jan 2006 11:52:07 +0000 (12:52 +0100)]
use GIT_DIR instead of /var/tmp

Not every system (will not one microsoft windows system) have /var/tmp,
whereas using GIT_DIR for random temporary files is more or less established.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: check, if t/trash directory was successfully created
Alex Riesen [Thu, 5 Jan 2006 11:57:36 +0000 (12:57 +0100)]
trivial: check, if t/trash directory was successfully created

and was successfully entered. Otherwise git-init-db will create it directly
in the working directory (t/) which can be dangerous.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: .gitignore precompiled python modules
Alex Riesen [Thu, 5 Jan 2006 16:38:58 +0000 (17:38 +0100)]
trivial: .gitignore precompiled python modules

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: use git-repo-config to detect how to run tests in the test repository
Alex Riesen [Thu, 5 Jan 2006 11:55:58 +0000 (12:55 +0100)]
trivial: use git-repo-config to detect how to run tests in the test repository

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: use git-repo-config to detect if the test can be run on the repository
Alex Riesen [Thu, 5 Jan 2006 11:55:03 +0000 (12:55 +0100)]
trivial: use git-repo-config to detect if the test can be run on the repository

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: remove the dots at the end of file names from merge-one-file
Alex Riesen [Thu, 5 Jan 2006 11:46:16 +0000 (12:46 +0100)]
trivial: remove the dots at the end of file names from merge-one-file

to make the output more friendly to mouse copy-paste.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: clarify, what are the config's user.name and user.email about
Alex Riesen [Thu, 5 Jan 2006 11:44:18 +0000 (12:44 +0100)]
trivial: clarify, what are the config's user.name and user.email about

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: typo in git-commit.sh
Alex Riesen [Thu, 5 Jan 2006 11:44:59 +0000 (12:44 +0100)]
trivial: typo in git-commit.sh

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agouse result of open(2) to check for presence
Alex Riesen [Thu, 5 Jan 2006 11:43:34 +0000 (12:43 +0100)]
use result of open(2) to check for presence

Not that the stat against open race would matter much in this context,
but that simplifies
the code a bit. Also some diagnostics added (why the open failed)

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agofix potential deadlock in create_one_file
Alex Riesen [Thu, 5 Jan 2006 09:00:12 +0000 (10:00 +0100)]
fix potential deadlock in create_one_file

It can happen if the temporary file already exists (i.e. after a panic
and reboot).

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: O_EXCL makes O_TRUNC redundant
Alex Riesen [Thu, 5 Jan 2006 08:58:06 +0000 (09:58 +0100)]
trivial: O_EXCL makes O_TRUNC redundant

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotrivial: retval of waitpid is not errno
Alex Riesen [Thu, 5 Jan 2006 08:56:37 +0000 (09:56 +0100)]
trivial: retval of waitpid is not errno

...but is used as such and passed to strerror.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix nasty approxidate bug
Linus Torvalds [Thu, 5 Jan 2006 03:33:55 +0000 (19:33 -0800)]
Fix nasty approxidate bug

Stupid me.

If approxidate ends up with a month that is ahead of the current month, it
decrements the year to last year.

Which is correct, and means that "last december" does the right thing.

HOWEVER. It should only do so if the year is the same as the current year.

Without this fix, "5 days ago" ends up being in 2004, because it first
decrements five days, getting us to December 2005 (correct), but then it
also ends up decrementing the year once more to turn that December into
"last year" (incorrect, since it already _was_ last year).

Duh. Pass me a donut.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAIX compile fix for repo-config.c
Amos Waterland [Thu, 5 Jan 2006 00:31:02 +0000 (19:31 -0500)]
AIX compile fix for repo-config.c

AIX 5 has a /usr/include/regex.h containing this code:

 #ifdef  _NO_PROTO
 extern  char    *regex();
 extern  char    *regcmp();
 #else /* _NO_PROTO */
 extern  char    *regex(const char *, const char *, ...);
 extern  char    *regcmp(const char *, ...);
 #endif  /* _NO_PROTO */

This means that repo-config.c is trying to redefine the `regex' symbol.
Here is a simple patch that just uses `regexp' as the symbol name instead.

Signed-off-by: Amos Waterland <apw@us.ibm.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-init-db(1): Describe --shared and the idempotent nature of init-db
Jonas Fonseca [Sat, 31 Dec 2005 17:30:25 +0000 (18:30 +0100)]
git-init-db(1): Describe --shared and the idempotent nature of init-db

Based on the recent discussion on the mailing list.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years ago?alloc: do not return NULL when asked for zero bytes
Junio C Hamano [Thu, 29 Dec 2005 09:31:26 +0000 (01:31 -0800)]
?alloc: do not return NULL when asked for zero bytes

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocode comments: spell
Junio C Hamano [Thu, 29 Dec 2005 09:30:08 +0000 (01:30 -0800)]
code comments: spell

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoDocumentation: spell.
Junio C Hamano [Thu, 29 Dec 2005 09:20:06 +0000 (01:20 -0800)]
Documentation: spell.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix skipping merge-order test with NO_OPENSSL=1.
Gerrit Pape [Wed, 28 Dec 2005 11:25:38 +0000 (12:25 +0100)]
Fix skipping merge-order test with NO_OPENSSL=1.

Move git-rev-list --merge-order usage check for 'OpenSSL not linked' after
test 1; we cannot trigger this unless we try to actually use --merge-order
by giving some ref, and we do not have any ref until we run the first test
to create commits.

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge fixes up to GIT 1.0.6
Junio C Hamano [Wed, 28 Dec 2005 02:13:30 +0000 (18:13 -0800)]
Merge fixes up to GIT 1.0.6

18 years agoGIT 1.0.6 v1.0.6
Junio C Hamano [Wed, 28 Dec 2005 02:08:58 +0000 (18:08 -0800)]
GIT 1.0.6

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosend-pack/receive-pack: allow errors to be reported back to pusher.
Junio C Hamano [Mon, 26 Dec 2005 07:18:37 +0000 (23:18 -0800)]
send-pack/receive-pack: allow errors to be reported back to pusher.

This updates the protocol between git-send-pack/git-receive-pack
in a backward compatible way to allow failures at the receiving
end to be propagated back to the sender.  Most notably, versions
of git-push before this could not notice if the update hook on
the receiving end refused to update the ref for its own policy
reasons.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMakefile: use git-describe to mark the git version.
Junio C Hamano [Tue, 27 Dec 2005 22:40:17 +0000 (14:40 -0800)]
Makefile: use git-describe to mark the git version.

Note: with this commit, the GIT maintainer workflow must change.
GIT-VERSION-GEN is now the file to munge when the default
version needs to be changed, not Makefile.  The tag needs to be
pushed into the repository to build the official tarball and
binary package beforehand.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-describe: documentation.
Junio C Hamano [Wed, 28 Dec 2005 00:10:56 +0000 (16:10 -0800)]
git-describe: documentation.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-describe: still prefer annotated tag under --all and --tags
Junio C Hamano [Wed, 28 Dec 2005 00:09:37 +0000 (16:09 -0800)]
git-describe: still prefer annotated tag under --all and --tags

Even though --all and --tags can be used to include non
annotated tags in the reference point candidates, prefer to use
annotated tags if there are more than one refs that name the
same commit.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-describe: --tags and --abbrev
Junio C Hamano [Tue, 27 Dec 2005 22:40:17 +0000 (14:40 -0800)]
git-describe: --tags and --abbrev

With --tags, not just annontated tags, but also any ref under
refs/tags/ are used to name the revision.

The number of digits is configurable with the --abbrev=<n> option.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-describe: use find_unique_abbrev()
Junio C Hamano [Tue, 27 Dec 2005 22:49:22 +0000 (14:49 -0800)]
git-describe: use find_unique_abbrev()

Just in case 8 hexadecimal digits are not enough.  We could use
shorter default if we wanted to.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-describe: really prefer tags only.
Junio C Hamano [Tue, 27 Dec 2005 22:36:49 +0000 (14:36 -0800)]
git-describe: really prefer tags only.

Often there are references other than annotated tags under
refs/tags hierarchy that are used to "keep things just in case".
default to use annotated tags only, still leaving the option to
use any ref with --all flag.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAdd a "git-describe" command
Linus Torvalds [Sat, 24 Dec 2005 21:50:45 +0000 (13:50 -0800)]
Add a "git-describe" command

It shows you the most recent tag that is reachable from a particular
commit is.

Maybe this is something that "git-name-rev" should be taught to do,
instead of having a separate command for it. Regardless, I find it useful.

What it does is to take any random commit, and "name" it by looking up the
most recent commit that is tagged and reachable from that commit. If the
match is exact, it will just print out that ref-name directly. Otherwise
it will print out the ref-name, followed by the 8-character "short SHA".

IOW, with something like Junios current tree, I get:

[torvalds@g5 git]$ git-describe parent
refs/tags/v1.0.4-g2414721b

ie the current head of my "parent" branch (ie Junio) is based on v1.0.4,
but since it has a few commits on top of that, it has added the git hash
of the thing to the end: "-g" + 8-char shorthand for the commit
2414721b194453f058079d897d13c4e377f92dc6.

Doing a "git-describe" on a tag-name will just show the full tag path:

[torvalds@g5 git]$ git-describe v1.0.4
refs/tags/v1.0.4

unless there are _other_ tags pointing to that commit, in which case it
will just choose one at random.

This is useful for two things:

 - automatic version naming in Makefiles, for example. We could use it in
   git itself: when doing "git --version", we could use this to give a
   much more useful description of exactly what version was installed.

 - for any random commit (say, you use "gitk <pathname>" or
   "git-whatchanged" to look at what has changed in some file), you can
   figure out what the last version of the repo was. Ie, say I find a bug
   in commit 39ca371c45b04cd50d0974030ae051906fc516b6, I just do:

[torvalds@g5 linux]$ git-describe 39ca371c45b04cd50d0974030ae051906fc516b6
refs/tags/v2.6.14-rc4-g39ca371c

   and I now know that it was _not_ in v2.6.14-rc4, but was presumably in
   v2.6.14-rc5.

The latter is useful when you want to see what "version timeframe" a
commit happened in.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoDo not mark tags fetched via --tags flag as mergeable
Junio C Hamano [Tue, 27 Dec 2005 19:52:51 +0000 (11:52 -0800)]
Do not mark tags fetched via --tags flag as mergeable

Otherwise "git pull --tags" would mistakenly try to merge all of
them, which is never what the user wants.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix bogus tests on rev-list output.
Junio C Hamano [Tue, 27 Dec 2005 19:06:43 +0000 (11:06 -0800)]
Fix bogus tests on rev-list output.

These tests seem to mean checking the output with expected
result, but was not doing its handrolled test helper function.

Also fix the guard to workaround wc output that have whitespace
padding, which was broken but not exposed because the test was
not testing it ;-).

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoGuard a test against wc that pads its output with whitespace
Junio C Hamano [Tue, 27 Dec 2005 18:51:23 +0000 (10:51 -0800)]
Guard a test against wc that pads its output with whitespace

Spotted by Johannes.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocopy_fd: close ifd on error
Sam Ravnborg [Tue, 27 Dec 2005 08:19:05 +0000 (09:19 +0100)]
copy_fd: close ifd on error

In copy_fd when write fails we ought to close input file descriptor.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge fixes up to GIT 1.0.5
Junio C Hamano [Tue, 27 Dec 2005 02:45:30 +0000 (18:45 -0800)]
Merge fixes up to GIT 1.0.5

18 years agoGIT 1.0.5 v1.0.5
Junio C Hamano [Tue, 27 Dec 2005 02:44:15 +0000 (18:44 -0800)]
GIT 1.0.5

Minor fixes.

Starting from this one I won't be touching debian/ directory
since the official maintainer seems to be reasonably quick to
package up things.  The packaging procedure used there seems to
be quite different from what I have, so I'd like to avoid
potential confusion and reduce work by the official maintainer
and myself.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoHandle symlinks graciously
Johannes Schindelin [Mon, 26 Dec 2005 21:31:42 +0000 (22:31 +0100)]
Handle symlinks graciously

This patch converts a stat() to an lstat() call, thereby fixing the case
when the date of a symlink was not the same as the one recorded in the
index. The included test case demonstrates this.

This is for the case that the symlink points to a non-existing file. If
the file exists, worse things than just an error message happen.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agot5300: avoid false failures.
Junio C Hamano [Tue, 27 Dec 2005 02:23:41 +0000 (18:23 -0800)]
t5300: avoid false failures.

Johannes found that the test has 1/256 chance of falsely
producing an uncorrupted idx file, causing the check to detect
corruption fail.  Now we have 1/2^160 chance of false failure
;-).

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoavoid asking ?alloc() for zero bytes.
Junio C Hamano [Mon, 26 Dec 2005 20:34:56 +0000 (12:34 -0800)]
avoid asking ?alloc() for zero bytes.

Avoid asking for zero bytes when that change simplifies overall
logic.  Later we would change the wrapper to ask for 1 byte on
platforms that return NULL for zero byte request.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoshort circuit out of a few places where we would allocate zero bytes
Eric Wong [Sat, 24 Dec 2005 12:12:43 +0000 (04:12 -0800)]
short circuit out of a few places where we would allocate zero bytes

dietlibc versions of malloc, calloc and realloc all return NULL if
they're told to allocate 0 bytes, causes the x* wrappers to die().

There are several more places where these calls could end up asking
for 0 bytes, too...

Maybe simply not die()-ing in the x* wrappers if 0/NULL is returned
when the requested size is zero is a safer and easier way to go.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/checkout'
Junio C Hamano [Mon, 26 Dec 2005 07:30:15 +0000 (23:30 -0800)]
Merge branch 'jc/checkout'

18 years agoTutorial: mention shared repository management.
Junio C Hamano [Fri, 23 Dec 2005 23:27:18 +0000 (15:27 -0800)]
Tutorial: mention shared repository management.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-init-db: initialize shared repositories with --shared
Johannes Schindelin [Thu, 22 Dec 2005 22:19:37 +0000 (23:19 +0100)]
git-init-db: initialize shared repositories with --shared

Now you can say

git-init-db --shared

if you want other users to be able to push into that repository.

[jc: info/ and objects/info/ need to be group writable if the
 repository is shared --- otherwise packs and refs files cannot
 be updated.]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoIntroduce core.sharedrepository
Johannes Schindelin [Thu, 22 Dec 2005 22:13:56 +0000 (23:13 +0100)]
Introduce core.sharedrepository

If the config variable 'core.sharedrepository' is set, the directories

$GIT_DIR/objects/
$GIT_DIR/objects/??
$GIT_DIR/objects/pack
$GIT_DIR/refs
$GIT_DIR/refs/heads
$GIT_DIR/refs/heads/tags

are set group writable (and g+s, since the git group may be not the primary
group of all users).

Since all files are written as lock files first, and then moved to
their destination, they do not have to be group writable.  Indeed, if
this leads to problems you found a bug.

Note that -- as in my first attempt -- the config variable is set in the
function which checks the repository format. If this were done in
git_default_config instead, a lot of programs would need to be modified
to call git_config(git_default_config) first.

[jc: git variables should be in environment.c unless there is a
 compelling reason to do otherwise.]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge fixes up to GIT 1.0.4
Junio C Hamano [Sat, 24 Dec 2005 08:16:56 +0000 (00:16 -0800)]
Merge fixes up to GIT 1.0.4

18 years agoGIT 1.0.4 v1.0.4
Junio C Hamano [Sat, 24 Dec 2005 08:02:08 +0000 (00:02 -0800)]
GIT 1.0.4

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agomailinfo: iconv does not like "latin-1" -- should spell it "latin1"
Junio C Hamano [Sat, 24 Dec 2005 07:56:52 +0000 (23:56 -0800)]
mailinfo: iconv does not like "latin-1" -- should spell it "latin1"

This was a stupid typo that did not follow

http://www.iana.org/assignments/character-sets

Long noticed but neglected by JC, but finally reported by
Marco.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agols-files --full-name: usage string and documentation.
Junio C Hamano [Fri, 23 Dec 2005 23:51:33 +0000 (15:51 -0800)]
ls-files --full-name: usage string and documentation.

Somehow this option was not mentioned anywhere in the
documentation nor the usage string.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agomerge --no-commit: tweak message
Junio C Hamano [Fri, 23 Dec 2005 23:48:09 +0000 (15:48 -0800)]
merge --no-commit: tweak message

We did not distinguish the case the user asked not to make a
commit with --no-commit flag and the automerge failed.  Tell
these cases apart and phrase dying message differently.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-clone: do not special case dumb http.
Junio C Hamano [Fri, 23 Dec 2005 00:01:46 +0000 (16:01 -0800)]
git-clone: do not special case dumb http.

Underlying http-fetch is supposed to be capable of handling
packed repositories just fine, so no need to special case it in
the wrapper script.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoshow-branch: usability updates.
Junio C Hamano [Fri, 23 Dec 2005 20:47:18 +0000 (12:47 -0800)]
show-branch: usability updates.

This does three things:

 . It simplifies the logic to handle the case in which no
   refs are given on the command line, and fixes the bug
   when only "--heads" is specified.  Earlier we showed
   them twice.

 . It avoids to add the same ref twice.

 . It sorts the glob result (e.g. "git show-branch
   'tags/v1.0*'") according to a more version friendly
   sort order.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocheck_packed_git_idx(): check integrity of the idx file itself.
Junio C Hamano [Fri, 23 Dec 2005 06:57:20 +0000 (22:57 -0800)]
check_packed_git_idx(): check integrity of the idx file itself.

Although pack-check.c had routine to verify the checksum for the
pack index file itself, the core did not check it before using
it.

This is stolen from the patch to tighten packname requirements.

Signed-off-by: Junio C Hamano <junkio@cox.net>
(cherry picked from 797bd6f490c91c07986382b9f268e0df712cb246 commit)

18 years agoAdjust to ls-tree --full-name when run from a subdirectory.
Junio C Hamano [Fri, 23 Dec 2005 22:10:16 +0000 (14:10 -0800)]
Adjust to ls-tree --full-name when run from a subdirectory.

A proposed change to show cwd relative paths by default from
ls-tree when run from a subdirectory means we would need to
give --full-name option to it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agols-tree: chomp leading directories when run from a subdirectory
Junio C Hamano [Fri, 23 Dec 2005 21:39:30 +0000 (13:39 -0800)]
ls-tree: chomp leading directories when run from a subdirectory

When run from a subdirectory, even though we filtered the output
based on where we were using pathspec, we wrote out the
repository relative paths, not subtree relative paths.  This
changes things so that it shows only the current subdirectory
relative paths.

For example, in Documentation subdirectory of git itself, this
used to be the case:

    $ git-ls-tree --name-only HEAD | grep how
    Documentation/git-show-branch.txt
    Documentation/git-show-index.txt
    Documentation/howto-index.sh
    Documentation/howto

But now it does this instead:

    $ git-ls-tree --name-only HEAD | grep how
    git-show-branch.txt
    git-show-index.txt
    howto-index.sh
    howto

There are two things to keep in mind.

1. This shows nothing.

   $ git-ls-tree --name-only HEAD ../ppc/

   This is to make things consistent with ls-files, which
   refuses relative path that goes uplevel.

2. These show things in full repository relative paths.  In this
   case, paths outside the current subdirectory are also shown.

   $ git-ls-tree --name-only --full-name HEAD | grep how
   Documentation/git-show-branch.txt
   Documentation/git-show-index.txt
   Documentation/howto-index.sh
   Documentation/howto

   $ git-ls-tree --name-only --full-name HEAD ../ppc/
   ppc/sha1.c
   ppc/sha1.h
   ppc/sha1ppc.S

The flag --full-name gives the same behaviour as 1.0, so it
ought to be the default if we really care about the backward
compatibility, but in practice no Porcelain runs ls-tree from a
subdirectory yet, and without --full-name is more human
friendly, so hopefully the default being not --full-name would
be acceptable.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocheckout: sometimes work from a subdirectory.
Junio C Hamano [Fri, 23 Dec 2005 06:37:50 +0000 (22:37 -0800)]
checkout: sometimes work from a subdirectory.

git-checkout does two very different things, and what they
should do when run from subdirectory are quite different.

It does not make any sense to run the one that switches the
current head from anywhere other than the toplevel:

git-checkout [-f] <branch>
        git-checkout [-b <branch>] <committish>

We could of course chdir to top and do the whole-tree checkout
in git-checkout, but the point is the operation does not make
sense on a partial tree.  The whole tree is checked out.

The other form is to update the index file and working tree file
selectively:

git-checkout <treeish> <file>... ;# out of tree to index and file
        git-checkout -- <file>...  ;# out of index to file

This form _does_ make sense to run from subdirectory; and I
myself often wish we supported this.

So here is a patch to do both.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocheck_packed_git_idx(): check integrity of the idx file itself.
Junio C Hamano [Fri, 23 Dec 2005 06:57:20 +0000 (22:57 -0800)]
check_packed_git_idx(): check integrity of the idx file itself.

Although pack-check.c had routine to verify the checksum for the
pack index file itself, the core did not check it before using
it.

This is stolen from the patch to tighten packname requirements.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agorev-parse: --show-cdup
Junio C Hamano [Fri, 23 Dec 2005 06:35:38 +0000 (22:35 -0800)]
rev-parse: --show-cdup

When --show-prefix is useful, sometimes it is easier to cd up to
the toplevel of the tree.  This is equivalent to:

    git rev-parse --show-prefix | sed -e 's|[^/][^/]*|..|g'

but we do not have to invoke sed for that.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge in fixes up to 1.0.3 maintenance branch.
Junio C Hamano [Fri, 23 Dec 2005 02:19:03 +0000 (18:19 -0800)]
Merge in fixes up to 1.0.3 maintenance branch.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoGIT 1.0.3 v1.0.3
Junio C Hamano [Fri, 23 Dec 2005 02:14:31 +0000 (18:14 -0800)]
GIT 1.0.3

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-clone: Support changing the origin branch with -o
Johannes Schindelin [Thu, 22 Dec 2005 22:37:24 +0000 (23:37 +0100)]
git-clone: Support changing the origin branch with -o

Earlier, git-clone stored upstream's master in the branch named 'origin',
possibly overwriting an existing such branch.

Now you can change it by calling git-clone with '-o <other_name>'.

[jc: added ref format check, subdirectory safety, documentation
 and usage string.]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosha1_to_hex: properly terminate the SHA1
Johannes Schindelin [Thu, 22 Dec 2005 17:55:59 +0000 (18:55 +0100)]
sha1_to_hex: properly terminate the SHA1

sha1_to_hex() returns a pointer to a static buffer. Some of its users
modify that buffer by appending a newline character. Other users rely
on the fact that you can call

printf("%s", sha1_to_hex(sha1));

Just to be on the safe side, terminate the SHA1 in sha1_to_hex().

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix for http-fetch from file:// URLs
Nick Hengeveld [Thu, 22 Dec 2005 17:09:05 +0000 (09:09 -0800)]
Fix for http-fetch from file:// URLs

Recognize missing files when using http-fetch with file:// URLs

Signed-off-by: Nick Hengeveld <nickh@reactrix.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-format-patch should show the correct version
Johannes Schindelin [Thu, 22 Dec 2005 19:38:23 +0000 (20:38 +0100)]
git-format-patch should show the correct version

We want to record the version of the tools the patch was generated with.
While these tools could be rebuilt, git-format-patch stayed the same and
report the wrong version.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosend-pack: reword non-fast-forward error message.
Junio C Hamano [Thu, 22 Dec 2005 20:39:39 +0000 (12:39 -0800)]
send-pack: reword non-fast-forward error message.

Wnen refusing to push a head, we said cryptic "remote 'branch'
object X does not exist on local" or "remote ref 'branch' is not
a strict subset of local ref 'branch'".  That was gittish.

Since the most likely reason this happens is because the pushed
head was not up-to-date, clarify the error message to say that
straight, and suggest pulling first.

First noticed by Johannes and seconded by Andreas.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoGIT: Support [address] in URLs
YOSHIFUJI Hideaki / 吉藤英明 [Wed, 21 Dec 2005 10:23:42 +0000 (19:23 +0900)]
GIT: Support [address] in URLs

Allow IPv6address/IPvFuture enclosed by [] in URLs, like:
   git push '[3ffe:ffff:...:1]:GIT/git'
or
   git push 'ssh://[3ffe:ffff:...:1]/GIT/git'

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agowhatchanged: customize diff-tree output
Junio C Hamano [Thu, 22 Dec 2005 06:25:00 +0000 (22:25 -0800)]
whatchanged: customize diff-tree output

This allows the configuration item whatchanged.difftree to
control the output from git-whatchanged command.  For example:

[whatchanged]
         difftree = --pretty=fuller --name-status -M

does rename detection, shows the commit header in "fuller"
format and lists affected pathnames and the kind of changes to
them.

When no such configuration item exists, the output format
defaults to "--pretty -M --abbrev".

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'fixes'
Junio C Hamano [Thu, 22 Dec 2005 07:48:31 +0000 (23:48 -0800)]
Merge branch 'fixes'

18 years ago\n usage in stderr output
Alex Riesen [Thu, 15 Dec 2005 07:47:30 +0000 (08:47 +0100)]
\n usage in stderr output

fprintf and die sometimes have missing/excessive "\n" in their arguments,
correct the strings where I think it would be appropriate.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-pack-redundant: speed and memory usage improvements
Lukas Sandström [Tue, 20 Dec 2005 20:05:54 +0000 (21:05 +0100)]
git-pack-redundant: speed and memory usage improvements

Slab allocation of llist entries gives some speed improvements.

Not computing the pack_list permutaions all at once reduces memory
usage greatly on repositories with many packs.

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agomerge-recursive: conflicting rename case.
Junio C Hamano [Mon, 12 Dec 2005 00:44:05 +0000 (16:44 -0800)]
merge-recursive: conflicting rename case.

This changes the way the case two branches rename the same path
to different paths is handled.  Earlier, the code removed the
original path and added both destinations to the index at
stage0.  This commit changes it to leave the original path at
stage1, and two destination paths at stage2 and stage3,
respectively.

[jc: I am not really sure if this makes much difference in the
real life merge situations.  What should happen when our branch
renames A to B and M to N, while their branch renames A to M?
That is, M remains in our tree as is.]

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoVersioning scheme changes.
Junio C Hamano [Thu, 22 Dec 2005 06:33:37 +0000 (22:33 -0800)]
Versioning scheme changes.

HPA suggests it is simply silly to imitate Linux versioning
scheme where the leading "2" does not mean anything anymore, and
I tend to agree.

The first feature release after 1.0.0 will be 1.1.0, and the
development path leading to 1.1.0 will carry 1.0.GIT as the
version number from now on.  Similarly, the third maintenance
release that follows 1.0.0 will not be 1.0.0c as planned, but
will be called 1.0.3.  The "maint" branch will merge in fixes
and immediately tagged, so there is no need for 1.0.2.GIT that
is in between 1.0.2 (aka 1.0.0b) and 1.0.3.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agosanity check in add_packed_git()
Pavel Roskin [Wed, 21 Dec 2005 23:47:09 +0000 (18:47 -0500)]
sanity check in add_packed_git()

add_packed_git() tries to get the pack SHA1 by parsing its name.  It may
access uninitialized memory for packs with short names.

Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'fixes'
Junio C Hamano [Wed, 21 Dec 2005 22:00:47 +0000 (14:00 -0800)]
Merge branch 'fixes'

18 years agoGIT 1.0.0b v1.0.0b v1.0.2
Junio C Hamano [Wed, 21 Dec 2005 21:51:51 +0000 (13:51 -0800)]
GIT 1.0.0b

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoserver-info: skip empty lines.
Junio C Hamano [Wed, 21 Dec 2005 21:48:47 +0000 (13:48 -0800)]
server-info: skip empty lines.

Now we allow an empty line in objects/info/packs file, recognize
that and stop complaining.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years ago[PATCH] quote.c: Make loop control more readable.
Pavel Roskin [Wed, 21 Dec 2005 20:35:48 +0000 (15:35 -0500)]
[PATCH] quote.c: Make loop control more readable.

quote_c_style_counted() in quote.c uses a hard-to-read  construct.
Convert this to a more traditional form of the for loop.

Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoGIT 1.0.0a v1.0.0a v1.0.1
Junio C Hamano [Wed, 21 Dec 2005 21:17:54 +0000 (13:17 -0800)]
GIT 1.0.0a

    - Avoid misleading success message on error (Johannes)
    - objects/info/packs: work around bug in http-fetch.c::fetch_indices()
    - http-fetch.c: fix objects/info/pack parsing.
    - An off-by-one bug found by valgrind (Pavel)

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAn off-by-one bug found by valgrind
Pavel Roskin [Wed, 21 Dec 2005 20:35:48 +0000 (15:35 -0500)]
An off-by-one bug found by valgrind

Insufficient memory is allocated in index-pack.c to hold the *.idx name.
One more byte should be allocated to hold the terminating 0.

Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAvoid misleading success message on error
Johannes Schindelin [Wed, 21 Dec 2005 16:53:29 +0000 (17:53 +0100)]
Avoid misleading success message on error

When a push fails (for example when the remote head does not fast forward
to the desired ref) it is not correct to print "Everything up-to-date".

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agohttp-fetch.c: fix objects/info/pack parsing.
Junio C Hamano [Wed, 21 Dec 2005 20:10:10 +0000 (12:10 -0800)]
http-fetch.c: fix objects/info/pack parsing.

It failed to register the last pack in the objects/info/packs
file.  Also it had an independent overrun error.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoobjects/info/packs: work around bug in http-fetch.c::fetch_indices()
Junio C Hamano [Wed, 21 Dec 2005 20:09:17 +0000 (12:09 -0800)]
objects/info/packs: work around bug in http-fetch.c::fetch_indices()

The code to fetch pack index files in deployed clients have a
bug that causes it to ignore the pack file on the last line of
objects/info/packs file, so append an empty line to work it
around.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoPost 1.0.0 development track.
Junio C Hamano [Wed, 21 Dec 2005 20:12:26 +0000 (12:12 -0800)]
Post 1.0.0 development track.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoGIT 1.0.0 v1.0.0
Junio C Hamano [Wed, 21 Dec 2005 08:01:00 +0000 (00:01 -0800)]
GIT 1.0.0

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMake "git-send-pack" less verbose by default
Linus Torvalds [Wed, 21 Dec 2005 02:13:02 +0000 (18:13 -0800)]
Make "git-send-pack" less verbose by default

It used to make sense to have git-send-pack talk about the things it sent
when (a) it was a new program and (b) nobody had a lot of tags and
branches.

These days, it's just distracting to see tons of

'refs/tags/xyz': up-to-date
...

when updating a remote repo.

So shut it up by default, and add a "--verbose" flag for those who really
want to see it.

Also, since this makes he case of everything being up-to-date just totally
silent, make it say "Everything up-to-date" if no refs needed updating.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoA shared repository should be writable by members.
Junio C Hamano [Wed, 21 Dec 2005 04:54:28 +0000 (20:54 -0800)]
A shared repository should be writable by members.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoce_smudge_racily_clean_entry: explain why it works.
Junio C Hamano [Tue, 20 Dec 2005 22:18:47 +0000 (14:18 -0800)]
ce_smudge_racily_clean_entry: explain why it works.

This is a tricky code and warrants extra commenting.  I wasted
30 minutes trying to break it until I realized why it works.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoRacy GIT (part #2)
Junio C Hamano [Tue, 20 Dec 2005 20:12:18 +0000 (12:12 -0800)]
Racy GIT (part #2)

The previous round caught the most trivial case well, but broke
down once index file is updated again.  Smudge problematic
entries (they should be very few if any under normal interactive
workflow) before writing a new index file out.

Signed-off-by: Junio C Hamano <junkio@cox.net>