git-notify: New subroutine for column alignment
Most notifications include an ASCII "table" with two columns. The
formatting of these columns is now handled by the new format_table()
subroutine, so that the alignment can easily be changed in the future.
Most notifications include an ASCII "table" with two columns. The
formatting of these columns is now handled by the new format_table()
subroutine, so that the alignment can easily be changed in the future.
git-notify: Ignore "empty" commits
Omit notifications regarding commits which don't change the tree
whatsoever.
Omit notifications regarding commits which don't change the tree
whatsoever.
git-notify: Remove unused tag notification code
The code which handles notifications regarding tags was unused, as only
objects listed by git-rev-list(1) are considered, and git-rev-list(1)
never spits out the sha1 of a tag object.
The code which handles notifications regarding tags was unused, as only
objects listed by git-rev-list(1) are considered, and git-rev-list(1)
never spits out the sha1 of a tag object.
git-notify: Save author without trailing space
Adjust the regular expression which catches the commit author name so
that it doesn't include the space character which follows that name.
Adjust the regular expression which catches the commit author name so
that it doesn't include the space character which follows that name.
Import git-update-mirror and git-notify
Import the (self-written) git-update-mirror script, which updates clones
of Git repositories and then calls git-notify (in just the same way as a
post-receive hook would be called by Git). The git-notify script is
imported from git://source.winehq.org/git/tools.git (commit: 03d66f34)
and generates notifications on repository changes. We'll use these
scripts for generating our commit e-mails.
Import the (self-written) git-update-mirror script, which updates clones
of Git repositories and then calls git-notify (in just the same way as a
post-receive hook would be called by Git). The git-notify script is
imported from git://source.winehq.org/git/tools.git (commit: 03d66f34)
and generates notifications on repository changes. We'll use these
scripts for generating our commit e-mails.
Fix usage of repeated -o options in check_snmp
Set proper network byte order for icmp_id and icmp_seq in icmp packets
Increment per-host sequence in check_icmp
Change default for SFSNAP_DEST
Correcting name and email address
Enhancements to tools/sfsnapshotgit
Using $srcdir is the proper way to go
Add sfsnapshotgit
Allow custom versions with the release file...
Updated documentation re: no equals sign and single quote
Updated NEWS file with docs changes
Test, again
Test
Oops - wrong author/bug in last commit!
Fix check_ircd binding to wrong interface (#668778)
Update RELEASING document with proper tag creation and push commands
Prep for 1.4.14 release
Ensure dirhandle is closed (Duncan Ferguson)
Fix skip number
Add a test that succeeds on check_snmp v1.4.13. Newer versions skip additional
lines so this new test fails on the current head.
Note: check_snmp v1.4.13 with multi-line strings return somewhat v3 output;
it's not exactly what the specs say but it doesn't appears to break them
either. The fix could eventually supports both v2 and v3 output formats.
lines so this new test fails on the current head.
Note: check_snmp v1.4.13 with multi-line strings return somewhat v3 output;
it's not exactly what the specs say but it doesn't appears to break them
either. The fix could eventually supports both v2 and v3 output formats.
Fix check_snmp passing single-quotes as -m argument when it should be empty
check_snmp: Add some verbose output and tests
Add tests using custom snmp agent
Only multi-line string test for now (regression test), counter rollover
tests planed with my snmp_counters_new branch.
NB: 64bit counters are broken in NetSNMP::agent from NetSNMP version 5.4.1
and lower, but might come in handy one day
Only multi-line string test for now (regression test), counter rollover
tests planed with my snmp_counters_new branch.
NB: 64bit counters are broken in NetSNMP::agent from NetSNMP version 5.4.1
and lower, but might come in handy one day
Fix check_snmp Timetick test with <1 day uptime
Add accidentally removed line plus a note about the web copy
Merge changes from web
Updated links for exchange.nagios.org
pst3 compile with Sun Studio Compiler
Added example for check_cluster to alert if more than X non-OK states
Switch back to "use Test" and plain prints instead of diag()
Tinderbox output testing commit
Make output of "make test" more verbose
This is intended to make error fixing based on tinderbox output
easier.
This is intended to make error fixing based on tinderbox output
easier.
Fixed error in rtt/rta calculation in case of system clock problems
Time differences are now set to 0 in case of backward timejumps so there are no wrap-around problems any more.
The RTA calculation hopefully gets a more accurate value in these cases also.
Time differences are now set to 0 in case of backward timejumps so there are no wrap-around problems any more.
The RTA calculation hopefully gets a more accurate value in these cases also.
Fixed testcases for check_snmp, check_ifstatus and check_ifoperstatus when no snmp community is specified
The checks for invalid/unavailable hosts need a complete command line.
They failed on hosts where no community was specified. Now, an invalid community is used so
the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway.
The checks for invalid/unavailable hosts need a complete command line.
They failed on hosts where no community was specified. Now, an invalid community is used so
the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway.
15 years agoFurther test parameters and skip blocks for check_ifoperstatus.t. getTestparam change...
Further test parameters and skip blocks for check_ifoperstatus.t. getTestparam changes for check_ifstatus.t and ifoperstatus.t
Added snmp_interface and snmp_ifxtable test parameters to check_ifoperstatus.t.
Also getTestParameter calls for both plugins were converted to use three arguments
instead of undocumented >3 arg behaviour which led to redundant data in NPTest.cache.
Added snmp_interface and snmp_ifxtable test parameters to check_ifoperstatus.t.
Also getTestParameter calls for both plugins were converted to use three arguments
instead of undocumented >3 arg behaviour which led to redundant data in NPTest.cache.
Merge branch 'master' of ssh://PsychoTrahe@repo.or.cz/srv/git/nagiosplugins
renamed check_ifoperstatus' newly introdced -x to -P so it fits check_ifstatus
check_ifstatus already used -x so both plugins can use same short option, now.
to specify privacy protocol.
check_ifstatus already used -x so both plugins can use same short option, now.
to specify privacy protocol.
Fixed SNMPv3 behaviour of check_ifstatus. Added -P to define privprotocol (#2343438 - Robin Schroeder)
check_ifstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.
Additionally the -P argument was added to specify the privprotocol.
check_ifstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.
Additionally the -P argument was added to specify the privprotocol.
Added testcases for check_ifoperstatus
Added testcases for check_ifoperstatus. No SNMPv3 testing
included for now.
Added testcases for check_ifoperstatus. No SNMPv3 testing
included for now.
minor fixes to check_ifoperstatus
Minor output fixes for check_ifoperstatus.
Fixed typo so that -n now implies -I as documented.
Minor output fixes for check_ifoperstatus.
Fixed typo so that -n now implies -I as documented.
Use a more "natural" way of writing argument lists in extra-opts tests.
check_ifoperstatus is now more user friendly in case of missing arguments
Added proper usage messages in case of missing arguments.
Removed accidently committed Data::Dumper call.
Minor whitespace fixes.
Added proper usage messages in case of missing arguments.
Removed accidently committed Data::Dumper call.
Minor whitespace fixes.
Whitespace and indent fixes for check_ifoperstatus
15 years agoFixed SNMPv3 behaviour of check_ifoperstatus. Added -x to define privprotocol (#23434...
Fixed SNMPv3 behaviour of check_ifoperstatus. Added -x to define privprotocol (#2343438 - Robin Schroeder)
check_ifoperstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.
Additionally the -x argument was added to specify the privprotocol.
check_ifoperstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.
Additionally the -x argument was added to specify the privprotocol.
Fix the memory allocation for the thresholds data
Allocate the appropriate amount of memory for storing the thresholds
data. Before, we allocated the amount of memory required for storing a
_pointer_ to the thresholds data. This crashed (at least) check_mysql
when using its "-S" option on FreeBSD/amd64 (as reported and analyzed by
Nikita Kalabukhov - 2797757).
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Allocate the appropriate amount of memory for storing the thresholds
data. Before, we allocated the amount of memory required for storing a
_pointer_ to the thresholds data. This crashed (at least) check_mysql
when using its "-S" option on FreeBSD/amd64 (as reported and analyzed by
Nikita Kalabukhov - 2797757).
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Don't use the plain char type for data buffers
Buffers which are used for holding arbitrary data should be referenced
using pointers to void and accessed using pointers to unsigned char.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Buffers which are used for holding arbitrary data should be referenced
using pointers to void and accessed using pointers to unsigned char.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Whitespace indent fixes for check_pgsql
Fixed check_icmp compiler warnings by including float.h
Self defined DBL_MAX caused compiler warnings. Now float.h
which defines DBL_MAX is included.
Self defined DBL_MAX caused compiler warnings. Now float.h
which defines DBL_MAX is included.
Fixed --help output for warn and critical thresholds (sf.net #2796624, debian #530553)
check_icmp wrongly calculated the current thresholds in --help output.
check_icmp wrongly calculated the current thresholds in --help output.
Added verbose output to check_pgsql (#2799281 - Jun Kuriyama)
check_pgsql displayed the -v flag in help output, but didn't
accept the verbosity argument. Added -v and basic verbose output.
check_pgsql displayed the -v flag in help output, but didn't
accept the verbosity argument. Added -v and basic verbose output.
check_fping now supports passing target timeout and interval to fping (#2347686 - Martin Foster)
Added support for passing timeout and interval length to check_fping.
To protect compatibility, both options use fping's defaults if they
are not specified on the command line.
Added support for passing timeout and interval length to check_fping.
To protect compatibility, both options use fping's defaults if they
are not specified on the command line.
check_snmp: Make use of standard threshold functions
This patch makes use of standard threshold functions. This allows using
doubles as thresholds.
Since SNMP supports only integers, double precision numbers are only
printed when parsed from a STRING type.
In addition, support for printing properly Timeticks type has been added,
and the code has been thoroughly cleaned.
This patch makes use of standard threshold functions. This allows using
doubles as thresholds.
Since SNMP supports only integers, double precision numbers are only
printed when parsed from a STRING type.
In addition, support for printing properly Timeticks type has been added,
and the code has been thoroughly cleaned.
Fix whitespaces in check_snmp
Fixed wrong perfdata label for output traffic in check_mrtgtraf
check_mrtgtraf used the label "in" for both input and output traffic.
This fixed, now.
check_mrtgtraf used the label "in" for both input and output traffic.
This fixed, now.
Removed -n option in check_smtp's help and usage output (#2782784)
Check_smtp's help showed the -n/--nocommand options to not send an
SMTP command. This usage is covered by check_tcp and is thus not needed
in check_smtp.
Check_smtp's help showed the -n/--nocommand options to not send an
SMTP command. This usage is covered by check_tcp and is thus not needed
in check_smtp.
Whitespace changes only
Fix a few minor typos
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Talk about Git instead of CVS
Update the Developer Guidelines to reflect the fact that our development
is done using Git instead of CVS these days (as noted by Chris Pepper on
the "nagiosplug-devel" list).
While at it, apply another few minor cleanups.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Update the Developer Guidelines to reflect the fact that our development
is done using Git instead of CVS these days (as noted by Chris Pepper on
the "nagiosplug-devel" list).
While at it, apply another few minor cleanups.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Remove comments regarding former requirements
Don't explain why Libtool and Gettext are no longer needed. Libtool
actually is a requirement, as (at least) the M4 macros provided by
Libtool are needed for our Autotools setup. And the fact that Gettext
is no longer needed probably isn't that interesting for new developers.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Don't explain why Libtool and Gettext are no longer needed. Libtool
actually is a requirement, as (at least) the M4 macros provided by
Libtool are needed for our Autotools setup. And the fact that Gettext
is no longer needed probably isn't that interesting for new developers.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
Fixed typo in check_disk
15 years agoFixed crash from check_nt when -H unspecified or given multiple times (sf.net #273175...
Fixed crash from check_nt when -H unspecified or given multiple times (sf.net #2731755, debian #521097)
check_nt: allow returning UNKNOWN on timeouts (-u)
Whitespace and intend cleanup
Update check_http short help with new stycky and stickyport options.
check_http: die when an invalid --onredirect option is specified
check_http: add --onredirect=stickyport - also follow the same port
Add the timegm Gnulib module
negate: make timeouts configurable
Make alarm handler customisable
negate: Fix not printing the real timeout in ALRM handler when timeout is left to default
tests/check_http.t: Add various timeout-related tests
Fixed check_http not timing-out on redirects
15 years agoRevert "Add timezone support and fix checks around cert expiration" (keep the expirat...
Revert "Add timezone support and fix checks around cert expiration" (keep the expiration fix)
This reverts commit d41a33a434558189300113c28b26e2d3d681d390.
This reverts commit d41a33a434558189300113c28b26e2d3d681d390.
Add suggested multi-oid test (John A. Barbuto)
check_snmp: Fix potential buffer overflow - enforce MAX_OIDS limit (John A. Barbuto)
Fix logging of STDERR in tinderbox tests phase
Add timezone support and fix checks around cert expiration
Check for existence of pre-instaleld pst3 for Solaris tests in t/check_procs.t
Fix check_snmp test on solaris
Update extended check_http tests for 0d78171...
Also add some tests, and make debug mode loop infinitely.
Also add some tests, and make debug mode loop infinitely.
check_http fixes:
- Fix broken printf on 500 errors
- Add bytes to normal output (accidentally removed in 0d78171)
- Fix broken printf on 500 errors
- Add bytes to normal output (accidentally removed in 0d78171)
check_snmp fixes:
- Fix broken compilation caused by typo in command ending
- Remove extra whitespaces at EOL
- Fix invalid host test on Ubuntu Hardy (and possibly others)
- Fix broken compilation caused by typo in command ending
- Remove extra whitespaces at EOL
- Fix invalid host test on Ubuntu Hardy (and possibly others)
Ignore stderr messages unless return code is non-zero or there is no output
Create expired cert for testing purposes. Updated tests to check
expired and unexpired certificates
expired and unexpired certificates